93999 2012-08-14 10:41:44 -0700 [BlackBerry] Don't crash on OOM in AC 2012-08-14 14:20:20 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 fspacek webkit-unassigned mifenton tonikitoo webkit.review.bot oldest_to_newest 695136 0 fspacek 2012-08-14 10:41:44 -0700 When we fail to allocate the bitmap surface for the contents of the AC layer, we should bail and not attempt any rendering. 695140 1 158367 fspacek 2012-08-14 10:43:22 -0700 Created attachment 158367 Fail gracefully in case of OOM 695280 2 158367 webkit.review.bot 2012-08-14 12:50:14 -0700 Comment on attachment 158367 Fail gracefully in case of OOM Rejecting attachment 158367 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13500381 695316 3 158402 fspacek 2012-08-14 13:16:00 -0700 Created attachment 158402 Fail gracefully in case of OOM Now with OOPS! 695385 4 158402 webkit.review.bot 2012-08-14 14:20:17 -0700 Comment on attachment 158402 Fail gracefully in case of OOM Clearing flags on attachment: 158402 Committed r125605: <http://trac.webkit.org/changeset/125605> 695386 5 webkit.review.bot 2012-08-14 14:20:20 -0700 All reviewed patches have been landed. Closing bug. 158367 2012-08-14 10:43:22 -0700 2012-08-14 13:16:00 -0700 Fail gracefully in case of OOM oom.diff text/plain 2956 fspacek ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ODE1YTU4Li40MDM0ODA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDgtMDkgIEZpbGlwIFNwYWNlayAgPGZzcGFjZWtAcmltLmNvbT4KKworICAgICAg ICBbQmxhY2tCZXJyeV0gRG9uJ3QgY3Jhc2ggb24gT09NIGluIEFDCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mzk5OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWS4KKworICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IEdlb3JnZSBTdGFp a29zLgorCisgICAgICAgIEZhaWwgZ3JhY2VmdWxseSBpbiBjYXNlIHdlIGZhaWwgdG8gYWxsb2Nh dGUgdGhlIGJpdG1hcAorICAgICAgICBmb3IgdGhlIEFDIGxheWVyIGNvbnRlbnRzLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9JbnN0cnVtZW50ZWRQbGF0Zm9ybUNh bnZhcy5oOgorICAgICAgICAoV2ViQ29yZTo6SW5zdHJ1bWVudGVkUGxhdGZvcm1DYW52YXM6Oklu c3RydW1lbnRlZFBsYXRmb3JtQ2FudmFzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9i bGFja2JlcnJ5L0xheWVyV2ViS2l0VGhyZWFkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheWVy V2ViS2l0VGhyZWFkOjpwYWludENvbnRlbnRzKToKKwogMjAxMi0wOC0xMyAgQW50b25pbyBHb21l cyAgPGFnb21lc0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBIYXJkd2FyZSBhY2Nl bGVyYXRlZCBzY3JvbGxpbmcgb2YgPHNlbGVjdD4gY29udGVudApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9JbnN0cnVtZW50ZWRQbGF0Zm9y bUNhbnZhcy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9J bnN0cnVtZW50ZWRQbGF0Zm9ybUNhbnZhcy5oCmluZGV4IDkyN2I1OTkuLjk0YTE2Y2IgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvSW5zdHJ1 bWVudGVkUGxhdGZvcm1DYW52YXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9ibGFja2JlcnJ5L0luc3RydW1lbnRlZFBsYXRmb3JtQ2FudmFzLmgKQEAgLTM2LDEyICsz NiwxMiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIEluc3RydW1lbnRlZFBsYXRmb3Jt Q2FudmFzIDogcHVibGljIFNrQ2FudmFzIHsKIHB1YmxpYzoKLSAgICBJbnN0cnVtZW50ZWRQbGF0 Zm9ybUNhbnZhcyhpbnQgd2lkdGgsIGludCBoZWlnaHQpCi0gICAgICAgIDogbV9zaXplKHdpZHRo LCBoZWlnaHQpCisgICAgSW5zdHJ1bWVudGVkUGxhdGZvcm1DYW52YXMoY29uc3QgU2tCaXRtYXAm IGJpdG1hcCkKKyAgICAgICAgOiBtX3NpemUoYml0bWFwLndpZHRoKCksIGJpdG1hcC5oZWlnaHQo KSkKICAgICAgICAgLCBtX2lzU29saWRDb2xvcih0cnVlKQogICAgICAgICAsIG1fc29saWRDb2xv cigwLCAwLCAwLCAwKQogICAgIHsKLSAgICAgICAgc2V0RGV2aWNlKG5ldyBTa0RldmljZShTa0Jp dG1hcDo6a0FSR0JfODg4OF9Db25maWcsIHdpZHRoLCBoZWlnaHQpKS0+dW5yZWYoKTsKKyAgICAg ICAgc2V0RGV2aWNlKG5ldyBTa0RldmljZShiaXRtYXApKS0+dW5yZWYoKTsKICAgICB9CiAKICAg ICB2aXJ0dWFsIH5JbnN0cnVtZW50ZWRQbGF0Zm9ybUNhbnZhcygpIHsgfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllcldlYktpdFRo cmVhZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xh eWVyV2ViS2l0VGhyZWFkLmNwcAppbmRleCA4ODhiMDRjLi5jZTU2ZGY1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyV2ViS2l0VGhy ZWFkLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5 L0xheWVyV2ViS2l0VGhyZWFkLmNwcApAQCAtMTEzLDcgKzExMywxNCBAQCBTa0JpdG1hcCBMYXll cldlYktpdFRocmVhZDo6cGFpbnRDb250ZW50cyhjb25zdCBJbnRSZWN0JiBjb250ZW50c1JlY3Qs IGRvdWJsZSBzYwogICAgIGlmIChkcmF3c0NvbnRlbnQoKSkgeyAvLyBMYXllciBjb250ZW50cyBt dXN0IGJlIGRyYXduIGludG8gYSBjYW52YXMuCiAgICAgICAgIEludFJlY3QgdW50cmFuc2Zvcm1l ZENvbnRlbnRzUmVjdCA9IGNvbnRlbnRzUmVjdDsKIAotICAgICAgICBjYW52YXMgPSBhZG9wdFB0 cihuZXcgSW5zdHJ1bWVudGVkUGxhdGZvcm1DYW52YXMoY29udGVudHNSZWN0LndpZHRoKCksIGNv bnRlbnRzUmVjdC5oZWlnaHQoKSkpOworICAgICAgICBTa0JpdG1hcCBjYW52YXNCaXRtYXA7Cisg ICAgICAgIGNhbnZhc0JpdG1hcC5zZXRDb25maWcoU2tCaXRtYXA6OmtBUkdCXzg4ODhfQ29uZmln LCBjb250ZW50c1JlY3Qud2lkdGgoKSwgY29udGVudHNSZWN0LmhlaWdodCgpKTsKKyAgICAgICAg aWYgKCFjYW52YXNCaXRtYXAuYWxsb2NQaXhlbHMoKSkKKyAgICAgICAgICAgIHJldHVybiBTa0Jp dG1hcCgpOworICAgICAgICBjYW52YXNCaXRtYXAuc2V0SXNPcGFxdWUoZmFsc2UpOworICAgICAg ICBjYW52YXNCaXRtYXAuZXJhc2VDb2xvcigwKTsKKworICAgICAgICBjYW52YXMgPSBhZG9wdFB0 cihuZXcgSW5zdHJ1bWVudGVkUGxhdGZvcm1DYW52YXMoY2FudmFzQml0bWFwKSk7CiAgICAgICAg IFBsYXRmb3JtQ29udGV4dFNraWEgc2tpYUNvbnRleHQoY2FudmFzLmdldCgpKTsKIAogICAgICAg ICBHcmFwaGljc0NvbnRleHQgZ3JhcGhpY3NDb250ZXh0KCZza2lhQ29udGV4dCk7Cg== 158402 2012-08-14 13:16:00 -0700 2012-08-14 14:20:16 -0700 Fail gracefully in case of OOM oom.diff text/plain 2964 fspacek ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ODE1YTU4Li40MDM0ODA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDgtMDkgIEZpbGlwIFNwYWNlayAgPGZzcGFjZWtAcmltLmNvbT4KKworICAgICAg ICBbQmxhY2tCZXJyeV0gRG9uJ3QgY3Jhc2ggb24gT09NIGluIEFDCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mzk5OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgR2Vv cmdlIFN0YWlrb3MuCisKKyAgICAgICAgRmFpbCBncmFjZWZ1bGx5IGluIGNhc2Ugd2UgZmFpbCB0 byBhbGxvY2F0ZSB0aGUgYml0bWFwCisgICAgICAgIGZvciB0aGUgQUMgbGF5ZXIgY29udGVudHMu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0luc3RydW1lbnRlZFBs YXRmb3JtQ2FudmFzLmg6CisgICAgICAgIChXZWJDb3JlOjpJbnN0cnVtZW50ZWRQbGF0Zm9ybUNh bnZhczo6SW5zdHJ1bWVudGVkUGxhdGZvcm1DYW52YXMpOgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJXZWJLaXRUaHJlYWQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TGF5ZXJXZWJLaXRUaHJlYWQ6OnBhaW50Q29udGVudHMpOgorCiAyMDEyLTA4LTEzICBBbnRv bmlvIEdvbWVzICA8YWdvbWVzQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEhhcmR3 YXJlIGFjY2VsZXJhdGVkIHNjcm9sbGluZyBvZiA8c2VsZWN0PiBjb250ZW50CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0luc3RydW1lbnRl ZFBsYXRmb3JtQ2FudmFzLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFj a2JlcnJ5L0luc3RydW1lbnRlZFBsYXRmb3JtQ2FudmFzLmgKaW5kZXggOTI3YjU5OS4uOTRhMTZj YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJy eS9JbnN0cnVtZW50ZWRQbGF0Zm9ybUNhbnZhcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvSW5zdHJ1bWVudGVkUGxhdGZvcm1DYW52YXMuaApAQCAt MzYsMTIgKzM2LDEyIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgSW5zdHJ1bWVudGVk UGxhdGZvcm1DYW52YXMgOiBwdWJsaWMgU2tDYW52YXMgewogcHVibGljOgotICAgIEluc3RydW1l bnRlZFBsYXRmb3JtQ2FudmFzKGludCB3aWR0aCwgaW50IGhlaWdodCkKLSAgICAgICAgOiBtX3Np emUod2lkdGgsIGhlaWdodCkKKyAgICBJbnN0cnVtZW50ZWRQbGF0Zm9ybUNhbnZhcyhjb25zdCBT a0JpdG1hcCYgYml0bWFwKQorICAgICAgICA6IG1fc2l6ZShiaXRtYXAud2lkdGgoKSwgYml0bWFw LmhlaWdodCgpKQogICAgICAgICAsIG1faXNTb2xpZENvbG9yKHRydWUpCiAgICAgICAgICwgbV9z b2xpZENvbG9yKDAsIDAsIDAsIDApCiAgICAgewotICAgICAgICBzZXREZXZpY2UobmV3IFNrRGV2 aWNlKFNrQml0bWFwOjprQVJHQl84ODg4X0NvbmZpZywgd2lkdGgsIGhlaWdodCkpLT51bnJlZigp OworICAgICAgICBzZXREZXZpY2UobmV3IFNrRGV2aWNlKGJpdG1hcCkpLT51bnJlZigpOwogICAg IH0KIAogICAgIHZpcnR1YWwgfkluc3RydW1lbnRlZFBsYXRmb3JtQ2FudmFzKCkgeyB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVy V2ViS2l0VGhyZWFkLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNr YmVycnkvTGF5ZXJXZWJLaXRUaHJlYWQuY3BwCmluZGV4IDg4OGIwNGMuLmNlNTZkZjUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJX ZWJLaXRUaHJlYWQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Js YWNrYmVycnkvTGF5ZXJXZWJLaXRUaHJlYWQuY3BwCkBAIC0xMTMsNyArMTEzLDE0IEBAIFNrQml0 bWFwIExheWVyV2ViS2l0VGhyZWFkOjpwYWludENvbnRlbnRzKGNvbnN0IEludFJlY3QmIGNvbnRl bnRzUmVjdCwgZG91YmxlIHNjCiAgICAgaWYgKGRyYXdzQ29udGVudCgpKSB7IC8vIExheWVyIGNv bnRlbnRzIG11c3QgYmUgZHJhd24gaW50byBhIGNhbnZhcy4KICAgICAgICAgSW50UmVjdCB1bnRy YW5zZm9ybWVkQ29udGVudHNSZWN0ID0gY29udGVudHNSZWN0OwogCi0gICAgICAgIGNhbnZhcyA9 IGFkb3B0UHRyKG5ldyBJbnN0cnVtZW50ZWRQbGF0Zm9ybUNhbnZhcyhjb250ZW50c1JlY3Qud2lk dGgoKSwgY29udGVudHNSZWN0LmhlaWdodCgpKSk7CisgICAgICAgIFNrQml0bWFwIGNhbnZhc0Jp dG1hcDsKKyAgICAgICAgY2FudmFzQml0bWFwLnNldENvbmZpZyhTa0JpdG1hcDo6a0FSR0JfODg4 OF9Db25maWcsIGNvbnRlbnRzUmVjdC53aWR0aCgpLCBjb250ZW50c1JlY3QuaGVpZ2h0KCkpOwor ICAgICAgICBpZiAoIWNhbnZhc0JpdG1hcC5hbGxvY1BpeGVscygpKQorICAgICAgICAgICAgcmV0 dXJuIFNrQml0bWFwKCk7CisgICAgICAgIGNhbnZhc0JpdG1hcC5zZXRJc09wYXF1ZShmYWxzZSk7 CisgICAgICAgIGNhbnZhc0JpdG1hcC5lcmFzZUNvbG9yKDApOworCisgICAgICAgIGNhbnZhcyA9 IGFkb3B0UHRyKG5ldyBJbnN0cnVtZW50ZWRQbGF0Zm9ybUNhbnZhcyhjYW52YXNCaXRtYXApKTsK ICAgICAgICAgUGxhdGZvcm1Db250ZXh0U2tpYSBza2lhQ29udGV4dChjYW52YXMuZ2V0KCkpOwog CiAgICAgICAgIEdyYXBoaWNzQ29udGV4dCBncmFwaGljc0NvbnRleHQoJnNraWFDb250ZXh0KTsK