<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>93997</bug_id>
          
          <creation_ts>2012-08-14 10:31:22 -0700</creation_ts>
          <short_desc>[Chromium] Fix warnings on Windows build</short_desc>
          <delta_ts>2012-08-14 17:33:40 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Scott Graham">scottmg</reporter>
          <assigned_to name="Scott Graham">scottmg</assigned_to>
          <cc>haraken</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>695125</commentid>
    <comment_count>0</comment_count>
    <who name="Scott Graham">scottmg</who>
    <bug_when>2012-08-14 10:31:22 -0700</bug_when>
    <thetext>[Chromium] Fix warnings on Windows build</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>695132</commentid>
    <comment_count>1</comment_count>
      <attachid>158365</attachid>
    <who name="Scott Graham">scottmg</who>
    <bug_when>2012-08-14 10:34:58 -0700</bug_when>
    <thetext>Created attachment 158365
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>695521</commentid>
    <comment_count>2</comment_count>
      <attachid>158365</attachid>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-08-14 16:30:11 -0700</bug_when>
    <thetext>Comment on attachment 158365
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158365&amp;action=review

&gt; Source/WebKit/chromium/tests/CCRenderSurfaceFiltersTest.cpp:56
&gt;      EXPECT_TRUE(isCombined(WebFilterOperation::createGrayscaleFilter(0.5)));

Don&apos;t you also need to change 0.5 to 0.5f?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>695531</commentid>
    <comment_count>3</comment_count>
    <who name="Scott Graham">scottmg</who>
    <bug_when>2012-08-14 16:35:27 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 158365 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=158365&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/chromium/tests/CCRenderSurfaceFiltersTest.cpp:56
&gt; &gt;      EXPECT_TRUE(isCombined(WebFilterOperation::createGrayscaleFilter(0.5)));
&gt; 
&gt; Don&apos;t you also need to change 0.5 to 0.5f?

No, 0.5 is exactly representable as a float, so there&apos;s no truncation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>695541</commentid>
    <comment_count>4</comment_count>
      <attachid>158365</attachid>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-08-14 16:43:14 -0700</bug_when>
    <thetext>Comment on attachment 158365
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158365&amp;action=review

&gt;&gt;&gt; Source/WebKit/chromium/tests/CCRenderSurfaceFiltersTest.cpp:56
&gt;&gt;&gt;      EXPECT_TRUE(isCombined(WebFilterOperation::createGrayscaleFilter(0.5)));
&gt;&gt; 
&gt;&gt; Don&apos;t you also need to change 0.5 to 0.5f?
&gt; 
&gt; No, 0.5 is exactly representable as a float, so there&apos;s no truncation.

Makes sense. Then let&apos;s add the comment. People will wonder why this test uses 0.3f and 0.5.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>695546</commentid>
    <comment_count>5</comment_count>
      <attachid>158445</attachid>
    <who name="Scott Graham">scottmg</who>
    <bug_when>2012-08-14 16:48:32 -0700</bug_when>
    <thetext>Created attachment 158445
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>695552</commentid>
    <comment_count>6</comment_count>
      <attachid>158445</attachid>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-08-14 16:52:35 -0700</bug_when>
    <thetext>Comment on attachment 158445
Patch

Looks OK</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>695584</commentid>
    <comment_count>7</comment_count>
      <attachid>158445</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-14 17:33:36 -0700</bug_when>
    <thetext>Comment on attachment 158445
Patch

Clearing flags on attachment: 158445

Committed r125625: &lt;http://trac.webkit.org/changeset/125625&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>695585</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-14 17:33:40 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>158365</attachid>
            <date>2012-08-14 10:34:58 -0700</date>
            <delta_ts>2012-08-14 16:48:30 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-93997-20120814103426.patch</filename>
            <type>text/plain</type>
            <size>5708</size>
            <attacher name="Scott Graham">scottmg</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4
IDhjYjljODEzN2YyMTk3NTM2ZjFjNDAxYThiZWFkNDZiZWE4YmUwNzcuLjQ1NTQwMTQwYWQzZmM5
YjA2MTcyMjIwYTgwODc5ZjRhYWQ3YWIwNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTggQEAKKzIwMTItMDgtMTQgIFNjb3R0IEdyYWhhbSAgPHNjb3R0bWdAY2hyb21p
dW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gRml4IHdhcm5pbmdzIG9uIFdpbmRvd3MgYnVp
bGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzOTk3
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMg
dHJ1bmNhdGlvbiBmcm9tICdkb3VibGUnIHRvICdmbG9hdCcgd2FybmluZ3Mgb24gQ2hyb21pdW0g
V2luZG93cworICAgICAgICBidWlsZC4KKworICAgICAgICAqIHRlc3RzL0NDUmVuZGVyU3VyZmFj
ZUZpbHRlcnNUZXN0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6VEVTVCk6CisgICAgICAgICogdGVz
dHMvQ0NTY3JvbGxiYXJBbmltYXRpb25Db250cm9sbGVyTGluZWFyRmFkZVRlc3QuY3BwOgorICAg
ICAgICAoV2ViQ29yZTo6VEVTVF9GKToKKwogMjAxMi0wOC0xNCAgSm9zaHVhIEJlbGwgIDxqc2Jl
bGxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEluZGV4ZWREQjogUGFzcyBjdXJzb3IgY29udGlu
dWUgcmVzdWx0cyBiYWNrIGluIGNhbGxiYWNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL3Rlc3RzL0NDUmVuZGVyU3VyZmFjZUZpbHRlcnNUZXN0LmNwcCBiL1NvdXJjZS9XZWJL
aXQvY2hyb21pdW0vdGVzdHMvQ0NSZW5kZXJTdXJmYWNlRmlsdGVyc1Rlc3QuY3BwCmluZGV4IGI1
NmE3ZmI0MjdmYjE3ZmRkMjE1YzNjZTkwM2M1YzczYWI4NjM5MWIuLjQzMTdiODU5NTFlNzVjMjc3
NmVlOTM2MjQyOGJkZWJjOWJhY2NlMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p
dW0vdGVzdHMvQ0NSZW5kZXJTdXJmYWNlRmlsdGVyc1Rlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJL
aXQvY2hyb21pdW0vdGVzdHMvQ0NSZW5kZXJTdXJmYWNlRmlsdGVyc1Rlc3QuY3BwCkBAIC01Miwy
NyArNTIsMjcgQEAgVEVTVChDQ1JlbmRlclN1cmZhY2VGaWx0ZXJzVGVzdCwgdGVzdENvbG9yTWF0
cml4RmlsdGVyc0NvbWJpbmVkKQogICAgIC8vIFNldmVyYWwgZmlsdGVycyBzaG91bGQgYWx3YXlz
IGNvbWJpbmUgZm9yIGFueSBhbW91bnQgYmV0d2VlbiAwIGFuZCAxOgogICAgIC8vIGdyYXlzY2Fs
ZSwgc2F0dXJhdGUsIGludmVydCwgY29udHJhc3QsIG9wYWNpdHkuCiAgICAgRVhQRUNUX1RSVUUo
aXNDb21iaW5lZChXZWJGaWx0ZXJPcGVyYXRpb246OmNyZWF0ZUdyYXlzY2FsZUZpbHRlcigwKSkp
OwotICAgIEVYUEVDVF9UUlVFKGlzQ29tYmluZWQoV2ViRmlsdGVyT3BlcmF0aW9uOjpjcmVhdGVH
cmF5c2NhbGVGaWx0ZXIoMC4zKSkpOworICAgIEVYUEVDVF9UUlVFKGlzQ29tYmluZWQoV2ViRmls
dGVyT3BlcmF0aW9uOjpjcmVhdGVHcmF5c2NhbGVGaWx0ZXIoMC4zZikpKTsKICAgICBFWFBFQ1Rf
VFJVRShpc0NvbWJpbmVkKFdlYkZpbHRlck9wZXJhdGlvbjo6Y3JlYXRlR3JheXNjYWxlRmlsdGVy
KDAuNSkpKTsKICAgICBFWFBFQ1RfVFJVRShpc0NvbWJpbmVkKFdlYkZpbHRlck9wZXJhdGlvbjo6
Y3JlYXRlR3JheXNjYWxlRmlsdGVyKDEpKSk7CiAKICAgICBFWFBFQ1RfVFJVRShpc0NvbWJpbmVk
KFdlYkZpbHRlck9wZXJhdGlvbjo6Y3JlYXRlU2F0dXJhdGVGaWx0ZXIoMCkpKTsKLSAgICBFWFBF
Q1RfVFJVRShpc0NvbWJpbmVkKFdlYkZpbHRlck9wZXJhdGlvbjo6Y3JlYXRlU2F0dXJhdGVGaWx0
ZXIoMC4zKSkpOworICAgIEVYUEVDVF9UUlVFKGlzQ29tYmluZWQoV2ViRmlsdGVyT3BlcmF0aW9u
OjpjcmVhdGVTYXR1cmF0ZUZpbHRlcigwLjNmKSkpOwogICAgIEVYUEVDVF9UUlVFKGlzQ29tYmlu
ZWQoV2ViRmlsdGVyT3BlcmF0aW9uOjpjcmVhdGVTYXR1cmF0ZUZpbHRlcigwLjUpKSk7CiAgICAg
RVhQRUNUX1RSVUUoaXNDb21iaW5lZChXZWJGaWx0ZXJPcGVyYXRpb246OmNyZWF0ZVNhdHVyYXRl
RmlsdGVyKDEpKSk7CiAKICAgICBFWFBFQ1RfVFJVRShpc0NvbWJpbmVkKFdlYkZpbHRlck9wZXJh
dGlvbjo6Y3JlYXRlSW52ZXJ0RmlsdGVyKDApKSk7Ci0gICAgRVhQRUNUX1RSVUUoaXNDb21iaW5l
ZChXZWJGaWx0ZXJPcGVyYXRpb246OmNyZWF0ZUludmVydEZpbHRlcigwLjMpKSk7CisgICAgRVhQ
RUNUX1RSVUUoaXNDb21iaW5lZChXZWJGaWx0ZXJPcGVyYXRpb246OmNyZWF0ZUludmVydEZpbHRl
cigwLjNmKSkpOwogICAgIEVYUEVDVF9UUlVFKGlzQ29tYmluZWQoV2ViRmlsdGVyT3BlcmF0aW9u
OjpjcmVhdGVJbnZlcnRGaWx0ZXIoMC41KSkpOwogICAgIEVYUEVDVF9UUlVFKGlzQ29tYmluZWQo
V2ViRmlsdGVyT3BlcmF0aW9uOjpjcmVhdGVJbnZlcnRGaWx0ZXIoMSkpKTsKIAogICAgIEVYUEVD
VF9UUlVFKGlzQ29tYmluZWQoV2ViRmlsdGVyT3BlcmF0aW9uOjpjcmVhdGVDb250cmFzdEZpbHRl
cigwKSkpOwotICAgIEVYUEVDVF9UUlVFKGlzQ29tYmluZWQoV2ViRmlsdGVyT3BlcmF0aW9uOjpj
cmVhdGVDb250cmFzdEZpbHRlcigwLjMpKSk7CisgICAgRVhQRUNUX1RSVUUoaXNDb21iaW5lZChX
ZWJGaWx0ZXJPcGVyYXRpb246OmNyZWF0ZUNvbnRyYXN0RmlsdGVyKDAuM2YpKSk7CiAgICAgRVhQ
RUNUX1RSVUUoaXNDb21iaW5lZChXZWJGaWx0ZXJPcGVyYXRpb246OmNyZWF0ZUNvbnRyYXN0Rmls
dGVyKDAuNSkpKTsKICAgICBFWFBFQ1RfVFJVRShpc0NvbWJpbmVkKFdlYkZpbHRlck9wZXJhdGlv
bjo6Y3JlYXRlQ29udHJhc3RGaWx0ZXIoMSkpKTsKIAogICAgIEVYUEVDVF9UUlVFKGlzQ29tYmlu
ZWQoV2ViRmlsdGVyT3BlcmF0aW9uOjpjcmVhdGVPcGFjaXR5RmlsdGVyKDApKSk7Ci0gICAgRVhQ
RUNUX1RSVUUoaXNDb21iaW5lZChXZWJGaWx0ZXJPcGVyYXRpb246OmNyZWF0ZU9wYWNpdHlGaWx0
ZXIoMC4zKSkpOworICAgIEVYUEVDVF9UUlVFKGlzQ29tYmluZWQoV2ViRmlsdGVyT3BlcmF0aW9u
OjpjcmVhdGVPcGFjaXR5RmlsdGVyKDAuM2YpKSk7CiAgICAgRVhQRUNUX1RSVUUoaXNDb21iaW5l
ZChXZWJGaWx0ZXJPcGVyYXRpb246OmNyZWF0ZU9wYWNpdHlGaWx0ZXIoMC41KSkpOwogICAgIEVY
UEVDVF9UUlVFKGlzQ29tYmluZWQoV2ViRmlsdGVyT3BlcmF0aW9uOjpjcmVhdGVPcGFjaXR5Rmls
dGVyKDEpKSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NT
Y3JvbGxiYXJBbmltYXRpb25Db250cm9sbGVyTGluZWFyRmFkZVRlc3QuY3BwIGIvU291cmNlL1dl
YktpdC9jaHJvbWl1bS90ZXN0cy9DQ1Njcm9sbGJhckFuaW1hdGlvbkNvbnRyb2xsZXJMaW5lYXJG
YWRlVGVzdC5jcHAKaW5kZXggZTZjZGMyNGMxYjVhYTczMGM1ZDEwNjgyNTljMjU3OWVhZDk3NGM3
Zi4uMjM4ZjNkZWI1NmZlNjliZjE4ZGZlMTA0Y2QyZmU4MGFlMzQ3ZTJkMyAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ1Njcm9sbGJhckFuaW1hdGlvbkNvbnRyb2xs
ZXJMaW5lYXJGYWRlVGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9D
Q1Njcm9sbGJhckFuaW1hdGlvbkNvbnRyb2xsZXJMaW5lYXJGYWRlVGVzdC5jcHAKQEAgLTg0LDkg
Kzg0LDkgQEAgVEVTVF9GKENDU2Nyb2xsYmFyQW5pbWF0aW9uQ29udHJvbGxlckxpbmVhckZhZGVU
ZXN0LCB2ZXJpZnlBd2FrZW5CeVNjcm9sbCkKICAgICBtX3Njcm9sbGJhckNvbnRyb2xsZXItPmFu
aW1hdGUoMyk7CiAgICAgRVhQRUNUX0ZMT0FUX0VRKDEsIG1fc2Nyb2xsYmFyTGF5ZXItPm9wYWNp
dHkoKSk7CiAgICAgbV9zY3JvbGxiYXJDb250cm9sbGVyLT5hbmltYXRlKDQpOwotICAgIEVYUEVD
VF9GTE9BVF9FUSgyIC8gMy4wLCBtX3Njcm9sbGJhckxheWVyLT5vcGFjaXR5KCkpOworICAgIEVY
UEVDVF9GTE9BVF9FUSgyIC8gMy4wZiwgbV9zY3JvbGxiYXJMYXllci0+b3BhY2l0eSgpKTsKICAg
ICBtX3Njcm9sbGJhckNvbnRyb2xsZXItPmFuaW1hdGUoNSk7Ci0gICAgRVhQRUNUX0ZMT0FUX0VR
KDEgLyAzLjAsIG1fc2Nyb2xsYmFyTGF5ZXItPm9wYWNpdHkoKSk7CisgICAgRVhQRUNUX0ZMT0FU
X0VRKDEgLyAzLjBmLCBtX3Njcm9sbGJhckxheWVyLT5vcGFjaXR5KCkpOwogICAgIG1fc2Nyb2xs
TGF5ZXItPnNldFNjcm9sbERlbHRhKEludFNpemUoMywgMykpOwogICAgIG1fc2Nyb2xsYmFyQ29u
dHJvbGxlci0+dXBkYXRlU2Nyb2xsT2Zmc2V0QXRUaW1lKG1fc2Nyb2xsTGF5ZXIuZ2V0KCksIDUp
OwogICAgIG1fc2Nyb2xsYmFyQ29udHJvbGxlci0+YW5pbWF0ZSg2KTsKQEAgLTk0LDkgKzk0LDkg
QEAgVEVTVF9GKENDU2Nyb2xsYmFyQW5pbWF0aW9uQ29udHJvbGxlckxpbmVhckZhZGVUZXN0LCB2
ZXJpZnlBd2FrZW5CeVNjcm9sbCkKICAgICBtX3Njcm9sbGJhckNvbnRyb2xsZXItPmFuaW1hdGUo
Nyk7CiAgICAgRVhQRUNUX0ZMT0FUX0VRKDEsIG1fc2Nyb2xsYmFyTGF5ZXItPm9wYWNpdHkoKSk7
CiAgICAgbV9zY3JvbGxiYXJDb250cm9sbGVyLT5hbmltYXRlKDgpOwotICAgIEVYUEVDVF9GTE9B
VF9FUSgyIC8gMy4wLCBtX3Njcm9sbGJhckxheWVyLT5vcGFjaXR5KCkpOworICAgIEVYUEVDVF9G
TE9BVF9FUSgyIC8gMy4wZiwgbV9zY3JvbGxiYXJMYXllci0+b3BhY2l0eSgpKTsKICAgICBtX3Nj
cm9sbGJhckNvbnRyb2xsZXItPmFuaW1hdGUoOSk7Ci0gICAgRVhQRUNUX0ZMT0FUX0VRKDEgLyAz
LjAsIG1fc2Nyb2xsYmFyTGF5ZXItPm9wYWNpdHkoKSk7CisgICAgRVhQRUNUX0ZMT0FUX0VRKDEg
LyAzLjBmLCBtX3Njcm9sbGJhckxheWVyLT5vcGFjaXR5KCkpOwogICAgIG1fc2Nyb2xsYmFyQ29u
dHJvbGxlci0+YW5pbWF0ZSgxMCk7CiAgICAgRVhQRUNUX0ZMT0FUX0VRKDAsIG1fc2Nyb2xsYmFy
TGF5ZXItPm9wYWNpdHkoKSk7CiB9CkBAIC0xMjcsOSArMTI3LDkgQEAgVEVTVF9GKENDU2Nyb2xs
YmFyQW5pbWF0aW9uQ29udHJvbGxlckxpbmVhckZhZGVUZXN0LCB2ZXJpZnlGb3JjZUF3YWtlbkJ5
UGluY2gpCiAgICAgbV9zY3JvbGxiYXJDb250cm9sbGVyLT5hbmltYXRlKDgpOwogICAgIEVYUEVD
VF9GTE9BVF9FUSgxLCBtX3Njcm9sbGJhckxheWVyLT5vcGFjaXR5KCkpOwogICAgIG1fc2Nyb2xs
YmFyQ29udHJvbGxlci0+YW5pbWF0ZSg5KTsKLSAgICBFWFBFQ1RfRkxPQVRfRVEoMiAvIDMuMCwg
bV9zY3JvbGxiYXJMYXllci0+b3BhY2l0eSgpKTsKKyAgICBFWFBFQ1RfRkxPQVRfRVEoMiAvIDMu
MGYsIG1fc2Nyb2xsYmFyTGF5ZXItPm9wYWNpdHkoKSk7CiAgICAgbV9zY3JvbGxiYXJDb250cm9s
bGVyLT5hbmltYXRlKDEwKTsKLSAgICBFWFBFQ1RfRkxPQVRfRVEoMSAvIDMuMCwgbV9zY3JvbGxi
YXJMYXllci0+b3BhY2l0eSgpKTsKKyAgICBFWFBFQ1RfRkxPQVRfRVEoMSAvIDMuMGYsIG1fc2Ny
b2xsYmFyTGF5ZXItPm9wYWNpdHkoKSk7CiAgICAgbV9zY3JvbGxiYXJDb250cm9sbGVyLT5hbmlt
YXRlKDExKTsKICAgICBFWFBFQ1RfRkxPQVRfRVEoMCwgbV9zY3JvbGxiYXJMYXllci0+b3BhY2l0
eSgpKTsKIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>158445</attachid>
            <date>2012-08-14 16:48:32 -0700</date>
            <delta_ts>2012-08-14 17:33:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-93997-20120814164759.patch</filename>
            <type>text/plain</type>
            <size>6016</size>
            <attacher name="Scott Graham">scottmg</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4
IDhjYjljODEzN2YyMTk3NTM2ZjFjNDAxYThiZWFkNDZiZWE4YmUwNzcuLjQ1NTQwMTQwYWQzZmM5
YjA2MTcyMjIwYTgwODc5ZjRhYWQ3YWIwNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTggQEAKKzIwMTItMDgtMTQgIFNjb3R0IEdyYWhhbSAgPHNjb3R0bWdAY2hyb21p
dW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gRml4IHdhcm5pbmdzIG9uIFdpbmRvd3MgYnVp
bGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzOTk3
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMg
dHJ1bmNhdGlvbiBmcm9tICdkb3VibGUnIHRvICdmbG9hdCcgd2FybmluZ3Mgb24gQ2hyb21pdW0g
V2luZG93cworICAgICAgICBidWlsZC4KKworICAgICAgICAqIHRlc3RzL0NDUmVuZGVyU3VyZmFj
ZUZpbHRlcnNUZXN0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6VEVTVCk6CisgICAgICAgICogdGVz
dHMvQ0NTY3JvbGxiYXJBbmltYXRpb25Db250cm9sbGVyTGluZWFyRmFkZVRlc3QuY3BwOgorICAg
ICAgICAoV2ViQ29yZTo6VEVTVF9GKToKKwogMjAxMi0wOC0xNCAgSm9zaHVhIEJlbGwgIDxqc2Jl
bGxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEluZGV4ZWREQjogUGFzcyBjdXJzb3IgY29udGlu
dWUgcmVzdWx0cyBiYWNrIGluIGNhbGxiYWNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL3Rlc3RzL0NDUmVuZGVyU3VyZmFjZUZpbHRlcnNUZXN0LmNwcCBiL1NvdXJjZS9XZWJL
aXQvY2hyb21pdW0vdGVzdHMvQ0NSZW5kZXJTdXJmYWNlRmlsdGVyc1Rlc3QuY3BwCmluZGV4IGI1
NmE3ZmI0MjdmYjE3ZmRkMjE1YzNjZTkwM2M1YzczYWI4NjM5MWIuLjFkMmE5YzU3MDc4MDhmMDNl
YTZkZjZmNzdlYzgyOWQyMWE2NTZiYzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p
dW0vdGVzdHMvQ0NSZW5kZXJTdXJmYWNlRmlsdGVyc1Rlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJL
aXQvY2hyb21pdW0vdGVzdHMvQ0NSZW5kZXJTdXJmYWNlRmlsdGVyc1Rlc3QuY3BwCkBAIC01Miwy
NyArNTIsMzAgQEAgVEVTVChDQ1JlbmRlclN1cmZhY2VGaWx0ZXJzVGVzdCwgdGVzdENvbG9yTWF0
cml4RmlsdGVyc0NvbWJpbmVkKQogICAgIC8vIFNldmVyYWwgZmlsdGVycyBzaG91bGQgYWx3YXlz
IGNvbWJpbmUgZm9yIGFueSBhbW91bnQgYmV0d2VlbiAwIGFuZCAxOgogICAgIC8vIGdyYXlzY2Fs
ZSwgc2F0dXJhdGUsIGludmVydCwgY29udHJhc3QsIG9wYWNpdHkuCiAgICAgRVhQRUNUX1RSVUUo
aXNDb21iaW5lZChXZWJGaWx0ZXJPcGVyYXRpb246OmNyZWF0ZUdyYXlzY2FsZUZpbHRlcigwKSkp
OwotICAgIEVYUEVDVF9UUlVFKGlzQ29tYmluZWQoV2ViRmlsdGVyT3BlcmF0aW9uOjpjcmVhdGVH
cmF5c2NhbGVGaWx0ZXIoMC4zKSkpOworICAgIC8vIE5vdGUgdGhhdCB3ZSB1c2UgMC4zZiB0byBh
dm9pZCAiYXJndW1lbnQgaXMgdHJ1bmNhdGVkIGZyb20gJ2RvdWJsZScgdG8KKyAgICAvLyAnZmxv
YXQnIiB3YXJuaW5ncyBvbiBXaW5kb3dzLiAwLjUgaXMgZXhhY3RseSByZXByZXNlbnRhYmxlIGFz
IGEgZmxvYXQsIHNvCisgICAgLy8gdGhlcmUgaXMgbm8gd2FybmluZy4KKyAgICBFWFBFQ1RfVFJV
RShpc0NvbWJpbmVkKFdlYkZpbHRlck9wZXJhdGlvbjo6Y3JlYXRlR3JheXNjYWxlRmlsdGVyKDAu
M2YpKSk7CiAgICAgRVhQRUNUX1RSVUUoaXNDb21iaW5lZChXZWJGaWx0ZXJPcGVyYXRpb246OmNy
ZWF0ZUdyYXlzY2FsZUZpbHRlcigwLjUpKSk7CiAgICAgRVhQRUNUX1RSVUUoaXNDb21iaW5lZChX
ZWJGaWx0ZXJPcGVyYXRpb246OmNyZWF0ZUdyYXlzY2FsZUZpbHRlcigxKSkpOwogCiAgICAgRVhQ
RUNUX1RSVUUoaXNDb21iaW5lZChXZWJGaWx0ZXJPcGVyYXRpb246OmNyZWF0ZVNhdHVyYXRlRmls
dGVyKDApKSk7Ci0gICAgRVhQRUNUX1RSVUUoaXNDb21iaW5lZChXZWJGaWx0ZXJPcGVyYXRpb246
OmNyZWF0ZVNhdHVyYXRlRmlsdGVyKDAuMykpKTsKKyAgICBFWFBFQ1RfVFJVRShpc0NvbWJpbmVk
KFdlYkZpbHRlck9wZXJhdGlvbjo6Y3JlYXRlU2F0dXJhdGVGaWx0ZXIoMC4zZikpKTsKICAgICBF
WFBFQ1RfVFJVRShpc0NvbWJpbmVkKFdlYkZpbHRlck9wZXJhdGlvbjo6Y3JlYXRlU2F0dXJhdGVG
aWx0ZXIoMC41KSkpOwogICAgIEVYUEVDVF9UUlVFKGlzQ29tYmluZWQoV2ViRmlsdGVyT3BlcmF0
aW9uOjpjcmVhdGVTYXR1cmF0ZUZpbHRlcigxKSkpOwogCiAgICAgRVhQRUNUX1RSVUUoaXNDb21i
aW5lZChXZWJGaWx0ZXJPcGVyYXRpb246OmNyZWF0ZUludmVydEZpbHRlcigwKSkpOwotICAgIEVY
UEVDVF9UUlVFKGlzQ29tYmluZWQoV2ViRmlsdGVyT3BlcmF0aW9uOjpjcmVhdGVJbnZlcnRGaWx0
ZXIoMC4zKSkpOworICAgIEVYUEVDVF9UUlVFKGlzQ29tYmluZWQoV2ViRmlsdGVyT3BlcmF0aW9u
OjpjcmVhdGVJbnZlcnRGaWx0ZXIoMC4zZikpKTsKICAgICBFWFBFQ1RfVFJVRShpc0NvbWJpbmVk
KFdlYkZpbHRlck9wZXJhdGlvbjo6Y3JlYXRlSW52ZXJ0RmlsdGVyKDAuNSkpKTsKICAgICBFWFBF
Q1RfVFJVRShpc0NvbWJpbmVkKFdlYkZpbHRlck9wZXJhdGlvbjo6Y3JlYXRlSW52ZXJ0RmlsdGVy
KDEpKSk7CiAKICAgICBFWFBFQ1RfVFJVRShpc0NvbWJpbmVkKFdlYkZpbHRlck9wZXJhdGlvbjo6
Y3JlYXRlQ29udHJhc3RGaWx0ZXIoMCkpKTsKLSAgICBFWFBFQ1RfVFJVRShpc0NvbWJpbmVkKFdl
YkZpbHRlck9wZXJhdGlvbjo6Y3JlYXRlQ29udHJhc3RGaWx0ZXIoMC4zKSkpOworICAgIEVYUEVD
VF9UUlVFKGlzQ29tYmluZWQoV2ViRmlsdGVyT3BlcmF0aW9uOjpjcmVhdGVDb250cmFzdEZpbHRl
cigwLjNmKSkpOwogICAgIEVYUEVDVF9UUlVFKGlzQ29tYmluZWQoV2ViRmlsdGVyT3BlcmF0aW9u
OjpjcmVhdGVDb250cmFzdEZpbHRlcigwLjUpKSk7CiAgICAgRVhQRUNUX1RSVUUoaXNDb21iaW5l
ZChXZWJGaWx0ZXJPcGVyYXRpb246OmNyZWF0ZUNvbnRyYXN0RmlsdGVyKDEpKSk7CiAKICAgICBF
WFBFQ1RfVFJVRShpc0NvbWJpbmVkKFdlYkZpbHRlck9wZXJhdGlvbjo6Y3JlYXRlT3BhY2l0eUZp
bHRlcigwKSkpOwotICAgIEVYUEVDVF9UUlVFKGlzQ29tYmluZWQoV2ViRmlsdGVyT3BlcmF0aW9u
OjpjcmVhdGVPcGFjaXR5RmlsdGVyKDAuMykpKTsKKyAgICBFWFBFQ1RfVFJVRShpc0NvbWJpbmVk
KFdlYkZpbHRlck9wZXJhdGlvbjo6Y3JlYXRlT3BhY2l0eUZpbHRlcigwLjNmKSkpOwogICAgIEVY
UEVDVF9UUlVFKGlzQ29tYmluZWQoV2ViRmlsdGVyT3BlcmF0aW9uOjpjcmVhdGVPcGFjaXR5Rmls
dGVyKDAuNSkpKTsKICAgICBFWFBFQ1RfVFJVRShpc0NvbWJpbmVkKFdlYkZpbHRlck9wZXJhdGlv
bjo6Y3JlYXRlT3BhY2l0eUZpbHRlcigxKSkpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0
L2Nocm9taXVtL3Rlc3RzL0NDU2Nyb2xsYmFyQW5pbWF0aW9uQ29udHJvbGxlckxpbmVhckZhZGVU
ZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NTY3JvbGxiYXJBbmltYXRp
b25Db250cm9sbGVyTGluZWFyRmFkZVRlc3QuY3BwCmluZGV4IGU2Y2RjMjRjMWI1YWE3MzBjNWQx
MDY4MjU5YzI1NzllYWQ5NzRjN2YuLjQyODdkMzY4YmVmMDg0N2NmNWMyZTdmOGUwOTJjNGI3MjVh
MTlhOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NTY3JvbGxi
YXJBbmltYXRpb25Db250cm9sbGVyTGluZWFyRmFkZVRlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJL
aXQvY2hyb21pdW0vdGVzdHMvQ0NTY3JvbGxiYXJBbmltYXRpb25Db250cm9sbGVyTGluZWFyRmFk
ZVRlc3QuY3BwCkBAIC04NCw5ICs4NCwxMSBAQCBURVNUX0YoQ0NTY3JvbGxiYXJBbmltYXRpb25D
b250cm9sbGVyTGluZWFyRmFkZVRlc3QsIHZlcmlmeUF3YWtlbkJ5U2Nyb2xsKQogICAgIG1fc2Ny
b2xsYmFyQ29udHJvbGxlci0+YW5pbWF0ZSgzKTsKICAgICBFWFBFQ1RfRkxPQVRfRVEoMSwgbV9z
Y3JvbGxiYXJMYXllci0+b3BhY2l0eSgpKTsKICAgICBtX3Njcm9sbGJhckNvbnRyb2xsZXItPmFu
aW1hdGUoNCk7Ci0gICAgRVhQRUNUX0ZMT0FUX0VRKDIgLyAzLjAsIG1fc2Nyb2xsYmFyTGF5ZXIt
Pm9wYWNpdHkoKSk7CisgICAgLy8gTm90ZSB0aGF0IHdlIHVzZSAzLjBmIHRvIGF2b2lkICJhcmd1
bWVudCBpcyB0cnVuY2F0ZWQgZnJvbSAnZG91YmxlJyB0bworICAgIC8vICdmbG9hdCciIHdhcm5p
bmdzIG9uIFdpbmRvd3MuCisgICAgRVhQRUNUX0ZMT0FUX0VRKDIgLyAzLjBmLCBtX3Njcm9sbGJh
ckxheWVyLT5vcGFjaXR5KCkpOwogICAgIG1fc2Nyb2xsYmFyQ29udHJvbGxlci0+YW5pbWF0ZSg1
KTsKLSAgICBFWFBFQ1RfRkxPQVRfRVEoMSAvIDMuMCwgbV9zY3JvbGxiYXJMYXllci0+b3BhY2l0
eSgpKTsKKyAgICBFWFBFQ1RfRkxPQVRfRVEoMSAvIDMuMGYsIG1fc2Nyb2xsYmFyTGF5ZXItPm9w
YWNpdHkoKSk7CiAgICAgbV9zY3JvbGxMYXllci0+c2V0U2Nyb2xsRGVsdGEoSW50U2l6ZSgzLCAz
KSk7CiAgICAgbV9zY3JvbGxiYXJDb250cm9sbGVyLT51cGRhdGVTY3JvbGxPZmZzZXRBdFRpbWUo
bV9zY3JvbGxMYXllci5nZXQoKSwgNSk7CiAgICAgbV9zY3JvbGxiYXJDb250cm9sbGVyLT5hbmlt
YXRlKDYpOwpAQCAtOTQsOSArOTYsOSBAQCBURVNUX0YoQ0NTY3JvbGxiYXJBbmltYXRpb25Db250
cm9sbGVyTGluZWFyRmFkZVRlc3QsIHZlcmlmeUF3YWtlbkJ5U2Nyb2xsKQogICAgIG1fc2Nyb2xs
YmFyQ29udHJvbGxlci0+YW5pbWF0ZSg3KTsKICAgICBFWFBFQ1RfRkxPQVRfRVEoMSwgbV9zY3Jv
bGxiYXJMYXllci0+b3BhY2l0eSgpKTsKICAgICBtX3Njcm9sbGJhckNvbnRyb2xsZXItPmFuaW1h
dGUoOCk7Ci0gICAgRVhQRUNUX0ZMT0FUX0VRKDIgLyAzLjAsIG1fc2Nyb2xsYmFyTGF5ZXItPm9w
YWNpdHkoKSk7CisgICAgRVhQRUNUX0ZMT0FUX0VRKDIgLyAzLjBmLCBtX3Njcm9sbGJhckxheWVy
LT5vcGFjaXR5KCkpOwogICAgIG1fc2Nyb2xsYmFyQ29udHJvbGxlci0+YW5pbWF0ZSg5KTsKLSAg
ICBFWFBFQ1RfRkxPQVRfRVEoMSAvIDMuMCwgbV9zY3JvbGxiYXJMYXllci0+b3BhY2l0eSgpKTsK
KyAgICBFWFBFQ1RfRkxPQVRfRVEoMSAvIDMuMGYsIG1fc2Nyb2xsYmFyTGF5ZXItPm9wYWNpdHko
KSk7CiAgICAgbV9zY3JvbGxiYXJDb250cm9sbGVyLT5hbmltYXRlKDEwKTsKICAgICBFWFBFQ1Rf
RkxPQVRfRVEoMCwgbV9zY3JvbGxiYXJMYXllci0+b3BhY2l0eSgpKTsKIH0KQEAgLTEyNyw5ICsx
MjksOSBAQCBURVNUX0YoQ0NTY3JvbGxiYXJBbmltYXRpb25Db250cm9sbGVyTGluZWFyRmFkZVRl
c3QsIHZlcmlmeUZvcmNlQXdha2VuQnlQaW5jaCkKICAgICBtX3Njcm9sbGJhckNvbnRyb2xsZXIt
PmFuaW1hdGUoOCk7CiAgICAgRVhQRUNUX0ZMT0FUX0VRKDEsIG1fc2Nyb2xsYmFyTGF5ZXItPm9w
YWNpdHkoKSk7CiAgICAgbV9zY3JvbGxiYXJDb250cm9sbGVyLT5hbmltYXRlKDkpOwotICAgIEVY
UEVDVF9GTE9BVF9FUSgyIC8gMy4wLCBtX3Njcm9sbGJhckxheWVyLT5vcGFjaXR5KCkpOworICAg
IEVYUEVDVF9GTE9BVF9FUSgyIC8gMy4wZiwgbV9zY3JvbGxiYXJMYXllci0+b3BhY2l0eSgpKTsK
ICAgICBtX3Njcm9sbGJhckNvbnRyb2xsZXItPmFuaW1hdGUoMTApOwotICAgIEVYUEVDVF9GTE9B
VF9FUSgxIC8gMy4wLCBtX3Njcm9sbGJhckxheWVyLT5vcGFjaXR5KCkpOworICAgIEVYUEVDVF9G
TE9BVF9FUSgxIC8gMy4wZiwgbV9zY3JvbGxiYXJMYXllci0+b3BhY2l0eSgpKTsKICAgICBtX3Nj
cm9sbGJhckNvbnRyb2xsZXItPmFuaW1hdGUoMTEpOwogICAgIEVYUEVDVF9GTE9BVF9FUSgwLCBt
X3Njcm9sbGJhckxheWVyLT5vcGFjaXR5KCkpOwogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>