93993 2012-08-14 10:24:52 -0700 Rename DOMWindow::clear to something more descriptive 2012-08-16 17:29:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 75793 1 webkit.review.bot abarth abarth eric japhet oldest_to_newest 695114 0 webkit.review.bot 2012-08-14 10:24:52 -0700 Rename DOMWindow::clear to something more descriptive Requested by abarth on #webkit. 697617 1 158930 abarth 2012-08-16 15:46:31 -0700 Created attachment 158930 Patch 697625 2 158930 eric 2012-08-16 15:51:47 -0700 Comment on attachment 158930 Patch OK. I take it resetDOMWindowProperties doesn't actually zero them? :) 697630 3 abarth 2012-08-16 15:53:33 -0700 > OK. I take it resetDOMWindowProperties doesn't actually zero them? :) It does zero them out. We can leave that name as "clear" if you think that's better. 697722 4 158930 webkit.review.bot 2012-08-16 17:29:50 -0700 Comment on attachment 158930 Patch Clearing flags on attachment: 158930 Committed r125832: <http://trac.webkit.org/changeset/125832> 697723 5 webkit.review.bot 2012-08-16 17:29:54 -0700 All reviewed patches have been landed. Closing bug. 158930 2012-08-16 15:46:31 -0700 2012-08-16 17:29:50 -0700 Patch bug-93993-20120816154556.patch text/plain 5851 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWRmM2VhODcyYzgxZTll MmViNzY1OTU3ZmNiZWM2N2EwZjI4MzM0Ny4uODZkYjRkZTE2NDIzMTJlZGJjMmZiYzFlZmYzNGNj YTgxMGY3MjY3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA4LTE2ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVuYW1lIERPTVdpbmRvdzo6 Y2xlYXIgdG8gc29tZXRoaW5nIG1vcmUgZGVzY3JpcHRpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzOTkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXMgcmVxdWVzdGVkIGJ5IEVyaWMgU2VpZGVsLiBJ biBXZWJLaXQsIHdlIHR5cGljYWxseSB1c2UgImNsZWFyIiB0bworICAgICAgICBtZWFuIHplcm9p bmcgb3V0IGEgcG9pbnRlciAoZS5nLiwgT3duUHRyOjpjbGVhcikuIEZvciBET01XaW5kb3csIGl0 J3MKKyAgICAgICAgbW9yZSBsaWtlIHdlJ3JlIHJlc2V0dGluZyB0aGUgRE9NV2luZG93IHRvIGEg a25vd24gc3RhdGUgKGkuZS4sIGl0cworICAgICAgICBpbml0aWFsIHN0YXRlKSwgbW9kdWxvIGEg d3JpbmtsZSB3LnIudC4gdGhlIFBhZ2VDYWNoZS4gVGhlIG5ldyBuYW1lCisgICAgICAgIGF0dGVt cHRzIHRvIGNsYXJpZnkgdGhlIHNpdHVhdGlvbi4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6fkRvY3VtZW50KToKKyAgICAgICAgKiBs b2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmNs ZWFyKToKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE T01XaW5kb3c6On5ET01XaW5kb3cpOgorICAgICAgICAoV2ViQ29yZTo6RE9NV2luZG93OjpmcmFt ZURlc3Ryb3llZCk6CisgICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6OnJlc2V0VW5sZXNzU3Vz cGVuZGVkRm9yUGFnZUNhY2hlKToKKyAgICAgICAgKFdlYkNvcmU6OkRPTVdpbmRvdzo6cmVzZXRE T01XaW5kb3dQcm9wZXJ0aWVzKToKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5oOgorICAgICAg ICAoRE9NV2luZG93KToKKwogMjAxMi0wOC0xNiAgTWF4IEZlaWwgIDxtZmVpbEByaW0uY29tPgog CiAgICAgICAgIFtCbGFja0JlcnJ5XSBTb21lIG1lZGlhIGNvbnRyb2xzIGFyZSBtaXNwb3NpdGlv bmVkIGZvciBkeW5hbWljIGxpdmUgc3RyZWFtcyAoSExTKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAK aW5kZXggYWY5ZmM0ODYzM2IyN2Y5OWU1NzY5NjQzN2EzNWQ2ODEwZTNhMjNhMi4uOTFmOTIxMDQy ODBlNjk3NmZjMGViM2M2MTUwYmU0ZDY1OTAyMzllZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3Bw CkBAIC02MTIsOSArNjEyLDkgQEAgRG9jdW1lbnQ6On5Eb2N1bWVudCgpCiAgICAgQVNTRVJUKCFt X3BhcmVudFRyZWVTY29wZSk7CiAgICAgQVNTRVJUKCFtX2d1YXJkUmVmQ291bnQpOwogCi0gICAg Ly8gRklYTUU6IFNob3VsZCB3ZSBjbGVhciBtX2RvbVdpbmRvdyB3aGVuIHdlIGRldGFjaCBmcm9t IHRoZSBGcmFtZT8KKyAgICAvLyBGSVhNRTogU2hvdWxkIHdlIHJlc2V0IG1fZG9tV2luZG93IHdo ZW4gd2UgZGV0YWNoIGZyb20gdGhlIEZyYW1lPwogICAgIGlmIChtX2RvbVdpbmRvdykKLSAgICAg ICAgbV9kb21XaW5kb3ctPmNsZWFyKCk7CisgICAgICAgIG1fZG9tV2luZG93LT5yZXNldFVubGVz c1N1c3BlbmRlZEZvclBhZ2VDYWNoZSgpOwogCiAgICAgbV9zY3JpcHRSdW5uZXIuY2xlYXIoKTsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKaW5kZXggMWRiOTQ4OTNmYzljNGYw YzE4NGU2NDc2ZTVjYzc1YWM4MzdhYzZhZS4uZWUyYTU0NzZjY2JkMTE0OWVhNzAwN2IxZDhlYjJl ZjdmMTA3NzkzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC01MjUs NyArNTI1LDcgQEAgdm9pZCBGcmFtZUxvYWRlcjo6Y2xlYXIoRG9jdW1lbnQqIG5ld0RvY3VtZW50 LCBib29sIGNsZWFyV2luZG93UHJvcGVydGllcywgYm9vbAogICAgIC8vIERvIHRoaXMgYWZ0ZXIg ZGV0YWNoaW5nIHRoZSBkb2N1bWVudCBzbyB0aGF0IHRoZSB1bmxvYWQgZXZlbnQgd29ya3MuCiAg ICAgaWYgKGNsZWFyV2luZG93UHJvcGVydGllcykgewogICAgICAgICBJbnNwZWN0b3JJbnN0cnVt ZW50YXRpb246OmZyYW1lV2luZG93RGlzY2FyZGVkKG1fZnJhbWUsIG1fZnJhbWUtPmRvY3VtZW50 KCktPmRvbVdpbmRvdygpKTsKLSAgICAgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+ZG9tV2luZG93 KCktPmNsZWFyKCk7CisgICAgICAgIG1fZnJhbWUtPmRvY3VtZW50KCktPmRvbVdpbmRvdygpLT5y ZXNldFVubGVzc1N1c3BlbmRlZEZvclBhZ2VDYWNoZSgpOwogICAgICAgICBtX2ZyYW1lLT5zY3Jp cHQoKS0+Y2xlYXJXaW5kb3dTaGVsbChuZXdEb2N1bWVudC0+ZG9tV2luZG93KCksIG1fZnJhbWUt PmRvY3VtZW50KCktPmluUGFnZUNhY2hlKCkpOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5k b3cuY3BwCmluZGV4IDYyN2ZmODVlNDVmOGUzYWY5Y2EyMTE0OWI4MWQyNDViYzY2ODBjN2YuLjI1 N2Y4ZjIzNDZkYTg1YmJmMmQ4ZjNkZGJjNjk4YzU0ZDM4YzgxNDUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RP TVdpbmRvdy5jcHAKQEAgLTQzNyw5ICs0MzcsOSBAQCBET01XaW5kb3c6On5ET01XaW5kb3coKQog ICAgIGVsc2UKICAgICAgICAgd2lsbERlc3Ryb3lEb2N1bWVudEluRnJhbWUoKTsKIAotICAgIC8v IEFzIHRoZSBBU1NFUlRzIGFib3ZlIGluZGljYXRlLCB0aGlzIGNsZWFyIHNob3VsZCBvbmx5IGJl IG5lY2VzYXJ5IGlmIHRoaXMgRE9NV2luZG93IGlzIHN1c3BlbmRlZCBmb3IgdGhlIHBhZ2UgY2Fj aGUuCisgICAgLy8gQXMgdGhlIEFTU0VSVHMgYWJvdmUgaW5kaWNhdGUsIHRoaXMgcmVzZXQgc2hv dWxkIG9ubHkgYmUgbmVjZXNzYXJ5IGlmIHRoaXMgRE9NV2luZG93IGlzIHN1c3BlbmRlZCBmb3Ig dGhlIHBhZ2UgY2FjaGUuCiAgICAgLy8gQnV0IHdlIGRvbid0IHdhbnQgdG8gcmlzayBhbnkgb2Yg dGhlc2Ugb2JqZWN0cyBoYW5naW5nIGFyb3VuZCBhZnRlciB3ZSd2ZSBiZWVuIGRlc3Ryb3llZC4K LSAgICBjbGVhckRPTVdpbmRvd1Byb3BlcnRpZXMoKTsKKyAgICByZXNldERPTVdpbmRvd1Byb3Bl cnRpZXMoKTsKIAogICAgIHJlbW92ZUFsbFVubG9hZEV2ZW50TGlzdGVuZXJzKHRoaXMpOwogICAg IHJlbW92ZUFsbEJlZm9yZVVubG9hZEV2ZW50TGlzdGVuZXJzKHRoaXMpOwpAQCAtNDc0LDcgKzQ3 NCw3IEBAIHZvaWQgRE9NV2luZG93OjpmcmFtZURlc3Ryb3llZCgpCiB7CiAgICAgd2lsbERlc3Ry b3lEb2N1bWVudEluRnJhbWUoKTsKICAgICBGcmFtZURlc3RydWN0aW9uT2JzZXJ2ZXI6OmZyYW1l RGVzdHJveWVkKCk7Ci0gICAgY2xlYXJET01XaW5kb3dQcm9wZXJ0aWVzKCk7CisgICAgcmVzZXRE T01XaW5kb3dQcm9wZXJ0aWVzKCk7CiB9CiAKIHZvaWQgRE9NV2luZG93Ojp3aWxsRGV0YWNoUGFn ZSgpCkBAIC01MjIsMTYgKzUyMiwxMiBAQCB2b2lkIERPTVdpbmRvdzo6dW5yZWdpc3RlclByb3Bl cnR5KERPTVdpbmRvd1Byb3BlcnR5KiBwcm9wZXJ0eSkKICAgICBtX3Byb3BlcnRpZXMucmVtb3Zl KHByb3BlcnR5KTsKIH0KIAotdm9pZCBET01XaW5kb3c6OmNsZWFyKCkKK3ZvaWQgRE9NV2luZG93 OjpyZXNldFVubGVzc1N1c3BlbmRlZEZvclBhZ2VDYWNoZSgpCiB7Ci0gICAgLy8gVGhlIG1haW4g ZnJhbWUgd2lsbCBhbHdheXMgdHJ5IHRvIGNsZWFyIGl0cyBET01XaW5kb3cgd2hlbiBhIG5ldyBs b2FkIGlzIGNvbW1pdHRlZCwgZXZlbiBpZiB0aGF0Ci0gICAgLy8gRE9NV2luZG93IGlzIHN1c3Bl bmRlZCBpbiB0aGUgcGFnZSBjYWNoZS4KLSAgICAvLyBJbiB0aG9zZSBjYXNlcyB3ZSBuZWVkIHRv IG1ha2Ugc3VyZSB3ZSBkb24ndCBhY3R1YWxseSBjbGVhciBpdC4KICAgICBpZiAobV9zdXNwZW5k ZWRGb3JQYWdlQ2FjaGUpCiAgICAgICAgIHJldHVybjsKLSAgICAKICAgICB3aWxsRGVzdHJveURv Y3VtZW50SW5GcmFtZSgpOwotICAgIGNsZWFyRE9NV2luZG93UHJvcGVydGllcygpOworICAgIHJl c2V0RE9NV2luZG93UHJvcGVydGllcygpOwogfQogCiB2b2lkIERPTVdpbmRvdzo6c3VzcGVuZEZv clBhZ2VDYWNoZSgpCkBAIC01NjcsNyArNTYzLDcgQEAgdm9pZCBET01XaW5kb3c6OnJlY29ubmVj dERPTVdpbmRvd1Byb3BlcnRpZXMoKQogICAgICAgICBwcm9wZXJ0aWVzW2ldLT5yZWNvbm5lY3RG cmFtZUZyb21QYWdlQ2FjaGUobV9mcmFtZSk7CiB9CiAKLXZvaWQgRE9NV2luZG93OjpjbGVhckRP TVdpbmRvd1Byb3BlcnRpZXMoKQordm9pZCBET01XaW5kb3c6OnJlc2V0RE9NV2luZG93UHJvcGVy dGllcygpCiB7CiAgICAgbV9wcm9wZXJ0aWVzLmNsZWFyKCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRv dy5oCmluZGV4IGE3YzIxNmE4NGYwNGVkMGU2ODY4NTQ2ZDkyYzM3OTZjM2I4MWQzYzguLjg3Mzk2 MTg1YzI1ZGIzNmFiNWM4NGQyYjgxYzM3NmVlNzBlOTJjMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRE9NV2luZG93LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5k b3cuaApAQCAtMTA5LDcgKzEwOSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9p ZCByZWdpc3RlclByb3BlcnR5KERPTVdpbmRvd1Byb3BlcnR5Kik7CiAgICAgICAgIHZvaWQgdW5y ZWdpc3RlclByb3BlcnR5KERPTVdpbmRvd1Byb3BlcnR5Kik7CiAKLSAgICAgICAgdm9pZCBjbGVh cigpOworICAgICAgICB2b2lkIHJlc2V0VW5sZXNzU3VzcGVuZGVkRm9yUGFnZUNhY2hlKCk7CiAg ICAgICAgIHZvaWQgc3VzcGVuZEZvclBhZ2VDYWNoZSgpOwogICAgICAgICB2b2lkIHJlc3VtZUZy b21QYWdlQ2FjaGUoKTsKIApAQCAtNDIyLDcgKzQyMiw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK ICAgICAgICAgICAgIFByZXBhcmVEaWFsb2dGdW5jdGlvbiA9IDAsIHZvaWQqIGZ1bmN0aW9uQ29u dGV4dCA9IDApOwogICAgICAgICBib29sIGlzSW5zZWN1cmVTY3JpcHRBY2Nlc3MoRE9NV2luZG93 KiBhY3RpdmVXaW5kb3csIGNvbnN0IFN0cmluZyYgdXJsU3RyaW5nKTsKIAotICAgICAgICB2b2lk IGNsZWFyRE9NV2luZG93UHJvcGVydGllcygpOworICAgICAgICB2b2lkIHJlc2V0RE9NV2luZG93 UHJvcGVydGllcygpOwogICAgICAgICB2b2lkIGRpc2Nvbm5lY3RET01XaW5kb3dQcm9wZXJ0aWVz KCk7CiAgICAgICAgIHZvaWQgcmVjb25uZWN0RE9NV2luZG93UHJvcGVydGllcygpOwogICAgICAg ICB2b2lkIHdpbGxEZXN0cm95RG9jdW1lbnRJbkZyYW1lKCk7Cg==