93980 2012-08-14 09:35:15 -0700 [WK2] Implement testRunner.setUseDeferredFrameLoading 2013-01-14 14:37:59 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 svillar webkit-unassigned cdumez mrobinson svillar zoltan.nyul oldest_to_newest 695048 0 svillar 2012-08-14 09:35:15 -0700 Needed by http/tests/appcache/load-from-appcache-defer-resume-crash.html 695066 1 mrobinson 2012-08-14 09:43:55 -0700 Does this apply to all ports or only to GTK+. If it's for all ports, perhaps we should remove the "[GTK]" tag. 696860 2 svillar 2012-08-16 00:53:07 -0700 (In reply to comment #1) > Does this apply to all ports or only to GTK+. If it's for all ports, perhaps we should remove the "[GTK]" tag. Yep you're right 764140 3 173585 zoltan.nyul 2012-11-12 01:09:40 -0800 Created attachment 173585 patch I added the setDeferredLoading method to the idl and TestRunner class, but the implementation would be just adding a timer for the mainloop like in the wk1 mac port, but the InjectedBundle is already asynchronous so i think there's no need for extra timers. 806636 4 173585 benjamin 2013-01-14 14:37:59 -0800 Comment on attachment 173585 patch View in context: https://bugs.webkit.org/attachment.cgi?id=173585&action=review Thank you for looking into this. > LayoutTests/platform/efl-wk2/TestExpectations:-199 > -# testRunner.setUseDeferredFrameLoading() is not implemented in WK2. Skipped so it does not generate PNG results. > -webkit.org/b/93980 http/tests/appcache/load-from-appcache-defer-resume-crash.html [ Skip ] > - What about gtk-wk2? > Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:116 > + // The InjectedBundle is already asynchronous so we don't need to implement it > + void setUseDeferredFrameLoading(bool) { } Doing that would be wrong. Any future test that would do "setUseDeferredFrameLoading(false)" would use an unimplemented feature. (What you could have done instead is rename the method so that it can only be set. E.g. forceDeferredFrameLoading().) I also think not doing anything is probably wrong. WebPage seems to have an API for deferredFrameLoading: WebPage::setDefersLoading(). 173585 2012-11-12 01:09:40 -0800 2013-01-14 14:37:59 -0800 patch 93980_implement_testRunner_setUseDeferredFrameLoading.patch text/plain 3545 zoltan.nyul ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NDFkNzE1Li5hODZhOWQ1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMTEt MDkgIFpvbHRhbiBOeXVsICA8em9sdGFuLm55dWxAaW50ZWwuY29tPgorCisgICAgICAgIFtXSzJd IEltcGxlbWVudCB0ZXN0UnVubmVyLnNldFVzZURlZmVycmVkRnJhbWVMb2FkaW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mzk4MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBmYWlsdXJlIGV4 cGVjdGF0aW9uIGZvciBodHRwL3Rlc3RzL2FwcGNhY2hlL2xvYWQtZnJvbS1hcHBjYWNoZS1kZWZl ci1yZXN1bWUtY3Jhc2guaHRtbCwKKyAgICAgICAgYmVjYXVzZSBpdCdzIGZpeGVkIGJ5IGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mzk4MAorCisgICAgICAgICogcGxh dGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEyLTExLTA1ICBaYW4gRG9iZXJz ZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBHVEsgZ2Fy ZGVuaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMi9UZXN0RXhw ZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRpb25z CmluZGV4IGU2MWVlMTcuLjBkYTRlYjcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2VmbC13azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwt d2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE5NCw5ICsxOTQsNiBAQCBCdWcoRUZMKSBmYXN0L21l ZGlhL3ZpZXctbW9kZS1tZWRpYS1mZWF0dXJlLmh0bWwgWyBGYWlsdXJlIF0KICMgV2ViS2l0VGVz dFJ1bm5lciBuZWVkcyBhbiBpbXBsZW1lbnRhdGlvbiBmb3IgZXZlbnRTZW5kZXIuc2NoZWR1bGVB c3luY2hyb25vdXNLZXlEb3duCiB3ZWJraXQub3JnL2IvOTM5NzkgZmFzdC9tdXRhdGlvbi9lbmQt b2YtdGFzay1kZWxpdmVyeS5odG1sIFsgRmFpbHVyZSBdCiAKLSMgdGVzdFJ1bm5lci5zZXRVc2VE ZWZlcnJlZEZyYW1lTG9hZGluZygpIGlzIG5vdCBpbXBsZW1lbnRlZCBpbiBXSzIuIFNraXBwZWQg c28gaXQgZG9lcyBub3QgZ2VuZXJhdGUgUE5HIHJlc3VsdHMuCi13ZWJraXQub3JnL2IvOTM5ODAg aHR0cC90ZXN0cy9hcHBjYWNoZS9sb2FkLWZyb20tYXBwY2FjaGUtZGVmZXItcmVzdW1lLWNyYXNo Lmh0bWwgWyBTa2lwIF0KLQogIyBXZWJLaXRUZXN0UnVubmVyIG5lZWRzIGFuIGltcGxlbWVudGF0 aW9uIGZvciB0ZXN0UnVubmVyLnNldFN0b3JhZ2VEYXRhYmFzZUlkbGVJbnRlcnZhbAogd2Via2l0 Lm9yZy9iLzkzOTgyIHN0b3JhZ2UvZG9tc3RvcmFnZS9zdG9yYWdlLWNsb3NlLWRhdGFiYXNlLW9u LWlkbGUuaHRtbCBbIEZhaWx1cmUgXQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9U b29scy9DaGFuZ2VMb2cKaW5kZXggNzIxYTIxYS4uY2IwMDhmNyAxMDA2NDQKLS0tIGEvVG9vbHMv Q2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEx LTA5ICBab2x0YW4gTnl1bCAgPHpvbHRhbi5ueXVsQGludGVsLmNvbT4KKworICAgICAgICBbV0sy XSBJbXBsZW1lbnQgdGVzdFJ1bm5lci5zZXRVc2VEZWZlcnJlZEZyYW1lTG9hZGluZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM5ODAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc2V0VXNlRGVmZXJy ZWRGcmFtZUxvYWRpbmcgZm9yIFdlYktpdFRlc3RSdW5uZXIuIAorCisgICAgICAgICogV2ViS2l0 VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9CaW5kaW5ncy9UZXN0UnVubmVyLmlkbDoKKyAgICAg ICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuaDoKKyAgICAg ICAgKFRlc3RSdW5uZXIpOgorICAgICAgICAoV1RSOjpUZXN0UnVubmVyOjpzZXRVc2VEZWZlcnJl ZEZyYW1lTG9hZGluZyk6CisKIDIwMTItMTEtMDUgIEt5dW5nVGFlIEtpbSAgPGt0Zi5raW1Ac2Ft c3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gRml4IGJ1aWxkIHdhcm5pbmcgaW4gRVdlYkxhdW5j aGVyL21haW4uYwpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1 bmRsZS9CaW5kaW5ncy9UZXN0UnVubmVyLmlkbCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5q ZWN0ZWRCdW5kbGUvQmluZGluZ3MvVGVzdFJ1bm5lci5pZGwKaW5kZXggNmRhZDFiMi4uM2NkOTY0 MiAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9CaW5k aW5ncy9UZXN0UnVubmVyLmlkbAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVk QnVuZGxlL0JpbmRpbmdzL1Rlc3RSdW5uZXIuaWRsCkBAIC03Miw2ICs3Miw3IEBAIGludGVyZmFj ZSBUZXN0UnVubmVyIHsKICAgICB2b2lkIHNldFRhYktleUN5Y2xlc1Rocm91Z2hFbGVtZW50cyhp biBib29sZWFuIGVuYWJsZWQpOwogICAgIHZvaWQgc2V0U2VyaWFsaXplSFRUUExvYWRzKCk7CiAg ICAgdm9pZCBkaXNwYXRjaFBlbmRpbmdMb2FkUmVxdWVzdHMoKTsKKyAgICB2b2lkIHNldFVzZURl ZmVycmVkRnJhbWVMb2FkaW5nKGluIGJvb2xlYW4gZmxhZyk7CiAKICAgICAvLyBTcGVjaWFsIERP TSBmdW5jdGlvbnMuCiAgICAgdm9pZCBjbGVhckJhY2tGb3J3YXJkTGlzdCgpOwpkaWZmIC0tZ2l0 IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9UZXN0UnVubmVyLmggYi9U b29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuaAppbmRleCA0 OGI5MjJjLi41YzEzM2FiIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVj dGVkQnVuZGxlL1Rlc3RSdW5uZXIuaAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVj dGVkQnVuZGxlL1Rlc3RSdW5uZXIuaApAQCAtMTEyLDYgKzExMiw4IEBAIHB1YmxpYzoKICAgICB2 b2lkIHNldFRhYktleUN5Y2xlc1Rocm91Z2hFbGVtZW50cyhib29sKTsKICAgICB2b2lkIHNldFNl cmlhbGl6ZUhUVFBMb2FkcygpOwogICAgIHZvaWQgZGlzcGF0Y2hQZW5kaW5nTG9hZFJlcXVlc3Rz KCk7CisgICAgLy8gVGhlIEluamVjdGVkQnVuZGxlIGlzIGFscmVhZHkgYXN5bmNocm9ub3VzIHNv IHdlIGRvbid0IG5lZWQgdG8gaW1wbGVtZW50IGl0CisgICAgdm9pZCBzZXRVc2VEZWZlcnJlZEZy YW1lTG9hZGluZyhib29sKSB7IH0KIAogICAgIC8vIFNwZWNpYWwgRE9NIGZ1bmN0aW9ucy4KICAg ICBKU1ZhbHVlUmVmIGNvbXB1dGVkU3R5bGVJbmNsdWRpbmdWaXNpdGVkSW5mbyhKU1ZhbHVlUmVm IGVsZW1lbnQpOwo=