93972 2012-08-14 08:53:13 -0700 beginElement() does not observe updated animation attributes 2012-08-14 14:34:16 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fmalita fmalita krit webkit.review.bot zimmermann oldest_to_newest 695020 0 158343 fmalita 2012-08-14 08:53:13 -0700 Created attachment 158343 Circle should move left-to-right, then right-to-left If an expired animation's attributes are updated programmatically and then the animation is restarted using beginElement(), the new values are ignored. In the attached test, the green circle should animate left-to-right, then right-to-left. Instead, it animates left-to-right twice. A workaround is to update the 'dur' attribute. Chromium issue: http://code.google.com/p/chromium/issues/detail?id=141793 695253 1 fmalita 2012-08-14 12:34:51 -0700 The 'from', 'to' & 'by' attributes are not claimed (isSupportedAttribute) by any of the SVGSMILElement descendants, hence updates are ignored. Patch coming soon. 695265 2 158394 fmalita 2012-08-14 12:43:52 -0700 Created attachment 158394 Patch 695336 3 158394 krit 2012-08-14 13:33:16 -0700 Comment on attachment 158394 Patch I don't think that this approach is correct. You make these attributes animatable, but they aren't from the spec. point of view. 695345 4 fmalita 2012-08-14 13:45:07 -0700 (In reply to comment #3) > (From update of attachment 158394 [details]) > I don't think that this approach is correct. You make these attributes animatable, but they aren't from the spec. point of view. Hm, not sure I understand: why are you saying the patch makes these animatable? AFAICT, isSupportedAttribute() == true doesn't mean the attribute is animatable - am I missing something? Looking at both SVG & SMIL specs, from/to/by appear to be defined at the same level as begin/end/dur/... - which are currently listed in SVGSMILElement::isSupportedAttribute(). 695356 5 158394 krit 2012-08-14 13:51:32 -0700 Comment on attachment 158394 Patch Sorry, my fault. Mixed it up with something different :(. 695402 6 158394 webkit.review.bot 2012-08-14 14:34:12 -0700 Comment on attachment 158394 Patch Clearing flags on attachment: 158394 Committed r125608: <http://trac.webkit.org/changeset/125608> 695403 7 webkit.review.bot 2012-08-14 14:34:16 -0700 All reviewed patches have been landed. Closing bug. 158343 2012-08-14 08:53:13 -0700 2012-08-14 08:53:13 -0700 Circle should move left-to-right, then right-to-left update-animation.svg image/svg+xml 558 fmalita PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPgogIDxjaXJjbGUgY3g9IjEw IiBjeT0iMTAiIHI9IjEwIiBmaWxsPSJncmVlbiI+CiAgICA8YW5pbWF0ZVRyYW5zZm9ybSBpZD0i YW5pIiBhdHRyaWJ1dGVOYW1lPSJ0cmFuc2Zvcm0iIGF0dHJpYnV0ZVR5cGU9InhtbCIgdHlwZT0i dHJhbnNsYXRlIiBmcm9tPSIxMCIgdG89IjIwMCIgYmVnaW49IjBzIiBkdXI9IjFzIiBmaWxsPSJm cmVlemUiIGFkZGl0aXZlPSJyZXBsYWNlIi8+CiAgPC9jaXJjbGU+Cgo8c2NyaXB0PgogIHdpbmRv dy5zZXRUaW1lb3V0KGZ1bmN0aW9uKCkgewogICAgdmFyIGFuaSA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCdhbmknKTsKICAgIGFuaS5zZXRBdHRyaWJ1dGUoImZyb20iLCAiMjAwIik7CiAgICBh bmkuc2V0QXR0cmlidXRlKCJ0byIsICIxMCIpOwogICAgLy9hbmkuc2V0QXR0cmlidXRlKCJiZWdp biIsICIycyIpOwogICAgLy9hbmkuc2V0QXR0cmlidXRlKCJkdXIiLCAiMXMiKTsKCiAgICBhbmku YmVnaW5FbGVtZW50KCk7CiAgfSwgMTEwMCk7Cjwvc2NyaXB0Pgo8L3N2Zz4K 158394 2012-08-14 12:43:52 -0700 2012-08-14 14:34:12 -0700 Patch bug-93972-20120814154319.patch text/plain 6235 fmalita U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2IwMWRiMTBlNTQ5NTY3 ZGQwYmQyY2M0MzdjMjZmNzQyNTA4Y2I2ZS4uZTFhMTJiNWE1YTcwZjExN2VhZmNmNDRmNDg1MTUx MjFkN2VhMDAyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTE0ICBGbG9y aW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgYmVnaW5FbGVtZW50 KCkgZG9lcyBub3Qgb2JzZXJ2ZSB1cGRhdGVkIGFuaW1hdGlvbiBhdHRyaWJ1dGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mzk3MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBTVkcgYW5pbWF0aW9u IGF0dHJpYnV0ZXMgJ2Zyb20nLCAndG8nIGFuZCAnYnknIHNob3VsZCBiZSByZWdpc3RlcmVkIGFz IHN1cHBvcnRlZAorICAgICAgICBTVkdTTUlMRWxlbWVudCBhdHRyaWJ1dGVzIGluIG9yZGVyIHRv IHRyaWdnZXIgYW5pbWF0aW9uQXR0cmlidXRlQ2hhbmdlZCgpIG9uIGR5bmFtaWMKKyAgICAgICAg dXBkYXRlcy4KKworICAgICAgICBUZXN0OiBzdmcvYW5pbWF0aW9ucy91cGRhdGVkLWF0dHJpYnV0 ZXMuaHRtbAorCisgICAgICAgICogc3ZnL1NWR0FuaW1hdGlvbkVsZW1lbnQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6U1ZHQW5pbWF0aW9uRWxlbWVudDo6dXBkYXRlQW5pbWF0aW9uKToKKyAgICAg ICAgTWlub3Igb3B0aW1pemF0aW9uIC0gYXZvaWQgcmVjYWxjdWxhdGluZyBhbmltYXRpb25Nb2Rl KCkuCisKKyAgICAgICAgKiBzdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlNWR1NNSUxFbGVtZW50Ojppc1N1cHBvcnRlZEF0dHJpYnV0ZSk6CisgICAg ICAgIFJlZ2lzdGVyICdmcm9tJywgJ3RvJyBhbmQgJ2J5JyBhcyBzdXBwb3J0ZWQgU1ZHU01JTEVs ZW1lbnQgYXR0cmlidXRlcy4KKwogMjAxMi0wOC0xNCAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29u QHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEdldCByaWQgb2YgZ2xDb3B5VGV4SW1h Z2UyRCBpbiBDYW52YXMgYW5kIFdlYkdMIGNvZGUgcGF0aHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3N2Zy9TVkdBbmltYXRpb25FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9T VkdBbmltYXRpb25FbGVtZW50LmNwcAppbmRleCAzNGYwZGMwZmNkODFkYjQwYWExNGQ2MWUyNzc4 M2ZhZjc4MDViYmMwLi42YWNlNjFiZWU5ZGQ5MDUzYThiYWMzZTBlNGRlZjk1NzUxNmZiMTNiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHQW5pbWF0aW9uRWxlbWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0FuaW1hdGlvbkVsZW1lbnQuY3BwCkBAIC01NzQsOCAr NTc0LDkgQEAgdm9pZCBTVkdBbmltYXRpb25FbGVtZW50Ojp1cGRhdGVBbmltYXRpb24oZmxvYXQg cGVyY2VudCwgdW5zaWduZWQgcmVwZWF0Q291bnQsIFMKICAgICAgICAgcmV0dXJuOwogCiAgICAg ZmxvYXQgZWZmZWN0aXZlUGVyY2VudDsKLSAgICBDYWxjTW9kZSBtb2RlID0gY2FsY01vZGUoKTsK LSAgICBpZiAoYW5pbWF0aW9uTW9kZSgpID09IFZhbHVlc0FuaW1hdGlvbikgeworICAgIENhbGNN b2RlIGNhbGNNb2RlID0gdGhpcy0+Y2FsY01vZGUoKTsKKyAgICBBbmltYXRpb25Nb2RlIGFuaW1h dGlvbk1vZGUgPSB0aGlzLT5hbmltYXRpb25Nb2RlKCk7CisgICAgaWYgKGFuaW1hdGlvbk1vZGUg PT0gVmFsdWVzQW5pbWF0aW9uKSB7CiAgICAgICAgIFN0cmluZyBmcm9tOwogICAgICAgICBTdHJp bmcgdG87CiAgICAgICAgIGN1cnJlbnRWYWx1ZXNGb3JWYWx1ZXNBbmltYXRpb24ocGVyY2VudCwg ZWZmZWN0aXZlUGVyY2VudCwgZnJvbSwgdG8pOwpAQCAtNTg2LDExICs1ODcsMTEgQEAgdm9pZCBT VkdBbmltYXRpb25FbGVtZW50Ojp1cGRhdGVBbmltYXRpb24oZmxvYXQgcGVyY2VudCwgdW5zaWdu ZWQgcmVwZWF0Q291bnQsIFMKICAgICAgICAgICAgIG1fbGFzdFZhbHVlc0FuaW1hdGlvbkZyb20g PSBmcm9tOwogICAgICAgICAgICAgbV9sYXN0VmFsdWVzQW5pbWF0aW9uVG8gPSB0bzsKICAgICAg ICAgfQotICAgIH0gZWxzZSBpZiAoIW1fa2V5UG9pbnRzLmlzRW1wdHkoKSAmJiBtb2RlICE9IENh bGNNb2RlUGFjZWQpCisgICAgfSBlbHNlIGlmICghbV9rZXlQb2ludHMuaXNFbXB0eSgpICYmIGNh bGNNb2RlICE9IENhbGNNb2RlUGFjZWQpCiAgICAgICAgIGVmZmVjdGl2ZVBlcmNlbnQgPSBjYWxj dWxhdGVQZXJjZW50RnJvbUtleVBvaW50cyhwZXJjZW50KTsKLSAgICBlbHNlIGlmIChtX2tleVBv aW50cy5pc0VtcHR5KCkgJiYgbW9kZSA9PSBDYWxjTW9kZVNwbGluZSAmJiBtX2tleVRpbWVzLnNp emUoKSA+IDEpCisgICAgZWxzZSBpZiAobV9rZXlQb2ludHMuaXNFbXB0eSgpICYmIGNhbGNNb2Rl ID09IENhbGNNb2RlU3BsaW5lICYmIG1fa2V5VGltZXMuc2l6ZSgpID4gMSkKICAgICAgICAgZWZm ZWN0aXZlUGVyY2VudCA9IGNhbGN1bGF0ZVBlcmNlbnRGb3JTcGxpbmUocGVyY2VudCwgY2FsY3Vs YXRlS2V5VGltZXNJbmRleChwZXJjZW50KSk7Ci0gICAgZWxzZSBpZiAoYW5pbWF0aW9uTW9kZSgp ID09IEZyb21Ub0FuaW1hdGlvbiB8fCBhbmltYXRpb25Nb2RlKCkgPT0gVG9BbmltYXRpb24pCisg ICAgZWxzZSBpZiAoYW5pbWF0aW9uTW9kZSA9PSBGcm9tVG9BbmltYXRpb24gfHwgYW5pbWF0aW9u TW9kZSA9PSBUb0FuaW1hdGlvbikKICAgICAgICAgZWZmZWN0aXZlUGVyY2VudCA9IGNhbGN1bGF0 ZVBlcmNlbnRGb3JGcm9tVG8ocGVyY2VudCk7CiAgICAgZWxzZQogICAgICAgICBlZmZlY3RpdmVQ ZXJjZW50ID0gcGVyY2VudDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRp b24vU1ZHU01JTEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TVkdT TUlMRWxlbWVudC5jcHAKaW5kZXggMGRjNmE4YTVkYTNiYmYxZjg5NDFiMWVlYmViY2NjNDNhYWIx NDg4OC4uNDNlODRiMWIzNWJkMDVlYzcyMWYyMzhmNzU1NmU3OGUxODBlOTgzNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TVkdTTUlMRWxlbWVudC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TVkdTTUlMRWxlbWVudC5jcHAKQEAgLTQxMCw2 ICs0MTAsOSBAQCBib29sIFNWR1NNSUxFbGVtZW50Ojppc1N1cHBvcnRlZEF0dHJpYnV0ZShjb25z dCBRdWFsaWZpZWROYW1lJiBhdHRyTmFtZSkKICAgICAgICAgc3VwcG9ydGVkQXR0cmlidXRlcy5h ZGQoU1ZHTmFtZXM6Om1pbkF0dHIpOwogICAgICAgICBzdXBwb3J0ZWRBdHRyaWJ1dGVzLmFkZChT VkdOYW1lczo6bWF4QXR0cik7CiAgICAgICAgIHN1cHBvcnRlZEF0dHJpYnV0ZXMuYWRkKFNWR05h bWVzOjphdHRyaWJ1dGVOYW1lQXR0cik7CisgICAgICAgIHN1cHBvcnRlZEF0dHJpYnV0ZXMuYWRk KFNWR05hbWVzOjpmcm9tQXR0cik7CisgICAgICAgIHN1cHBvcnRlZEF0dHJpYnV0ZXMuYWRkKFNW R05hbWVzOjp0b0F0dHIpOworICAgICAgICBzdXBwb3J0ZWRBdHRyaWJ1dGVzLmFkZChTVkdOYW1l czo6YnlBdHRyKTsKICAgICAgICAgc3VwcG9ydGVkQXR0cmlidXRlcy5hZGQoWExpbmtOYW1lczo6 aHJlZkF0dHIpOwogICAgIH0KICAgICByZXR1cm4gc3VwcG9ydGVkQXR0cmlidXRlcy5jb250YWlu czxRdWFsaWZpZWROYW1lLCBTVkdBdHRyaWJ1dGVIYXNoVHJhbnNsYXRvcj4oYXR0ck5hbWUpOwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IDM4YzQ4MGNjZTZiOTJmYTg1OThiYTRhNzVjMmMzMWIwYTZhNzIxZTYuLmIzODZjMzY5 NTE5YmE4ZTA1OTNjYzRlZGIyYTBkOGUwNGUzZGRhOTIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxMi0wOC0xNCAgRmxvcmluIE1hbGl0YSAgPGZtYWxpdGFAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIGJlZ2luRWxlbWVudCgpIGRvZXMgbm90IG9ic2VydmUgdXBkYXRlZCBhbmltYXRpb24gYXR0 cmlidXRlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTM5NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHN2Zy9hbmltYXRpb25zL3VwZGF0ZWQtYXR0cmlidXRlcy1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIHN2Zy9hbmltYXRpb25zL3VwZGF0ZWQtYXR0cmlidXRlcy5odG1sOiBBZGRlZC4K KwogMjAxMi0wOC0xNCAgVGhpYWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGlu dGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBHYXJkZW5pbmcgb2YgZmFpbGluZyB0ZXN0cyBhbmQg bmV3IHBhc3NlcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvdXBkYXRl ZC1hdHRyaWJ1dGVzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL3Vw ZGF0ZWQtYXR0cmlidXRlcy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNmI4NDZjMGE1MjYzNzgx YzVjMDBjM2RkMTFhYmI3ZGQzM2YyYWIwMgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L3N2Zy9hbmltYXRpb25zL3VwZGF0ZWQtYXR0cmlidXRlcy1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSwyIEBACitQQVNTOiBhbmltYXRlZCB3aWR0aCBpcyAxMDAKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvc3ZnL2FuaW1hdGlvbnMvdXBkYXRlZC1hdHRyaWJ1dGVzLmh0bWwgYi9MYXlvdXRUZXN0 cy9zdmcvYW5pbWF0aW9ucy91cGRhdGVkLWF0dHJpYnV0ZXMuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iY2Jk ZGI3Y2VmYTFjZDdhOTM4NzY3OWNlZjAwZDU2YWJlZmNmMjZjCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvdXBkYXRlZC1hdHRyaWJ1dGVzLmh0bWwKQEAgLTAs MCArMSwzNiBAQAorPGh0bWw+Cis8Ym9keT4KKyAgPCEtLSBUZXN0IGZvciBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM5NzIgLS0+CisgIDxkaXYgaWQ9InJlc3VsdCI+ PC9kaXY+CisKKyAgPHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPgorICAg IDxyZWN0IGlkPSJyZWN0IiBoZWlnaHQ9IjEwMCIgZmlsbD0iZ3JlZW4iPgorICAgICAgPGFuaW1h dGUgaWQ9ImFuaW1hdGlvbiIgYXR0cmlidXRlTmFtZT0id2lkdGgiIGZyb209IjEwIiB0bz0iMTAw IiBiZWdpbj0iMHMiIGR1cj0iaW5kZWZpbml0ZSIgZmlsbD0iZnJlZXplIiAvPgorICAgIDwvcmVj dD4KKyAgPC9zdmc+CisKKzxzY3JpcHQ+CisgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAg IHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgp OworICB9CisKKyAgZnVuY3Rpb24gY2hlY2soKSB7CisgICAgdmFyIHdpZHRoID0gZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoJ3JlY3QnKS53aWR0aC5hbmltVmFsLnZhbHVlOworICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQnKS5pbm5lckhUTUwgPSAod2lkdGggPT0gMTAwID8gIlBB U1M6ICIgOiAiRkFJTDogIikgKyAnYW5pbWF0ZWQgd2lkdGggaXMgJyArIHdpZHRoOworCisgICAg aWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Cisg IH0KKworICB3aW5kb3cuc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICB2YXIgYW5pID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2FuaW1hdGlvbicpOworICAgIGFuaS5zZXRBdHRyaWJ1dGUo ImZyb20iLCAiMTAwIik7CisgICAgYW5pLmJlZ2luRWxlbWVudCgpOworCisgICAgd2luZG93LnNl dFRpbWVvdXQoZnVuY3Rpb24oKSB7IGNoZWNrKCk7IH0sIDApOworICB9LCAwKTsKKzwvc2NyaXB0 PgorPC9ib2R5PgorPC9odG1sPgorCg==