93970 2012-08-14 08:26:59 -0700 REGRESSION r125500: 7 tests crashing on Mac bots 2012-08-14 14:02:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://build-safari.apple.com/results/Mountain%20Lion%20Debug%20Tests/r125500_44228%20(2510)/results.html P2 Normal --- 1 eric.carlson tsepez dino eric tsepez webkit.review.bot oldest_to_newest 695000 0 eric.carlson 2012-08-14 08:26:59 -0700 The following tests started crashing on the Mac bots between r125497 and r125500 (inclusive): http/tests/security/contentSecurityPolicy/object-src-url-blocked.html userscripts/user-script-top-frame-only.html fast/loader/reload-zero-byte-plugin.html fast/frames/iframe-plugin-load-remove-document-crash.html plugins/plugin-document-back-forward.html plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream.html plugins/inner-html-display-none.html http://trac.webkit.org/log/trunk?rev=125500&stop_rev=125497&limit=5 http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r125495%20%282315%29/results.html succeeded http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r125500%20%282316%29/results.html failed 695067 1 tsepez 2012-08-14 09:44:14 -0700 Undoubtedly fallout from https://bugs.webkit.org/show_bug.cgi?id=93283. Eric, I'd suggest putting the NULL checks back in for the other ports that we'd agreed to remove from the original patch. 695074 2 eric.carlson 2012-08-14 09:52:39 -0700 (In reply to comment #1) > Undoubtedly fallout from https://bugs.webkit.org/show_bug.cgi?id=93283. Eric, I'd suggest putting the NULL checks back in for the other ports that we'd agreed to remove from the original patch. I don't have access to the bug. Can you fix it? 695212 3 158387 tsepez 2012-08-14 11:50:10 -0700 Created attachment 158387 Patch 695233 4 158387 eric 2012-08-14 12:16:49 -0700 Comment on attachment 158387 Patch OK. 695368 5 158387 webkit.review.bot 2012-08-14 14:02:39 -0700 Comment on attachment 158387 Patch Clearing flags on attachment: 158387 Committed r125601: <http://trac.webkit.org/changeset/125601> 695369 6 webkit.review.bot 2012-08-14 14:02:43 -0700 All reviewed patches have been landed. Closing bug. 158387 2012-08-14 11:50:10 -0700 2012-08-14 14:02:39 -0700 Patch patch_93970.txt text/plain 1422 tsepez SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTU4NSkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTE0 ICBUb20gU2VwZXogIDx0c2VwZXpAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04g cjEyNTUwMDogNyB0ZXN0cyBjcmFzaGluZyBvbiBNYWMgYm90cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM5NzAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIFdlYkZyYW1lTG9hZGVyQ2xpZW50Ojpy ZWRpcmVjdERhdGFUb1BsdWdpbiBleHBlY3QgdGhlIG5vdyByZWFsIHBvc3NpYmlsaXR5CisgICAg ICAgIG9mIGEgTlVMTCBwbHVnaW5XaWRnZXQgYXJndW1lbnQuCisKKyAgICAgICAgKiBXZWJDb3Jl U3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5tbToKKyAgICAgICAgKFdlYkZyYW1lTG9hZGVy Q2xpZW50OjpyZWRpcmVjdERhdGFUb1BsdWdpbikKKyAgICAgICAgCiAyMDEyLTA4LTA5ICBLaW51 a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBodHRwL3Rlc3RzL3Nl Y3VyaXR5L21peGVkQ29udGVudC9ibG9iLXVybC1pbi1pZnJhbWUuaHRtbCBmYWlscyBvbiBNYWMK SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xp ZW50Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dl YkZyYW1lTG9hZGVyQ2xpZW50Lm1tCShyZXZpc2lvbiAxMjU1ODMpCisrKyBTb3VyY2UvV2ViS2l0 L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5tbQkod29ya2luZyBjb3B5 KQpAQCAtMTcyNCw2ICsxNzI0LDkgQEAgUGFzc1JlZlB0cjxXaWRnZXQ+IFdlYkZyYW1lTG9hZGVy Q2xpZW50OgogCiB2b2lkIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpyZWRpcmVjdERhdGFUb1BsdWdp bihXaWRnZXQqIHBsdWdpbldpZGdldCkKIHsKKyAgICBpZiAoIXBsdWdpbldpZGdldCkKKyAgICAg ICAgcmV0dXJuOworCiAgICAgQkVHSU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TOwogCiAgICAgV2Vi SFRNTFJlcHJlc2VudGF0aW9uICpyZXByZXNlbnRhdGlvbiA9IChXZWJIVE1MUmVwcmVzZW50YXRp b24gKilbW21fd2ViRnJhbWUuZ2V0KCkgX2RhdGFTb3VyY2VdIHJlcHJlc2VudGF0aW9uXTsK