93959 2012-08-14 05:10:52 -0700 Refactor EventDispatcher, moving code to make actual changes easier to review later 2012-08-14 17:56:22 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91290 1 hayato hayato dglazkov webcomponents-bugzilla webkit.review.bot oldest_to_newest 694850 0 hayato 2012-08-14 05:10:52 -0700 This is one of the separated patches from https://bugs.webkit.org/attachment.cgi?id=157682. See the comment https://bugs.webkit.org/show_bug.cgi?id=91290#c26. 694854 1 158300 hayato 2012-08-14 05:15:54 -0700 Created attachment 158300 move code 695604 2 158300 webkit.review.bot 2012-08-14 17:56:18 -0700 Comment on attachment 158300 move code Clearing flags on attachment: 158300 Committed r125626: <http://trac.webkit.org/changeset/125626> 695605 3 webkit.review.bot 2012-08-14 17:56:22 -0700 All reviewed patches have been landed. Closing bug. 158300 2012-08-14 05:15:54 -0700 2012-08-14 17:56:17 -0700 move code bug-93959-20120814211522.patch text/plain 4611 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzM5NzM2ZWJmMzI1MzY3 ODJhZjUxOTE0NjY4OWZmYzJkYzhiNTFmZS4uYjgyMmVmOGNiZWViOWRmNmU4MDZiNDQyZDQ0MTVk NjYyMjEyNTg1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTE0ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZWZhY3RvciBFdmVudERp c3BhdGNoZXIsIG1vdmluZyBjb2RlIHRvIG1ha2UgYWN0dWFsIGNoYW5nZXMgZWFzaWVyIHRvIHJl dmlldyBsYXRlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTkzOTU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzIC0gbm8gbmV3IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBkb20v RXZlbnREaXNwYXRjaGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50RGlzcGF0Y2hlcjo6 ZGlzcGF0Y2hTY29wZWRFdmVudCk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNv cmU6OkV2ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0Y2hTaW11bGF0ZWRDbGljayk6CisKIDIwMTItMDgt MTQgIFlvc2hpZnVtaSBJbm91ZSAgPHlvc2luQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbRm9y bXNdIE1vdmUgd2hlZWwgZXZlbnQgaGFuZGxlciB0byBzcGluIGJ1dHRvbiBjbGFzcwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcAppbmRleCBlMWE2MGYzZDQwYjNhMjk1Zjk3ZmE4 MWU2OTBmY2FkZDc1Mjg0Y2I0Li4zMGFmMGYzM2M2YmM5YzVlMzgwYmM3YmJjYTI1NDlkOGU1YmFh NmY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcApAQCAtMTUxLDM5ICsx NTEsNiBAQCBpbmxpbmUgc3RhdGljIEV2ZW50VGFyZ2V0KiBldmVudFRhcmdldFJlc3BlY3RpbmdT VkdUYXJnZXRSdWxlcyhOb2RlKiByZWZlcmVuY2VObwogICAgIHJldHVybiByZWZlcmVuY2VOb2Rl OwogfQogCi12b2lkIEV2ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0Y2hTY29wZWRFdmVudChOb2RlKiBu b2RlLCBQYXNzUmVmUHRyPEV2ZW50RGlzcGF0Y2hNZWRpYXRvcj4gbWVkaWF0b3IpCi17Ci0gICAg Ly8gV2UgbmVlZCB0byBzZXQgdGhlIHRhcmdldCBoZXJlIGJlY2F1c2UgaXQgY2FuIGdvIGF3YXkg YnkgdGhlIHRpbWUgd2UgYWN0dWFsbHkgZmlyZSB0aGUgZXZlbnQuCi0gICAgbWVkaWF0b3ItPmV2 ZW50KCktPnNldFRhcmdldChldmVudFRhcmdldFJlc3BlY3RpbmdTVkdUYXJnZXRSdWxlcyhub2Rl KSk7Ci0gICAgU2NvcGVkRXZlbnRRdWV1ZTo6aW5zdGFuY2UoKS0+ZW5xdWV1ZUV2ZW50RGlzcGF0 Y2hNZWRpYXRvcihtZWRpYXRvcik7Ci19Ci0KLXZvaWQgRXZlbnREaXNwYXRjaGVyOjpkaXNwYXRj aFNpbXVsYXRlZENsaWNrKE5vZGUqIG5vZGUsIFBhc3NSZWZQdHI8RXZlbnQ+IHVuZGVybHlpbmdF dmVudCwgYm9vbCBzZW5kTW91c2VFdmVudHMsIGJvb2wgc2hvd1ByZXNzZWRMb29rKQotewotICAg IGlmIChub2RlLT5kaXNhYmxlZCgpKQotICAgICAgICByZXR1cm47Ci0KLSAgICBpZiAoIWdOb2Rl c0Rpc3BhdGNoaW5nU2ltdWxhdGVkQ2xpY2tzKQotICAgICAgICBnTm9kZXNEaXNwYXRjaGluZ1Np bXVsYXRlZENsaWNrcyA9IG5ldyBIYXNoU2V0PE5vZGUqPjsKLSAgICBlbHNlIGlmIChnTm9kZXNE aXNwYXRjaGluZ1NpbXVsYXRlZENsaWNrcy0+Y29udGFpbnMobm9kZSkpCi0gICAgICAgIHJldHVy bjsKLQotICAgIGdOb2Rlc0Rpc3BhdGNoaW5nU2ltdWxhdGVkQ2xpY2tzLT5hZGQobm9kZSk7Ci0K LSAgICAvLyBzZW5kIG1vdXNlZG93biBhbmQgbW91c2V1cCBiZWZvcmUgdGhlIGNsaWNrLCBpZiBy ZXF1ZXN0ZWQKLSAgICBpZiAoc2VuZE1vdXNlRXZlbnRzKQotICAgICAgICBFdmVudERpc3BhdGNo ZXIobm9kZSkuZGlzcGF0Y2hFdmVudChTaW11bGF0ZWRNb3VzZUV2ZW50OjpjcmVhdGUoZXZlbnRO YW1lcygpLm1vdXNlZG93bkV2ZW50LCBub2RlLT5kb2N1bWVudCgpLT5kZWZhdWx0VmlldygpLCB1 bmRlcmx5aW5nRXZlbnQpKTsKLSAgICBub2RlLT5zZXRBY3RpdmUodHJ1ZSwgc2hvd1ByZXNzZWRM b29rKTsKLSAgICBpZiAoc2VuZE1vdXNlRXZlbnRzKQotICAgICAgICBFdmVudERpc3BhdGNoZXIo bm9kZSkuZGlzcGF0Y2hFdmVudChTaW11bGF0ZWRNb3VzZUV2ZW50OjpjcmVhdGUoZXZlbnROYW1l cygpLm1vdXNldXBFdmVudCwgbm9kZS0+ZG9jdW1lbnQoKS0+ZGVmYXVsdFZpZXcoKSwgdW5kZXJs eWluZ0V2ZW50KSk7Ci0gICAgbm9kZS0+c2V0QWN0aXZlKGZhbHNlKTsKLQotICAgIC8vIGFsd2F5 cyBzZW5kIGNsaWNrCi0gICAgRXZlbnREaXNwYXRjaGVyKG5vZGUpLmRpc3BhdGNoRXZlbnQoU2lt dWxhdGVkTW91c2VFdmVudDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5jbGlja0V2ZW50LCBub2RlLT5k b2N1bWVudCgpLT5kZWZhdWx0VmlldygpLCB1bmRlcmx5aW5nRXZlbnQpKTsKLQotICAgIGdOb2Rl c0Rpc3BhdGNoaW5nU2ltdWxhdGVkQ2xpY2tzLT5yZW1vdmUobm9kZSk7Ci19Ci0KIHZvaWQgRXZl bnREaXNwYXRjaGVyOjphZGp1c3RSZWxhdGVkVGFyZ2V0KEV2ZW50KiBldmVudCwgUGFzc1JlZlB0 cjxFdmVudFRhcmdldD4gcHJwUmVsYXRlZFRhcmdldCkKIHsKICAgICBpZiAoIXBycFJlbGF0ZWRU YXJnZXQpCkBAIC0yMzgsNiArMjA1LDM5IEBAIHZvaWQgRXZlbnREaXNwYXRjaGVyOjplbnN1cmVF dmVudEFuY2VzdG9ycyhFdmVudCogZXZlbnQpCiAgICAgfQogfQogCit2b2lkIEV2ZW50RGlzcGF0 Y2hlcjo6ZGlzcGF0Y2hTY29wZWRFdmVudChOb2RlKiBub2RlLCBQYXNzUmVmUHRyPEV2ZW50RGlz cGF0Y2hNZWRpYXRvcj4gbWVkaWF0b3IpCit7CisgICAgLy8gV2UgbmVlZCB0byBzZXQgdGhlIHRh cmdldCBoZXJlIGJlY2F1c2UgaXQgY2FuIGdvIGF3YXkgYnkgdGhlIHRpbWUgd2UgYWN0dWFsbHkg ZmlyZSB0aGUgZXZlbnQuCisgICAgbWVkaWF0b3ItPmV2ZW50KCktPnNldFRhcmdldChldmVudFRh cmdldFJlc3BlY3RpbmdTVkdUYXJnZXRSdWxlcyhub2RlKSk7CisgICAgU2NvcGVkRXZlbnRRdWV1 ZTo6aW5zdGFuY2UoKS0+ZW5xdWV1ZUV2ZW50RGlzcGF0Y2hNZWRpYXRvcihtZWRpYXRvcik7Cit9 CisKK3ZvaWQgRXZlbnREaXNwYXRjaGVyOjpkaXNwYXRjaFNpbXVsYXRlZENsaWNrKE5vZGUqIG5v ZGUsIFBhc3NSZWZQdHI8RXZlbnQ+IHVuZGVybHlpbmdFdmVudCwgYm9vbCBzZW5kTW91c2VFdmVu dHMsIGJvb2wgc2hvd1ByZXNzZWRMb29rKQoreworICAgIGlmIChub2RlLT5kaXNhYmxlZCgpKQor ICAgICAgICByZXR1cm47CisKKyAgICBpZiAoIWdOb2Rlc0Rpc3BhdGNoaW5nU2ltdWxhdGVkQ2xp Y2tzKQorICAgICAgICBnTm9kZXNEaXNwYXRjaGluZ1NpbXVsYXRlZENsaWNrcyA9IG5ldyBIYXNo U2V0PE5vZGUqPjsKKyAgICBlbHNlIGlmIChnTm9kZXNEaXNwYXRjaGluZ1NpbXVsYXRlZENsaWNr cy0+Y29udGFpbnMobm9kZSkpCisgICAgICAgIHJldHVybjsKKworICAgIGdOb2Rlc0Rpc3BhdGNo aW5nU2ltdWxhdGVkQ2xpY2tzLT5hZGQobm9kZSk7CisKKyAgICAvLyBzZW5kIG1vdXNlZG93biBh bmQgbW91c2V1cCBiZWZvcmUgdGhlIGNsaWNrLCBpZiByZXF1ZXN0ZWQKKyAgICBpZiAoc2VuZE1v dXNlRXZlbnRzKQorICAgICAgICBFdmVudERpc3BhdGNoZXIobm9kZSkuZGlzcGF0Y2hFdmVudChT aW11bGF0ZWRNb3VzZUV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLm1vdXNlZG93bkV2ZW50LCBu b2RlLT5kb2N1bWVudCgpLT5kZWZhdWx0VmlldygpLCB1bmRlcmx5aW5nRXZlbnQpKTsKKyAgICBu b2RlLT5zZXRBY3RpdmUodHJ1ZSwgc2hvd1ByZXNzZWRMb29rKTsKKyAgICBpZiAoc2VuZE1vdXNl RXZlbnRzKQorICAgICAgICBFdmVudERpc3BhdGNoZXIobm9kZSkuZGlzcGF0Y2hFdmVudChTaW11 bGF0ZWRNb3VzZUV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLm1vdXNldXBFdmVudCwgbm9kZS0+ ZG9jdW1lbnQoKS0+ZGVmYXVsdFZpZXcoKSwgdW5kZXJseWluZ0V2ZW50KSk7CisgICAgbm9kZS0+ c2V0QWN0aXZlKGZhbHNlKTsKKworICAgIC8vIGFsd2F5cyBzZW5kIGNsaWNrCisgICAgRXZlbnRE aXNwYXRjaGVyKG5vZGUpLmRpc3BhdGNoRXZlbnQoU2ltdWxhdGVkTW91c2VFdmVudDo6Y3JlYXRl KGV2ZW50TmFtZXMoKS5jbGlja0V2ZW50LCBub2RlLT5kb2N1bWVudCgpLT5kZWZhdWx0Vmlldygp LCB1bmRlcmx5aW5nRXZlbnQpKTsKKworICAgIGdOb2Rlc0Rpc3BhdGNoaW5nU2ltdWxhdGVkQ2xp Y2tzLT5yZW1vdmUobm9kZSk7Cit9CisKIGJvb2wgRXZlbnREaXNwYXRjaGVyOjpkaXNwYXRjaEV2 ZW50KFBhc3NSZWZQdHI8RXZlbnQ+IHBycEV2ZW50KQogewogI2lmbmRlZiBOREVCVUcK