93957 2012-08-14 04:48:58 -0700 Clear pattern to prevent timing problem between cancelVibration and vibrate 2012-08-14 17:10:56 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kihong.kwon webkit-unassigned haraken morrita naginenis vimff0 webkit.review.bot oldest_to_newest 694823 0 kihong.kwon 2012-08-14 04:48:58 -0700 If there is javascript codes like below, navigator.vibrate(1000); navigator.vibrate(0); cancelVibrate() can be called before calling vibrate().(It's timer timing issue) In this case, cancelVibrate() is not working at all. We need to fix this. 694856 1 158301 kihong.kwon 2012-08-14 05:22:28 -0700 Created attachment 158301 Patch 694857 2 kihong.kwon 2012-08-14 05:24:42 -0700 CC haraken and morrita. 694859 3 158301 haraken 2012-08-14 05:26:17 -0700 Comment on attachment 158301 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158301&action=review > Source/WebCore/ChangeLog:11 > + There is a timing issue in the cancelVibration. > + Since vibrate works based on timer, cancelVibration might be called > + eariler than vibrate when cancelVibration is called just after vibrate call. > + It can be prevented from clearing m_pattern in the cancelVibration. Can't you write a layout test for this? 694874 4 kihong.kwon 2012-08-14 05:44:45 -0700 (In reply to comment #3) > (From update of attachment 158301 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=158301&action=review > > > Source/WebCore/ChangeLog:11 > > + There is a timing issue in the cancelVibration. > > + Since vibrate works based on timer, cancelVibration might be called > > + eariler than vibrate when cancelVibration is called just after vibrate call. > > + It can be prevented from clearing m_pattern in the cancelVibration. > > Can't you write a layout test for this? There is no return value in the Vibration API. Therefore, if we add layout test, I think we have only way to use printf like legacy notification tests.(LayoutTests/fast/notifications/) But IMHO it's not good to us. I would like to get your opinion about this please. :) 695532 5 158301 haraken 2012-08-14 16:37:06 -0700 Comment on attachment 158301 Patch Thanks, I understood that writing the test is difficult. The change looks reasonable, let's land it. 695568 6 158301 webkit.review.bot 2012-08-14 17:10:51 -0700 Comment on attachment 158301 Patch Clearing flags on attachment: 158301 Committed r125624: <http://trac.webkit.org/changeset/125624> 695569 7 webkit.review.bot 2012-08-14 17:10:56 -0700 All reviewed patches have been landed. Closing bug. 158301 2012-08-14 05:22:28 -0700 2012-08-14 17:10:51 -0700 Patch bug-93957-20120814212155.patch text/plain 1578 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDI3MGYzNTFiM2RmNTIz M2VhMzljYWU2MmMzODA1MDQxODE4ZDQ0OC4uMjYyZTQ3YTgwMTExYTAyYmFjNzhmMzg4YTE0ZTUw NGRjMGJjMmE5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTE0ICBLaWhv bmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIENsZWFyIHBhdHRl cm4gdG8gcHJldmVudCB0aW1pbmcgcHJvYmxlbSBiZXR3ZWVuIGNhbmNlbFZpYnJhdGlvbiBhbmQg dmlicmF0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTM5NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGVyZSBpcyBhIHRpbWluZyBpc3N1ZSBpbiB0aGUgY2FuY2VsVmlicmF0aW9uLgorICAgICAgICBT aW5jZSB2aWJyYXRlIHdvcmtzIGJhc2VkIG9uIHRpbWVyLCBjYW5jZWxWaWJyYXRpb24gbWlnaHQg YmUgY2FsbGVkCisgICAgICAgIGVhcmlsZXIgdGhhbiB2aWJyYXRlIHdoZW4gY2FuY2VsVmlicmF0 aW9uIGlzIGNhbGxlZCBqdXN0IGFmdGVyIHZpYnJhdGUgY2FsbC4KKyAgICAgICAgSXQgY2FuIGJl IHByZXZlbnRlZCBmcm9tIGNsZWFyaW5nIG1fcGF0dGVybiBpbiB0aGUgY2FuY2VsVmlicmF0aW9u LgorCisgICAgICAgICogTW9kdWxlcy92aWJyYXRpb24vVmlicmF0aW9uLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlZpYnJhdGlvbjo6Y2FuY2VsVmlicmF0aW9uKToKKwogMjAxMi0wOC0xNCAgS3dh bmdZb25nIENob2kgIDxreTAuY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBGaXhl ZCBkaXNwbGF5aW5nIGJ1ZmZlcmluZyBwcm9ncmVzcyBpbiB0aGUgbWVkaWEgY29udHJvbC4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvdmlicmF0aW9uL1ZpYnJhdGlvbi5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3ZpYnJhdGlvbi9WaWJyYXRpb24uY3BwCmluZGV4IGEx ZGE0YjA0NzhlNTM5Y2VmOTFkZDYzNGY0MGVkNDZkNDJlMmY5MGUuLjRkZTBjYWI4OGU2MjMxOWZk ZTI0YWJkODA4N2Y2N2M3MTA4MWUyM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvdmlicmF0aW9uL1ZpYnJhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy92 aWJyYXRpb24vVmlicmF0aW9uLmNwcApAQCAtNzMsNiArNzMsNyBAQCB2b2lkIFZpYnJhdGlvbjo6 dmlicmF0ZShjb25zdCBWaWJyYXRpb25QYXR0ZXJuJiBwYXR0ZXJuKQogCiB2b2lkIFZpYnJhdGlv bjo6Y2FuY2VsVmlicmF0aW9uKCkKIHsKKyAgICBtX3BhdHRlcm4uY2xlYXIoKTsKICAgICBpZiAo bV9pc1ZpYnJhdGluZykgewogICAgICAgICBtX3ZpYnJhdGlvbkNsaWVudC0+Y2FuY2VsVmlicmF0 aW9uKCk7CiAgICAgICAgIG1faXNWaWJyYXRpbmcgPSBmYWxzZTsK