93952 2012-08-14 03:42:16 -0700 Remove custom bindings from ConvolverNode.idl 2012-08-14 05:10:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 code.vineet code.vineet abarth eric.carlson feature-media-reviews gyuyoung.kim haraken kbr ojan rakuco webkit.review.bot oldest_to_newest 694765 0 code.vineet 2012-08-14 03:42:16 -0700 We should remove custom bindings as CodeGenerator uses UNUSED_PARAM macro. This was introduced in r72838. 694768 1 158284 code.vineet 2012-08-14 03:46:57 -0700 Created attachment 158284 Patch Actually I was planning to remove custom bindings from AudioBufferSourceNode.idl to but I couldn't find a way to throw exception from AudioBufferSourceNode::setBuffer() in AudioBufferSourceNode.cpp for both JSC and V8. Is there any way to throw TypeError in common both for JSC and V8? 694774 2 haraken 2012-08-14 03:54:04 -0700 (In reply to comment #1) > Actually I was planning to remove custom bindings from AudioBufferSourceNode.idl to but I couldn't find a way to throw exception from AudioBufferSourceNode::setBuffer() in AudioBufferSourceNode.cpp for both JSC and V8. > Is there any way to throw TypeError in common both for JSC and V8? No. If you could throw TypeError from WebCore, binding layer has to catch the error and rethrow it to JavaScript, which means that you cannot avoid handling error in the binding layer anyway. 694775 3 158284 haraken 2012-08-14 03:54:12 -0700 Comment on attachment 158284 Patch OK 694798 4 code.vineet 2012-08-14 04:25:54 -0700 (In reply to comment #2) > (In reply to comment #1) > > Actually I was planning to remove custom bindings from AudioBufferSourceNode.idl to but I couldn't find a way to throw exception from AudioBufferSourceNode::setBuffer() in AudioBufferSourceNode.cpp for both JSC and V8. > > Is there any way to throw TypeError in common both for JSC and V8? > > No. If you could throw TypeError from WebCore, binding layer has to catch the error and rethrow it to JavaScript, which means that you cannot avoid handling error in the binding layer anyway. Ohh thanks I got it. For that we can use ExceptionCode enum. So we may use INVALID_ACCESS_ERR for TypeError. But again we have different TypeError messages here like "Value is not of type AudioBuffer" and "AudioBuffer unsupported number of channels" too :(. 694807 5 haraken 2012-08-14 04:33:35 -0700 (In reply to comment #4) > Ohh thanks I got it. For that we can use ExceptionCode enum. > So we may use INVALID_ACCESS_ERR for TypeError. Actually ExceptionCode is not for JavaScript errors but for DOM exceptions. We don't want to mix them just for auto-generating code. But if we can remove a bunch of custom bindings by introducing something like that, it might be worth considering. It would depend on the benefit. > But again we have different TypeError messages here like "Value is not of type AudioBuffer" and "AudioBuffer unsupported number of channels" too :(. Yeah. My point is that "given that the binding layer has to handle the error anyway, let's handle it straightforwardly in the binding layer even if we use custom bindings". 694851 6 158284 webkit.review.bot 2012-08-14 05:10:52 -0700 Comment on attachment 158284 Patch Clearing flags on attachment: 158284 Committed r125550: <http://trac.webkit.org/changeset/125550> 694852 7 webkit.review.bot 2012-08-14 05:10:59 -0700 All reviewed patches have been landed. Closing bug. 158284 2012-08-14 03:46:57 -0700 2012-08-14 05:10:52 -0700 Patch convolverNode_patch.diff text/plain 9326 code.vineet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTUzNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTE0ICBWaW5lZXQg Q2hhdWRoYXJ5ICA8cmdmNzQ4QG1vdG9yb2xhLmNvbT4KKworICAgICAgICBSZW1vdmUgY3VzdG9t IEpTQyBiaW5kaW5ncyBmcm9tIENvbnZvbHZlck5vZGUuaWRsCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mzk1MgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCByZW1vdmUgY3VzdG9tIGJpbmRp bmdzIGFzIENvZGVHZW5lcmF0b3IgdXNlcyBVTlVTRURfUEFSQU0gbWFjcm8uCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLiBObyBiZWhhdmlvdXJhbCBjaGFuZ2VzLgorICAgICAgICBBbGwgdGVzdHMg dW5kZXIgd2ViYXVkaW8vKiBzaG91bGQgYmVoYXZlIHNhbWUuCisKKyAgICAgICAgKiBHTlVtYWtl ZmlsZS5saXN0LmFtOiBSZW1vdmVkIEpTQ29udm9sdmVyTm9kZUN1c3RvbS5jcHAgZnJvbSBidWls ZHMuCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9Db252b2x2ZXJOb2RlLmlkbDogUmVtb3Zl ZCBbSlNDdXN0b21TZXR0ZXJdLgorICAgICAgICAqIFVzZUpTQy5jbWFrZTogUmVtb3ZlZCBKU0Nv bnZvbHZlck5vZGVDdXN0b20uY3BwIGZyb20gYnVpbGRzLgorICAgICAgICAqIFdlYkNvcmUuZ3lw aTogRGl0dG8uCisgICAgICAgICogV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOiBE aXR0bworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTQ29udm9sdmVyTm9kZUN1c3RvbS5jcHA6IFJl bW92ZWQuCisKIDIwMTItMDgtMTQgIEt3YW5nWW9uZyBDaG9pICA8a3kwLmNob2lAc2Ftc3VuZy5j b20+CiAKICAgICAgICAgW0VGTF0gRml4ZWQgZGlzcGxheWluZyBidWZmZXJpbmcgcHJvZ3Jlc3Mg aW4gdGhlIG1lZGlhIGNvbnRyb2wuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5s aXN0LmFtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0J KHJldmlzaW9uIDEyNTUwNykKKysrIFNvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0J KHdvcmtpbmcgY29weSkKQEAgLTU3NzQsNyArNTc3NCw2IEBAIHdlYmNvcmVfc291cmNlcyArPSBc CiAJU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9XYXZlVGFibGUuaCBcCiAJU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvSlNBdWRpb0J1ZmZlclNvdXJjZU5vZGVDdXN0b20uY3BwIFwK IAlTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0F1ZGlvQ29udGV4dEN1c3RvbS5jcHAgXAot CVNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ29udm9sdmVyTm9kZUN1c3RvbS5jcHAgXAog CVNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSmF2YVNjcmlwdEF1ZGlvTm9kZUN1c3RvbS5j cHAgXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0F1ZGlvQXJyYXkuaCBcCiAJU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vQXVkaW9CdXMuY3BwIFwKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL1VzZUpTQy5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Vc2VKU0Mu Y21ha2UJKHJldmlzaW9uIDEyNTUwNykKKysrIFNvdXJjZS9XZWJDb3JlL1VzZUpTQy5jbWFrZQko d29ya2luZyBjb3B5KQpAQCAtMjc2LDcgKzI3Niw2IEBAIElGIChFTkFCTEVfV0VCX0FVRElPKQog ICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwogICAgICAgICBiaW5kaW5ncy9qcy9KU0F1 ZGlvQnVmZmVyU291cmNlTm9kZUN1c3RvbS5jcHAKICAgICAgICAgYmluZGluZ3MvanMvSlNBdWRp b0NvbnRleHRDdXN0b20uY3BwCi0gICAgICAgIGJpbmRpbmdzL2pzL0pTQ29udm9sdmVyTm9kZUN1 c3RvbS5jcHAKICAgICAgICAgYmluZGluZ3MvanMvSlNKYXZhU2NyaXB0QXVkaW9Ob2RlQ3VzdG9t LmNwcAogICAgICkKIEVORElGICgpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXBpCShyZXZpc2lvbiAxMjU1 MDcpCisrKyBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkJKHdvcmtpbmcgY29weSkKQEAgLTE5 NjAsNyArMTk2MCw2IEBACiAgICAgICAgICAgICAnYmluZGluZ3MvanMvSlNDYW52YXNSZW5kZXJp bmdDb250ZXh0Q3VzdG9tLmNwcCcsCiAgICAgICAgICAgICAnYmluZGluZ3MvanMvSlNDbGlwYm9h cmRDdXN0b20uY3BwJywKICAgICAgICAgICAgICdiaW5kaW5ncy9qcy9KU0NvbnNvbGVDdXN0b20u Y3BwJywKLSAgICAgICAgICAgICdiaW5kaW5ncy9qcy9KU0NvbnZvbHZlck5vZGVDdXN0b20uY3Bw JywKICAgICAgICAgICAgICdiaW5kaW5ncy9qcy9KU0Nvb3JkaW5hdGVzQ3VzdG9tLmNwcCcsCiAg ICAgICAgICAgICAnYmluZGluZ3MvanMvSlNDdXN0b21TUUxTdGF0ZW1lbnRFcnJvckNhbGxiYWNr LmNwcCcsCiAgICAgICAgICAgICAnYmluZGluZ3MvanMvSlNDdXN0b21Wb2lkQ2FsbGJhY2suY3Bw JywKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQ29udm9sdmVyTm9kZS5p ZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9Db252b2x2 ZXJOb2RlLmlkbAkocmV2aXNpb24gMTI1NTA3KQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJhdWRpby9Db252b2x2ZXJOb2RlLmlkbAkod29ya2luZyBjb3B5KQpAQCAtMjgsNyArMjgsNyBA QCBtb2R1bGUgYXVkaW8gewogICAgICAgICBDb25kaXRpb25hbD1XRUJfQVVESU8sCiAgICAgICAg IEpTR2VuZXJhdGVUb0pTT2JqZWN0CiAgICAgXSBDb252b2x2ZXJOb2RlIDogQXVkaW9Ob2RlIHsK LSAgICAgICAgYXR0cmlidXRlIFtKU0N1c3RvbVNldHRlcl0gQXVkaW9CdWZmZXIgYnVmZmVyOwor ICAgICAgICBhdHRyaWJ1dGUgQXVkaW9CdWZmZXIgYnVmZmVyOwogICAgICAgICBhdHRyaWJ1dGUg Ym9vbGVhbiBub3JtYWxpemU7CiAgICAgfTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL1dlYkNv cmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvago9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oJKHJldmlzaW9uIDEyNTUwNykKKysr IFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagkod29ya2lu ZyBjb3B5KQpAQCAtNjQ5OSw3ICs2NDk5LDYgQEAKIAkJRkRFQTYyNDcxNTIxMDJGQzAwNDc5REYw IC8qIEpTV2F2ZVRhYmxlLmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZp bGVSZWYgPSBGREVBNjI0NTE1MjEwMkZDMDA0NzlERjAgLyogSlNXYXZlVGFibGUuaCAqLzsgfTsK IAkJRkRFQUFBRjMxMkIwMkVFNDAwRENGMzNCIC8qIEpTQXVkaW9CdWZmZXJTb3VyY2VOb2RlQ3Vz dG9tLmNwcCBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IEZE RUFBQUVGMTJCMDJFRTQwMERDRjMzQiAvKiBKU0F1ZGlvQnVmZmVyU291cmNlTm9kZUN1c3RvbS5j cHAgKi87IH07CiAJCUZERUFBQUY0MTJCMDJFRTQwMERDRjMzQiAvKiBKU0F1ZGlvQ29udGV4dEN1 c3RvbS5jcHAgaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBG REVBQUFGMDEyQjAyRUU0MDBEQ0YzM0IgLyogSlNBdWRpb0NvbnRleHRDdXN0b20uY3BwICovOyB9 OwotCQlGREVBQUFGNjEyQjAyRUU0MDBEQ0YzM0IgLyogSlNDb252b2x2ZXJOb2RlQ3VzdG9tLmNw cCBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IEZERUFBQUYy MTJCMDJFRTQwMERDRjMzQiAvKiBKU0NvbnZvbHZlck5vZGVDdXN0b20uY3BwICovOyB9OwogCQlG REVBQUFGRTEyQjAyRjQ5MDBEQ0YzM0IgLyogSlNKYXZhU2NyaXB0QXVkaW9Ob2RlQ3VzdG9tLmNw cCBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IEZERUFBQUZE MTJCMDJGNDkwMERDRjMzQiAvKiBKU0phdmFTY3JpcHRBdWRpb05vZGVDdXN0b20uY3BwICovOyB9 OwogCQlGREYwOURDODEzOTlCNjIyMDA2ODhFNUIgLyogSlNCaXF1YWRGaWx0ZXJOb2RlLmNwcCBp biBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IEZERjA5REM2MTM5 OUI2MjIwMDY4OEU1QiAvKiBKU0JpcXVhZEZpbHRlck5vZGUuY3BwICovOyB9OwogCQlGREYwOURD OTEzOTlCNjIyMDA2ODhFNUIgLyogSlNCaXF1YWRGaWx0ZXJOb2RlLmggaW4gSGVhZGVycyAqLyA9 IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBGREYwOURDNzEzOTlCNjIyMDA2ODhFNUIg LyogSlNCaXF1YWRGaWx0ZXJOb2RlLmggKi87IH07CkBAIC0xMzg5Myw3ICsxMzg5Miw2IEBACiAJ CUZERUE2MjQ1MTUyMTAyRkMwMDQ3OURGMCAvKiBKU1dhdmVUYWJsZS5oICovID0ge2lzYSA9IFBC WEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gc291 cmNlY29kZS5jLmg7IHBhdGggPSBKU1dhdmVUYWJsZS5oOyBzb3VyY2VUcmVlID0gIjxncm91cD4i OyB9OwogCQlGREVBQUFFRjEyQjAyRUU0MDBEQ0YzM0IgLyogSlNBdWRpb0J1ZmZlclNvdXJjZU5v ZGVDdXN0b20uY3BwICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9 IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jcHAuY3BwOyBwYXRoID0gSlNBdWRp b0J1ZmZlclNvdXJjZU5vZGVDdXN0b20uY3BwOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9Owog CQlGREVBQUFGMDEyQjAyRUU0MDBEQ0YzM0IgLyogSlNBdWRpb0NvbnRleHRDdXN0b20uY3BwICov ID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZp bGVUeXBlID0gc291cmNlY29kZS5jcHAuY3BwOyBwYXRoID0gSlNBdWRpb0NvbnRleHRDdXN0b20u Y3BwOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwotCQlGREVBQUFGMjEyQjAyRUU0MDBEQ0Yz M0IgLyogSlNDb252b2x2ZXJOb2RlQ3VzdG9tLmNwcCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJl bmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuY3Bw LmNwcDsgcGF0aCA9IEpTQ29udm9sdmVyTm9kZUN1c3RvbS5jcHA7IHNvdXJjZVRyZWUgPSAiPGdy b3VwPiI7IH07CiAJCUZERUFBQUZEMTJCMDJGNDkwMERDRjMzQiAvKiBKU0phdmFTY3JpcHRBdWRp b05vZGVDdXN0b20uY3BwICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGlu ZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jcHAuY3BwOyBwYXRoID0gSlNK YXZhU2NyaXB0QXVkaW9Ob2RlQ3VzdG9tLmNwcDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsK IAkJRkRGMDlEQzYxMzk5QjYyMjAwNjg4RTVCIC8qIEpTQmlxdWFkRmlsdGVyTm9kZS5jcHAgKi8g PSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmls ZVR5cGUgPSBzb3VyY2Vjb2RlLmNwcC5jcHA7IHBhdGggPSBKU0JpcXVhZEZpbHRlck5vZGUuY3Bw OyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQlGREYwOURDNzEzOTlCNjIyMDA2ODhFNUIg LyogSlNCaXF1YWRGaWx0ZXJOb2RlLmggKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgZmls ZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmMuaDsgcGF0aCA9 IEpTQmlxdWFkRmlsdGVyTm9kZS5oOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwpAQCAtMjAy MTYsNyArMjAyMTQsNiBAQAogCQkJCTkzQkE1OUIxMEYyQUE1RkUwMDhFOEU5OSAvKiBKU0NEQVRB U2VjdGlvbkN1c3RvbS5jcHAgKi8sCiAJCQkJQkNBODNFNTEwRDdDRTIwNTAwMzQyMUE4IC8qIEpT Q2xpcGJvYXJkQ3VzdG9tLmNwcCAqLywKIAkJCQlDMERGQzg2RjBEQjY4NDFBMDAzRUFFN0MgLyog SlNDb25zb2xlQ3VzdG9tLmNwcCAqLywKLQkJCQlGREVBQUFGMjEyQjAyRUU0MDBEQ0YzM0IgLyog SlNDb252b2x2ZXJOb2RlQ3VzdG9tLmNwcCAqLywKIAkJCQlGRTcwMEREMDBGOTJEODFBMDA4RTJC RkUgLyogSlNDb29yZGluYXRlc0N1c3RvbS5jcHAgKi8sCiAJCQkJRTFBRDE0OTAxMjk3MzM3NDAw QUNBOTg5IC8qIEpTQ1NTRm9udEZhY2VSdWxlQ3VzdG9tLmNwcCAqLywKIAkJCQlFMUFEMTQ3QjEy OTczMDdFMDBBQ0E5ODkgLyogSlNDU1NJbXBvcnRSdWxlQ3VzdG9tLmNwcCAqLywKQEAgLTI2ODkw LDcgKzI2ODg3LDYgQEAKIAkJCQlCQzk4NTQzRDBDRDNEOThCMDAwNjlCQzEgLyogSlNDb25zb2xl LmNwcCBpbiBTb3VyY2VzICovLAogCQkJCUMwREZDODcwMERCNjg0MUEwMDNFQUU3QyAvKiBKU0Nv bnNvbGVDdXN0b20uY3BwIGluIFNvdXJjZXMgKi8sCiAJCQkJRkRBMTVFQkQxMkIwM0YwQjAwM0E1 ODNBIC8qIEpTQ29udm9sdmVyTm9kZS5jcHAgaW4gU291cmNlcyAqLywKLQkJCQlGREVBQUFGNjEy QjAyRUU0MDBEQ0YzM0IgLyogSlNDb252b2x2ZXJOb2RlQ3VzdG9tLmNwcCBpbiBTb3VyY2VzICov LAogCQkJCUZFNkZENDhEMEY2NzZFOTMwMDA5Mjg3MyAvKiBKU0Nvb3JkaW5hdGVzLmNwcCBpbiBT b3VyY2VzICovLAogCQkJCUZFNzAwREQxMEY5MkQ4MUEwMDhFMkJGRSAvKiBKU0Nvb3JkaW5hdGVz Q3VzdG9tLmNwcCBpbiBTb3VyY2VzICovLAogCQkJCTkzMDcwNUQ4MDlFMEM5QjcwMEIxN0ZFNCAv KiBKU0NvdW50ZXIuY3BwIGluIFNvdXJjZXMgKi8sCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU0NvbnZvbHZlck5vZGVDdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ29udm9sdmVyTm9kZUN1c3RvbS5jcHAJKHJldmlzaW9uIDEy NTUwNykKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ29udm9sdmVyTm9kZUN1c3Rv bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEsNDcgKzAsMCBAQAotLyoKLSAqIENvcHlyaWdodCAo QykgMjAxMCwgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KLSAqCi0gKiBSZWRpc3Ry aWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhv dXQKLSAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xs b3dpbmcgY29uZGl0aW9ucwotICogYXJlIG1ldDoKLSAqIDEuICBSZWRpc3RyaWJ1dGlvbnMgb2Yg c291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAotICogICAgbm90aWNl LCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgot ICogMi4gIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUg YWJvdmUgY29weXJpZ2h0Ci0gKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFu ZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCi0gKiAgICBkb2N1bWVudGF0aW9uIGFu ZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgotICoK LSAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRS SUJVVE9SUyBgYEFTIElTJycgQU5EIEFOWQotICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJ RVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRAotICogV0FSUkFO VElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQ T1NFIEFSRQotICogRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJ VFMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZCi0gKiBESVJFQ1QsIElORElSRUNULCBJ TkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUwot ICogKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElU VVRFIEdPT0RTIE9SIFNFUlZJQ0VTOwotICogTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7 IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OCi0gKiBBTlkg VEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElU WSwgT1IgVE9SVAotICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lO RyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMKLSAqIFNPRlRXQVJFLCBFVkVOIElG IEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgotICovCi0KLSNpbmNs dWRlICJjb25maWcuaCIKLQotI2lmIEVOQUJMRShXRUJfQVVESU8pCi0KLSNpbmNsdWRlICJDb252 b2x2ZXJOb2RlLmgiCi0KLSNpbmNsdWRlICJBdWRpb0J1ZmZlci5oIgotI2luY2x1ZGUgIkpTQXVk aW9CdWZmZXIuaCIKLSNpbmNsdWRlICJKU0NvbnZvbHZlck5vZGUuaCIKLQotdXNpbmcgbmFtZXNw YWNlIEpTQzsKLQotbmFtZXNwYWNlIFdlYkNvcmUgewotCi12b2lkIEpTQ29udm9sdmVyTm9kZTo6 c2V0QnVmZmVyKEV4ZWNTdGF0ZSosIEpTVmFsdWUgdmFsdWUpCi17Ci0gICAgQ29udm9sdmVyTm9k ZSogaW1wID0gc3RhdGljX2Nhc3Q8Q29udm9sdmVyTm9kZSo+KGltcGwoKSk7Ci0gICAgaW1wLT5z ZXRCdWZmZXIodG9BdWRpb0J1ZmZlcih2YWx1ZSkpOwotfQotCi19IC8vIG5hbWVzcGFjZSBXZWJD b3JlCi0KLSNlbmRpZiAvLyBFTkFCTEUoV0VCX0FVRElPKQo=