<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>93931</bug_id>
          
          <creation_ts>2012-08-13 22:17:40 -0700</creation_ts>
          <short_desc>[EFL] Remove alloca usage.</short_desc>
          <delta_ts>2012-08-17 05:19:08 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kangil Han">kangil.han</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>g.czajkowski</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>rakuco</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>694505</commentid>
    <comment_count>0</comment_count>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-13 22:17:40 -0700</bug_when>
    <thetext>Fixed compile time warning with respect to array and uninitialized variables.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>694507</commentid>
    <comment_count>1</comment_count>
      <attachid>158214</attachid>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-13 22:20:06 -0700</bug_when>
    <thetext>Created attachment 158214
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>694540</commentid>
    <comment_count>2</comment_count>
      <attachid>158214</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-13 23:09:48 -0700</bug_when>
    <thetext>Comment on attachment 158214
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158214&amp;action=review

&gt; Source/WebCore/platform/efl/ScrollbarEfl.cpp:174
&gt; -    char buffer[sizeof(Edje_Message_Float_Set) + sizeof(double)];
&gt; -    Edje_Message_Float_Set* message = reinterpret_cast&lt;Edje_Message_Float_Set*&gt;(buffer);
&gt; +    Edje_Message_Float_Set* message = static_cast&lt;Edje_Message_Float_Set*&gt;(alloca(sizeof(Edje_Message_Float_Set) + sizeof(double)));

Whenever you change weird constructs like this, you must check the logs and use svn blame first -- there is a reason for not using alloca() here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>694648</commentid>
    <comment_count>3</comment_count>
      <attachid>158256</attachid>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-14 01:23:43 -0700</bug_when>
    <thetext>Created attachment 158256
patch

Under current edje implementation, it seems we wouldn&apos;t avoid malloc usage even in cpp source code. :-(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>694665</commentid>
    <comment_count>4</comment_count>
    <who name="Grzegorz Czajkowski">g.czajkowski</who>
    <bug_when>2012-08-14 01:45:17 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; Created an attachment (id=158256) [details]
&gt; patch
&gt; 
&gt; Under current edje implementation, it seems we wouldn&apos;t avoid malloc usage even in cpp source code. :-(

Informal r- from my side because of two reason:

1) According to WebKit-Efl style we should avoid memory allocation with malloc and friends. new operator is preferred. 

2) I don&apos;t see any benefits of allocating/freeing memory in this case.

You can get more information here https://bugs.webkit.org/show_bug.cgi?id=72017.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>694679</commentid>
    <comment_count>5</comment_count>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-14 01:54:32 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Informal r- from my side because of two reason:
&gt; 
&gt; 1) According to WebKit-Efl style we should avoid memory allocation with malloc and friends. new operator is preferred. 
&gt; 
&gt; 2) I don&apos;t see any benefits of allocating/freeing memory in this case.
&gt; 
&gt; You can get more information here https://bugs.webkit.org/show_bug.cgi?id=72017.

Would you please suggest a way to remove build warning message under this circumstances?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>694722</commentid>
    <comment_count>6</comment_count>
      <attachid>158269</attachid>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-14 02:31:32 -0700</bug_when>
    <thetext>Created attachment 158269
patch

How about this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>694733</commentid>
    <comment_count>7</comment_count>
    <who name="Grzegorz Czajkowski">g.czajkowski</who>
    <bug_when>2012-08-14 03:06:52 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; Created an attachment (id=158269) [details]
&gt; patch
&gt; 
&gt; How about this?

Thanks for the patch and newly introduced solution how to avoid problems with a little problematic Edje_Message_Float_Set struct.

In the origin code &apos;buffer&apos; is created on stack, so we don&apos;t need to take of freeing memory and possibles memory leaks but compiler complains on &apos;message&apos; pointer after reinterpret_cast that it is not initialized.

Your patch creates &apos;buffer&apos; on heap and it&apos;s deleted when function returns (delete [] buffer).
Additionally you have to twice cast, char * -&gt; void and then void* -&gt; Edje_Message_Float_Set*. 

Is it really worth to resolve this compilation warning?
Kubo what do you think?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>694911</commentid>
    <comment_count>8</comment_count>
      <attachid>158269</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-14 06:36:04 -0700</bug_when>
    <thetext>Comment on attachment 158269
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158269&amp;action=review

&gt; Source/WebCore/ChangeLog:17
&gt; +        * platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
&gt; +        (WebCore::HarfBuzzShaper::selectionRect): fix &apos;toX and fromX may be used uninitialized in this function&apos; warning.

Note that this isn&apos;t related to the bug title anymore :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>694912</commentid>
    <comment_count>9</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-14 06:37:43 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; Is it really worth to resolve this compilation warning?
&gt; Kubo what do you think?

I tried the following snippet here:

    char buffer[sizeof(Edje_Message_Float_Set) + sizeof(double)];
    Edje_Message_Float_Set *message = reinterpret_cast&lt;Edje_Message_Float_Set*&gt;(buffer);

and neither gcc 4.7.1 nor clang 3.1 with -Wall and -Wextra have raised any warning such as the one Kangil mentions in the ChangeLog.

Kangil, what compiler are you using and what flags are being passed to it when building these files?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>696504</commentid>
    <comment_count>10</comment_count>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-15 16:45:06 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; I tried the following snippet here:
&gt; 
&gt;     char buffer[sizeof(Edje_Message_Float_Set) + sizeof(double)];
&gt;     Edje_Message_Float_Set *message = reinterpret_cast&lt;Edje_Message_Float_Set*&gt;(buffer);
&gt; 
&gt; and neither gcc 4.7.1 nor clang 3.1 with -Wall and -Wextra have raised any warning such as the one Kangil mentions in the ChangeLog.
&gt; 
&gt; Kangil, what compiler are you using and what flags are being passed to it when building these files?

Here it is. :-)
{
gcc (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1

/home/hankangil/dev/WebKit/webkit-gtk/WebKit/Source/WebCore/platform/efl/ScrollbarEfl.cpp:184:23: warning: array subscript is above array bounds [-Warray-bounds]
/home/hankangil/dev/WebKit/webkit-gtk/WebKit/Source/WebCore/platform/efl/ScrollbarEfl.cpp:186:23: warning: array subscript is above array bounds [-Warray-bounds]
}

(In reply to comment #8)
&gt; Note that this isn&apos;t related to the bug title anymore :-)

I will select better title after figuring out the direction how I could resolve build warning with respect to strange edje message stuff. ;-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>696573</commentid>
    <comment_count>11</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-15 17:57:33 -0700</bug_when>
    <thetext>(In reply to comment #10)
&gt; &gt; and neither gcc 4.7.1 nor clang 3.1 with -Wall and -Wextra have raised any warning such as the one Kangil mentions in the ChangeLog.
&gt; &gt; 
&gt; &gt; Kangil, what compiler are you using and what flags are being passed to it when building these files?
&gt; 
&gt; Here it is. :-)
&gt; {
&gt; gcc (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1

Right. I&apos;ve tried the following snippet with gcc 4.6.3 and it didn&apos;t produce any warnings either:

#include &lt;Edje.h&gt;

int main()
{
    char buffer[sizeof(Edje_Message_Float_Set) + sizeof(double)];
    Edje_Message_Float_Set* message = reinterpret_cast&lt;Edje_Message_Float_Set*&gt;(buffer);

    message-&gt;count = 2;
    message-&gt;val[0] = 0.0;
    message-&gt;val[1] = 1.0;

    return 0;
}

Does this code make your compiler produce any kind of warning?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>696584</commentid>
    <comment_count>12</comment_count>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-15 18:12:01 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; Does this code make your compiler produce any kind of warning?

I used &apos;g++ (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1&apos; and found *NO* error on your code snippet. This is very interesting!!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>696774</commentid>
    <comment_count>13</comment_count>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-15 23:09:41 -0700</bug_when>
    <thetext>Here is interesting result I&apos;ve found. It depends on gcc optimization flag.

-O0(no optimization) : no warning message.
-O1 : no warning message.
-O2 : test.cpp:16:19: warning: array subscript is above array bounds [-Warray-bounds]
-O3(actually used in efl build) : test.cpp:16:19: warning: array subscript is above array bounds [-Warray-bounds]

Given circumstances, my two cents on this, I know edje has implemented unusually, using *new* keyword would be unavoidable.

rakuco, grzegorz: how do you think about this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>696789</commentid>
    <comment_count>14</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-15 23:45:20 -0700</bug_when>
    <thetext>OK, I&apos;ve managed to reproduce that warning with my code snippet by calling edje_object_message_send() in it (clang still doesn&apos;t produce any warning).

There are two possible solutions here:

1) Use plain old malloc() here specifying the amount of bytes we want to allocate and avoiding all those casts.

2) Refining Kangil&apos;s proposed patch.

Solution 2) is interesting because the static_cast&lt;void*&gt;() is not necessary, so we can remove some bloat. We could also pass the allocated memory to an OwnPtr, thus avoiding the need to free the memory manually.

Kangil, can you produce a new patch following those suggestions (please also refrain from changing variable names to keep it as short as possible)?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>696796</commentid>
    <comment_count>15</comment_count>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-15 23:52:57 -0700</bug_when>
    <thetext>(In reply to comment #14)
&gt; OK, I&apos;ve managed to reproduce that warning with my code snippet by calling edje_object_message_send() in it (clang still doesn&apos;t produce any warning).
&gt; 
&gt; There are two possible solutions here:
&gt; 
&gt; 1) Use plain old malloc() here specifying the amount of bytes we want to allocate and avoiding all those casts.
&gt; 
&gt; 2) Refining Kangil&apos;s proposed patch.
&gt; 
&gt; Solution 2) is interesting because the static_cast&lt;void*&gt;() is not necessary, so we can remove some bloat. We could also pass the allocated memory to an OwnPtr, thus avoiding the need to free the memory manually.
&gt; 
&gt; Kangil, can you produce a new patch following those suggestions (please also refrain from changing variable names to keep it as short as possible)?

Sure, I will get back with an updated one. ;-)
Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>696814</commentid>
    <comment_count>16</comment_count>
    <who name="Grzegorz Czajkowski">g.czajkowski</who>
    <bug_when>2012-08-16 00:14:19 -0700</bug_when>
    <thetext>(In reply to comment #14)
&gt; OK, I&apos;ve managed to reproduce that warning with my code snippet by calling edje_object_message_send() in it (clang still doesn&apos;t produce any warning).
&gt; 
&gt; There are two possible solutions here:
&gt; 
&gt; 1) Use plain old malloc() here specifying the amount of bytes we want to allocate and avoiding all those casts.
&gt; 
How about using new placement instead? Does it produce warning too? I couldn&apos;t verify it as I am facing problem to access svn.enlightenment.org and git.webkit.org :/ sorry

char* buffer = new char[sizeof(Edje_Message_Float_Set) + sizeof(double)])
Edje_Message_Float_Set* message = new(buffer) Edje_Message_Float_Set;

This plus smart pointer may be another solution for us.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>696871</commentid>
    <comment_count>17</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-16 01:00:39 -0700</bug_when>
    <thetext>(In reply to comment #16)
&gt; How about using new placement instead? Does it produce warning too?

I don&apos;t think you can use placement new here, as Edje_Message_Float_Set is a C type that does not have a constructor or a placement new overload.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>696879</commentid>
    <comment_count>18</comment_count>
    <who name="Grzegorz Czajkowski">g.czajkowski</who>
    <bug_when>2012-08-16 01:14:15 -0700</bug_when>
    <thetext>(In reply to comment #17)
&gt; (In reply to comment #16)
&gt; &gt; How about using new placement instead? Does it produce warning too?
&gt; 
&gt; I don&apos;t think you can use placement new here, as Edje_Message_Float_Set is a C type that does not have a constructor or a placement new overload.

Hmm, I&apos;ve been trying to use this one at https://bugs.webkit.org/show_bug.cgi?id=72017 (see 5th patch). As I remember it has worked.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>696885</commentid>
    <comment_count>19</comment_count>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-16 01:19:12 -0700</bug_when>
    <thetext>(In reply to comment #18)
&gt; Hmm, I&apos;ve been trying to use this one at https://bugs.webkit.org/show_bug.cgi?id=72017 (see 5th patch). As I remember it has worked.

Don&apos;t worry. I will test your code snippet and get back with result. :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>696931</commentid>
    <comment_count>20</comment_count>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-16 02:10:10 -0700</bug_when>
    <thetext>grzegorz&apos;s code snippet works. :-)

rakuco, grzegorz: we can pick better one. which one would you prefer?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>697166</commentid>
    <comment_count>21</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-16 08:26:50 -0700</bug_when>
    <thetext>(In reply to comment #20)
&gt; grzegorz&apos;s code snippet works. :-)

Hmm, it was failing here because &lt;new&gt; had to be included in that snippet I was using.

Go for the placement new version, as it is cleaner and conveys the intents better than the casts. Just for safety, please #include &lt;new&gt; as well to make sure the global placement new overload is available.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>697898</commentid>
    <comment_count>22</comment_count>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-16 22:43:46 -0700</bug_when>
    <thetext>(In reply to comment #21)
&gt; Hmm, it was failing here because &lt;new&gt; had to be included in that snippet I was using.
&gt; 
&gt; Go for the placement new version, as it is cleaner and conveys the intents better than the casts. Just for safety, please #include &lt;new&gt; as well to make sure the global placement new overload is available.

new version has one drawback.
it seems we couldn&apos;t use OwnPtr for this case.
Would you prefer explicit *delete* usage?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>697953</commentid>
    <comment_count>23</comment_count>
      <attachid>159017</attachid>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-17 00:04:50 -0700</bug_when>
    <thetext>Created attachment 159017
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>697972</commentid>
    <comment_count>24</comment_count>
      <attachid>159017</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-17 00:25:44 -0700</bug_when>
    <thetext>Comment on attachment 159017
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159017&amp;action=review

&gt; Source/WebCore/ChangeLog:3
&gt; +        [EFL] Remove alloca usage and fix compile warning in WebCore

The original title about removing warnings from WebCore makes more sense here, as removing alloca is part of this process.

&gt; Source/WebCore/ChangeLog:9
&gt; +        To keep portable source code, alloca has been discouraged.
&gt; +        Therefore, this patch removed alloca usage from EFL port.

I would mention here that we&apos;re unifying the approaches for the creation of Edje_Message_Float_Set messages, and getting rid of alloca is part of it, since it is not portable. It&apos;d also be good to mention the compiler warnings you were getting.

&gt; Source/WebCore/platform/efl/RenderThemeEfl.cpp:360
&gt; +    edje_object_message_send(entry-&gt;o, EDJE_MESSAGE_FLOAT_SET, 0, msg);

See the comment in line 327; you do not need to send this message unconditionally.

&gt; Source/WebCore/platform/efl/RenderThemeEfl.cpp:450
&gt; +            EINA_LOG_ERR(&quot;Could not set file: %s&quot;, errmsg);

Not really related to this patch.

&gt; Source/WebCore/platform/efl/ScrollbarEfl.cpp:175
&gt; +    Edje_Message_Float_Set* msg = new(buffer.get()) Edje_Message_Float_Set;

The renaming of this variable makes the patch needlessly bigger.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>698044</commentid>
    <comment_count>25</comment_count>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-17 01:35:49 -0700</bug_when>
    <thetext>(In reply to comment #24)
&gt; &gt; Source/WebCore/platform/efl/RenderThemeEfl.cpp:360
&gt; &gt; +    edje_object_message_send(entry-&gt;o, EDJE_MESSAGE_FLOAT_SET, 0, msg);
&gt; 
&gt; See the comment in line 327; you do not need to send this message unconditionally.
&gt; 

I couldn&apos;t see your comment in line 327. What was that about?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>698049</commentid>
    <comment_count>26</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-17 01:52:18 -0700</bug_when>
    <thetext>(In reply to comment #25)
&gt; I couldn&apos;t see your comment in line 327. What was that about?

http://trac.webkit.org/browser/trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp#L327</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>698102</commentid>
    <comment_count>27</comment_count>
      <attachid>159060</attachid>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-17 02:46:55 -0700</bug_when>
    <thetext>Created attachment 159060
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>698107</commentid>
    <comment_count>28</comment_count>
      <attachid>159060</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-08-17 02:50:07 -0700</bug_when>
    <thetext>Comment on attachment 159060
patch

Looks great, thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>698114</commentid>
    <comment_count>29</comment_count>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-17 02:53:30 -0700</bug_when>
    <thetext>(In reply to comment #28)
&gt; (From update of attachment 159060 [details])
&gt; Looks great, thanks!

Thanks for great review, too!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>698132</commentid>
    <comment_count>30</comment_count>
    <who name="Grzegorz Czajkowski">g.czajkowski</who>
    <bug_when>2012-08-17 03:11:59 -0700</bug_when>
    <thetext>Informal r+ from my side too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>698142</commentid>
    <comment_count>31</comment_count>
    <who name="Kangil Han">kangil.han</who>
    <bug_when>2012-08-17 03:18:17 -0700</bug_when>
    <thetext>(In reply to comment #30)
&gt; Informal r+ from my side too.

Thanks grzegorz. Your suggestion(using *new*) has helped me a lot. :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>698226</commentid>
    <comment_count>32</comment_count>
      <attachid>159060</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2012-08-17 05:14:10 -0700</bug_when>
    <thetext>Comment on attachment 159060
patch

LGTM</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>698233</commentid>
    <comment_count>33</comment_count>
      <attachid>159060</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-17 05:19:01 -0700</bug_when>
    <thetext>Comment on attachment 159060
patch

Clearing flags on attachment: 159060

Committed r125883: &lt;http://trac.webkit.org/changeset/125883&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>698234</commentid>
    <comment_count>34</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-17 05:19:08 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>158214</attachid>
            <date>2012-08-13 22:20:06 -0700</date>
            <delta_ts>2012-08-14 01:23:43 -0700</delta_ts>
            <desc>patch</desc>
            <filename>build_warning_patch.txt</filename>
            <type>text/plain</type>
            <size>2326</size>
            <attacher name="Kangil Han">kangil.han</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAxOWQxY2U1Li5lM2Q3YjA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTItMDgtMTQgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg
ICAgICAgIFJlbW92ZSBXZWJDb3JlIGJ1aWxkIHdhcm5pbmcgbWVzc2FnZS4KKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzOTMxCisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgY29tcGlsZSB0aW1lIHdh
cm5pbmcgd2l0aCByZXNwZWN0IHRvIGFycmF5IGFuZCB1bmluaXRpYWxpemVkIHZhcmlhYmxlcy4K
KworICAgICAgICAqIHBsYXRmb3JtL2VmbC9TY3JvbGxiYXJFZmwuY3BwOgorICAgICAgICAoU2Ny
b2xsYmFyRWZsOjp1cGRhdGVUaHVtYlBvc2l0aW9uQW5kUHJvcG9ydGlvbik6IGZpeCAnYXJyYXkg
c3Vic2NyaXB0IGlzIGFib3ZlIGFycmF5IGJvdW5kcycgY29tcGlsZSB3YXJuaW5nLgorICAgICAg
ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L25nL0hhcmZCdXp6U2hhcGVyLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OkhhcmZCdXp6U2hhcGVyOjpzZWxlY3Rpb25SZWN0KTogZml4ICd0b1gg
YW5kIGZyb21YIG1heSBiZSB1c2VkIHVuaW5pdGlhbGl6ZWQgaW4gdGhpcyBmdW5jdGlvbicgd2Fy
bmluZy4KKwogMjAxMi0wOC0xMiAgU2hhd24gU2luZ2ggIDxzaGF3bnNpbmdoQGNocm9taXVtLm9y
Zz4KIAogICAgICAgICBbY2hyb21pdW1dIHJlbmRlclN1cmZhY2UgaW4gaW5jb3JyZWN0IHNwYWNl
IGlmIG93bmluZyBsYXllciBoYXMgZW1wdHkgYnV0IG5vbi16ZXJvIGJvdW5kcwpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHAgYi9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcAppbmRleCBjZTdmN2JmLi40NjEx
ZjFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZs
LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcApA
QCAtMTcxLDggKzE3MSw3IEBAIHZvaWQgU2Nyb2xsYmFyRWZsOjp1cGRhdGVUaHVtYlBvc2l0aW9u
QW5kUHJvcG9ydGlvbigpCiAgICAgbV9sYXN0VG90YWxTaXplID0gdFNpemU7CiAgICAgbV9sYXN0
VmlzaWJsZVNpemUgPSB2U2l6ZTsKIAotICAgIGNoYXIgYnVmZmVyW3NpemVvZihFZGplX01lc3Nh
Z2VfRmxvYXRfU2V0KSArIHNpemVvZihkb3VibGUpXTsKLSAgICBFZGplX01lc3NhZ2VfRmxvYXRf
U2V0KiBtZXNzYWdlID0gcmVpbnRlcnByZXRfY2FzdDxFZGplX01lc3NhZ2VfRmxvYXRfU2V0Kj4o
YnVmZmVyKTsKKyAgICBFZGplX01lc3NhZ2VfRmxvYXRfU2V0KiBtZXNzYWdlID0gc3RhdGljX2Nh
c3Q8RWRqZV9NZXNzYWdlX0Zsb2F0X1NldCo+KGFsbG9jYShzaXplb2YoRWRqZV9NZXNzYWdlX0Zs
b2F0X1NldCkgKyBzaXplb2YoZG91YmxlKSkpOwogICAgIG1lc3NhZ2UtPmNvdW50ID0gMjsKIAog
ICAgIGlmICh0U2l6ZSAtIHZTaXplID4gMCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L25nL0hhcmZCdXp6U2hhcGVyLmNwcCBiL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L25nL0hhcmZCdXp6U2hhcGVyLmNwcApp
bmRleCBjM2JiNTRkLi4zMmU0ZDU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9ncmFwaGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6elNoYXBlci5jcHAKKysrIGIvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovbmcvSGFyZkJ1enpTaGFwZXIuY3BwCkBA
IC00MDMsOCArNDAzLDggQEAgaW50IEhhcmZCdXp6U2hhcGVyOjpvZmZzZXRGb3JQb3NpdGlvbihm
bG9hdCB0YXJnZXRYKQogRmxvYXRSZWN0IEhhcmZCdXp6U2hhcGVyOjpzZWxlY3Rpb25SZWN0KGNv
bnN0IEZsb2F0UG9pbnQmIHBvaW50LCBpbnQgaGVpZ2h0LCBpbnQgZnJvbSwgaW50IHRvKQogewog
ICAgIGZsb2F0IGN1cnJlbnRYID0gMDsKLSAgICBmbG9hdCBmcm9tWDsKLSAgICBmbG9hdCB0b1g7
CisgICAgZmxvYXQgZnJvbVggPSAwOworICAgIGZsb2F0IHRvWCA9IDA7CiAgICAgYm9vbCBmb3Vu
ZEZyb21YID0gZmFsc2U7CiAgICAgYm9vbCBmb3VuZFRvWCA9IGZhbHNlOwogCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>158256</attachid>
            <date>2012-08-14 01:23:43 -0700</date>
            <delta_ts>2012-08-14 02:31:32 -0700</delta_ts>
            <desc>patch</desc>
            <filename>alloca_patch.txt</filename>
            <type>text/plain</type>
            <size>5834</size>
            <attacher name="Kangil Han">kangil.han</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAxOWQxY2U1Li44ZjE2ZTQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg
QEAKKzIwMTItMDgtMTQgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg
ICAgICAgIFtFRkxdIFJlbW92ZSBhbGxvY2EgdXNhZ2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzkzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRvIGtlZXAgcG9ydGFibGUgc291cmNlIGNvZGUsIGFs
bG9jYSBoYXMgYmVlbiBkaXNjb3VyYWdlZC4KKyAgICAgICAgVGhlcmVmb3JlLCB0aGlzIHBhdGNo
IHJlbW92ZWQgYWxsb2NhIHVzYWdlIGZyb20gRUZMIHBvcnQuCisgICAgICAgIFBsdXMsIGZpeGVk
IFdlYkNvcmUgYnVpbGQgd2FybmluZyBtZXNzYWdlcy4KKworICAgICAgICAqIHBsYXRmb3JtL2Vm
bC9SZW5kZXJUaGVtZUVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUVmbDo6
cGFpbnRUaGVtZVBhcnQpOiByZW1vdmUgYWxsb2NhIHVzYWdlLgorICAgICAgICAqIHBsYXRmb3Jt
L2VmbC9TY3JvbGxiYXJFZmwuY3BwOgorICAgICAgICAoU2Nyb2xsYmFyRWZsOjp1cGRhdGVUaHVt
YlBvc2l0aW9uQW5kUHJvcG9ydGlvbik6IGZpeCAnYXJyYXkgc3Vic2NyaXB0IGlzIGFib3ZlIGFy
cmF5IGJvdW5kcycgY29tcGlsZSB3YXJuaW5nLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz
L2hhcmZidXp6L25nL0hhcmZCdXp6U2hhcGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhhcmZC
dXp6U2hhcGVyOjpzZWxlY3Rpb25SZWN0KTogZml4ICd0b1ggYW5kIGZyb21YIG1heSBiZSB1c2Vk
IHVuaW5pdGlhbGl6ZWQgaW4gdGhpcyBmdW5jdGlvbicgd2FybmluZy4KKwogMjAxMi0wOC0xMiAg
U2hhd24gU2luZ2ggIDxzaGF3bnNpbmdoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21p
dW1dIHJlbmRlclN1cmZhY2UgaW4gaW5jb3JyZWN0IHNwYWNlIGlmIG93bmluZyBsYXllciBoYXMg
ZW1wdHkgYnV0IG5vbi16ZXJvIGJvdW5kcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vm
bC9SZW5kZXJUaGVtZUVmbC5jcHAKaW5kZXggOGVkYzJhYS4uMmM4MzNjMSAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcAorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCkBAIC0zMjQsNDYgKzMy
NCw0NSBAQCBib29sIFJlbmRlclRoZW1lRWZsOjpwYWludFRoZW1lUGFydChSZW5kZXJPYmplY3Qq
IG9iamVjdCwgRm9ybVR5cGUgdHlwZSwgY29uc3QgUAogICAgIGNhaXJvID0gaW5mby5jb250ZXh0
LT5wbGF0Zm9ybUNvbnRleHQoKS0+Y3IoKTsKICAgICBBU1NFUlQoY2Fpcm8pOwogCisgICAgRWRq
ZV9NZXNzYWdlX0Zsb2F0X1NldCogbWVzc2FnZSA9IHN0YXRpY19jYXN0PEVkamVfTWVzc2FnZV9G
bG9hdF9TZXQqPihtYWxsb2Moc2l6ZW9mKEVkamVfTWVzc2FnZV9GbG9hdF9TZXQpICsgc2l6ZW9m
KGRvdWJsZSkpKTsKKyAgICBtZXNzYWdlLT5jb3VudCA9IDI7CisKICAgICAvLyBDdXJyZW50bHks
IG9ubHkgc2xpZGVycyBuZWVkcyB0aGlzIG1lc3NhZ2U7IGlmIG90aGVyIHdpZGdldCBldmVyIG5l
ZWRzIHNwZWNpYWwKICAgICAvLyB0cmVhdG1lbnQsIG1vdmUgdGhlbSB0byBzcGVjaWFsIGZ1bmN0
aW9ucy4KICAgICBpZiAodHlwZSA9PSBTbGlkZXJWZXJ0aWNhbCB8fCB0eXBlID09IFNsaWRlckhv
cml6b250YWwpIHsKLSAgICAgICAgaWYgKCFvYmplY3QtPmlzU2xpZGVyKCkpCisgICAgICAgIGlm
ICghb2JqZWN0LT5pc1NsaWRlcigpKSB7CisgICAgICAgICAgICBpZiAobWVzc2FnZSkKKyAgICAg
ICAgICAgICAgICBmcmVlKG1lc3NhZ2UpOwogICAgICAgICAgICAgcmV0dXJuIHRydWU7IC8vIHBy
b2JhYmx5IGhhdmUgLXdlYmtpdC1hcHBlYXJhbmNlOiBzbGlkZXIuLgorICAgICAgICB9CiAKICAg
ICAgICAgUmVuZGVyU2xpZGVyKiByZW5kZXJTbGlkZXIgPSB0b1JlbmRlclNsaWRlcihvYmplY3Qp
OwogICAgICAgICBIVE1MSW5wdXRFbGVtZW50KiBpbnB1dCA9IHJlbmRlclNsaWRlci0+bm9kZSgp
LT50b0lucHV0RWxlbWVudCgpOwotICAgICAgICBFZGplX01lc3NhZ2VfRmxvYXRfU2V0KiBtc2c7
CiAgICAgICAgIGRvdWJsZSB2YWx1ZVJhbmdlID0gaW5wdXQtPm1heGltdW0oKSAtIGlucHV0LT5t
aW5pbXVtKCk7CiAKLSAgICAgICAgbXNnID0gc3RhdGljX2Nhc3Q8RWRqZV9NZXNzYWdlX0Zsb2F0
X1NldCo+KGFsbG9jYShzaXplb2YoRWRqZV9NZXNzYWdlX0Zsb2F0X1NldCkgKyBzaXplb2YoZmxv
YXQpKSk7Ci0gICAgICAgIG1zZy0+Y291bnQgPSAyOwogICAgICAgICBpZiAodmFsdWVSYW5nZSA+
IDApCi0gICAgICAgICAgICBtc2ctPnZhbFswXSA9IHN0YXRpY19jYXN0PGZsb2F0PigoaW5wdXQt
PnZhbHVlQXNOdW1iZXIoKSAtIGlucHV0LT5taW5pbXVtKCkpIC8gdmFsdWVSYW5nZSk7CisgICAg
ICAgICAgICBtZXNzYWdlLT52YWxbMF0gPSBzdGF0aWNfY2FzdDxmbG9hdD4oKGlucHV0LT52YWx1
ZUFzTnVtYmVyKCkgLSBpbnB1dC0+bWluaW11bSgpKSAvIHZhbHVlUmFuZ2UpOwogICAgICAgICBl
bHNlCi0gICAgICAgICAgICBtc2ctPnZhbFswXSA9IDA7Ci0gICAgICAgIG1zZy0+dmFsWzFdID0g
MC4xOwotICAgICAgICBlZGplX29iamVjdF9tZXNzYWdlX3NlbmQoZW50cnktPm8sIEVESkVfTUVT
U0FHRV9GTE9BVF9TRVQsIDAsIG1zZyk7CisgICAgICAgICAgICBtZXNzYWdlLT52YWxbMF0gPSAw
OworICAgICAgICBtZXNzYWdlLT52YWxbMV0gPSAwLjE7CiAjaWYgRU5BQkxFKFBST0dSRVNTX0VM
RU1FTlQpCiAgICAgfSBlbHNlIGlmICh0eXBlID09IFByb2dyZXNzQmFyKSB7CiAgICAgICAgIFJl
bmRlclByb2dyZXNzKiByZW5kZXJQcm9ncmVzcyA9IHRvUmVuZGVyUHJvZ3Jlc3Mob2JqZWN0KTsK
LSAgICAgICAgRWRqZV9NZXNzYWdlX0Zsb2F0X1NldCogbXNnOwotICAgICAgICBpbnQgbWF4Owot
ICAgICAgICBkb3VibGUgdmFsdWU7CisgICAgICAgIGludCBtYXggPSByZWN0LndpZHRoKCk7Cisg
ICAgICAgIGRvdWJsZSB2YWx1ZSA9IHJlbmRlclByb2dyZXNzLT5wb3NpdGlvbigpOwogCi0gICAg
ICAgIG1zZyA9IHN0YXRpY19jYXN0PEVkamVfTWVzc2FnZV9GbG9hdF9TZXQqPihhbGxvY2Eoc2l6
ZW9mKEVkamVfTWVzc2FnZV9GbG9hdF9TZXQpICsgc2l6ZW9mKGZsb2F0KSkpOwotICAgICAgICBt
YXggPSByZWN0LndpZHRoKCk7Ci0gICAgICAgIHZhbHVlID0gcmVuZGVyUHJvZ3Jlc3MtPnBvc2l0
aW9uKCk7Ci0KLSAgICAgICAgbXNnLT5jb3VudCA9IDI7CiAgICAgICAgIGlmIChvYmplY3QtPnN0
eWxlKCktPmRpcmVjdGlvbigpID09IFJUTCkKLSAgICAgICAgICAgIG1zZy0+dmFsWzBdID0gKDEu
MCAtIHZhbHVlKSAqIG1heDsKKyAgICAgICAgICAgIG1lc3NhZ2UtPnZhbFswXSA9ICgxLjAgLSB2
YWx1ZSkgKiBtYXg7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIG1zZy0+dmFsWzBdID0gMDsK
LSAgICAgICAgbXNnLT52YWxbMV0gPSB2YWx1ZTsKLSAgICAgICAgZWRqZV9vYmplY3RfbWVzc2Fn
ZV9zZW5kKGVudHJ5LT5vLCBFREpFX01FU1NBR0VfRkxPQVRfU0VULCAwLCBtc2cpOworICAgICAg
ICAgICAgbWVzc2FnZS0+dmFsWzBdID0gMDsKKyAgICAgICAgbWVzc2FnZS0+dmFsWzFdID0gdmFs
dWU7CiAjZW5kaWYKICAgICB9CiAKKyAgICBlZGplX29iamVjdF9tZXNzYWdlX3NlbmQoZW50cnkt
Pm8sIEVESkVfTUVTU0FHRV9GTE9BVF9TRVQsIDAsIG1lc3NhZ2UpOworICAgIGlmIChtZXNzYWdl
KQorICAgICAgICBmcmVlKG1lc3NhZ2UpOworCiAgICAgZWRqZV9vYmplY3RfY2FsY19mb3JjZShl
bnRyeS0+byk7CiAgICAgZWRqZV9vYmplY3RfbWVzc2FnZV9zaWduYWxfcHJvY2VzcyhlbnRyeS0+
byk7CiAgICAgdXBkYXRlcyA9IGV2YXNfcmVuZGVyX3VwZGF0ZXMoZWNvcmVfZXZhc19nZXQoZW50
cnktPmVlKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xs
YmFyRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxiYXJFZmwuY3Bw
CmluZGV4IGNlN2Y3YmYuLjVjNGY0OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2VmbC9TY3JvbGxiYXJFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vm
bC9TY3JvbGxiYXJFZmwuY3BwCkBAIC0xNzEsOCArMTcxLDcgQEAgdm9pZCBTY3JvbGxiYXJFZmw6
OnVwZGF0ZVRodW1iUG9zaXRpb25BbmRQcm9wb3J0aW9uKCkKICAgICBtX2xhc3RUb3RhbFNpemUg
PSB0U2l6ZTsKICAgICBtX2xhc3RWaXNpYmxlU2l6ZSA9IHZTaXplOwogCi0gICAgY2hhciBidWZm
ZXJbc2l6ZW9mKEVkamVfTWVzc2FnZV9GbG9hdF9TZXQpICsgc2l6ZW9mKGRvdWJsZSldOwotICAg
IEVkamVfTWVzc2FnZV9GbG9hdF9TZXQqIG1lc3NhZ2UgPSByZWludGVycHJldF9jYXN0PEVkamVf
TWVzc2FnZV9GbG9hdF9TZXQqPihidWZmZXIpOworICAgIEVkamVfTWVzc2FnZV9GbG9hdF9TZXQq
IG1lc3NhZ2UgPSBzdGF0aWNfY2FzdDxFZGplX01lc3NhZ2VfRmxvYXRfU2V0Kj4obWFsbG9jKHNp
emVvZihFZGplX01lc3NhZ2VfRmxvYXRfU2V0KSArIHNpemVvZihkb3VibGUpKSk7CiAgICAgbWVz
c2FnZS0+Y291bnQgPSAyOwogCiAgICAgaWYgKHRTaXplIC0gdlNpemUgPiAwKQpAQCAtMTg2LDYg
KzE4NSw5IEBAIHZvaWQgU2Nyb2xsYmFyRWZsOjp1cGRhdGVUaHVtYlBvc2l0aW9uQW5kUHJvcG9y
dGlvbigpCiAgICAgICAgIG1lc3NhZ2UtPnZhbFsxXSA9IDAuMDsKIAogICAgIGVkamVfb2JqZWN0
X21lc3NhZ2Vfc2VuZChwbGF0Zm9ybVdpZGdldCgpLCBFREpFX01FU1NBR0VfRkxPQVRfU0VULCAw
LCBtZXNzYWdlKTsKKworICAgIGlmIChtZXNzYWdlKQorICAgICAgICBmcmVlKG1lc3NhZ2UpOwog
fQogCiB2b2lkIFNjcm9sbGJhckVmbDo6c2V0RnJhbWVSZWN0KGNvbnN0IEludFJlY3QmIHJlY3Qp
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9u
Zy9IYXJmQnV6elNoYXBlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9o
YXJmYnV6ei9uZy9IYXJmQnV6elNoYXBlci5jcHAKaW5kZXggYzNiYjU0ZC4uMzJlNGQ1NiAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovbmcvSGFy
ZkJ1enpTaGFwZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hh
cmZidXp6L25nL0hhcmZCdXp6U2hhcGVyLmNwcApAQCAtNDAzLDggKzQwMyw4IEBAIGludCBIYXJm
QnV6elNoYXBlcjo6b2Zmc2V0Rm9yUG9zaXRpb24oZmxvYXQgdGFyZ2V0WCkKIEZsb2F0UmVjdCBI
YXJmQnV6elNoYXBlcjo6c2VsZWN0aW9uUmVjdChjb25zdCBGbG9hdFBvaW50JiBwb2ludCwgaW50
IGhlaWdodCwgaW50IGZyb20sIGludCB0bykKIHsKICAgICBmbG9hdCBjdXJyZW50WCA9IDA7Ci0g
ICAgZmxvYXQgZnJvbVg7Ci0gICAgZmxvYXQgdG9YOworICAgIGZsb2F0IGZyb21YID0gMDsKKyAg
ICBmbG9hdCB0b1ggPSAwOwogICAgIGJvb2wgZm91bmRGcm9tWCA9IGZhbHNlOwogICAgIGJvb2wg
Zm91bmRUb1ggPSBmYWxzZTsKIAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>158269</attachid>
            <date>2012-08-14 02:31:32 -0700</date>
            <delta_ts>2012-08-17 00:04:50 -0700</delta_ts>
            <desc>patch</desc>
            <filename>alloca_patch.txt</filename>
            <type>text/plain</type>
            <size>5937</size>
            <attacher name="Kangil Han">kangil.han</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAxOWQxY2U1Li44ZjE2ZTQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg
QEAKKzIwMTItMDgtMTQgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg
ICAgICAgIFtFRkxdIFJlbW92ZSBhbGxvY2EgdXNhZ2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzkzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRvIGtlZXAgcG9ydGFibGUgc291cmNlIGNvZGUsIGFs
bG9jYSBoYXMgYmVlbiBkaXNjb3VyYWdlZC4KKyAgICAgICAgVGhlcmVmb3JlLCB0aGlzIHBhdGNo
IHJlbW92ZWQgYWxsb2NhIHVzYWdlIGZyb20gRUZMIHBvcnQuCisgICAgICAgIFBsdXMsIGZpeGVk
IFdlYkNvcmUgYnVpbGQgd2FybmluZyBtZXNzYWdlcy4KKworICAgICAgICAqIHBsYXRmb3JtL2Vm
bC9SZW5kZXJUaGVtZUVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUVmbDo6
cGFpbnRUaGVtZVBhcnQpOiByZW1vdmUgYWxsb2NhIHVzYWdlLgorICAgICAgICAqIHBsYXRmb3Jt
L2VmbC9TY3JvbGxiYXJFZmwuY3BwOgorICAgICAgICAoU2Nyb2xsYmFyRWZsOjp1cGRhdGVUaHVt
YlBvc2l0aW9uQW5kUHJvcG9ydGlvbik6IGZpeCAnYXJyYXkgc3Vic2NyaXB0IGlzIGFib3ZlIGFy
cmF5IGJvdW5kcycgY29tcGlsZSB3YXJuaW5nLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz
L2hhcmZidXp6L25nL0hhcmZCdXp6U2hhcGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhhcmZC
dXp6U2hhcGVyOjpzZWxlY3Rpb25SZWN0KTogZml4ICd0b1ggYW5kIGZyb21YIG1heSBiZSB1c2Vk
IHVuaW5pdGlhbGl6ZWQgaW4gdGhpcyBmdW5jdGlvbicgd2FybmluZy4KKwogMjAxMi0wOC0xMiAg
U2hhd24gU2luZ2ggIDxzaGF3bnNpbmdoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21p
dW1dIHJlbmRlclN1cmZhY2UgaW4gaW5jb3JyZWN0IHNwYWNlIGlmIG93bmluZyBsYXllciBoYXMg
ZW1wdHkgYnV0IG5vbi16ZXJvIGJvdW5kcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vm
bC9SZW5kZXJUaGVtZUVmbC5jcHAKaW5kZXggOGVkYzJhYS4uMTdhNTA5MiAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcAorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCkBAIC0zMjQsNDYgKzMy
NCw0NiBAQCBib29sIFJlbmRlclRoZW1lRWZsOjpwYWludFRoZW1lUGFydChSZW5kZXJPYmplY3Qq
IG9iamVjdCwgRm9ybVR5cGUgdHlwZSwgY29uc3QgUAogICAgIGNhaXJvID0gaW5mby5jb250ZXh0
LT5wbGF0Zm9ybUNvbnRleHQoKS0+Y3IoKTsKICAgICBBU1NFUlQoY2Fpcm8pOwogCisgICAgY2hh
ciogYnVmZmVyID0gbmV3IGNoYXJbc2l6ZW9mKEVkamVfTWVzc2FnZV9GbG9hdF9TZXQpICsgc2l6
ZW9mKGRvdWJsZSldOworICAgIEVkamVfTWVzc2FnZV9GbG9hdF9TZXQqIG1lc3NhZ2UgPSBzdGF0
aWNfY2FzdDxFZGplX01lc3NhZ2VfRmxvYXRfU2V0Kj4oc3RhdGljX2Nhc3Q8dm9pZCo+KGJ1ZmZl
cikpOworICAgIG1lc3NhZ2UtPmNvdW50ID0gMjsKKwogICAgIC8vIEN1cnJlbnRseSwgb25seSBz
bGlkZXJzIG5lZWRzIHRoaXMgbWVzc2FnZTsgaWYgb3RoZXIgd2lkZ2V0IGV2ZXIgbmVlZHMgc3Bl
Y2lhbAogICAgIC8vIHRyZWF0bWVudCwgbW92ZSB0aGVtIHRvIHNwZWNpYWwgZnVuY3Rpb25zLgog
ICAgIGlmICh0eXBlID09IFNsaWRlclZlcnRpY2FsIHx8IHR5cGUgPT0gU2xpZGVySG9yaXpvbnRh
bCkgewotICAgICAgICBpZiAoIW9iamVjdC0+aXNTbGlkZXIoKSkKKyAgICAgICAgaWYgKCFvYmpl
Y3QtPmlzU2xpZGVyKCkpIHsKKyAgICAgICAgICAgIGlmIChidWZmZXIpCisgICAgICAgICAgICAg
ICAgZGVsZXRlIFtdYnVmZmVyOwogICAgICAgICAgICAgcmV0dXJuIHRydWU7IC8vIHByb2JhYmx5
IGhhdmUgLXdlYmtpdC1hcHBlYXJhbmNlOiBzbGlkZXIuLgorICAgICAgICB9CiAKICAgICAgICAg
UmVuZGVyU2xpZGVyKiByZW5kZXJTbGlkZXIgPSB0b1JlbmRlclNsaWRlcihvYmplY3QpOwogICAg
ICAgICBIVE1MSW5wdXRFbGVtZW50KiBpbnB1dCA9IHJlbmRlclNsaWRlci0+bm9kZSgpLT50b0lu
cHV0RWxlbWVudCgpOwotICAgICAgICBFZGplX01lc3NhZ2VfRmxvYXRfU2V0KiBtc2c7CiAgICAg
ICAgIGRvdWJsZSB2YWx1ZVJhbmdlID0gaW5wdXQtPm1heGltdW0oKSAtIGlucHV0LT5taW5pbXVt
KCk7CiAKLSAgICAgICAgbXNnID0gc3RhdGljX2Nhc3Q8RWRqZV9NZXNzYWdlX0Zsb2F0X1NldCo+
KGFsbG9jYShzaXplb2YoRWRqZV9NZXNzYWdlX0Zsb2F0X1NldCkgKyBzaXplb2YoZmxvYXQpKSk7
Ci0gICAgICAgIG1zZy0+Y291bnQgPSAyOwogICAgICAgICBpZiAodmFsdWVSYW5nZSA+IDApCi0g
ICAgICAgICAgICBtc2ctPnZhbFswXSA9IHN0YXRpY19jYXN0PGZsb2F0PigoaW5wdXQtPnZhbHVl
QXNOdW1iZXIoKSAtIGlucHV0LT5taW5pbXVtKCkpIC8gdmFsdWVSYW5nZSk7CisgICAgICAgICAg
ICBtZXNzYWdlLT52YWxbMF0gPSBzdGF0aWNfY2FzdDxmbG9hdD4oKGlucHV0LT52YWx1ZUFzTnVt
YmVyKCkgLSBpbnB1dC0+bWluaW11bSgpKSAvIHZhbHVlUmFuZ2UpOwogICAgICAgICBlbHNlCi0g
ICAgICAgICAgICBtc2ctPnZhbFswXSA9IDA7Ci0gICAgICAgIG1zZy0+dmFsWzFdID0gMC4xOwot
ICAgICAgICBlZGplX29iamVjdF9tZXNzYWdlX3NlbmQoZW50cnktPm8sIEVESkVfTUVTU0FHRV9G
TE9BVF9TRVQsIDAsIG1zZyk7CisgICAgICAgICAgICBtZXNzYWdlLT52YWxbMF0gPSAwOworICAg
ICAgICBtZXNzYWdlLT52YWxbMV0gPSAwLjE7CiAjaWYgRU5BQkxFKFBST0dSRVNTX0VMRU1FTlQp
CiAgICAgfSBlbHNlIGlmICh0eXBlID09IFByb2dyZXNzQmFyKSB7CiAgICAgICAgIFJlbmRlclBy
b2dyZXNzKiByZW5kZXJQcm9ncmVzcyA9IHRvUmVuZGVyUHJvZ3Jlc3Mob2JqZWN0KTsKLSAgICAg
ICAgRWRqZV9NZXNzYWdlX0Zsb2F0X1NldCogbXNnOwotICAgICAgICBpbnQgbWF4OwotICAgICAg
ICBkb3VibGUgdmFsdWU7CisgICAgICAgIGludCBtYXggPSByZWN0LndpZHRoKCk7CisgICAgICAg
IGRvdWJsZSB2YWx1ZSA9IHJlbmRlclByb2dyZXNzLT5wb3NpdGlvbigpOwogCi0gICAgICAgIG1z
ZyA9IHN0YXRpY19jYXN0PEVkamVfTWVzc2FnZV9GbG9hdF9TZXQqPihhbGxvY2Eoc2l6ZW9mKEVk
amVfTWVzc2FnZV9GbG9hdF9TZXQpICsgc2l6ZW9mKGZsb2F0KSkpOwotICAgICAgICBtYXggPSBy
ZWN0LndpZHRoKCk7Ci0gICAgICAgIHZhbHVlID0gcmVuZGVyUHJvZ3Jlc3MtPnBvc2l0aW9uKCk7
Ci0KLSAgICAgICAgbXNnLT5jb3VudCA9IDI7CiAgICAgICAgIGlmIChvYmplY3QtPnN0eWxlKCkt
PmRpcmVjdGlvbigpID09IFJUTCkKLSAgICAgICAgICAgIG1zZy0+dmFsWzBdID0gKDEuMCAtIHZh
bHVlKSAqIG1heDsKKyAgICAgICAgICAgIG1lc3NhZ2UtPnZhbFswXSA9ICgxLjAgLSB2YWx1ZSkg
KiBtYXg7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIG1zZy0+dmFsWzBdID0gMDsKLSAgICAg
ICAgbXNnLT52YWxbMV0gPSB2YWx1ZTsKLSAgICAgICAgZWRqZV9vYmplY3RfbWVzc2FnZV9zZW5k
KGVudHJ5LT5vLCBFREpFX01FU1NBR0VfRkxPQVRfU0VULCAwLCBtc2cpOworICAgICAgICAgICAg
bWVzc2FnZS0+dmFsWzBdID0gMDsKKyAgICAgICAgbWVzc2FnZS0+dmFsWzFdID0gdmFsdWU7CiAj
ZW5kaWYKICAgICB9CiAKKyAgICBlZGplX29iamVjdF9tZXNzYWdlX3NlbmQoZW50cnktPm8sIEVE
SkVfTUVTU0FHRV9GTE9BVF9TRVQsIDAsIG1lc3NhZ2UpOworICAgIGlmIChidWZmZXIpCisgICAg
ICAgIGRlbGV0ZSBbXWJ1ZmZlcjsKKwogICAgIGVkamVfb2JqZWN0X2NhbGNfZm9yY2UoZW50cnkt
Pm8pOwogICAgIGVkamVfb2JqZWN0X21lc3NhZ2Vfc2lnbmFsX3Byb2Nlc3MoZW50cnktPm8pOwog
ICAgIHVwZGF0ZXMgPSBldmFzX3JlbmRlcl91cGRhdGVzKGVjb3JlX2V2YXNfZ2V0KGVudHJ5LT5l
ZSkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVm
bC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcAppbmRl
eCBjZTdmN2JmLi41ZTZmZDIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9l
ZmwvU2Nyb2xsYmFyRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Ny
b2xsYmFyRWZsLmNwcApAQCAtMTcxLDggKzE3MSw4IEBAIHZvaWQgU2Nyb2xsYmFyRWZsOjp1cGRh
dGVUaHVtYlBvc2l0aW9uQW5kUHJvcG9ydGlvbigpCiAgICAgbV9sYXN0VG90YWxTaXplID0gdFNp
emU7CiAgICAgbV9sYXN0VmlzaWJsZVNpemUgPSB2U2l6ZTsKIAotICAgIGNoYXIgYnVmZmVyW3Np
emVvZihFZGplX01lc3NhZ2VfRmxvYXRfU2V0KSArIHNpemVvZihkb3VibGUpXTsKLSAgICBFZGpl
X01lc3NhZ2VfRmxvYXRfU2V0KiBtZXNzYWdlID0gcmVpbnRlcnByZXRfY2FzdDxFZGplX01lc3Nh
Z2VfRmxvYXRfU2V0Kj4oYnVmZmVyKTsKKyAgICBjaGFyKiBidWZmZXIgPSBuZXcgY2hhcltzaXpl
b2YoRWRqZV9NZXNzYWdlX0Zsb2F0X1NldCkgKyBzaXplb2YoZG91YmxlKV07CisgICAgRWRqZV9N
ZXNzYWdlX0Zsb2F0X1NldCogbWVzc2FnZSA9IHN0YXRpY19jYXN0PEVkamVfTWVzc2FnZV9GbG9h
dF9TZXQqPihzdGF0aWNfY2FzdDx2b2lkKj4oYnVmZmVyKSk7CiAgICAgbWVzc2FnZS0+Y291bnQg
PSAyOwogCiAgICAgaWYgKHRTaXplIC0gdlNpemUgPiAwKQpAQCAtMTg2LDYgKzE4Niw5IEBAIHZv
aWQgU2Nyb2xsYmFyRWZsOjp1cGRhdGVUaHVtYlBvc2l0aW9uQW5kUHJvcG9ydGlvbigpCiAgICAg
ICAgIG1lc3NhZ2UtPnZhbFsxXSA9IDAuMDsKIAogICAgIGVkamVfb2JqZWN0X21lc3NhZ2Vfc2Vu
ZChwbGF0Zm9ybVdpZGdldCgpLCBFREpFX01FU1NBR0VfRkxPQVRfU0VULCAwLCBtZXNzYWdlKTsK
KworICAgIGlmIChidWZmZXIpCisgICAgICAgIGRlbGV0ZSBbXWJ1ZmZlcjsKIH0KIAogdm9pZCBT
Y3JvbGxiYXJFZmw6OnNldEZyYW1lUmVjdChjb25zdCBJbnRSZWN0JiByZWN0KQpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovbmcvSGFyZkJ1enpT
aGFwZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovbmcv
SGFyZkJ1enpTaGFwZXIuY3BwCmluZGV4IGMzYmI1NGQuLjMyZTRkNTYgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L25nL0hhcmZCdXp6U2hhcGVy
LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9uZy9I
YXJmQnV6elNoYXBlci5jcHAKQEAgLTQwMyw4ICs0MDMsOCBAQCBpbnQgSGFyZkJ1enpTaGFwZXI6
Om9mZnNldEZvclBvc2l0aW9uKGZsb2F0IHRhcmdldFgpCiBGbG9hdFJlY3QgSGFyZkJ1enpTaGFw
ZXI6OnNlbGVjdGlvblJlY3QoY29uc3QgRmxvYXRQb2ludCYgcG9pbnQsIGludCBoZWlnaHQsIGlu
dCBmcm9tLCBpbnQgdG8pCiB7CiAgICAgZmxvYXQgY3VycmVudFggPSAwOwotICAgIGZsb2F0IGZy
b21YOwotICAgIGZsb2F0IHRvWDsKKyAgICBmbG9hdCBmcm9tWCA9IDA7CisgICAgZmxvYXQgdG9Y
ID0gMDsKICAgICBib29sIGZvdW5kRnJvbVggPSBmYWxzZTsKICAgICBib29sIGZvdW5kVG9YID0g
ZmFsc2U7CiAK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>159017</attachid>
            <date>2012-08-17 00:04:50 -0700</date>
            <delta_ts>2012-08-17 02:46:55 -0700</delta_ts>
            <desc>patch</desc>
            <filename>alloca_patch.txt</filename>
            <type>text/plain</type>
            <size>6139</size>
            <attacher name="Kangil Han">kangil.han</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAyNWY1ZjIwLi4zZDI1NGRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg
QEAKKzIwMTItMDgtMTcgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg
ICAgICAgIFtFRkxdIFJlbW92ZSBhbGxvY2EgdXNhZ2UgYW5kIGZpeCBjb21waWxlIHdhcm5pbmcg
aW4gV2ViQ29yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9OTM5MzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBUbyBrZWVwIHBvcnRhYmxlIHNvdXJjZSBjb2RlLCBhbGxvY2EgaGFzIGJlZW4gZGlzY291cmFn
ZWQuCisgICAgICAgIFRoZXJlZm9yZSwgdGhpcyBwYXRjaCByZW1vdmVkIGFsbG9jYSB1c2FnZSBm
cm9tIEVGTCBwb3J0LgorICAgICAgICBQbHVzLCBmaXhlZCBXZWJDb3JlIGJ1aWxkIHdhcm5pbmcg
bWVzc2FnZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwOgor
ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVFZmw6OnBhaW50VGhlbWVQYXJ0KToKKyAgICAg
ICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lRWZsOjpjcmVhdGVFZGplKToKKyAgICAgICAgKiBwbGF0
Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcDoKKyAgICAgICAgKFNjcm9sbGJhckVmbDo6dXBkYXRl
VGh1bWJQb3NpdGlvbkFuZFByb3BvcnRpb24pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz
L2hhcmZidXp6L25nL0hhcmZCdXp6U2hhcGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhhcmZC
dXp6U2hhcGVyOjpzZWxlY3Rpb25SZWN0KToKKwogMjAxMi0wOC0xNiAgSm9obiBCYXRlcyAgPGpi
YXRlc0Bnb29nbGUuY29tPgogCiAgICAgICAgIEZpeCB2c3luYy1kaXNhYmxlZCBOdWxsIHBvaW50
ZXIgY3Jhc2ggYnVnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVu
ZGVyVGhlbWVFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1l
RWZsLmNwcAppbmRleCBkMzA5MzFlLi4xNmUyM2Q1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAKQEAgLTMyNCw2ICszMjQsMTAgQEAgYm9vbCBS
ZW5kZXJUaGVtZUVmbDo6cGFpbnRUaGVtZVBhcnQoUmVuZGVyT2JqZWN0KiBvYmplY3QsIEZvcm1U
eXBlIHR5cGUsIGNvbnN0IFAKICAgICBjYWlybyA9IGluZm8uY29udGV4dC0+cGxhdGZvcm1Db250
ZXh0KCktPmNyKCk7CiAgICAgQVNTRVJUKGNhaXJvKTsKIAorICAgIE93bkFycmF5UHRyPGNoYXI+
IGJ1ZmZlciA9IGFkb3B0QXJyYXlQdHIobmV3IGNoYXJbc2l6ZW9mKEVkamVfTWVzc2FnZV9GbG9h
dF9TZXQpICsgc2l6ZW9mKGRvdWJsZSldKTsKKyAgICBFZGplX01lc3NhZ2VfRmxvYXRfU2V0KiBt
c2cgPSBuZXcoYnVmZmVyLmdldCgpKSBFZGplX01lc3NhZ2VfRmxvYXRfU2V0OworICAgIG1zZy0+
Y291bnQgPSAyOworCiAgICAgLy8gQ3VycmVudGx5LCBvbmx5IHNsaWRlcnMgbmVlZHMgdGhpcyBt
ZXNzYWdlOyBpZiBvdGhlciB3aWRnZXQgZXZlciBuZWVkcyBzcGVjaWFsCiAgICAgLy8gdHJlYXRt
ZW50LCBtb3ZlIHRoZW0gdG8gc3BlY2lhbCBmdW5jdGlvbnMuCiAgICAgaWYgKHR5cGUgPT0gU2xp
ZGVyVmVydGljYWwgfHwgdHlwZSA9PSBTbGlkZXJIb3Jpem9udGFsKSB7CkBAIC0zMzIsMzggKzMz
NiwyOSBAQCBib29sIFJlbmRlclRoZW1lRWZsOjpwYWludFRoZW1lUGFydChSZW5kZXJPYmplY3Qq
IG9iamVjdCwgRm9ybVR5cGUgdHlwZSwgY29uc3QgUAogCiAgICAgICAgIFJlbmRlclNsaWRlciog
cmVuZGVyU2xpZGVyID0gdG9SZW5kZXJTbGlkZXIob2JqZWN0KTsKICAgICAgICAgSFRNTElucHV0
RWxlbWVudCogaW5wdXQgPSByZW5kZXJTbGlkZXItPm5vZGUoKS0+dG9JbnB1dEVsZW1lbnQoKTsK
LSAgICAgICAgRWRqZV9NZXNzYWdlX0Zsb2F0X1NldCogbXNnOwogICAgICAgICBkb3VibGUgdmFs
dWVSYW5nZSA9IGlucHV0LT5tYXhpbXVtKCkgLSBpbnB1dC0+bWluaW11bSgpOwogCi0gICAgICAg
IG1zZyA9IHN0YXRpY19jYXN0PEVkamVfTWVzc2FnZV9GbG9hdF9TZXQqPihhbGxvY2Eoc2l6ZW9m
KEVkamVfTWVzc2FnZV9GbG9hdF9TZXQpICsgc2l6ZW9mKGZsb2F0KSkpOwotICAgICAgICBtc2ct
PmNvdW50ID0gMjsKICAgICAgICAgaWYgKHZhbHVlUmFuZ2UgPiAwKQogICAgICAgICAgICAgbXNn
LT52YWxbMF0gPSBzdGF0aWNfY2FzdDxmbG9hdD4oKGlucHV0LT52YWx1ZUFzTnVtYmVyKCkgLSBp
bnB1dC0+bWluaW11bSgpKSAvIHZhbHVlUmFuZ2UpOwogICAgICAgICBlbHNlCiAgICAgICAgICAg
ICBtc2ctPnZhbFswXSA9IDA7CiAgICAgICAgIG1zZy0+dmFsWzFdID0gMC4xOwotICAgICAgICBl
ZGplX29iamVjdF9tZXNzYWdlX3NlbmQoZW50cnktPm8sIEVESkVfTUVTU0FHRV9GTE9BVF9TRVQs
IDAsIG1zZyk7CiAjaWYgRU5BQkxFKFBST0dSRVNTX0VMRU1FTlQpCiAgICAgfSBlbHNlIGlmICh0
eXBlID09IFByb2dyZXNzQmFyKSB7CiAgICAgICAgIFJlbmRlclByb2dyZXNzKiByZW5kZXJQcm9n
cmVzcyA9IHRvUmVuZGVyUHJvZ3Jlc3Mob2JqZWN0KTsKLSAgICAgICAgRWRqZV9NZXNzYWdlX0Zs
b2F0X1NldCogbXNnOwotICAgICAgICBpbnQgbWF4OwotICAgICAgICBkb3VibGUgdmFsdWU7Ci0K
LSAgICAgICAgbXNnID0gc3RhdGljX2Nhc3Q8RWRqZV9NZXNzYWdlX0Zsb2F0X1NldCo+KGFsbG9j
YShzaXplb2YoRWRqZV9NZXNzYWdlX0Zsb2F0X1NldCkgKyBzaXplb2YoZmxvYXQpKSk7Ci0gICAg
ICAgIG1heCA9IHJlY3Qud2lkdGgoKTsKLSAgICAgICAgdmFsdWUgPSByZW5kZXJQcm9ncmVzcy0+
cG9zaXRpb24oKTsKKyAgICAgICAgaW50IG1heCA9IHJlY3Qud2lkdGgoKTsKKyAgICAgICAgZG91
YmxlIHZhbHVlID0gcmVuZGVyUHJvZ3Jlc3MtPnBvc2l0aW9uKCk7CiAKLSAgICAgICAgbXNnLT5j
b3VudCA9IDI7CiAgICAgICAgIGlmIChvYmplY3QtPnN0eWxlKCktPmRpcmVjdGlvbigpID09IFJU
TCkKICAgICAgICAgICAgIG1zZy0+dmFsWzBdID0gKDEuMCAtIHZhbHVlKSAqIG1heDsKICAgICAg
ICAgZWxzZQogICAgICAgICAgICAgbXNnLT52YWxbMF0gPSAwOwogICAgICAgICBtc2ctPnZhbFsx
XSA9IHZhbHVlOwotICAgICAgICBlZGplX29iamVjdF9tZXNzYWdlX3NlbmQoZW50cnktPm8sIEVE
SkVfTUVTU0FHRV9GTE9BVF9TRVQsIDAsIG1zZyk7CiAjZW5kaWYKICAgICB9CiAKKyAgICBlZGpl
X29iamVjdF9tZXNzYWdlX3NlbmQoZW50cnktPm8sIEVESkVfTUVTU0FHRV9GTE9BVF9TRVQsIDAs
IG1zZyk7CisKICAgICBlZGplX29iamVjdF9jYWxjX2ZvcmNlKGVudHJ5LT5vKTsKICAgICBlZGpl
X29iamVjdF9tZXNzYWdlX3NpZ25hbF9wcm9jZXNzKGVudHJ5LT5vKTsKICAgICB1cGRhdGVzID0g
ZXZhc19yZW5kZXJfdXBkYXRlcyhlY29yZV9ldmFzX2dldChlbnRyeS0+ZWUpKTsKQEAgLTQ1Miw2
ICs0NDcsNyBAQCB2b2lkIFJlbmRlclRoZW1lRWZsOjpjcmVhdGVFZGplKCkKICAgICAgICAgZWxz
ZSBpZiAoIWVkamVfb2JqZWN0X2ZpbGVfc2V0KG1fZWRqZSwgbV90aGVtZVBhdGgudXRmOCgpLmRh
dGEoKSwgIndlYmtpdC9iYXNlIikpIHsKICAgICAgICAgICAgIEVkamVfTG9hZF9FcnJvciBlcnIg
PSBlZGplX29iamVjdF9sb2FkX2Vycm9yX2dldChtX2VkamUpOwogICAgICAgICAgICAgY29uc3Qg
Y2hhciogZXJybXNnID0gZWRqZV9sb2FkX2Vycm9yX3N0cihlcnIpOworICAgICAgICAgICAgRUlO
QV9MT0dfRVJSKCJDb3VsZCBub3Qgc2V0IGZpbGU6ICVzIiwgZXJybXNnKTsKICAgICAgICAgICAg
IGV2YXNfb2JqZWN0X2RlbChtX2VkamUpOwogICAgICAgICAgICAgbV9lZGplID0gMDsKICAgICAg
ICAgfSBlbHNlIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3Jv
bGxiYXJFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5j
cHAKaW5kZXggY2U3ZjdiZi4uZDFjMmM0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
ZWZsL1Njcm9sbGJhckVmbC5jcHAKQEAgLTE3MSwyMSArMTcxLDIxIEBAIHZvaWQgU2Nyb2xsYmFy
RWZsOjp1cGRhdGVUaHVtYlBvc2l0aW9uQW5kUHJvcG9ydGlvbigpCiAgICAgbV9sYXN0VG90YWxT
aXplID0gdFNpemU7CiAgICAgbV9sYXN0VmlzaWJsZVNpemUgPSB2U2l6ZTsKIAotICAgIGNoYXIg
YnVmZmVyW3NpemVvZihFZGplX01lc3NhZ2VfRmxvYXRfU2V0KSArIHNpemVvZihkb3VibGUpXTsK
LSAgICBFZGplX01lc3NhZ2VfRmxvYXRfU2V0KiBtZXNzYWdlID0gcmVpbnRlcnByZXRfY2FzdDxF
ZGplX01lc3NhZ2VfRmxvYXRfU2V0Kj4oYnVmZmVyKTsKLSAgICBtZXNzYWdlLT5jb3VudCA9IDI7
CisgICAgT3duQXJyYXlQdHI8Y2hhcj4gYnVmZmVyID0gYWRvcHRBcnJheVB0cihuZXcgY2hhcltz
aXplb2YoRWRqZV9NZXNzYWdlX0Zsb2F0X1NldCkgKyBzaXplb2YoZG91YmxlKV0pOworICAgIEVk
amVfTWVzc2FnZV9GbG9hdF9TZXQqIG1zZyA9IG5ldyhidWZmZXIuZ2V0KCkpIEVkamVfTWVzc2Fn
ZV9GbG9hdF9TZXQ7CisgICAgbXNnLT5jb3VudCA9IDI7CiAKICAgICBpZiAodFNpemUgLSB2U2l6
ZSA+IDApCi0gICAgICAgIG1lc3NhZ2UtPnZhbFswXSA9IHBvcyAvIHN0YXRpY19jYXN0PGZsb2F0
Pih0U2l6ZSAtIHZTaXplKTsKKyAgICAgICAgbXNnLT52YWxbMF0gPSBwb3MgLyBzdGF0aWNfY2Fz
dDxmbG9hdD4odFNpemUgLSB2U2l6ZSk7CiAgICAgZWxzZQotICAgICAgICBtZXNzYWdlLT52YWxb
MF0gPSAwLjA7CisgICAgICAgIG1zZy0+dmFsWzBdID0gMC4wOwogCiAgICAgaWYgKHRTaXplID4g
MCkKLSAgICAgICAgbWVzc2FnZS0+dmFsWzFdID0gdlNpemUgLyBzdGF0aWNfY2FzdDxmbG9hdD4o
dFNpemUpOworICAgICAgICBtc2ctPnZhbFsxXSA9IHZTaXplIC8gc3RhdGljX2Nhc3Q8ZmxvYXQ+
KHRTaXplKTsKICAgICBlbHNlCi0gICAgICAgIG1lc3NhZ2UtPnZhbFsxXSA9IDAuMDsKKyAgICAg
ICAgbXNnLT52YWxbMV0gPSAwLjA7CiAKLSAgICBlZGplX29iamVjdF9tZXNzYWdlX3NlbmQocGxh
dGZvcm1XaWRnZXQoKSwgRURKRV9NRVNTQUdFX0ZMT0FUX1NFVCwgMCwgbWVzc2FnZSk7CisgICAg
ZWRqZV9vYmplY3RfbWVzc2FnZV9zZW5kKHBsYXRmb3JtV2lkZ2V0KCksIEVESkVfTUVTU0FHRV9G
TE9BVF9TRVQsIDAsIG1zZyk7CiB9CiAKIHZvaWQgU2Nyb2xsYmFyRWZsOjpzZXRGcmFtZVJlY3Qo
Y29uc3QgSW50UmVjdCYgcmVjdCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2dyYXBoaWNzL2hhcmZidXp6L25nL0hhcmZCdXp6U2hhcGVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl
L3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L25nL0hhcmZCdXp6U2hhcGVyLmNwcAppbmRleCBj
M2JiNTRkLi4zMmU0ZDU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw
aGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6elNoYXBlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovbmcvSGFyZkJ1enpTaGFwZXIuY3BwCkBAIC00MDMs
OCArNDAzLDggQEAgaW50IEhhcmZCdXp6U2hhcGVyOjpvZmZzZXRGb3JQb3NpdGlvbihmbG9hdCB0
YXJnZXRYKQogRmxvYXRSZWN0IEhhcmZCdXp6U2hhcGVyOjpzZWxlY3Rpb25SZWN0KGNvbnN0IEZs
b2F0UG9pbnQmIHBvaW50LCBpbnQgaGVpZ2h0LCBpbnQgZnJvbSwgaW50IHRvKQogewogICAgIGZs
b2F0IGN1cnJlbnRYID0gMDsKLSAgICBmbG9hdCBmcm9tWDsKLSAgICBmbG9hdCB0b1g7CisgICAg
ZmxvYXQgZnJvbVggPSAwOworICAgIGZsb2F0IHRvWCA9IDA7CiAgICAgYm9vbCBmb3VuZEZyb21Y
ID0gZmFsc2U7CiAgICAgYm9vbCBmb3VuZFRvWCA9IGZhbHNlOwogCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>159060</attachid>
            <date>2012-08-17 02:46:55 -0700</date>
            <delta_ts>2012-08-17 05:19:01 -0700</delta_ts>
            <desc>patch</desc>
            <filename>alloca_only_patch.txt</filename>
            <type>text/plain</type>
            <size>3876</size>
            <attacher name="Kangil Han">kangil.han</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAyNWY1ZjIwLi5mODc5OTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTItMDgtMTcgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg
ICAgICAgIFtFRkxdIFJlbW92ZSBhbGxvY2EgdXNhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzOTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBpcyB1bmlmeWluZyB0aGUgYXBwcm9h
Y2hlcyBmb3IgdGhlIGNyZWF0aW9uIG9mIEVkamVfTWVzc2FnZV9GbG9hdF9TZXQgbWVzc2FnZXMs
IGFuZCBnZXR0aW5nIHJpZCBvZiBhbGxvY2EgaXMgcGFydCBvZiBpdCwgc2luY2UgaXQgaXMgbm90
IHBvcnRhYmxlLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcDoK
KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lRWZsOjpwYWludFRoZW1lUGFydCk6CisgICAg
ICAgICogcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHA6CisgICAgICAgIChTY3JvbGxiYXJF
Zmw6OnVwZGF0ZVRodW1iUG9zaXRpb25BbmRQcm9wb3J0aW9uKToKKwogMjAxMi0wOC0xNiAgSm9o
biBCYXRlcyAgPGpiYXRlc0Bnb29nbGUuY29tPgogCiAgICAgICAgIEZpeCB2c3luYy1kaXNhYmxl
ZCBOdWxsIHBvaW50ZXIgY3Jhc2ggYnVnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZs
L1JlbmRlclRoZW1lRWZsLmNwcAppbmRleCBkMzA5MzFlLi40ZTQ5OGEzIDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCisrKyBiL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAKQEAgLTQyLDYgKzQyLDcg
QEAKIAogI2luY2x1ZGUgPEVjb3JlX0V2YXMuaD4KICNpbmNsdWRlIDxFZGplLmg+CisjaW5jbHVk
ZSA8bmV3PgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KICNpbmNsdWRlIDx3dGYvdGV4
dC9XVEZTdHJpbmcuaD4KIApAQCAtMzMyLDExICszMzMsMTIgQEAgYm9vbCBSZW5kZXJUaGVtZUVm
bDo6cGFpbnRUaGVtZVBhcnQoUmVuZGVyT2JqZWN0KiBvYmplY3QsIEZvcm1UeXBlIHR5cGUsIGNv
bnN0IFAKIAogICAgICAgICBSZW5kZXJTbGlkZXIqIHJlbmRlclNsaWRlciA9IHRvUmVuZGVyU2xp
ZGVyKG9iamVjdCk7CiAgICAgICAgIEhUTUxJbnB1dEVsZW1lbnQqIGlucHV0ID0gcmVuZGVyU2xp
ZGVyLT5ub2RlKCktPnRvSW5wdXRFbGVtZW50KCk7Ci0gICAgICAgIEVkamVfTWVzc2FnZV9GbG9h
dF9TZXQqIG1zZzsKICAgICAgICAgZG91YmxlIHZhbHVlUmFuZ2UgPSBpbnB1dC0+bWF4aW11bSgp
IC0gaW5wdXQtPm1pbmltdW0oKTsKIAotICAgICAgICBtc2cgPSBzdGF0aWNfY2FzdDxFZGplX01l
c3NhZ2VfRmxvYXRfU2V0Kj4oYWxsb2NhKHNpemVvZihFZGplX01lc3NhZ2VfRmxvYXRfU2V0KSAr
IHNpemVvZihmbG9hdCkpKTsKKyAgICAgICAgT3duQXJyYXlQdHI8Y2hhcj4gYnVmZmVyID0gYWRv
cHRBcnJheVB0cihuZXcgY2hhcltzaXplb2YoRWRqZV9NZXNzYWdlX0Zsb2F0X1NldCkgKyBzaXpl
b2YoZG91YmxlKV0pOworICAgICAgICBFZGplX01lc3NhZ2VfRmxvYXRfU2V0KiBtc2cgPSBuZXco
YnVmZmVyLmdldCgpKSBFZGplX01lc3NhZ2VfRmxvYXRfU2V0OwogICAgICAgICBtc2ctPmNvdW50
ID0gMjsKKwogICAgICAgICBpZiAodmFsdWVSYW5nZSA+IDApCiAgICAgICAgICAgICBtc2ctPnZh
bFswXSA9IHN0YXRpY19jYXN0PGZsb2F0PigoaW5wdXQtPnZhbHVlQXNOdW1iZXIoKSAtIGlucHV0
LT5taW5pbXVtKCkpIC8gdmFsdWVSYW5nZSk7CiAgICAgICAgIGVsc2UKQEAgLTM0NiwxNSArMzQ4
LDE0IEBAIGJvb2wgUmVuZGVyVGhlbWVFZmw6OnBhaW50VGhlbWVQYXJ0KFJlbmRlck9iamVjdCog
b2JqZWN0LCBGb3JtVHlwZSB0eXBlLCBjb25zdCBQCiAjaWYgRU5BQkxFKFBST0dSRVNTX0VMRU1F
TlQpCiAgICAgfSBlbHNlIGlmICh0eXBlID09IFByb2dyZXNzQmFyKSB7CiAgICAgICAgIFJlbmRl
clByb2dyZXNzKiByZW5kZXJQcm9ncmVzcyA9IHRvUmVuZGVyUHJvZ3Jlc3Mob2JqZWN0KTsKLSAg
ICAgICAgRWRqZV9NZXNzYWdlX0Zsb2F0X1NldCogbXNnOwotICAgICAgICBpbnQgbWF4OwotICAg
ICAgICBkb3VibGUgdmFsdWU7CiAKLSAgICAgICAgbXNnID0gc3RhdGljX2Nhc3Q8RWRqZV9NZXNz
YWdlX0Zsb2F0X1NldCo+KGFsbG9jYShzaXplb2YoRWRqZV9NZXNzYWdlX0Zsb2F0X1NldCkgKyBz
aXplb2YoZmxvYXQpKSk7Ci0gICAgICAgIG1heCA9IHJlY3Qud2lkdGgoKTsKLSAgICAgICAgdmFs
dWUgPSByZW5kZXJQcm9ncmVzcy0+cG9zaXRpb24oKTsKKyAgICAgICAgaW50IG1heCA9IHJlY3Qu
d2lkdGgoKTsKKyAgICAgICAgZG91YmxlIHZhbHVlID0gcmVuZGVyUHJvZ3Jlc3MtPnBvc2l0aW9u
KCk7CiAKKyAgICAgICAgT3duQXJyYXlQdHI8Y2hhcj4gYnVmZmVyID0gYWRvcHRBcnJheVB0cihu
ZXcgY2hhcltzaXplb2YoRWRqZV9NZXNzYWdlX0Zsb2F0X1NldCkgKyBzaXplb2YoZG91YmxlKV0p
OworICAgICAgICBFZGplX01lc3NhZ2VfRmxvYXRfU2V0KiBtc2cgPSBuZXcoYnVmZmVyLmdldCgp
KSBFZGplX01lc3NhZ2VfRmxvYXRfU2V0OwogICAgICAgICBtc2ctPmNvdW50ID0gMjsKKwogICAg
ICAgICBpZiAob2JqZWN0LT5zdHlsZSgpLT5kaXJlY3Rpb24oKSA9PSBSVEwpCiAgICAgICAgICAg
ICBtc2ctPnZhbFswXSA9ICgxLjAgLSB2YWx1ZSkgKiBtYXg7CiAgICAgICAgIGVsc2UKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxiYXJFZmwuY3BwIGIvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHAKaW5kZXggY2U3ZjdiZi4u
MWFhZjRjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJh
ckVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5j
cHAKQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNsdWRlIDxFY29yZS5oPgogI2luY2x1ZGUgPEVkamUu
aD4KICNpbmNsdWRlIDxFdmFzLmg+CisjaW5jbHVkZSA8bmV3PgogI2luY2x1ZGUgPHN0cmluZz4K
ICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKQEAgLTE3MSw4ICsxNzIsOCBAQCB2b2lk
IFNjcm9sbGJhckVmbDo6dXBkYXRlVGh1bWJQb3NpdGlvbkFuZFByb3BvcnRpb24oKQogICAgIG1f
bGFzdFRvdGFsU2l6ZSA9IHRTaXplOwogICAgIG1fbGFzdFZpc2libGVTaXplID0gdlNpemU7CiAK
LSAgICBjaGFyIGJ1ZmZlcltzaXplb2YoRWRqZV9NZXNzYWdlX0Zsb2F0X1NldCkgKyBzaXplb2Yo
ZG91YmxlKV07Ci0gICAgRWRqZV9NZXNzYWdlX0Zsb2F0X1NldCogbWVzc2FnZSA9IHJlaW50ZXJw
cmV0X2Nhc3Q8RWRqZV9NZXNzYWdlX0Zsb2F0X1NldCo+KGJ1ZmZlcik7CisgICAgT3duQXJyYXlQ
dHI8Y2hhcj4gYnVmZmVyID0gYWRvcHRBcnJheVB0cihuZXcgY2hhcltzaXplb2YoRWRqZV9NZXNz
YWdlX0Zsb2F0X1NldCkgKyBzaXplb2YoZG91YmxlKV0pOworICAgIEVkamVfTWVzc2FnZV9GbG9h
dF9TZXQqIG1lc3NhZ2UgPSBuZXcoYnVmZmVyLmdldCgpKSBFZGplX01lc3NhZ2VfRmxvYXRfU2V0
OwogICAgIG1lc3NhZ2UtPmNvdW50ID0gMjsKIAogICAgIGlmICh0U2l6ZSAtIHZTaXplID4gMCkK
</data>

          </attachment>
      

    </bug>

</bugzilla>