93930 2012-08-13 22:07:46 -0700 Web Inspector: Use default parameter on error case of reportResult in InspectorFileSystemAgent 2012-08-15 08:56:48 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 68203 93933 0 tzik tzik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 694499 0 tzik 2012-08-13 22:07:46 -0700 As a minor clean up, I'd like to use default parameter on error case of reportResult. 694500 1 158210 tzik 2012-08-13 22:10:45 -0700 Created attachment 158210 Patch 696035 2 158210 webkit.review.bot 2012-08-15 08:56:44 -0700 Comment on attachment 158210 Patch Clearing flags on attachment: 158210 Committed r125677: <http://trac.webkit.org/changeset/125677> 696037 3 webkit.review.bot 2012-08-15 08:56:48 -0700 All reviewed patches have been landed. Closing bug. 158210 2012-08-13 22:10:45 -0700 2012-08-15 08:56:44 -0700 Patch bug-93930-20120814141012.patch text/plain 6998 tzik U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzhiMzUyMzQ3MDZiOWE5 NDRiZmRkN2Q0MzI0MTg4ZDNiZTJiNjMyNS4uMDViOTgwZjNkY2E4MWMzODA2YmUzMjdlOGU3YWQ3 MWJkNTcxYjU1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTEzICBUYWlq dSBUc3Vpa2kgIDx0emlrQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBV c2UgZGVmYXVsdCBwYXJhbWV0ZXIgb24gcmVwb3J0UmVzdWx0IGluIEluc3BlY3RvckZpbGVTeXN0 ZW1BZ2VudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTM5MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO byBmdW5jdGlvbmFsIGNoYW5nZS4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JGaWxl U3lzdGVtQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZSk6CisKIDIwMTItMDgtMTMgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtWOF0gUmVtb3ZlIFtU cmVhdFJldHVybmVkTnVsbEFzPUZhbHNlXQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvckZpbGVTeXN0ZW1BZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yRmlsZVN5c3RlbUFnZW50LmNwcAppbmRleCAxYjdkZjk1ODAxMGQ3NGRl Y2JjZjEwYTNkM2YzMTcyZmRjNGZkYWY5Li5kNjBiMDJjNDQwMjU0NGRkY2VhNGE5YmEwNjA0NjVi YWFiOWIyZmFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y RmlsZVN5c3RlbUFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yRmlsZVN5c3RlbUFnZW50LmNwcApAQCAtMTU1LDcgKzE1NSw3IEBAIHByaXZhdGU6CiAgICAg Ym9vbCBkaWRIaXRFcnJvcihGaWxlRXJyb3IqKTsKICAgICBib29sIGRpZEdldEVudHJ5KEVudHJ5 Kik7CiAKLSAgICB2b2lkIHJlcG9ydFJlc3VsdChGaWxlRXJyb3I6OkVycm9yQ29kZSBlcnJvckNv ZGUsIFBhc3NSZWZQdHI8VHlwZUJ1aWxkZXI6OkZpbGVTeXN0ZW06OkVudHJ5PiBlbnRyeSkKKyAg ICB2b2lkIHJlcG9ydFJlc3VsdChGaWxlRXJyb3I6OkVycm9yQ29kZSBlcnJvckNvZGUsIFBhc3NS ZWZQdHI8VHlwZUJ1aWxkZXI6OkZpbGVTeXN0ZW06OkVudHJ5PiBlbnRyeSA9IDApCiAgICAgewog ICAgICAgICBpZiAoIW1fZnJvbnRlbmRQcm92aWRlciB8fCAhbV9mcm9udGVuZFByb3ZpZGVyLT5m cm9udGVuZCgpKQogICAgICAgICAgICAgcmV0dXJuOwpAQCAtMTc1LDcgKzE3NSw3IEBAIHByaXZh dGU6CiAKIGJvb2wgRmlsZVN5c3RlbVJvb3RSZXF1ZXN0OjpkaWRIaXRFcnJvcihGaWxlRXJyb3Iq IGVycm9yKQogewotICAgIHJlcG9ydFJlc3VsdChlcnJvci0+Y29kZSgpLCAwKTsKKyAgICByZXBv cnRSZXN1bHQoZXJyb3ItPmNvZGUoKSk7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKQEAgLTIwOCw3 ICsyMDgsNyBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIH5EaXJlY3RvcnlDb250ZW50UmVxdWVz dCgpCiAgICAgewotICAgICAgICByZXBvcnRSZXN1bHQoRmlsZUVycm9yOjpBQk9SVF9FUlIsIDAp OworICAgICAgICByZXBvcnRSZXN1bHQoRmlsZUVycm9yOjpBQk9SVF9FUlIpOwogICAgIH0KIAog ICAgIHZvaWQgc3RhcnQoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCopOwpAQCAtMjE2LDE0ICsyMTYs MTQgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICBib29sIGRpZEhpdEVycm9yKEZpbGVFcnJvciog ZXJyb3IpCiAgICAgewotICAgICAgICByZXBvcnRSZXN1bHQoZXJyb3ItPmNvZGUoKSwgMCk7Cisg ICAgICAgIHJlcG9ydFJlc3VsdChlcnJvci0+Y29kZSgpKTsKICAgICAgICAgcmV0dXJuIHRydWU7 CiAgICAgfQogCiAgICAgYm9vbCBkaWRHZXRFbnRyeShFbnRyeSopOwogICAgIGJvb2wgZGlkUmVh ZERpcmVjdG9yeUVudHJpZXMoRW50cnlBcnJheSopOwogCi0gICAgdm9pZCByZXBvcnRSZXN1bHQo RmlsZUVycm9yOjpFcnJvckNvZGUgZXJyb3JDb2RlLCBQYXNzUmVmUHRyPEFycmF5PFR5cGVCdWls ZGVyOjpGaWxlU3lzdGVtOjpFbnRyeT4gPiBlbnRyaWVzKQorICAgIHZvaWQgcmVwb3J0UmVzdWx0 KEZpbGVFcnJvcjo6RXJyb3JDb2RlIGVycm9yQ29kZSwgUGFzc1JlZlB0cjxBcnJheTxUeXBlQnVp bGRlcjo6RmlsZVN5c3RlbTo6RW50cnk+ID4gZW50cmllcyA9IDApCiAgICAgewogICAgICAgICBp ZiAoIW1fZnJvbnRlbmRQcm92aWRlciB8fCAhbV9mcm9udGVuZFByb3ZpZGVyLT5mcm9udGVuZCgp KQogICAgICAgICAgICAgcmV0dXJuOwpAQCAtMjUyLDcgKzI1Miw3IEBAIHZvaWQgRGlyZWN0b3J5 Q29udGVudFJlcXVlc3Q6OnN0YXJ0KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIHNjcmlwdEV4ZWN1 dGlvbkNvbnRlCiAgICAgRmlsZVN5c3RlbVR5cGUgdHlwZTsKICAgICBTdHJpbmcgcGF0aDsKICAg ICBpZiAoIURPTUZpbGVTeXN0ZW1CYXNlOjpjcmFja0ZpbGVTeXN0ZW1VUkwobV91cmwsIHR5cGUs IHBhdGgpKSB7Ci0gICAgICAgIHJlcG9ydFJlc3VsdChGaWxlRXJyb3I6OlNZTlRBWF9FUlIsIDAp OworICAgICAgICByZXBvcnRSZXN1bHQoRmlsZUVycm9yOjpTWU5UQVhfRVJSKTsKICAgICAgICAg cmV0dXJuOwogICAgIH0KIApAQCAtMjY2LDcgKzI2Niw3IEBAIHZvaWQgRGlyZWN0b3J5Q29udGVu dFJlcXVlc3Q6OnN0YXJ0KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIHNjcmlwdEV4ZWN1dGlvbkNv bnRlCiBib29sIERpcmVjdG9yeUNvbnRlbnRSZXF1ZXN0OjpkaWRHZXRFbnRyeShFbnRyeSogZW50 cnkpCiB7CiAgICAgaWYgKCFlbnRyeS0+aXNEaXJlY3RvcnkoKSkgewotICAgICAgICByZXBvcnRS ZXN1bHQoRmlsZUVycm9yOjpUWVBFX01JU01BVENIX0VSUiwgMCk7CisgICAgICAgIHJlcG9ydFJl c3VsdChGaWxlRXJyb3I6OlRZUEVfTUlTTUFUQ0hfRVJSKTsKICAgICAgICAgcmV0dXJuIHRydWU7 CiAgICAgfQogCkBAIC0yNzksNyArMjc5LDcgQEAgYm9vbCBEaXJlY3RvcnlDb250ZW50UmVxdWVz dDo6ZGlkR2V0RW50cnkoRW50cnkqIGVudHJ5KQogdm9pZCBEaXJlY3RvcnlDb250ZW50UmVxdWVz dDo6cmVhZERpcmVjdG9yeUVudHJpZXMoKQogewogICAgIGlmICghbV9kaXJlY3RvcnlSZWFkZXIt PmZpbGVzeXN0ZW0oKS0+c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKSB7Ci0gICAgICAgIHJlcG9y dFJlc3VsdChGaWxlRXJyb3I6OkFCT1JUX0VSUiwgMCk7CisgICAgICAgIHJlcG9ydFJlc3VsdChG aWxlRXJyb3I6OkFCT1JUX0VSUik7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKQEAgLTM0MCwy MCArMzQwLDIyIEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgfk1ldGFkYXRhUmVxdWVzdCgpCiAg ICAgewotICAgICAgICByZXBvcnRSZXN1bHQoRmlsZUVycm9yOjpBQk9SVF9FUlIsIDApOworICAg ICAgICByZXBvcnRSZXN1bHQoRmlsZUVycm9yOjpBQk9SVF9FUlIpOwogICAgIH0KIAorICAgIHZv aWQgc3RhcnQoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCopOworCitwcml2YXRlOgogICAgIGJvb2wg ZGlkSGl0RXJyb3IoRmlsZUVycm9yKiBlcnJvcikKICAgICB7Ci0gICAgICAgIHJlcG9ydFJlc3Vs dChlcnJvci0+Y29kZSgpLCAwKTsKKyAgICAgICAgcmVwb3J0UmVzdWx0KGVycm9yLT5jb2RlKCkp OwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKLSAgICB2b2lkIHN0YXJ0KFNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQqKTsKICAgICBib29sIGRpZEdldEVudHJ5KEVudHJ5Kik7CiAgICAgYm9v bCBkaWRHZXRNZXRhZGF0YShNZXRhZGF0YSopOwogCi0gICAgdm9pZCByZXBvcnRSZXN1bHQoRmls ZUVycm9yOjpFcnJvckNvZGUgZXJyb3JDb2RlLCBQYXNzUmVmUHRyPFR5cGVCdWlsZGVyOjpGaWxl U3lzdGVtOjpNZXRhZGF0YT4gbWV0YWRhdGEpCisgICAgdm9pZCByZXBvcnRSZXN1bHQoRmlsZUVy cm9yOjpFcnJvckNvZGUgZXJyb3JDb2RlLCBQYXNzUmVmUHRyPFR5cGVCdWlsZGVyOjpGaWxlU3lz dGVtOjpNZXRhZGF0YT4gbWV0YWRhdGEgPSAwKQogICAgIHsKICAgICAgICAgaWYgKCFtX2Zyb250 ZW5kUHJvdmlkZXIgfHwgIW1fZnJvbnRlbmRQcm92aWRlci0+ZnJvbnRlbmQoKSkKICAgICAgICAg ICAgIHJldHVybjsKQEAgLTM2MSw3ICszNjMsNiBAQCBwdWJsaWM6CiAgICAgICAgIG1fZnJvbnRl bmRQcm92aWRlciA9IDA7CiAgICAgfQogCi1wcml2YXRlOgogICAgIE1ldGFkYXRhUmVxdWVzdChQ YXNzUmVmUHRyPEZyb250ZW5kUHJvdmlkZXI+IGZyb250ZW5kUHJvdmlkZXIsIGludCByZXF1ZXN0 SWQsIGNvbnN0IFN0cmluZyYgdXJsKQogICAgICAgICA6IG1fZnJvbnRlbmRQcm92aWRlcihmcm9u dGVuZFByb3ZpZGVyKQogICAgICAgICAsIG1fcmVxdWVzdElkKHJlcXVlc3RJZCkKQEAgLTM4OSw3 ICszOTAsNyBAQCB2b2lkIE1ldGFkYXRhUmVxdWVzdDo6c3RhcnQoU2NyaXB0RXhlY3V0aW9uQ29u dGV4dCogc2NyaXB0RXhlY3V0aW9uQ29udGV4dCkKIGJvb2wgTWV0YWRhdGFSZXF1ZXN0OjpkaWRH ZXRFbnRyeShFbnRyeSogZW50cnkpCiB7CiAgICAgaWYgKCFlbnRyeS0+ZmlsZXN5c3RlbSgpLT5z Y3JpcHRFeGVjdXRpb25Db250ZXh0KCkpIHsKLSAgICAgICAgcmVwb3J0UmVzdWx0KEZpbGVFcnJv cjo6QUJPUlRfRVJSLCAwKTsKKyAgICAgICAgcmVwb3J0UmVzdWx0KEZpbGVFcnJvcjo6QUJPUlRf RVJSKTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCkBAIC00MjAsMTIgKzQyMSwxMSBA QCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIH5GaWxlQ29udGVudFJlcXVlc3QoKQogICAgIHsKLSAg ICAgICAgcmVwb3J0UmVzdWx0KEZpbGVFcnJvcjo6QUJPUlRfRVJSLCAwLCAwKTsKKyAgICAgICAg cmVwb3J0UmVzdWx0KEZpbGVFcnJvcjo6QUJPUlRfRVJSKTsKICAgICB9CiAKICAgICB2b2lkIHN0 YXJ0KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqKTsKIAotCiAgICAgdmlydHVhbCBib29sIG9wZXJh dG9yPT0oY29uc3QgRXZlbnRMaXN0ZW5lciYgb3RoZXIpIE9WRVJSSURFCiAgICAgewogICAgICAg ICByZXR1cm4gdGhpcyA9PSAmb3RoZXI7CkBAIC00NDIsNyArNDQyLDcgQEAgcHVibGljOgogcHJp dmF0ZToKICAgICBib29sIGRpZEhpdEVycm9yKEZpbGVFcnJvciogZXJyb3IpCiAgICAgewotICAg ICAgICByZXBvcnRSZXN1bHQoZXJyb3ItPmNvZGUoKSwgMCwgMCk7CisgICAgICAgIHJlcG9ydFJl c3VsdChlcnJvci0+Y29kZSgpKTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCkBAIC00 NTAsNyArNDUwLDcgQEAgcHJpdmF0ZToKICAgICBib29sIGRpZEdldEZpbGUoRmlsZSopOwogICAg IHZvaWQgZGlkUmVhZCgpOwogCi0gICAgdm9pZCByZXBvcnRSZXN1bHQoRmlsZUVycm9yOjpFcnJv ckNvZGUgZXJyb3JDb2RlLCBjb25zdCBTdHJpbmcqIHJlc3VsdCwgY29uc3QgU3RyaW5nKiBjaGFy c2V0KQorICAgIHZvaWQgcmVwb3J0UmVzdWx0KEZpbGVFcnJvcjo6RXJyb3JDb2RlIGVycm9yQ29k ZSwgY29uc3QgU3RyaW5nKiByZXN1bHQgPSAwLCBjb25zdCBTdHJpbmcqIGNoYXJzZXQgPSAwKQog ICAgIHsKICAgICAgICAgaWYgKCFtX2Zyb250ZW5kUHJvdmlkZXIgfHwgIW1fZnJvbnRlbmRQcm92 aWRlci0+ZnJvbnRlbmQoKSkKICAgICAgICAgICAgIHJldHVybjsKQEAgLTQ4Nyw3ICs0ODcsNyBA QCB2b2lkIEZpbGVDb250ZW50UmVxdWVzdDo6c3RhcnQoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCog c2NyaXB0RXhlY3V0aW9uQ29udGV4dCkKICAgICBGaWxlU3lzdGVtVHlwZSB0eXBlOwogICAgIFN0 cmluZyBwYXRoOwogICAgIGlmICghRE9NRmlsZVN5c3RlbUJhc2U6OmNyYWNrRmlsZVN5c3RlbVVS TChtX3VybCwgdHlwZSwgcGF0aCkpIHsKLSAgICAgICAgcmVwb3J0UmVzdWx0KEZpbGVFcnJvcjo6 U1lOVEFYX0VSUiwgMCwgMCk7CisgICAgICAgIHJlcG9ydFJlc3VsdChGaWxlRXJyb3I6OlNZTlRB WF9FUlIpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCkBAIC01MDEsMTIgKzUwMSwxMiBAQCB2 b2lkIEZpbGVDb250ZW50UmVxdWVzdDo6c3RhcnQoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogc2Ny aXB0RXhlY3V0aW9uQ29udGV4dCkKIGJvb2wgRmlsZUNvbnRlbnRSZXF1ZXN0OjpkaWRHZXRFbnRy eShFbnRyeSogZW50cnkpCiB7CiAgICAgaWYgKGVudHJ5LT5pc0RpcmVjdG9yeSgpKSB7Ci0gICAg ICAgIHJlcG9ydFJlc3VsdChGaWxlRXJyb3I6OlRZUEVfTUlTTUFUQ0hfRVJSLCAwLCAwKTsKKyAg ICAgICAgcmVwb3J0UmVzdWx0KEZpbGVFcnJvcjo6VFlQRV9NSVNNQVRDSF9FUlIpOwogICAgICAg ICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKICAgICBpZiAoIWVudHJ5LT5maWxlc3lzdGVtKCktPnNj cmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkgewotICAgICAgICByZXBvcnRSZXN1bHQoRmlsZUVycm9y OjpBQk9SVF9FUlIsIDAsIDApOworICAgICAgICByZXBvcnRSZXN1bHQoRmlsZUVycm9yOjpBQk9S VF9FUlIpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKQEAgLTU0OCw3ICs1NDgsNyBA QCB2b2lkIEZpbGVDb250ZW50UmVxdWVzdDo6ZGlkUmVhZCgpCiAgICAgcmVwb3J0UmVzdWx0KHN0 YXRpY19jYXN0PEZpbGVFcnJvcjo6RXJyb3JDb2RlPigwKSwgJnJlc3VsdCwgJm1fY2hhcnNldCk7 CiB9CiAKLX0KK30gLy8gYW5vbnltb3VzIG5hbWVzcGFjZQogCiAvLyBzdGF0aWMKIFBhc3NPd25Q dHI8SW5zcGVjdG9yRmlsZVN5c3RlbUFnZW50PiBJbnNwZWN0b3JGaWxlU3lzdGVtQWdlbnQ6OmNy ZWF0ZShJbnN0cnVtZW50aW5nQWdlbnRzKiBpbnN0cnVtZW50aW5nQWdlbnRzLCBJbnNwZWN0b3JQ YWdlQWdlbnQqIHBhZ2VBZ2VudCwgSW5zcGVjdG9yU3RhdGUqIHN0YXRlKQo=