93918 2012-08-13 17:55:32 -0700 [Chromium] Patch CCThreadProxy to call setTimebaseAndInterval on CCScheduler 2012-08-13 19:54:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbates jbates cc-bugs jamesr webkit.review.bot oldest_to_newest 694306 0 jbates 2012-08-13 17:55:32 -0700 [Chromium] Patch CCThreadProxy to call setTimebaseAndInterval on CCScheduler 694311 1 158173 jbates 2012-08-13 17:56:54 -0700 Created attachment 158173 Patch 694321 2 158173 jamesr 2012-08-13 18:00:16 -0700 Comment on attachment 158173 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158173&action=review > Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp:81 > + TRACE_EVENT1("cc", "CCFrameRateController::setActive", "active", active); This seems unnecessarily spammy, can you put it below the early-out? When would we want to know about redundant sets? 694323 3 158173 jbates 2012-08-13 18:01:52 -0700 Comment on attachment 158173 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158173&action=review >> Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp:81 >> + TRACE_EVENT1("cc", "CCFrameRateController::setActive", "active", active); > > This seems unnecessarily spammy, can you put it below the early-out? When would we want to know about redundant sets? For debugging it's helpful to see. I will change it back once we've got the new thread code working. 694329 4 158173 jamesr 2012-08-13 18:06:55 -0700 Comment on attachment 158173 Patch OK 694434 5 158173 webkit.review.bot 2012-08-13 19:54:13 -0700 Comment on attachment 158173 Patch Clearing flags on attachment: 158173 Committed r125504: <http://trac.webkit.org/changeset/125504> 694435 6 webkit.review.bot 2012-08-13 19:54:16 -0700 All reviewed patches have been landed. Closing bug. 158173 2012-08-13 17:56:54 -0700 2012-08-13 19:54:13 -0700 Patch bug-93918-20120813175623.patch text/plain 3519 jbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmVjMGUzMjM1MGZiN2E3 M2ExMWU3MmQyYTM5ODM3NzQ5ZmVkOWY4YS4uNzE1NTc2OTM3ZjZmYzYxY2I5ZGU2NTA0NzNmMWIz Y2Y4NTI4MzdhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTEzICBKb2hu IEJhdGVzICA8amJhdGVzQGdvb2dsZS5jb20+CisKKyAgICAgICAgW0Nocm9taXVtXSBQYXRjaCBD Q1RocmVhZFByb3h5IHRvIGNhbGwgc2V0VGltZWJhc2VBbmRJbnRlcnZhbCBvbiBDQ1NjaGVkdWxl cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM5MTgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHNvLCB1 cGRhdGUgc29tZSB0cmFjZSBldmVudHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9jYy9DQ0RlbGF5QmFzZWRUaW1lU291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkNDRGVsYXlCYXNlZFRpbWVTb3VyY2U6OnNldEFjdGl2ZSk6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NGcmFtZVJhdGVDb250cm9sbGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNDRnJhbWVSYXRlQ29udHJvbGxlcjo6c2V0QWN0aXZlKToKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1RocmVhZFByb3h5LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNDVGhyZWFkUHJveHk6Om9uVlN5bmNQYXJhbWV0ZXJzQ2hhbmdlZCk6CisKIDIw MTItMDgtMTMgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KIAogICAgICAg ICBbUXRdIEFkZCBncHJvZi5wcmYgdG8gYnVpbGQgV2ViS2l0IHdpdGggZ3Byb2YgZW5hYmxlZApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2Mv Q0NEZWxheUJhc2VkVGltZVNvdXJjZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9jYy9DQ0RlbGF5QmFzZWRUaW1lU291cmNlLmNwcAppbmRleCAyNTk4YjE5 MGU4YTM2OTU3MTA5ZTYzYTc0ODYxOWRmMzk1MDA4YTIwLi4zZjBkN2M0NDgwNWNmZjA3OGZlMjhh ZTFkZDQ3YzQ0NzdhMWJkOTYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9jYy9DQ0RlbGF5QmFzZWRUaW1lU291cmNlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0RlbGF5QmFzZWRUaW1l U291cmNlLmNwcApAQCAtMjYsNiArMjYsNyBAQAogCiAjaW5jbHVkZSAiY2MvQ0NEZWxheUJhc2Vk VGltZVNvdXJjZS5oIgogCisjaW5jbHVkZSAiVHJhY2VFdmVudC5oIgogI2luY2x1ZGUgPGFsZ29y aXRobT4KICNpbmNsdWRlIDx3dGYvQ3VycmVudFRpbWUuaD4KICNpbmNsdWRlIDx3dGYvTWF0aEV4 dHJhcy5oPgpAQCAtNjYsNiArNjcsNyBAQCBDQ0RlbGF5QmFzZWRUaW1lU291cmNlOjpDQ0RlbGF5 QmFzZWRUaW1lU291cmNlKGRvdWJsZSBpbnRlcnZhbFNlY29uZHMsIENDVGhyZWFkKgogCiB2b2lk IENDRGVsYXlCYXNlZFRpbWVTb3VyY2U6OnNldEFjdGl2ZShib29sIGFjdGl2ZSkKIHsKKyAgICBU UkFDRV9FVkVOVDEoImNjIiwgIkNDRGVsYXlCYXNlZFRpbWVTb3VyY2U6OnNldEFjdGl2ZSIsICJh Y3RpdmUiLCBhY3RpdmUpOwogICAgIGlmICghYWN0aXZlKSB7CiAgICAgICAgIG1fc3RhdGUgPSBT VEFURV9JTkFDVElWRTsKICAgICAgICAgbV90aW1lci5zdG9wKCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0ZyYW1lUmF0ZUNvbnRy b2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2Mv Q0NGcmFtZVJhdGVDb250cm9sbGVyLmNwcAppbmRleCBiNTJmYjVmNmYxZmQ1M2U1YTFjY2ZmMzJl MzA5N2FjODllN2E5Y2RkLi5mMTliMzllZTM2ZDZiMTRkZmY1NGUwZmU3ZjUwZmRmM2I0YjRlOWU1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9j Yy9DQ0ZyYW1lUmF0ZUNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDRnJhbWVSYXRlQ29udHJvbGxlci5jcHAKQEAgLTc4LDkg Kzc4LDkgQEAgQ0NGcmFtZVJhdGVDb250cm9sbGVyOjp+Q0NGcmFtZVJhdGVDb250cm9sbGVyKCkK IAogdm9pZCBDQ0ZyYW1lUmF0ZUNvbnRyb2xsZXI6OnNldEFjdGl2ZShib29sIGFjdGl2ZSkKIHsK KyAgICBUUkFDRV9FVkVOVDEoImNjIiwgIkNDRnJhbWVSYXRlQ29udHJvbGxlcjo6c2V0QWN0aXZl IiwgImFjdGl2ZSIsIGFjdGl2ZSk7CiAgICAgaWYgKG1fYWN0aXZlID09IGFjdGl2ZSkKICAgICAg ICAgcmV0dXJuOwotICAgIFRSQUNFX0VWRU5UMSgiY2MiLCAiQ0NGcmFtZVJhdGVDb250cm9sbGVy OjpzZXRBY3RpdmUiLCAiYWN0aXZlIiwgYWN0aXZlKTsKICAgICBtX2FjdGl2ZSA9IGFjdGl2ZTsK IAogICAgIGlmIChtX2lzVGltZVNvdXJjZVRocm90dGxpbmcpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1RocmVhZFByb3h5LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGhyZWFkUHJv eHkuY3BwCmluZGV4IGQzNzE2OGYxMTBhN2E5NmIxODlkMDExODBkY2NmODlkZGQ3YTBmYzIuLjMx ZDM1NzFiZDZmMGMyNmZhMmM3YWIwN2MwZDg3ZjNlYzM1NzljYmMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGhyZWFkUHJveHkuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGhy ZWFkUHJveHkuY3BwCkBAIC0zMjgsNyArMzI4LDcgQEAgdm9pZCBDQ1RocmVhZFByb3h5OjpvblZT eW5jUGFyYW1ldGVyc0NoYW5nZWQoZG91YmxlIG1vbm90b25pY1RpbWViYXNlLCBkb3VibGUgaW4K IHsKICAgICBBU1NFUlQoaXNJbXBsVGhyZWFkKCkpOwogICAgIFRSQUNFX0VWRU5UMCgiY2MiLCAi Q0NUaHJlYWRQcm94eTo6b25WU3luY1BhcmFtZXRlcnNDaGFuZ2VkIik7Ci0gICAgLy8gRklYTUU6 IHJvdXRlIHRoaXMgaW50byB0aGUgc2NoZWR1bGVyIG9uY2UgdGhlIHNjaGVkdWxlciBzdXBwb3J0 cyB2c3luYy4KKyAgICBtX3NjaGVkdWxlck9uSW1wbFRocmVhZC0+c2V0VGltZWJhc2VBbmRJbnRl cnZhbChtb25vdG9uaWNUaW1lYmFzZSwgaW50ZXJ2YWxJblNlY29uZHMpOwogfQogCiB2b2lkIEND VGhyZWFkUHJveHk6OnNldE5lZWRzQ29tbWl0T25JbXBsVGhyZWFkKCkK