93904 2012-08-13 14:56:02 -0700 old-run-webkit-tests should skip reference tests with all file extensions, not just .html. 2012-08-14 14:16:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong roger_fong dpranke thorton webkit.review.bot oldest_to_newest 694129 0 roger_fong 2012-08-13 14:56:02 -0700 old-run-webkit-tests ref test only skipped .html test. They need to skip .html, .shtml, .xml, .xhtml, .pl, .htm, .php, .svg, .mht. 694130 1 thorton 2012-08-13 14:56:28 -0700 (In reply to comment #0) > old-run-webkit-tests ref test only skipped .html test. > They need to skip .html, .shtml, .xml, .xhtml, .pl, .htm, .php, .svg, .mht. You should mention in the bug where you got this list from, probably. 694137 2 158116 roger_fong 2012-08-13 15:05:11 -0700 Created attachment 158116 patch 694138 3 roger_fong 2012-08-13 15:05:29 -0700 Hey Dirk, Could I get you to review this? Thanks, Roger 694139 4 158116 thorton 2012-08-13 15:06:42 -0700 Comment on attachment 158116 patch View in context: https://bugs.webkit.org/attachment.cgi?id=158116&action=review > Tools/Scripts/old-run-webkit-tests:2574 > + foreach (@extensions) { > + if (-f "$base-$expectedTag.$_" || -f "$base-$expectedTag-$mismatchTag.$_") { > + return 1; > + } > + } I wonder if you should match only the extension that was used in $filename. 695153 5 158116 dpranke 2012-08-14 10:58:06 -0700 Comment on attachment 158116 patch View in context: https://bugs.webkit.org/attachment.cgi?id=158116&action=review change basically looks fine. > Tools/Scripts/old-run-webkit-tests:2563 > + if ($filename =~ /-$expectedTag(-$mismatchTag)?\.(html|shtml|xml|xhtml|htm|php|svg|mht)$/) { Are all of these actually used in reftests? That seems unlikely. > Tools/Scripts/old-run-webkit-tests:2568 > + my @extensions = ('html','shtml','xml','xhtml','htm','php','svg','mht'); it would be good if we could share the same list here and above >> Tools/Scripts/old-run-webkit-tests:2574 >> + } > > I wonder if you should match only the extension that was used in $filename. I'm not actually sure that matching extensions is (or should be) a requirement. 695157 6 thorton 2012-08-14 11:00:48 -0700 (In reply to comment #5) > (From update of attachment 158116 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=158116&action=review > > change basically looks fine. > > > Tools/Scripts/old-run-webkit-tests:2563 > > + if ($filename =~ /-$expectedTag(-$mismatchTag)?\.(html|shtml|xml|xhtml|htm|php|svg|mht)$/) { > > Are all of these actually used in reftests? That seems unlikely. Probably not, but this is the list that's supported by NRWT, so it'll prevent surprises. > > Tools/Scripts/old-run-webkit-tests:2568 > > + my @extensions = ('html','shtml','xml','xhtml','htm','php','svg','mht'); > > it would be good if we could share the same list here and above Agreed. > >> Tools/Scripts/old-run-webkit-tests:2574 > >> + } > > > > I wonder if you should match only the extension that was used in $filename. > > I'm not actually sure that matching extensions is (or should be) a requirement. Sure, I suppose that doesn't make any sense. Ignore me :) 695160 7 dpranke 2012-08-14 11:03:33 -0700 (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 158116 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=158116&action=review > > > > change basically looks fine. > > > > > Tools/Scripts/old-run-webkit-tests:2563 > > > + if ($filename =~ /-$expectedTag(-$mismatchTag)?\.(html|shtml|xml|xhtml|htm|php|svg|mht)$/) { > > > > Are all of these actually used in reftests? That seems unlikely. > > Probably not, but this is the list that's supported by NRWT, so it'll prevent surprises. > Sure. NRWT also has '.pl' :) - webkitpy.layout_tests.port.base.Port._supported_file_extensions ... 695189 8 158381 roger_fong 2012-08-14 11:28:18 -0700 Created attachment 158381 patch Made that array fix, Added .pl 695195 9 roger_fong 2012-08-14 11:30:54 -0700 I'm also not a perl expert...as in I've never used it...so one sec on that patch... 695218 10 158388 roger_fong 2012-08-14 11:58:58 -0700 Created attachment 158388 perl fix That should do it. Ran it on the whole svg animations test folder (lots of ref tests there) and none of them ran. I'll get Tim to OK the perl but I'm pretty sure it's right now. 695268 11 158388 thorton 2012-08-14 12:46:02 -0700 Comment on attachment 158388 perl fix View in context: https://bugs.webkit.org/attachment.cgi?id=158388&action=review > Source/WebCore/platform/graphics/win/FontCGWin.cpp:309 > + shouldUseFontSmoothing = true; Hmm? > Tools/Scripts/old-run-webkit-tests:2563 > + my @extensions = ('html','shtml','xml','xhtml','htm','php','svg','mht','.pl'); No period. 695281 12 158395 roger_fong 2012-08-14 12:50:41 -0700 Created attachment 158395 doh 695289 13 158395 thorton 2012-08-14 12:55:25 -0700 Comment on attachment 158395 doh View in context: https://bugs.webkit.org/attachment.cgi?id=158395&action=review > Tools/Scripts/old-run-webkit-tests:2565 > + my $extensionStr = join("|", @extensions); > + my $regexStr = "-$expectedTag(-$mismatchTag)?\\.(".$extensionStr.")\$"; This looks suspiciously like hungarian notation, which we don't do :) > Tools/Scripts/old-run-webkit-tests:2572 > + foreach (@extensions) { you can do foreach my $extension (@extensions) and then use the nice, named $extension instead of the meaningless $_ below. 695296 14 dpranke 2012-08-14 13:01:46 -0700 all fine comments; my r+ was way too sloppy :(. 695303 15 158399 roger_fong 2012-08-14 13:05:50 -0700 Created attachment 158399 Rei 695305 16 158399 thorton 2012-08-14 13:06:40 -0700 Comment on attachment 158399 Rei View in context: https://bugs.webkit.org/attachment.cgi?id=158399&action=review > Tools/Scripts/old-run-webkit-tests:2565 > + my $extensions_joined = join("|", @extensions); > + my $extension_expression = "-$expectedTag(-$mismatchTag)?\\.(".$extensions_joined.")\$"; These should be camel case, not underscored :D 695311 17 158400 roger_fong 2012-08-14 13:12:40 -0700 Created attachment 158400 Mee 695382 18 158400 webkit.review.bot 2012-08-14 14:16:23 -0700 Comment on attachment 158400 Mee Clearing flags on attachment: 158400 Committed r125604: <http://trac.webkit.org/changeset/125604> 695383 19 webkit.review.bot 2012-08-14 14:16:27 -0700 All reviewed patches have been landed. Closing bug. 158116 2012-08-13 15:05:11 -0700 2012-08-14 11:28:18 -0700 patch 93904_patch.txt text/plain 1749 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyNTQ1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEyLTA4LTEzICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgb2xkLXJ1bi13ZWJraXQtdGVzdHMgc2hvdWxkIHNraXAgYWxsIGZpbGUgZXh0 ZW5zaW9ucyBmb3IgcmVmIHRlc3RzLCBub3QganVzdCAuaHRtbC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzOTA0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgb2xkLXJ1bi13ZWJraXQtdGVzdHMgcmVmIHRl c3Qgb25seSBza2lwcGVkIC5odG1sIHRlc3QuCisgICAgICAgIFRoZXkgbmVlZCB0byBza2lwIC5o dG1sLCAuc2h0bWwsIC54bWwsIC54aHRtbCwgLnBsLCAuaHRtLCAucGhwLCAuc3ZnLCAubWh0Lgor ICAgICAgICAKKyAgICAgICAgKiBTY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzOgorICAgICAg ICAoaXNVc2VkSW5SZWZ0ZXN0KTogU2tpcCBhbGwgZXh0ZW5zaW9ucyBmb3IgcmVmIHRlc3RzLgor CiAyMDEyLTA4LTEzICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29Ad2Via2l0Lm9yZz4K IAogICAgICAgICBbQ01ha2VdIFJlbW92ZSBnbGliLXJlbGF0ZWQgRmluZCBtb2R1bGVzIGFuZCB3 cml0ZSBzaW5nbGUgbmV3IG9uZSBpbnN0ZWFkLgpJbmRleDogVG9vbHMvU2NyaXB0cy9vbGQtcnVu LXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0 LXRlc3RzCShyZXZpc2lvbiAxMjU0MjgpCisrKyBUb29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0 LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0yNTYwLDExICsyNTYwLDE5IEBAIG15IEB0ZXN0c0Zv dW5kOwogc3ViIGlzVXNlZEluUmVmdGVzdCgkKQogewogICAgIG15ICRmaWxlbmFtZSA9ICRfWzBd OwotICAgIGlmICgkZmlsZW5hbWUgPX4gLy0kZXhwZWN0ZWRUYWcoLSRtaXNtYXRjaFRhZyk/XC5o dG1sJC8pIHsKKyAgICBpZiAoJGZpbGVuYW1lID1+IC8tJGV4cGVjdGVkVGFnKC0kbWlzbWF0Y2hU YWcpP1wuKGh0bWx8c2h0bWx8eG1sfHhodG1sfGh0bXxwaHB8c3ZnfG1odCkkLykgewogICAgICAg ICByZXR1cm4gMTsKICAgICB9CiAgICAgbXkgJGJhc2UgPSBzdHJpcEV4dGVuc2lvbigkZmlsZW5h bWUpOwotICAgIHJldHVybiAoLWYgIiRiYXNlLSRleHBlY3RlZFRhZy5odG1sIiB8fCAtZiAiJGJh c2UtJGV4cGVjdGVkVGFnLSRtaXNtYXRjaFRhZy5odG1sIik7CisgICAgCisgICAgbXkgQGV4dGVu c2lvbnMgPSAoJ2h0bWwnLCdzaHRtbCcsJ3htbCcsJ3hodG1sJywnaHRtJywncGhwJywnc3ZnJywn bWh0Jyk7CisgICAgCisgICAgZm9yZWFjaCAoQGV4dGVuc2lvbnMpIHsKKyAgICAgICAgaWYgKC1m ICIkYmFzZS0kZXhwZWN0ZWRUYWcuJF8iIHx8IC1mICIkYmFzZS0kZXhwZWN0ZWRUYWctJG1pc21h dGNoVGFnLiRfIikgeworICAgICAgICAgICAgcmV0dXJuIDE7CisgICAgICAgIH0KKyAgICB9Cisg ICAgcmV0dXJuIDA7CiB9CiAKIHN1YiBkaXJlY3RvcnlGaWx0ZXIK 158381 2012-08-14 11:28:18 -0700 2012-08-14 11:58:58 -0700 patch 93904_patch.txt text/plain 1701 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyNTQ3MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEyLTA4LTE0ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgb2xkLXJ1bi13ZWJraXQtdGVzdHMgc2hvdWxkIHNraXAgYWxsIGZpbGUgZXh0 ZW5zaW9ucyBmb3IgcmVmIHRlc3RzLCBub3QganVzdCAuaHRtbC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzOTA0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgb2xkLXJ1bi13ZWJraXQtdGVzdHMgcmVmIHRl c3Qgb25seSBza2lwcGVkIC5odG1sIHRlc3QuCisgICAgICAgIFRoZXkgbmVlZCB0byBza2lwIC5o dG1sLCAuc2h0bWwsIC54bWwsIC54aHRtbCwgLnBsLCAuaHRtLCAucGhwLCAuc3ZnLCAubWh0Lgor ICAgICAgICAKKyAgICAgICAgKiBTY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzOgorICAgICAg ICAoaXNVc2VkSW5SZWZ0ZXN0KTogU2tpcCBhbGwgZXh0ZW5zaW9ucyBmb3IgcmVmIHRlc3RzLgor CiAyMDEyLTA4LTExICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29Ad2Via2l0Lm9yZz4K IAogICAgICAgICBbQ01ha2VdIFJld3JpdGUgRmluZExpYlNvdXAyLmNtYWtlLgpJbmRleDogVG9v bHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL29sZC1ydW4td2Via2l0LXRlc3RzCShyZXZpc2lvbiAxMjU0NzMpCisrKyBUb29scy9TY3Jp cHRzL29sZC1ydW4td2Via2l0LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0yNTYwLDExICsyNTYw LDE5IEBAIG15IEB0ZXN0c0ZvdW5kOwogc3ViIGlzVXNlZEluUmVmdGVzdCgkKQogewogICAgIG15 ICRmaWxlbmFtZSA9ICRfWzBdOwotICAgIGlmICgkZmlsZW5hbWUgPX4gLy0kZXhwZWN0ZWRUYWco LSRtaXNtYXRjaFRhZyk/XC5odG1sJC8pIHsKKyAgICBteSBAZXh0ZW5zaW9ucyA9ICgnaHRtbCcs J3NodG1sJywneG1sJywneGh0bWwnLCdodG0nLCdwaHAnLCdzdmcnLCdtaHQnLCcucGwnKTsKKyAg ICAKKyAgICBpZiAoJGZpbGVuYW1lID1+IC8tJGV4cGVjdGVkVGFnKC0kbWlzbWF0Y2hUYWcpP1wu KGpvaW4gInwiLCBAZXh0ZW5zaW9ucykkLykgewogICAgICAgICByZXR1cm4gMTsKICAgICB9CiAg ICAgbXkgJGJhc2UgPSBzdHJpcEV4dGVuc2lvbigkZmlsZW5hbWUpOwotICAgIHJldHVybiAoLWYg IiRiYXNlLSRleHBlY3RlZFRhZy5odG1sIiB8fCAtZiAiJGJhc2UtJGV4cGVjdGVkVGFnLSRtaXNt YXRjaFRhZy5odG1sIik7CisgICAgCisgICAgZm9yZWFjaCAoQGV4dGVuc2lvbnMpIHsKKyAgICAg ICAgaWYgKC1mICIkYmFzZS0kZXhwZWN0ZWRUYWcuJF8iIHx8IC1mICIkYmFzZS0kZXhwZWN0ZWRU YWctJG1pc21hdGNoVGFnLiRfIikgeworICAgICAgICAgICAgcmV0dXJuIDE7CisgICAgICAgIH0K KyAgICB9CisgICAgcmV0dXJuIDA7CiB9CiAKIHN1YiBkaXJlY3RvcnlGaWx0ZXIK 158388 2012-08-14 11:58:58 -0700 2012-08-14 12:50:41 -0700 perl fix 93904_patch.txt text/plain 2373 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9Gb250Q0dXaW4uY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9Gb250 Q0dXaW4uY3BwCShyZXZpc2lvbiAxMjU0NzMpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy93aW4vRm9udENHV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzA2LDcgKzMwNiw3 IEBAIHZvaWQgRm9udDo6ZHJhd0dseXBocyhHcmFwaGljc0NvbnRleHQqIGcKICAgICBzd2l0Y2go Zm9udERlc2NyaXB0aW9uKCkuZm9udFNtb290aGluZygpKSB7CiAgICAgY2FzZSBBbnRpYWxpYXNl ZDogewogICAgICAgICBncmFwaGljc0NvbnRleHQtPnNldFNob3VsZEFudGlhbGlhcyh0cnVlKTsK LSAgICAgICAgc2hvdWxkVXNlRm9udFNtb290aGluZyA9IGZhbHNlOworICAgICAgICBzaG91bGRV c2VGb250U21vb3RoaW5nID0gdHJ1ZTsKICAgICAgICAgYnJlYWs7CiAgICAgfQogICAgIGNhc2Ug U3VicGl4ZWxBbnRpYWxpYXNlZDogewpJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMTI1NDczKQorKysgVG9vbHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDgtMTQgIFJvZ2VyIEZvbmcg IDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KKworICAgICAgICBvbGQtcnVuLXdlYmtpdC10ZXN0cyBz aG91bGQgc2tpcCBhbGwgZmlsZSBleHRlbnNpb25zIGZvciByZWYgdGVzdHMsIG5vdCBqdXN0IC5o dG1sLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM5 MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBvbGQt cnVuLXdlYmtpdC10ZXN0cyByZWYgdGVzdCBvbmx5IHNraXBwZWQgLmh0bWwgdGVzdC4KKyAgICAg ICAgVGhleSBuZWVkIHRvIHNraXAgLmh0bWwsIC5zaHRtbCwgLnhtbCwgLnhodG1sLCAucGwsIC5o dG0sIC5waHAsIC5zdmcsIC5taHQuCisgICAgICAgIAorICAgICAgICAqIFNjcmlwdHMvb2xkLXJ1 bi13ZWJraXQtdGVzdHM6CisgICAgICAgIChpc1VzZWRJblJlZnRlc3QpOiBTa2lwIGFsbCBleHRl bnNpb25zIGZvciByZWYgdGVzdHMuCisKIDIwMTItMDgtMTEgIFJhcGhhZWwgS3VibyBkYSBDb3N0 YSAgPHJha3Vjb0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtDTWFrZV0gUmV3cml0ZSBGaW5kTGli U291cDIuY21ha2UuCkluZGV4OiBUb29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMJKHJldmlzaW9u IDEyNTQ3MykKKysrIFRvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMJKHdvcmtpbmcg Y29weSkKQEAgLTI1NjAsMTEgKzI1NjAsMjEgQEAgbXkgQHRlc3RzRm91bmQ7CiBzdWIgaXNVc2Vk SW5SZWZ0ZXN0KCQpCiB7CiAgICAgbXkgJGZpbGVuYW1lID0gJF9bMF07Ci0gICAgaWYgKCRmaWxl bmFtZSA9fiAvLSRleHBlY3RlZFRhZygtJG1pc21hdGNoVGFnKT9cLmh0bWwkLykgeworICAgIG15 IEBleHRlbnNpb25zID0gKCdodG1sJywnc2h0bWwnLCd4bWwnLCd4aHRtbCcsJ2h0bScsJ3BocCcs J3N2ZycsJ21odCcsJy5wbCcpOworICAgIG15ICRleHRlbnNpb25TdHIgPSBqb2luKCJ8IiwgQGV4 dGVuc2lvbnMpOworICAgIG15ICRyZWdleFN0ciA9ICItJGV4cGVjdGVkVGFnKC0kbWlzbWF0Y2hU YWcpP1xcLigiLiRleHRlbnNpb25TdHIuIilcJCI7CisgICAgCisgICAgaWYgKCRmaWxlbmFtZSA9 fiAvJHJlZ2V4U3RyLykgewogICAgICAgICByZXR1cm4gMTsKICAgICB9CiAgICAgbXkgJGJhc2Ug PSBzdHJpcEV4dGVuc2lvbigkZmlsZW5hbWUpOwotICAgIHJldHVybiAoLWYgIiRiYXNlLSRleHBl Y3RlZFRhZy5odG1sIiB8fCAtZiAiJGJhc2UtJGV4cGVjdGVkVGFnLSRtaXNtYXRjaFRhZy5odG1s Iik7CisgICAgCisgICAgZm9yZWFjaCAoQGV4dGVuc2lvbnMpIHsKKyAgICAgICAgaWYgKC1mICIk YmFzZS0kZXhwZWN0ZWRUYWcuJF8iIHx8IC1mICIkYmFzZS0kZXhwZWN0ZWRUYWctJG1pc21hdGNo VGFnLiRfIikgeworICAgICAgICAgICAgcmV0dXJuIDE7CisgICAgICAgIH0KKyAgICB9CisgICAg cmV0dXJuIDA7CiB9CiAKIHN1YiBkaXJlY3RvcnlGaWx0ZXIK 158395 2012-08-14 12:50:41 -0700 2012-08-14 13:05:50 -0700 doh 93904_patch.txt text/plain 1779 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyNTQ3MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEyLTA4LTE0ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgb2xkLXJ1bi13ZWJraXQtdGVzdHMgc2hvdWxkIHNraXAgYWxsIGZpbGUgZXh0 ZW5zaW9ucyBmb3IgcmVmIHRlc3RzLCBub3QganVzdCAuaHRtbC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzOTA0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgb2xkLXJ1bi13ZWJraXQtdGVzdHMgcmVmIHRl c3Qgb25seSBza2lwcGVkIC5odG1sIHRlc3QuCisgICAgICAgIFRoZXkgbmVlZCB0byBza2lwIC5o dG1sLCAuc2h0bWwsIC54bWwsIC54aHRtbCwgLnBsLCAuaHRtLCAucGhwLCAuc3ZnLCAubWh0Lgor ICAgICAgICAKKyAgICAgICAgKiBTY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzOgorICAgICAg ICAoaXNVc2VkSW5SZWZ0ZXN0KTogU2tpcCBhbGwgZXh0ZW5zaW9ucyBmb3IgcmVmIHRlc3RzLgor CiAyMDEyLTA4LTExICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29Ad2Via2l0Lm9yZz4K IAogICAgICAgICBbQ01ha2VdIFJld3JpdGUgRmluZExpYlNvdXAyLmNtYWtlLgpJbmRleDogVG9v bHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL29sZC1ydW4td2Via2l0LXRlc3RzCShyZXZpc2lvbiAxMjU0NzMpCisrKyBUb29scy9TY3Jp cHRzL29sZC1ydW4td2Via2l0LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0yNTYwLDExICsyNTYw LDIxIEBAIG15IEB0ZXN0c0ZvdW5kOwogc3ViIGlzVXNlZEluUmVmdGVzdCgkKQogewogICAgIG15 ICRmaWxlbmFtZSA9ICRfWzBdOwotICAgIGlmICgkZmlsZW5hbWUgPX4gLy0kZXhwZWN0ZWRUYWco LSRtaXNtYXRjaFRhZyk/XC5odG1sJC8pIHsKKyAgICBteSBAZXh0ZW5zaW9ucyA9ICgnaHRtbCcs J3NodG1sJywneG1sJywneGh0bWwnLCdodG0nLCdwaHAnLCdzdmcnLCdtaHQnLCdwbCcpOworICAg IG15ICRleHRlbnNpb25TdHIgPSBqb2luKCJ8IiwgQGV4dGVuc2lvbnMpOworICAgIG15ICRyZWdl eFN0ciA9ICItJGV4cGVjdGVkVGFnKC0kbWlzbWF0Y2hUYWcpP1xcLigiLiRleHRlbnNpb25TdHIu IilcJCI7CisgICAgCisgICAgaWYgKCRmaWxlbmFtZSA9fiAvJHJlZ2V4U3RyLykgewogICAgICAg ICByZXR1cm4gMTsKICAgICB9CiAgICAgbXkgJGJhc2UgPSBzdHJpcEV4dGVuc2lvbigkZmlsZW5h bWUpOwotICAgIHJldHVybiAoLWYgIiRiYXNlLSRleHBlY3RlZFRhZy5odG1sIiB8fCAtZiAiJGJh c2UtJGV4cGVjdGVkVGFnLSRtaXNtYXRjaFRhZy5odG1sIik7CisgICAgCisgICAgZm9yZWFjaCAo QGV4dGVuc2lvbnMpIHsKKyAgICAgICAgaWYgKC1mICIkYmFzZS0kZXhwZWN0ZWRUYWcuJF8iIHx8 IC1mICIkYmFzZS0kZXhwZWN0ZWRUYWctJG1pc21hdGNoVGFnLiRfIikgeworICAgICAgICAgICAg cmV0dXJuIDE7CisgICAgICAgIH0KKyAgICB9CisgICAgcmV0dXJuIDA7CiB9CiAKIHN1YiBkaXJl Y3RvcnlGaWx0ZXIK 158399 2012-08-14 13:05:50 -0700 2012-08-14 13:12:40 -0700 Rei 93904_patch.txt text/plain 1851 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyNTQ3MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEyLTA4LTE0ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgb2xkLXJ1bi13ZWJraXQtdGVzdHMgc2hvdWxkIHNraXAgYWxsIGZpbGUgZXh0 ZW5zaW9ucyBmb3IgcmVmIHRlc3RzLCBub3QganVzdCAuaHRtbC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzOTA0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgb2xkLXJ1bi13ZWJraXQtdGVzdHMgcmVmIHRl c3Qgb25seSBza2lwcGVkIC5odG1sIHRlc3QuCisgICAgICAgIFRoZXkgbmVlZCB0byBza2lwIC5o dG1sLCAuc2h0bWwsIC54bWwsIC54aHRtbCwgLnBsLCAuaHRtLCAucGhwLCAuc3ZnLCAubWh0Lgor ICAgICAgICAKKyAgICAgICAgKiBTY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzOgorICAgICAg ICAoaXNVc2VkSW5SZWZ0ZXN0KTogU2tpcCBhbGwgZXh0ZW5zaW9ucyBmb3IgcmVmIHRlc3RzLgor CiAyMDEyLTA4LTExICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29Ad2Via2l0Lm9yZz4K IAogICAgICAgICBbQ01ha2VdIFJld3JpdGUgRmluZExpYlNvdXAyLmNtYWtlLgpJbmRleDogVG9v bHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL29sZC1ydW4td2Via2l0LXRlc3RzCShyZXZpc2lvbiAxMjU0NzMpCisrKyBUb29scy9TY3Jp cHRzL29sZC1ydW4td2Via2l0LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0yNTYwLDExICsyNTYw LDIxIEBAIG15IEB0ZXN0c0ZvdW5kOwogc3ViIGlzVXNlZEluUmVmdGVzdCgkKQogewogICAgIG15 ICRmaWxlbmFtZSA9ICRfWzBdOwotICAgIGlmICgkZmlsZW5hbWUgPX4gLy0kZXhwZWN0ZWRUYWco LSRtaXNtYXRjaFRhZyk/XC5odG1sJC8pIHsKKyAgICBteSBAZXh0ZW5zaW9ucyA9ICgnaHRtbCcs J3NodG1sJywneG1sJywneGh0bWwnLCdodG0nLCdwaHAnLCdzdmcnLCdtaHQnLCdwbCcpOworICAg IG15ICRleHRlbnNpb25zX2pvaW5lZCA9IGpvaW4oInwiLCBAZXh0ZW5zaW9ucyk7CisgICAgbXkg JGV4dGVuc2lvbl9leHByZXNzaW9uID0gIi0kZXhwZWN0ZWRUYWcoLSRtaXNtYXRjaFRhZyk/XFwu KCIuJGV4dGVuc2lvbnNfam9pbmVkLiIpXCQiOworICAgIAorICAgIGlmICgkZmlsZW5hbWUgPX4g LyRleHRlbnNpb25fZXhwcmVzc2lvbi8pIHsKICAgICAgICAgcmV0dXJuIDE7CiAgICAgfQogICAg IG15ICRiYXNlID0gc3RyaXBFeHRlbnNpb24oJGZpbGVuYW1lKTsKLSAgICByZXR1cm4gKC1mICIk YmFzZS0kZXhwZWN0ZWRUYWcuaHRtbCIgfHwgLWYgIiRiYXNlLSRleHBlY3RlZFRhZy0kbWlzbWF0 Y2hUYWcuaHRtbCIpOworICAgIAorICAgIGZvcmVhY2ggKG15ICRleHRlbnNpb24gQGV4dGVuc2lv bnMpIHsKKyAgICAgICAgaWYgKC1mICIkYmFzZS0kZXhwZWN0ZWRUYWcuJGV4dGVuc2lvbiIgfHwg LWYgIiRiYXNlLSRleHBlY3RlZFRhZy0kbWlzbWF0Y2hUYWcuJGV4dGVuc2lvbnNfam9pbmVkIikg eworICAgICAgICAgICAgcmV0dXJuIDE7CisgICAgICAgIH0KKyAgICB9CisgICAgcmV0dXJuIDA7 CiB9CiAKIHN1YiBkaXJlY3RvcnlGaWx0ZXIK 158400 2012-08-14 13:12:40 -0700 2012-08-14 14:16:23 -0700 Mee 93904_patch.txt text/plain 1846 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyNTQ3MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEyLTA4LTE0ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgb2xkLXJ1bi13ZWJraXQtdGVzdHMgc2hvdWxkIHNraXAgYWxsIGZpbGUgZXh0 ZW5zaW9ucyBmb3IgcmVmIHRlc3RzLCBub3QganVzdCAuaHRtbC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzOTA0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgb2xkLXJ1bi13ZWJraXQtdGVzdHMgcmVmIHRl c3Qgb25seSBza2lwcGVkIC5odG1sIHRlc3QuCisgICAgICAgIFRoZXkgbmVlZCB0byBza2lwIC5o dG1sLCAuc2h0bWwsIC54bWwsIC54aHRtbCwgLnBsLCAuaHRtLCAucGhwLCAuc3ZnLCAubWh0Lgor ICAgICAgICAKKyAgICAgICAgKiBTY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzOgorICAgICAg ICAoaXNVc2VkSW5SZWZ0ZXN0KTogU2tpcCBhbGwgZXh0ZW5zaW9ucyBmb3IgcmVmIHRlc3RzLgor CiAyMDEyLTA4LTExICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29Ad2Via2l0Lm9yZz4K IAogICAgICAgICBbQ01ha2VdIFJld3JpdGUgRmluZExpYlNvdXAyLmNtYWtlLgpJbmRleDogVG9v bHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL29sZC1ydW4td2Via2l0LXRlc3RzCShyZXZpc2lvbiAxMjU0NzMpCisrKyBUb29scy9TY3Jp cHRzL29sZC1ydW4td2Via2l0LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0yNTYwLDExICsyNTYw LDIxIEBAIG15IEB0ZXN0c0ZvdW5kOwogc3ViIGlzVXNlZEluUmVmdGVzdCgkKQogewogICAgIG15 ICRmaWxlbmFtZSA9ICRfWzBdOwotICAgIGlmICgkZmlsZW5hbWUgPX4gLy0kZXhwZWN0ZWRUYWco LSRtaXNtYXRjaFRhZyk/XC5odG1sJC8pIHsKKyAgICBteSBAZXh0ZW5zaW9ucyA9ICgnaHRtbCcs J3NodG1sJywneG1sJywneGh0bWwnLCdodG0nLCdwaHAnLCdzdmcnLCdtaHQnLCdwbCcpOworICAg IG15ICRleHRlbnNpb25zSm9pbmVkID0gam9pbigifCIsIEBleHRlbnNpb25zKTsKKyAgICBteSAk ZXh0ZW5zaW9uRXhwcmVzc2lvbiA9ICItJGV4cGVjdGVkVGFnKC0kbWlzbWF0Y2hUYWcpP1xcLigi LiRleHRlbnNpb25zSm9pbmVkLiIpXCQiOworICAgIAorICAgIGlmICgkZmlsZW5hbWUgPX4gLyRl eHRlbnNpb25FeHByZXNzaW9uLykgewogICAgICAgICByZXR1cm4gMTsKICAgICB9CiAgICAgbXkg JGJhc2UgPSBzdHJpcEV4dGVuc2lvbigkZmlsZW5hbWUpOwotICAgIHJldHVybiAoLWYgIiRiYXNl LSRleHBlY3RlZFRhZy5odG1sIiB8fCAtZiAiJGJhc2UtJGV4cGVjdGVkVGFnLSRtaXNtYXRjaFRh Zy5odG1sIik7CisgICAgCisgICAgZm9yZWFjaCBteSAkZXh0ZW5zaW9uIChAZXh0ZW5zaW9ucykg eworICAgICAgICBpZiAoLWYgIiRiYXNlLSRleHBlY3RlZFRhZy4kZXh0ZW5zaW9uIiB8fCAtZiAi JGJhc2UtJGV4cGVjdGVkVGFnLSRtaXNtYXRjaFRhZy4kZXh0ZW5zaW9uc0pvaW5lZCIpIHsKKyAg ICAgICAgICAgIHJldHVybiAxOworICAgICAgICB9CisgICAgfQorICAgIHJldHVybiAwOwogfQog CiBzdWIgZGlyZWN0b3J5RmlsdGVyCg==