93885 2012-08-13 13:06:29 -0700 [GTK] String returned by g_path_get_dirname() must be freed 2012-08-14 00:31:53 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis pnormand webkit.review.bot oldest_to_newest 693991 0 naginenis 2012-08-13 13:06:29 -0700 Memory leak in GTK's DRT code. To fix the leak, string retuned by g_path_get_dirname() must be freed. ==13984== 102 bytes in 2 blocks are definitely lost in loss record 9,327 of 10,890 ==13984== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==13984== by 0xCB3AA38: g_malloc (gmem.c:159) ==13984== by 0xCB23A35: g_path_get_dirname (gfileutils.c:2454) ==13984== by 0x474F61: pathFromSoupURI(_SoupURI*) (DumpRenderTree.cpp:1130) ==13984== by 0x47507B: convertSoupMessageToURLPath(_SoupMessage*) (DumpRenderTree.cpp:1141) ==13984== by 0x4750BD: convertNetworkRequestToURLPath(_WebKitNetworkRequest*) (DumpRenderTree.cpp:1147) ==13984== by 0x47582C: willSendRequestCallback(_WebKitWebView*, _WebKitWebFrame*, _WebKitWebResource*, _WebKitNetworkRequest*, _WebKitNetworkResponse*) (DumpRenderTree.cpp:1263) ==13984== by 0x6F0681E: webkit_marshal_VOID__OBJECT_OBJECT_OBJECT_OBJECT (webkitmarshal.cpp:1124) ==13984== by 0xC8ADCA1: g_closure_invoke (gclosure.c:777) ==13984== by 0xC8BED70: signal_emit_unlocked_R (gsignal.c:3547) ==13984== by 0xC8C7098: g_signal_emit_valist (gsignal.c:3296) ==13984== by 0xC8C7753: g_signal_emit_by_name (gsignal.c:3389) 694007 1 158086 naginenis 2012-08-13 13:18:59 -0700 Created attachment 158086 Patch 694601 2 158086 webkit.review.bot 2012-08-14 00:31:49 -0700 Comment on attachment 158086 Patch Clearing flags on attachment: 158086 Committed r125515: <http://trac.webkit.org/changeset/125515> 694602 3 webkit.review.bot 2012-08-14 00:31:53 -0700 All reviewed patches have been landed. Closing bug. 158086 2012-08-13 13:18:59 -0700 2012-08-14 00:31:49 -0700 Patch 93885.patch text/plain 1437 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlNDYz ZWMwLi4zMmRlOWIxMyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTEzICBTdWRhcnNhbmEgTmFnaW5lbmkg IDxzdWRhcnNhbmEubmFnaW5lbmlAbGludXguaW50ZWwuY29tPgorCisgICAgICAgIFtHVEtdIFN0 cmluZyByZXR1cm5lZCBieSBnX3BhdGhfZ2V0X2Rpcm5hbWUoKSBtdXN0IGJlIGZyZWVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mzg4NQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhIG1lbW9yeSBs ZWFrIGluIEdUSydzIERSVCBjb2RlLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0R1 bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKHBhdGhGcm9tU291cFVSSSk6IEZyZWUgdGhlIHN0 cmluZyByZXR1cm5lZCBieSBnX3BhdGhfZ2V0X2Rpcm5hbWUoKS4KKwogMjAxMi0wOC0xMyAgUGV0 ZXIgQmV2ZXJsb28gIDxwZXRlckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBG aXggYXBrIGdlbmVyYXRpb24gZm9yIHRoZSBBbmRyb2lkIHBsYXRmb3JtCmRpZmYgLS1naXQgYS9U b29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCBmYWU4NjY2Li5hZGQyMzg5IDEw MDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCisr KyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTExMjYs NyArMTEyNiw4IEBAIHN0YXRpYyBDU3RyaW5nIHBhdGhGcm9tU291cFVSSShTb3VwVVJJKiB1cmkp CiAgICAgICAgIHJldHVybiBDU3RyaW5nKHVyaVN0cmluZy5nZXQoKSk7CiAgICAgfQogCi0gICAg R093blB0cjxnY2hhcj4gcGF0aERpcm5hbWUoZ19wYXRoX2dldF9iYXNlbmFtZShnX3BhdGhfZ2V0 X2Rpcm5hbWUodXJpLT5wYXRoKSkpOworICAgIEdPd25QdHI8Z2NoYXI+IHBhcmVudFBhdGgoZ19w YXRoX2dldF9kaXJuYW1lKHVyaS0+cGF0aCkpOworICAgIEdPd25QdHI8Z2NoYXI+IHBhdGhEaXJu YW1lKGdfcGF0aF9nZXRfYmFzZW5hbWUocGFyZW50UGF0aC5nZXQoKSkpOwogICAgIEdPd25QdHI8 Z2NoYXI+IHBhdGhCYXNlbmFtZShnX3BhdGhfZ2V0X2Jhc2VuYW1lKHVyaS0+cGF0aCkpOwogICAg IEdPd25QdHI8Z2NoYXI+IHVybFBhdGgoZ19zdHJkdXBfcHJpbnRmKCIlcy8lcyIsIHBhdGhEaXJu YW1lLmdldCgpLCBwYXRoQmFzZW5hbWUuZ2V0KCkpKTsKICAgICByZXR1cm4gQ1N0cmluZyh1cmxQ YXRoLmdldCgpKTsK