93864 2012-08-13 10:38:11 -0700 Media(Stream|Element)AudioSourceNode should be guarded by the WEB_AUDIO condition as well 2012-08-13 13:18:17 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan abarth crogers eric.carlson feature-media-reviews ojan webkit.review.bot oldest_to_newest 693799 0 zan 2012-08-13 10:38:11 -0700 Currently the MediaStreamAudioSourceNode lists only the MEDIA_SOURCE feature under the Conditional attribute. The compilation then fails when the MEDIA_STREAM feature is enabled but the WEB_AUDIO feature is not. Both guards are used in MediaStreamAudioSourceNode.cpp but only MEDIA_STREAM in MediaStreamAudioSourceNode.h. 693818 1 158041 zan 2012-08-13 10:49:54 -0700 Created attachment 158041 Patch 693824 2 zan 2012-08-13 10:54:50 -0700 MediaElementAudioSourceNode suffers the same issue, meaning there would be compilation errors when enabling WEB_AUDIO and disabling the VIDEO feature. Just to make it clear, the GTK port intends to include all the files into the build, regardless of any feature being enabled or not. The GTK port currently enables the MEDIA_STREAM feature and disables WEB_AUDIO, and that's where the errors were first noticed. 693826 3 zan 2012-08-13 10:55:32 -0700 Changing the title accordingly, uploading a new patch soon. 693835 4 158046 zan 2012-08-13 11:03:32 -0700 Created attachment 158046 Patch 694005 5 158046 webkit.review.bot 2012-08-13 13:18:13 -0700 Comment on attachment 158046 Patch Clearing flags on attachment: 158046 Committed r125440: <http://trac.webkit.org/changeset/125440> 694006 6 webkit.review.bot 2012-08-13 13:18:17 -0700 All reviewed patches have been landed. Closing bug. 158041 2012-08-13 10:49:54 -0700 2012-08-13 11:03:25 -0700 Patch bug-93864-20120813104923.patch text/plain 2165 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTQyNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTEzICBaYW4gRG9i ZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisKKyAgICAgICAgTWVkaWFTdHJlYW1BdWRp b1NvdXJjZU5vZGUgc2hvdWxkIGJlIGd1YXJkZWQgYnkgdGhlIFdFQl9BVURJTyBjb25kaXRpb24g YXMgd2VsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTM4NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgV0VCX0FVRElPIHRvIHRoZSBDb25kaXRpb25hbCBhdHRyaWJ1dGUgaW4gdGhlIElETCBmaWxl IGFuZCB0aGUKKyAgICAgICAgRU5BQkxFKFdFQl9BVURJTykgZ3VhcmQgaW4gdGhlIGhlYWRlciBm aWxlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAtIG5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisg ICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9NZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZS5oOgor ICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGUuaWRs OgorCiAyMDEyLTA4LTEzICBMZWFuZHJvIEdyYWNpYSBHaWwgIDxsZWFuZHJvZ3JhY2lhQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIEZpeCBuaXRzIGluIHRoZSBmaW5kLWluLXBh Z2UgbWF0Y2ggcmVjdHMgQVBJCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlv L01lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvTW9kdWxlcy93ZWJhdWRpby9NZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZS5oCShyZXZpc2lv biAxMjU0MjYpCisrKyBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL01lZGlhU3RyZWFt QXVkaW9Tb3VyY2VOb2RlLmgJKHdvcmtpbmcgY29weSkKQEAgLTI1LDcgKzI1LDcgQEAKICNpZm5k ZWYgTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGVfaAogI2RlZmluZSBNZWRpYVN0cmVhbUF1ZGlv U291cmNlTm9kZV9oCiAKLSNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKQorI2lmIEVOQUJMRShXRUJf QVVESU8pICYmIEVOQUJMRShNRURJQV9TVFJFQU0pCiAKICNpbmNsdWRlICJBdWRpb1NvdXJjZU5v ZGUuaCIKICNpbmNsdWRlICJBdWRpb1NvdXJjZVByb3ZpZGVyLmgiCkBAIC03Miw2ICs3Miw2IEBA IHByaXZhdGU6CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAotI2VuZGlmIC8vIEVOQUJMRShN RURJQV9TVFJFQU0pCisjZW5kaWYgLy8gRU5BQkxFKFdFQl9BVURJTykgJiYgRU5BQkxFKE1FRElB X1NUUkVBTSkKIAogI2VuZGlmIC8vIE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlX2gKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5v ZGUuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vTWVk aWFTdHJlYW1BdWRpb1NvdXJjZU5vZGUuaWRsCShyZXZpc2lvbiAxMjU0MjYpCisrKyBTb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL01lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlLmlkbAko d29ya2luZyBjb3B5KQpAQCAtMjQsNyArMjQsNyBAQAogCiBtb2R1bGUgYXVkaW8gewogICAgIGlu dGVyZmFjZSBbCi0gICAgICAgIENvbmRpdGlvbmFsPU1FRElBX1NUUkVBTSwKKyAgICAgICAgQ29u ZGl0aW9uYWw9V0VCX0FVRElPJk1FRElBX1NUUkVBTSwKICAgICAgICAgSlNHZW5lcmF0ZVRvSlNP YmplY3QKICAgICBdIE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlIDogQXVkaW9Tb3VyY2VOb2Rl IHsKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIE1lZGlhU3RyZWFtIG1lZGlhU3RyZWFtOwo= 158046 2012-08-13 11:03:32 -0700 2012-08-13 13:18:13 -0700 Patch bug-93864-20120813110300.patch text/plain 3069 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTQyOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTEzICBaYW4gRG9i ZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisKKyAgICAgICAgTWVkaWEoU3RyZWFtfEVs ZW1lbnQpQXVkaW9Tb3VyY2VOb2RlIHNob3VsZCBiZSBndWFyZGVkIGJ5IHRoZSBXRUJfQVVESU8g Y29uZGl0aW9uIGFzIHdlbGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkzODY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkIHRoZSBXRUJfQVVESU8gdG8gdGhlIENvbmRpdGlvbmFsIGF0dHJpYnV0ZSBp biBNZWRpYUVsZW1lbnRBdWRpb1NvdXJjZU5vZGUKKyAgICAgICAgSURMIGZpbGUgYW5kIHRoZSBF TkFCTEUoV0VCX0FVRElPKSBjb21waWxhdGlvbiBndWFyZCB0byB0aGUgaGVhZGVyIGZpbGVzIGZv ciBib3RoCisgICAgICAgIE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlIGFuZCBNZWRpYUVsZW1l bnRBdWRpb1NvdXJjZU5vZGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC0gbm8gbmV3IGZ1bmN0 aW9uYWxpdHkuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL01lZGlhRWxlbWVudEF1ZGlv U291cmNlTm9kZS5oOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vTWVkaWFTdHJlYW1BdWRp b1NvdXJjZU5vZGUuaDoKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL01lZGlhU3RyZWFtQXVk aW9Tb3VyY2VOb2RlLmlkbDoKKwogMjAxMi0wOC0xMyAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5o YXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBQb3J0IG1ldGEgbWV0aG9kL3NpZ25h bC9zbG90IGhhbmRsaW5nIGluIHJ1bi10aW1lIGJyaWRnZSB0byB1c2UgSlNDIEMgQVBJCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL01lZGlhRWxlbWVudEF1ZGlvU291cmNl Tm9kZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vTWVk aWFFbGVtZW50QXVkaW9Tb3VyY2VOb2RlLmgJKHJldmlzaW9uIDEyNTQyOCkKKysrIFNvdXJjZS9X ZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vTWVkaWFFbGVtZW50QXVkaW9Tb3VyY2VOb2RlLmgJKHdv cmtpbmcgY29weSkKQEAgLTI1LDcgKzI1LDcgQEAKICNpZm5kZWYgTWVkaWFFbGVtZW50QXVkaW9T b3VyY2VOb2RlX2gKICNkZWZpbmUgTWVkaWFFbGVtZW50QXVkaW9Tb3VyY2VOb2RlX2gKIAotI2lm IEVOQUJMRShWSURFTykKKyNpZiBFTkFCTEUoV0VCX0FVRElPKSAmJiBFTkFCTEUoVklERU8pCiAK ICNpbmNsdWRlICJBdWRpb1NvdXJjZU5vZGUuaCIKICNpbmNsdWRlICJBdWRpb1NvdXJjZVByb3Zp ZGVyQ2xpZW50LmgiCkBAIC03NCw2ICs3NCw2IEBAIHByaXZhdGU6CiAKIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUKIAotI2VuZGlmIC8vIEVOQUJMRShWSURFTykKKyNlbmRpZiAvLyBFTkFCTEUoV0VC X0FVRElPKSAmJiBFTkFCTEUoVklERU8pCiAKICNlbmRpZiAvLyBNZWRpYUVsZW1lbnRBdWRpb1Nv dXJjZU5vZGVfaApJbmRleDogU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9NZWRpYVN0 cmVhbUF1ZGlvU291cmNlTm9kZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVs ZXMvd2ViYXVkaW8vTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGUuaAkocmV2aXNpb24gMTI1NDI4 KQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9NZWRpYVN0cmVhbUF1ZGlvU291 cmNlTm9kZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNSw3ICsyNSw3IEBACiAjaWZuZGVmIE1lZGlh U3RyZWFtQXVkaW9Tb3VyY2VOb2RlX2gKICNkZWZpbmUgTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5v ZGVfaAogCi0jaWYgRU5BQkxFKE1FRElBX1NUUkVBTSkKKyNpZiBFTkFCTEUoV0VCX0FVRElPKSAm JiBFTkFCTEUoTUVESUFfU1RSRUFNKQogCiAjaW5jbHVkZSAiQXVkaW9Tb3VyY2VOb2RlLmgiCiAj aW5jbHVkZSAiQXVkaW9Tb3VyY2VQcm92aWRlci5oIgpAQCAtNzIsNiArNzIsNiBAQCBwcml2YXRl OgogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKLSNlbmRpZiAvLyBFTkFCTEUoTUVESUFfU1RS RUFNKQorI2VuZGlmIC8vIEVOQUJMRShXRUJfQVVESU8pICYmIEVOQUJMRShNRURJQV9TVFJFQU0p CiAKICNlbmRpZiAvLyBNZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZV9oCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL01lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlLmlkbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL01lZGlhU3RyZWFt QXVkaW9Tb3VyY2VOb2RlLmlkbAkocmV2aXNpb24gMTI1NDI4KQorKysgU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJhdWRpby9NZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZS5pZGwJKHdvcmtpbmcg Y29weSkKQEAgLTI0LDcgKzI0LDcgQEAKIAogbW9kdWxlIGF1ZGlvIHsKICAgICBpbnRlcmZhY2Ug WwotICAgICAgICBDb25kaXRpb25hbD1NRURJQV9TVFJFQU0sCisgICAgICAgIENvbmRpdGlvbmFs PVdFQl9BVURJTyZNRURJQV9TVFJFQU0sCiAgICAgICAgIEpTR2VuZXJhdGVUb0pTT2JqZWN0CiAg ICAgXSBNZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZSA6IEF1ZGlvU291cmNlTm9kZSB7CiAgICAg ICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBNZWRpYVN0cmVhbSBtZWRpYVN0cmVhbTsK