9384 2006-06-10 01:04:22 -0700 WebView's initWithCoder: does not set useBackForwardList correctly 2006-06-10 06:33:41 -0700 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 Graham.Dennis webkit-unassigned oldest_to_newest 45225 0 Graham.Dennis 2006-06-10 01:04:22 -0700 When init'ing with a keyed coder, the value of useBackForwardList in WebView's _private ivar is set on line 1608, but this value is reset on line 1630 by the function's local variable useBackForwardList. Instead of setting the value of useBackForwardList in the _private ivar on line 1608, the local variable should be set, which in turn sets the value in the _private ivar. I will attach a patch in a moment. 45226 1 8793 Graham.Dennis 2006-06-10 01:08:47 -0700 Created attachment 8793 patch 45245 2 8793 sullivan 2006-06-10 06:29:08 -0700 Comment on attachment 8793 patch Good catch. I'm surprised the method even compiles, since the local variable useBackForwardList is uninitialized (but then used!) if [decoder allowsKeyedCoding] returns YES. 45246 3 sullivan 2006-06-10 06:33:41 -0700 Commited in svn revision 14804. 8793 2006-06-10 01:08:47 -0700 2006-06-10 06:29:08 -0700 patch 9384.diff text/plain 1402 Graham.Dennis SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODAx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDYtMDYt MTAgIEdyYWhhbSBEZW5uaXMgIDxHcmFoYW0uRGVubmlzQGdtYWlsLmNvbT4KKworICAgICAgICA8 aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05Mzg0PgorICAg ICAgICBXZWJWaWV3J3MgaW5pdFdpdGhDb2RlcjogbWV0aG9kIGRvZXMgbm90IHNldCB1c2VCYWNr Rm9yd2FyZExpc3QKKyAgICAgICAgY29ycmVjdGx5CisgICAgICAgIAorICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlZpZXcvV2ViVmlldy5tOgorICAg ICAgICAoLVtXZWJWaWV3IGluaXRXaXRoQ29kZXI6XSk6CisgICAgICAgIE1ha2Ugc3VyZSB0aGF0 IHRoZSBmdW5jdGlvbiB2YXJpYWJsZSB1c2VCYWNrRm9yd2FyZExpc3QgaXMgY29ycmVjdGx5Cisg ICAgICAgIHNldCwgc28gdGhhdCB0aGUgY29weSBpbiB0aGUgX3ByaXZhdGUgaXZhciBpcyBzZXQu CisKIDIwMDYtMDYtMDkgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAg IFJlbmFtZSB1cGRhdGVGb2N1c1N0YXRlIHRvIHVwZGF0ZUFjdGl2ZVN0YXRlLgpJbmRleDogV2Vi Vmlldy9XZWJWaWV3Lm0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViVmlldy9XZWJWaWV3Lm0JKHJldmlzaW9u IDE0NjE5KQorKysgV2ViVmlldy9XZWJWaWV3Lm0JKHdvcmtpbmcgY29weSkKQEAgLTE2MDUsNyAr MTYwNSw3IEBAIE5TX0RVUklORwogICAgICAgICBmcmFtZU5hbWUgPSBbZGVjb2RlciBkZWNvZGVP YmplY3RGb3JLZXk6QCJGcmFtZU5hbWUiXTsKICAgICAgICAgZ3JvdXBOYW1lID0gW2RlY29kZXIg ZGVjb2RlT2JqZWN0Rm9yS2V5OkAiR3JvdXBOYW1lIl07CiAgICAgICAgIHByZWZlcmVuY2VzID0g W2RlY29kZXIgZGVjb2RlT2JqZWN0Rm9yS2V5OkAiUHJlZmVyZW5jZXMiXTsKLQlyZXN1bHQtPl9w cml2YXRlLT51c2VCYWNrRm9yd2FyZExpc3QgPSBbZGVjb2RlciBkZWNvZGVCb29sRm9yS2V5OkAi VXNlQmFja0ZvcndhcmRMaXN0Il07CisgICAgICAgIHVzZUJhY2tGb3J3YXJkTGlzdCA9IFtkZWNv ZGVyIGRlY29kZUJvb2xGb3JLZXk6QCJVc2VCYWNrRm9yd2FyZExpc3QiXTsKICAgICB9IGVsc2Ug ewogICAgICAgICBpbnQgdmVyc2lvbjsKICAgICAgICAgW2RlY29kZXIgZGVjb2RlVmFsdWVPZk9i akNUeXBlOkBlbmNvZGUoaW50KSBhdDomdmVyc2lvbl07Cg==