<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>93837</bug_id>
          
          <creation_ts>2012-08-13 06:33:50 -0700</creation_ts>
          <short_desc>[SOUP][WK2] Missing LocalTerminationDisabler in WebCookieManager::setCookiePersistentStorage()</short_desc>
          <delta_ts>2012-08-13 09:37:04 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>gustavo</cc>
    
    <cc>kenneth</cc>
    
    <cc>mrobinson</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>693611</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-08-13 06:33:50 -0700</bug_when>
    <thetext>SOUP-specific implementation of WebCookieManager::setCookiePersistentStorage() is missing a WebCore::LocalTerminationDisabler.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>693617</commentid>
    <comment_count>1</comment_count>
      <attachid>157983</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-08-13 06:36:18 -0700</bug_when>
    <thetext>Created attachment 157983
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>693694</commentid>
    <comment_count>2</comment_count>
      <attachid>157983</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2012-08-13 08:49:49 -0700</bug_when>
    <thetext>Comment on attachment 157983
Patch

Good catch, thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>693727</commentid>
    <comment_count>3</comment_count>
      <attachid>157983</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-13 09:36:59 -0700</bug_when>
    <thetext>Comment on attachment 157983
Patch

Clearing flags on attachment: 157983

Committed r125421: &lt;http://trac.webkit.org/changeset/125421&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>693728</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-13 09:37:04 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>157983</attachid>
            <date>2012-08-13 06:36:18 -0700</date>
            <delta_ts>2012-08-13 09:36:59 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>93837_soup_persistentcookiestorage.patch</filename>
            <type>text/plain</type>
            <size>1737</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCA4YTk1YmQ5Li5jZjc5YjI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTItMDgtMTMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs
LmNvbT4KKworICAgICAgICBbU09VUF1bV0syXSBNaXNzaW5nIExvY2FsVGVybWluYXRpb25EaXNh
YmxlciBpbiBXZWJDb29raWVNYW5hZ2VyOjpzZXRDb29raWVQZXJzaXN0ZW50U3RvcmFnZSgpCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzgzNworCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBtaXNzaW5n
IFdlYkNvcmU6OkxvY2FsVGVybWluYXRpb25EaXNhYmxlciBpbgorICAgICAgICBXZWJDb29raWVN
YW5hZ2VyOjpzZXRDb29raWVQZXJzaXN0ZW50U3RvcmFnZSgpIHRvCisgICAgICAgIHRlbXBvcmFy
aWx5IGRpc2FibGUgcHJvY2VzcyB0ZXJtaW5hdGlvbi4KKworICAgICAgICAqIFdlYlByb2Nlc3Mv
Q29va2llcy9zb3VwL1dlYkNvb2tpZU1hbmFnZXJTb3VwLmNwcDoKKyAgICAgICAgKFdlYktpdDo6
V2ViQ29va2llTWFuYWdlcjo6c2V0Q29va2llUGVyc2lzdGVudFN0b3JhZ2UpOgorCiAyMDEyLTA4
LTEyICBOdW5vIExvcGVzICA8bmxvcGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggYnVpbGQg
d2l0aCByZWNlbnQgY2xhbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz
L0Nvb2tpZXMvc291cC9XZWJDb29raWVNYW5hZ2VyU291cC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9X
ZWJQcm9jZXNzL0Nvb2tpZXMvc291cC9XZWJDb29raWVNYW5hZ2VyU291cC5jcHAKaW5kZXggOWIz
ZmJhZi4uOTgyYzc3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Db29r
aWVzL3NvdXAvV2ViQ29va2llTWFuYWdlclNvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dl
YlByb2Nlc3MvQ29va2llcy9zb3VwL1dlYkNvb2tpZU1hbmFnZXJTb3VwLmNwcApAQCAtMjcsNiAr
MjcsNyBAQAogI2luY2x1ZGUgIldlYkNvb2tpZU1hbmFnZXIuaCIKIAogI2luY2x1ZGUgIldlYktp
dFNvdXBDb29raWVKYXJTcWxpdGUuaCIKKyNpbmNsdWRlICJXZWJQcm9jZXNzLmgiCiAjaW5jbHVk
ZSA8V2ViQ29yZS9Db29raWVKYXJTb3VwLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZUhh
bmRsZS5oPgogI2luY2x1ZGUgPGxpYnNvdXAvc291cC5oPgpAQCAtODMsNiArODQsOCBAQCBIVFRQ
Q29va2llQWNjZXB0UG9saWN5IFdlYkNvb2tpZU1hbmFnZXI6OnBsYXRmb3JtR2V0SFRUUENvb2tp
ZUFjY2VwdFBvbGljeSgpCiAKIHZvaWQgV2ViQ29va2llTWFuYWdlcjo6c2V0Q29va2llUGVyc2lz
dGVudFN0b3JhZ2UoY29uc3QgU3RyaW5nJiBzdG9yYWdlUGF0aCwgdWludDMyX3Qgc3RvcmFnZVR5
cGUpCiB7CisgICAgV2ViUHJvY2Vzczo6TG9jYWxUZXJtaW5hdGlvbkRpc2FibGVyIHRlcm1pbmF0
aW9uRGlzYWJsZXIoV2ViUHJvY2Vzczo6c2hhcmVkKCkpOworCiAgICAgR1JlZlB0cjxTb3VwQ29v
a2llSmFyPiBqYXI7CiAgICAgc3dpdGNoIChzdG9yYWdlVHlwZSkgewogICAgIGNhc2UgU291cENv
b2tpZVBlcnNpc3RlbnRTdG9yYWdlVGV4dDoK
</data>

          </attachment>
      

    </bug>

</bugzilla>