93836 2012-08-13 06:31:10 -0700 [V8] Remove unused methods from V8Binding.h 2012-08-13 19:26:09 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93095 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 693609 0 haraken 2012-08-13 06:31:10 -0700 enableStringImplCache() and v8UndetectableString() are not used by anybody. 693610 1 157980 haraken 2012-08-13 06:32:07 -0700 Created attachment 157980 Patch 693804 2 157980 abarth 2012-08-13 10:40:52 -0700 Comment on attachment 157980 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157980&action=review > Source/WebCore/bindings/v8/V8Binding.h:-398 > - inline v8::Handle<v8::String> v8UndetectableString(const String& str) > - { > - return v8::String::NewUndetectable(fromWebCoreString(str), str.length()); > - } I'm surprised this isn't used by document.all. Maybe that uses another mechanism now? 694373 3 haraken 2012-08-13 18:35:13 -0700 Committed r125492: <http://trac.webkit.org/changeset/125492> 694375 4 157980 haraken 2012-08-13 18:35:51 -0700 Comment on attachment 157980 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157980&action=review >> Source/WebCore/bindings/v8/V8Binding.h:-398 >> - } > > I'm surprised this isn't used by document.all. Maybe that uses another mechanism now? It's realized by forcibly setting properties on 'this' object. (i.e. info.This()->ForceSet(name, value)) http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp&exact_package=chromium&q=v8htmldocumentcustom.cpp&type=cs&l=184 157980 2012-08-13 06:32:07 -0700 2012-08-13 19:26:09 -0700 Patch bug-93836-20120813223135.patch text/plain 2131 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWMzZjExMGM1YTc4Mzcx MmQ4NjQ4NTI2ODg2ZGNmMjc5ZTM5M2MyNy4uYTAwMGMzOGEzYTU2MmJiYWQ0NDAwNTdiNjkxYmRi ODQ4MzcxZTg2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTEzICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbW92ZSB1 bnVzZWQgbWV0aG9kcyBmcm9tIFY4QmluZGluZy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzgzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGVuYWJsZVN0cmluZ0ltcGxDYWNoZSgpIGFuZCB2OFVuZGV0 ZWN0YWJsZVN0cmluZygpIGFyZSBub3QgdXNlZCBieSBhbnlib2R5LgorCisgICAgICAgIE5vIHRl c3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEJp bmRpbmcuaDoKKwogMjAxMi0wOC0xMiAgUHJhdmluIEQgIDxwcmF2aW5kLjJrNEBnbWFpbC5jb20+ CiAKICAgICAgICAgdGFibGUgY2VsbC5jZWxsSW5kZXggc2hvdWxkIHJldHVybiAtMSBpZiB0aGVy ZSBpcyBubyBwYXJlbnQgdGFibGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4QmluZGluZy5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgK aW5kZXggY2EzYWZiNjQ5YjY2NmRlMmE0ZWRiMTM5OTE1OTU2Njk0MTkxNDllYy4uYWRmMzlkM2Zh Mzc1YWRiOWE3MmJmMTJmNzFmZGY1OTkxMzg2N2MxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhCaW5kaW5nLmgKQEAgLTI4NywxMSArMjg3LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog ICAgICAgICByZXR1cm4gdjhWYWx1ZTsKICAgICB9CiAKLSAgICAvLyBFbmFibGVzIGNhY2hpbmcg djggd3JhcHBlcnMgY3JlYXRlZCBmb3IgV1RGOjpTdHJpbmdJbXBsLiAgQ3VycmVudGx5IHRoaXMg Y2FjaGUgcmVxdWlyZXMKLSAgICAvLyBhbGwgdGhlIGNhbGxzIChib3RoIHRvIGNvbnZlcnQgV1RG OjpTdHJpbmcgdG8gdjg6OlN0cmluZyBhbmQgdG8gR0MgdGhlIGhhbmRsZSkKLSAgICAvLyB0byBi ZSBwZXJmb3JtZWQgb24gdGhlIG1haW4gdGhyZWFkLgotICAgIHZvaWQgZW5hYmxlU3RyaW5nSW1w bENhY2hlKCk7Ci0KICAgICAvLyBDb252ZXJ0IGEgdmFsdWUgdG8gYSAzMi1iaXQgaW50ZWdlci4g IFRoZSBjb252ZXJzaW9uIGZhaWxzIGlmIHRoZQogICAgIC8vIHZhbHVlIGNhbm5vdCBiZSBjb252 ZXJ0ZWQgdG8gYW4gaW50ZWdlciBvciBjb252ZXJ0cyB0byBuYW4gb3IgdG8gYW4gaW5maW5pdHku CiAgICAgaW50IHRvSW50MzIodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHZhbHVlLCBib29sJiBvayk7 CkBAIC0zOTIsMTEgKzM4Nyw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgcmV0dXJu ICh2YWx1ZS0+SXNOdWxsKCkgfHwgdmFsdWUtPklzVW5kZWZpbmVkKCkpID8gU3RyaW5nKCkgOiB0 b1dlYkNvcmVTdHJpbmcodmFsdWUpOwogICAgIH0KIAotICAgIGlubGluZSB2ODo6SGFuZGxlPHY4 OjpTdHJpbmc+IHY4VW5kZXRlY3RhYmxlU3RyaW5nKGNvbnN0IFN0cmluZyYgc3RyKQotICAgIHsK LSAgICAgICAgcmV0dXJuIHY4OjpTdHJpbmc6Ok5ld1VuZGV0ZWN0YWJsZShmcm9tV2ViQ29yZVN0 cmluZyhzdHIpLCBzdHIubGVuZ3RoKCkpOwotICAgIH0KLQogICAgIGlubGluZSB2ODo6SGFuZGxl PHY4OjpWYWx1ZT4gdjhTdHJpbmdPck51bGwoY29uc3QgU3RyaW5nJiBzdHIsIHY4OjpJc29sYXRl KiBpc29sYXRlID0gMCkKICAgICB7CiAgICAgICAgIHJldHVybiBzdHIuaXNOdWxsKCkgPyB2ODo6 SGFuZGxlPHY4OjpWYWx1ZT4odjg6Ok51bGwoKSkgOiB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4odjhT dHJpbmcoc3RyLCBpc29sYXRlKSk7Cg==