93834 2012-08-13 05:56:29 -0700 [V8] Move hintForGCIfNecessary() from V8Proxy.h to V8GCController.h 2012-08-13 19:25:42 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85330 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 693584 0 haraken 2012-08-13 05:56:29 -0700 We can move hintForGCIfNecessary() from V8Proxy.h to V8GCController.h. 693586 1 157975 haraken 2012-08-13 05:57:46 -0700 Created attachment 157975 Patch 693801 2 157975 abarth 2012-08-13 10:39:15 -0700 Comment on attachment 157975 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157975&action=review > Source/WebCore/bindings/v8/V8GCController.cpp:525 > + if (data->shouldCollectGarbageSoon()) { Prefer early return. > Source/WebCore/bindings/v8/V8GCController.cpp:526 > + const int longIdlePauseInMs = 1000; longIdlePauseInMs -> longIdlePauseInMS > Source/WebCore/bindings/v8/V8GCController.h:79 > + static void hintForGCIfNecessary(); Can we think of a better name for this function? Perhaps collectGarbageIfNecessary? 694369 3 haraken 2012-08-13 18:32:20 -0700 (In reply to comment #2) > > Source/WebCore/bindings/v8/V8GCController.cpp:525 > > + if (data->shouldCollectGarbageSoon()) { > > Prefer early return. > > > Source/WebCore/bindings/v8/V8GCController.cpp:526 > > + const int longIdlePauseInMs = 1000; > > longIdlePauseInMs -> longIdlePauseInMS > > > Source/WebCore/bindings/v8/V8GCController.h:79 > > + static void hintForGCIfNecessary(); > > Can we think of a better name for this function? Perhaps collectGarbageIfNecessary? Done. 694370 4 haraken 2012-08-13 18:32:29 -0700 Committed r125491: <http://trac.webkit.org/changeset/125491> 157975 2012-08-13 05:57:46 -0700 2012-08-13 19:25:42 -0700 Patch bug-93834-20120813215714.patch text/plain 4017 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWMzZjExMGM1YTc4Mzcx MmQ4NjQ4NTI2ODg2ZGNmMjc5ZTM5M2MyNy4uYjlmMDZkMWZhZThhMWYwZWFkZGEyNzUzOTA2MTQy YzM1ODQ1MzQxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTEzICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1vdmUgaGlu dEZvckdDSWZOZWNlc3NhcnkoKSBmcm9tIFY4UHJveHkuaCB0byBWOEdDQ29udHJvbGxlci5oCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzgzNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2gg bW92ZXMgaGludEZvckdDSWZOZWNlc3NhcnkoKSBmcm9tIFY4UHJveHkuaCB0byBWOEdDQ29udHJv bGxlci5oLgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAg ICAgICAgKiBiaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpWOEdDQ29udHJvbGxlcjo6aGludEZvckdDSWZOZWNlc3NhcnkpOgorICAgICAgICAqIGJpbmRp bmdzL3Y4L1Y4R0NDb250cm9sbGVyLmg6CisgICAgICAgIChWOEdDQ29udHJvbGxlcik6CisgICAg ICAgICogYmluZGluZ3MvdjgvVjhQcm94eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOFByb3h5 OjpjbGVhckZvckNsb3NlKToKKyAgICAgICAgKFdlYkNvcmU6OlY4UHJveHk6OmNsZWFyRm9yTmF2 aWdhdGlvbik6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhQcm94eS5oOgorICAgICAgICAoVjhQ cm94eSk6CisKIDIwMTItMDgtMTIgIFByYXZpbiBEICA8cHJhdmluZC4yazRAZ21haWwuY29tPgog CiAgICAgICAgIHRhYmxlIGNlbGwuY2VsbEluZGV4IHNob3VsZCByZXR1cm4gLTEgaWYgdGhlcmUg aXMgbm8gcGFyZW50IHRhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOEdDQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29u dHJvbGxlci5jcHAKaW5kZXggNGMzZDU3NDI4ZGYxYTA3MjQxOTM0YmI5MGEzZmM3MDM4NDdhYWQy YS4uYTc2MGIzZjZmYmQ3ZTNkMzQyNTZmY2RlMzUxYTE3MDE4NjdlYmE2YyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcApAQCAtNTE5LDUgKzUxOSwx NSBAQCB2b2lkIFY4R0NDb250cm9sbGVyOjpjaGVja01lbW9yeVVzYWdlKCkKICNlbmRpZgogfQog Cit2b2lkIFY4R0NDb250cm9sbGVyOjpoaW50Rm9yR0NJZk5lY2Vzc2FyeSgpCit7CisgICAgVjhQ ZXJJc29sYXRlRGF0YSogZGF0YSA9IFY4UGVySXNvbGF0ZURhdGE6OmN1cnJlbnQoKTsKKyAgICBp ZiAoZGF0YS0+c2hvdWxkQ29sbGVjdEdhcmJhZ2VTb29uKCkpIHsKKyAgICAgICAgY29uc3QgaW50 IGxvbmdJZGxlUGF1c2VJbk1zID0gMTAwMDsKKyAgICAgICAgZGF0YS0+Y2xlYXJTaG91bGRDb2xs ZWN0R2FyYmFnZVNvb24oKTsKKyAgICAgICAgdjg6OlY4OjpDb250ZXh0RGlzcG9zZWROb3RpZmlj YXRpb24oKTsKKyAgICAgICAgdjg6OlY4OjpJZGxlTm90aWZpY2F0aW9uKGxvbmdJZGxlUGF1c2VJ bk1zKTsKKyAgICB9Cit9CiAKIH0gIC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5oIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuaAppbmRleCA5NDY2Yzk4YmI1NmFhMWE5ODYy MTk2ZGFiNjgxODdmNmI5OGY5ZTUwLi5mNzc0OWZkOGE2MzhkZTMxNTA4ZDIyZDc5ZDQyNGRmZmUw OTJkZmZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJv bGxlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmgK QEAgLTc2LDYgKzc2LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBzdGF0aWMgdm9p ZCBnY0VwaWxvZ3VlKCk7CiAKICAgICAgICAgc3RhdGljIHZvaWQgY2hlY2tNZW1vcnlVc2FnZSgp OworICAgICAgICBzdGF0aWMgdm9pZCBoaW50Rm9yR0NJZk5lY2Vzc2FyeSgpOwogCiAgICAgcHJp dmF0ZToKICAgICAgICAgLy8gRXN0aW1hdGUgb2YgY3VycmVudCB3b3JraW5nIHNldC4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAKaW5kZXggNjgzMjkyODEyZTVkYmNmZWI1YmZk ZWFlM2IzNmNlZTA1YTI5NWNiNi4uMjRhZDk1ZjA3ZjM5NzQxYjcwYWU5ZDIxYmRiNmU1NDdmZjEz YzgwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAKQEAgLTQ0NiwyOCAr NDQ2LDE3IEBAIHZvaWQgVjhQcm94eTo6cmVzZXRJc29sYXRlZFdvcmxkcygpCiAgICAgbV9pc29s YXRlZFdvcmxkU2VjdXJpdHlPcmlnaW5zLmNsZWFyKCk7CiB9CiAKLXZvaWQgVjhQcm94eTo6aGlu dEZvckdDSWZOZWNlc3NhcnkoKQotewotICAgIFY4UGVySXNvbGF0ZURhdGEqIGRhdGEgPSBWOFBl cklzb2xhdGVEYXRhOjpjdXJyZW50KCk7Ci0gICAgaWYgKGRhdGEtPnNob3VsZENvbGxlY3RHYXJi YWdlU29vbigpKSB7Ci0gICAgICAgIGNvbnN0IGludCBsb25nSWRsZVBhdXNlSW5NcyA9IDEwMDA7 Ci0gICAgICAgIGRhdGEtPmNsZWFyU2hvdWxkQ29sbGVjdEdhcmJhZ2VTb29uKCk7Ci0gICAgICAg IHY4OjpWODo6Q29udGV4dERpc3Bvc2VkTm90aWZpY2F0aW9uKCk7Ci0gICAgICAgIHY4OjpWODo6 SWRsZU5vdGlmaWNhdGlvbihsb25nSWRsZVBhdXNlSW5Ncyk7Ci0gICAgfQotfQotCiB2b2lkIFY4 UHJveHk6OmNsZWFyRm9yQ2xvc2UoKQogewogICAgIHJlc2V0SXNvbGF0ZWRXb3JsZHMoKTsKLSAg ICBoaW50Rm9yR0NJZk5lY2Vzc2FyeSgpOworICAgIFY4R0NDb250cm9sbGVyOjpoaW50Rm9yR0NJ Zk5lY2Vzc2FyeSgpOwogICAgIHdpbmRvd1NoZWxsKCktPmNsZWFyRm9yQ2xvc2UoKTsKIH0KIAog dm9pZCBWOFByb3h5OjpjbGVhckZvck5hdmlnYXRpb24oKQogewogICAgIHJlc2V0SXNvbGF0ZWRX b3JsZHMoKTsKLSAgICBoaW50Rm9yR0NJZk5lY2Vzc2FyeSgpOworICAgIFY4R0NDb250cm9sbGVy OjpoaW50Rm9yR0NJZk5lY2Vzc2FyeSgpOwogICAgIHdpbmRvd1NoZWxsKCktPmNsZWFyRm9yTmF2 aWdhdGlvbigpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OFByb3h5LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmgKaW5kZXggZDJl NmRlZDMxOWNiMjU1ODRmMmM1N2NhMWJkZjY3NGNiMTE3MmQ3NC4uMWY2OTQ4Yzk5ODA1MTYwNjY4 NmY3YjJmMjVmZWRkY2ViY2UzY2NlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHku aApAQCAtMTg4LDggKzE4OCw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICBwcml2YXRlOgog ICAgICAgICB2b2lkIHJlc2V0SXNvbGF0ZWRXb3JsZHMoKTsKIAotICAgICAgICB2b2lkIGhpbnRG b3JHQ0lmTmVjZXNzYXJ5KCk7Ci0KICAgICAgICAgUGFzc093blB0cjx2ODo6U2NyaXB0RGF0YT4g cHJlY29tcGlsZVNjcmlwdCh2ODo6SGFuZGxlPHY4OjpTdHJpbmc+LCBDYWNoZWRTY3JpcHQqKTsK IAogICAgICAgICBGcmFtZSogbV9mcmFtZTsK