93828 2012-08-13 05:29:05 -0700 [EFL][WK2][Minibrowser] Support html link of blank target attribute. 2012-10-12 00:39:21 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED DUPLICATE 98667 P2 Normal --- 1 kangil.han jinwoo7.song cdumez d-r jinwoo7.song lucas.de.marchi rakuco ryuan.choi tmpsantos webkit.review.bot oldest_to_newest 693564 0 kangil.han 2012-08-13 05:29:05 -0700 Supporting html link of blank target attribute would be needed for verifying basic webkit behavior in minibrowser. 693567 1 157972 kangil.han 2012-08-13 05:32:20 -0700 Created attachment 157972 patch 693568 2 webkit.review.bot 2012-08-13 05:35:20 -0700 Attachment 157972 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/efl/..." exit_code: 1 Tools/MiniBrowser/efl/main.c:184: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Tools/MiniBrowser/efl/main.c:184: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Tools/MiniBrowser/efl/main.c:195: Missing space after , [whitespace/comma] [3] Tools/MiniBrowser/efl/main.c:209: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 693612 3 157981 kangil.han 2012-08-13 06:34:09 -0700 Created attachment 157981 patch 693682 4 kangil.han 2012-08-13 08:38:56 -0700 formal/informal review please! 694327 5 157981 rakuco 2012-08-13 18:06:31 -0700 Comment on attachment 157981 patch Erm, needing to fork() just launch a new window does not smell very well. I haven't been watching the development of the WK2 port very closely, though. Are you sure there isn't a saner way to do this? 694335 6 kangil.han 2012-08-13 18:13:31 -0700 (In reply to comment #5) > (From update of attachment 157981 [details]) > Erm, needing to fork() just launch a new window does not smell very well. I haven't been watching the development of the WK2 port very closely, though. Are you sure there isn't a saner way to do this? Sorry, I don't have an idea at a moment. :-( I will ask more formal/informal reviews. ;-) 694346 7 kangil.han 2012-08-13 18:19:20 -0700 ryuan: informal review please? 694350 8 157981 ryuan.choi 2012-08-13 18:24:19 -0700 Comment on attachment 157981 patch View in context: https://bugs.webkit.org/attachment.cgi?id=157981&action=review > Tools/MiniBrowser/efl/main.c:203 > + pid = fork(); > + if (!pid) // child process > + execl(cmd, cmd, url, (char *)NULL); > + else if (pid < 0) // failed to fork > + fprintf(stderr, "Failed to fork\n"); You don't need to fork process. Instead, create new evas and ewk_view. > Tools/MiniBrowser/efl/main.c:253 > + evas_object_smart_callback_add(app->browser, "policy,decision,new,window", on_new_window, app); If I am right, policy,decision,new,window is for creating window. You can call create,window 694355 9 ryuan.choi 2012-08-13 18:25:35 -0700 (In reply to comment #8) > (From update of attachment 157981 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157981&action=review > > > Tools/MiniBrowser/efl/main.c:203 > > + pid = fork(); > > + if (!pid) // child process > > + execl(cmd, cmd, url, (char *)NULL); > > + else if (pid < 0) // failed to fork > > + fprintf(stderr, "Failed to fork\n"); > > You don't need to fork process. > Instead, create new evas and ewk_view. > > > Tools/MiniBrowser/efl/main.c:253 > > + evas_object_smart_callback_add(app->browser, "policy,decision,new,window", on_new_window, app); > > If I am right, policy,decision,new,window is for creating window. "is not for" > > You can call create,window 733813 10 jinwoo7.song 2012-10-03 10:15:52 -0700 Kangil, can I take over this bug? 734389 11 kangil.han 2012-10-03 23:11:53 -0700 (In reply to comment #10) > Kangil, can I take over this bug? Sure! 740471 12 jinwoo7.song 2012-10-11 17:42:31 -0700 This bug is no more valid as the following patch addressed this issue. http://trac.webkit.org/changeset/130660 *** This bug has been marked as a duplicate of bug 98667 *** 157972 2012-08-13 05:32:20 -0700 2012-08-13 06:34:09 -0700 patch minibrowser_patch.txt text/plain 2583 kangil.han ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkMjNl OTJiLi5lZDhhZjc3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDgtMTMgIEthbmdpbCBIYW4gIDxrYW5naWwu aGFuQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl1bTWluaWJyb3dzZXJdIFN1cHBv cnQgaHRtbCBsaW5rIG9mIGJsYW5rIHRhcmdldCBhdHRyaWJ1dGUuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzgyOAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN1cHBvcnRpbmcgaHRtbCBsaW5rIG9mIGJs YW5rIHRhcmdldCBhdHRyaWJ1dGUgd291bGQgYmUgbmVlZGVkIGZvciB2ZXJpZnlpbmcgYmFzaWMg d2Via2l0IGJlaGF2aW9yIGluIG1pbmlicm93c2VyLgorCisgICAgICAgICogTWluaUJyb3dzZXIv ZWZsL21haW4uYzoKKyAgICAgICAgKGdldF9jdXJyZW50X3BhdGgpOgorICAgICAgICAob25fbmV3 X3dpbmRvdyk6CisgICAgICAgIChicm93c2VyQ3JlYXRlKToKKwogMjAxMi0wOC0wOSAgWGlhbnpo dSBXYW5nICA8d2FuZ3hpYW56aHVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bS1B bmRyb2lkXSBTa2lwIGxheW91dCB0ZXN0cyBkaXJlY3RvcmllcyB0aGF0IGFyZSBub3QgYXBwbGlj YWJsZQpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYyBiL1Rvb2xzL01p bmlCcm93c2VyL2VmbC9tYWluLmMKaW5kZXggMDI2MzBmMS4uYzQ0NDE3NiAxMDA2NDQKLS0tIGEv VG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwv bWFpbi5jCkBAIC0xNzcsNiArMTc3LDQxIEBAIG9uX2Vycm9yKHZvaWQgKnVzZXJfZGF0YSwgRXZh c19PYmplY3QgKndlYnZpZXcsIHZvaWQgKmV2ZW50X2luZm8pCiAgICAgZWluYV9zdHJidWZfZnJl ZShidWZmZXIpOwogfQogCitzdGF0aWMgY2hhciAqCitnZXRfY3VycmVudF9wYXRoKHZvaWQpCit7 CisgICAgY2hhciBjd2RbMTAyNF07CisgICAgaWYgKGdldGN3ZChjd2QsIHNpemVvZihjd2QpKSAh PSBOVUxMKQorICAgICAgICByZXR1cm4gY3dkOworICAgIGVsc2UKKyAgICAgICAgcmV0dXJuIE5V TEw7Cit9CisKK3N0YXRpYyB2b2lkCitvbl9uZXdfd2luZG93KHZvaWQgKnVzZXJfZGF0YSwgRXZh c19PYmplY3QgKndlYnZpZXcsIHZvaWQgKmV2ZW50X2luZm8pCit7CisgICAgaW50IGFyZ2M7Cisg ICAgY2hhciAqKmFyZ3Y7CisgICAgY2hhciBjbWRbMTAyNF0gPSB7MCx9OworICAgIGNoYXIgKmN3 ZDsKKyAgICBwaWRfdCBwaWQ7CisKKyAgICBjb25zdCBFd2tfTmF2aWdhdGlvbl9Qb2xpY3lfRGVj aXNpb24gKmRlY2lzaW9uID0gKEV3a19OYXZpZ2F0aW9uX1BvbGljeV9EZWNpc2lvbiAqKWV2ZW50 X2luZm87CisgICAgY29uc3QgRXdrX1VybF9SZXF1ZXN0ICpyZXF1ZXN0ID0gZXdrX25hdmlnYXRp b25fcG9saWN5X3JlcXVlc3RfZ2V0KGRlY2lzaW9uKTsKKyAgICBjb25zdCBjaGFyICp1cmwgPSBl d2tfdXJsX3JlcXVlc3RfdXJsX2dldChyZXF1ZXN0KTsKKyAgICBlY29yZV9hcHBfYXJnc19nZXQo JmFyZ2MsICZhcmd2KTsKKyAgICBjd2Q9IGdldF9jdXJyZW50X3BhdGgoKTsKKyAgICBpZiAoIWN3 ZCkKKyAgICAgICAgcmV0dXJuOworCisgICAgc25wcmludGYoY21kLCBzaXplb2YoY21kKSwgIiVz LyVzIiwgY3dkLCBhcmd2WzBdKTsKKyAgICBwaWQgPSBmb3JrKCk7CisgICAgaWYgKHBpZCA9PSAw KSAvLyBjaGlsZCBwcm9jZXNzCisgICAgICAgIGV4ZWNsKGNtZCwgY21kLCB1cmwsIChjaGFyICop TlVMTCk7CisgICAgZWxzZSBpZiAocGlkIDwgMCkgLy8gZmFpbGVkIHRvIGZvcmsKKyAgICAgICAg ZnByaW50ZihzdGRlcnIsICJGYWlsZWQgdG8gZm9ya1xuIik7Cit9CisKIHN0YXRpYyBpbnQKIHF1 aXQoRWluYV9Cb29sIHN1Y2Nlc3MsIGNvbnN0IGNoYXIgKm1zZykKIHsKQEAgLTIyNCw2ICsyNTks NyBAQCBzdGF0aWMgTWluaUJyb3dzZXIgKmJyb3dzZXJDcmVhdGUoY29uc3QgY2hhciAqdXJsLCBj b25zdCBjaGFyICplbmdpbmUpCiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGFw cC0+YnJvd3NlciwgImxvYWQsZXJyb3IiLCBvbl9lcnJvciwgYXBwKTsKICAgICBldmFzX29iamVj dF9zbWFydF9jYWxsYmFja19hZGQoYXBwLT5icm93c2VyLCAibG9hZCxwcm9ncmVzcyIsIG9uX3By b2dyZXNzLCBhcHApOwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHAtPmJy b3dzZXIsICJ0aXRsZSxjaGFuZ2VkIiwgb25fdGl0bGVfY2hhbmdlZCwgYXBwKTsKKyAgICBldmFz X29iamVjdF9zbWFydF9jYWxsYmFja19hZGQoYXBwLT5icm93c2VyLCAicG9saWN5LGRlY2lzaW9u LG5ldyx3aW5kb3ciLCBvbl9uZXdfd2luZG93LCBhcHApOwogCiAgICAgZXZhc19vYmplY3RfZXZl bnRfY2FsbGJhY2tfYWRkKGFwcC0+YnJvd3NlciwgRVZBU19DQUxMQkFDS19LRVlfRE9XTiwgb25f a2V5X2Rvd24sIGFwcCk7CiAK 157981 2012-08-13 06:34:09 -0700 2012-10-12 00:39:21 -0700 patch minibrowser_patch.txt text/plain 2640 kangil.han ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkMjNl OTJiLi5lZDhhZjc3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDgtMTMgIEthbmdpbCBIYW4gIDxrYW5naWwu aGFuQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl1bTWluaWJyb3dzZXJdIFN1cHBv cnQgaHRtbCBsaW5rIG9mIGJsYW5rIHRhcmdldCBhdHRyaWJ1dGUuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzgyOAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN1cHBvcnRpbmcgaHRtbCBsaW5rIG9mIGJs YW5rIHRhcmdldCBhdHRyaWJ1dGUgd291bGQgYmUgbmVlZGVkIGZvciB2ZXJpZnlpbmcgYmFzaWMg d2Via2l0IGJlaGF2aW9yIGluIG1pbmlicm93c2VyLgorCisgICAgICAgICogTWluaUJyb3dzZXIv ZWZsL21haW4uYzoKKyAgICAgICAgKGdldF9jdXJyZW50X3BhdGgpOgorICAgICAgICAob25fbmV3 X3dpbmRvdyk6CisgICAgICAgIChicm93c2VyQ3JlYXRlKToKKwogMjAxMi0wOC0wOSAgWGlhbnpo dSBXYW5nICA8d2FuZ3hpYW56aHVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bS1B bmRyb2lkXSBTa2lwIGxheW91dCB0ZXN0cyBkaXJlY3RvcmllcyB0aGF0IGFyZSBub3QgYXBwbGlj YWJsZQpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYyBiL1Rvb2xzL01p bmlCcm93c2VyL2VmbC9tYWluLmMKaW5kZXggMDI2MzBmMS4uMjA3ZmVlMCAxMDA2NDQKLS0tIGEv VG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwv bWFpbi5jCkBAIC0yMyw2ICsyMyw4IEBACiAjaW5jbHVkZSA8RWluYS5oPgogI2luY2x1ZGUgPEV2 YXMuaD4KIAorI2luY2x1ZGUgPHVuaXN0ZC5oPgorCiBzdGF0aWMgY29uc3QgaW50IERFRkFVTFRf V0lEVEggPSA4MDA7CiBzdGF0aWMgY29uc3QgaW50IERFRkFVTFRfSEVJR0hUID0gNjAwOwogc3Rh dGljIGNvbnN0IGNoYXIgREVGQVVMVF9VUkxbXSA9ICJodHRwOi8vd3d3Lmdvb2dsZS5jb20vIjsK QEAgLTE3Nyw2ICsxNzksMzAgQEAgb25fZXJyb3Iodm9pZCAqdXNlcl9kYXRhLCBFdmFzX09iamVj dCAqd2Vidmlldywgdm9pZCAqZXZlbnRfaW5mbykKICAgICBlaW5hX3N0cmJ1Zl9mcmVlKGJ1ZmZl cik7CiB9CiAKK3N0YXRpYyB2b2lkCitvbl9uZXdfd2luZG93KHZvaWQgKnVzZXJfZGF0YSwgRXZh c19PYmplY3QgKndlYnZpZXcsIHZvaWQgKmV2ZW50X2luZm8pCit7CisgICAgaW50IGFyZ2M7Cisg ICAgY2hhciAqKmFyZ3Y7CisgICAgY2hhciBjbWRbMTAyNF0gPSB7MCwgfTsKKyAgICBjaGFyIGN3 ZFs1MTJdID0gezAsIH07CisgICAgcGlkX3QgcGlkOworCisgICAgY29uc3QgRXdrX05hdmlnYXRp b25fUG9saWN5X0RlY2lzaW9uICpkZWNpc2lvbiA9IChFd2tfTmF2aWdhdGlvbl9Qb2xpY3lfRGVj aXNpb24gKilldmVudF9pbmZvOworICAgIGNvbnN0IEV3a19VcmxfUmVxdWVzdCAqcmVxdWVzdCA9 IGV3a19uYXZpZ2F0aW9uX3BvbGljeV9yZXF1ZXN0X2dldChkZWNpc2lvbik7CisgICAgY29uc3Qg Y2hhciAqdXJsID0gZXdrX3VybF9yZXF1ZXN0X3VybF9nZXQocmVxdWVzdCk7CisgICAgZWNvcmVf YXBwX2FyZ3NfZ2V0KCZhcmdjLCAmYXJndik7CisgICAgaWYgKCFnZXRjd2QoY3dkLCBzaXplb2Yo Y3dkKSkpCisgICAgICAgIHJldHVybjsKKworICAgIHNucHJpbnRmKGNtZCwgc2l6ZW9mKGNtZCks ICIlcy8lcyIsIGN3ZCwgYXJndlswXSk7CisgICAgcGlkID0gZm9yaygpOworICAgIGlmICghcGlk KSAvLyBjaGlsZCBwcm9jZXNzCisgICAgICAgIGV4ZWNsKGNtZCwgY21kLCB1cmwsIChjaGFyICop TlVMTCk7CisgICAgZWxzZSBpZiAocGlkIDwgMCkgLy8gZmFpbGVkIHRvIGZvcmsKKyAgICAgICAg ZnByaW50ZihzdGRlcnIsICJGYWlsZWQgdG8gZm9ya1xuIik7Cit9CisKIHN0YXRpYyBpbnQKIHF1 aXQoRWluYV9Cb29sIHN1Y2Nlc3MsIGNvbnN0IGNoYXIgKm1zZykKIHsKQEAgLTIyNCw2ICsyNTAs NyBAQCBzdGF0aWMgTWluaUJyb3dzZXIgKmJyb3dzZXJDcmVhdGUoY29uc3QgY2hhciAqdXJsLCBj b25zdCBjaGFyICplbmdpbmUpCiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGFw cC0+YnJvd3NlciwgImxvYWQsZXJyb3IiLCBvbl9lcnJvciwgYXBwKTsKICAgICBldmFzX29iamVj dF9zbWFydF9jYWxsYmFja19hZGQoYXBwLT5icm93c2VyLCAibG9hZCxwcm9ncmVzcyIsIG9uX3By b2dyZXNzLCBhcHApOwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHAtPmJy b3dzZXIsICJ0aXRsZSxjaGFuZ2VkIiwgb25fdGl0bGVfY2hhbmdlZCwgYXBwKTsKKyAgICBldmFz X29iamVjdF9zbWFydF9jYWxsYmFja19hZGQoYXBwLT5icm93c2VyLCAicG9saWN5LGRlY2lzaW9u LG5ldyx3aW5kb3ciLCBvbl9uZXdfd2luZG93LCBhcHApOwogCiAgICAgZXZhc19vYmplY3RfZXZl bnRfY2FsbGJhY2tfYWRkKGFwcC0+YnJvd3NlciwgRVZBU19DQUxMQkFDS19LRVlfRE9XTiwgb25f a2V5X2Rvd24sIGFwcCk7CiAK