93817 2012-08-13 03:59:02 -0700 [Chromium] Fix nits in the find-in-page match rects API 2012-08-13 10:43:14 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93111 1 leandrogracia leandrogracia abarth webkit.review.bot oldest_to_newest 693514 0 leandrogracia 2012-08-13 03:59:02 -0700 This patch is a follow-up of 93111 in order to fix a few pending nits. 693522 1 157956 leandrogracia 2012-08-13 04:07:18 -0700 Created attachment 157956 Patch 693794 2 abarth 2012-08-13 10:29:09 -0700 Thanks! 693806 3 157956 webkit.review.bot 2012-08-13 10:43:11 -0700 Comment on attachment 157956 Patch Clearing flags on attachment: 157956 Committed r125427: <http://trac.webkit.org/changeset/125427> 693807 4 webkit.review.bot 2012-08-13 10:43:14 -0700 All reviewed patches have been landed. Closing bug. 157956 2012-08-13 04:07:18 -0700 2012-08-13 10:43:11 -0700 Patch bug-93817-20120813120646.patch text/plain 5116 leandrogracia U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NDA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWVhMTBkY2I4OWMxNTg5 NTBkYTQwOTA0ZDE0NTgwYWE1NThkMGVhYy4uZDZkMDBhZWIzZDBjMDg1Y2ZiNGY3YjU2NjViMDNi ZTg2YTdlYzQ0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTEzICBMZWFu ZHJvIEdyYWNpYSBHaWwgIDxsZWFuZHJvZ3JhY2lhQGNocm9taXVtLm9yZz4KKworICAgICAgICBb Q2hyb21pdW1dIEZpeCBuaXRzIGluIHRoZSBmaW5kLWluLXBhZ2UgbWF0Y2ggcmVjdHMgQVBJCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzgxNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2gg Zml4ZXMgYSBmZXcgcGVuZGluZyBuaXRzIGZyb20gOTMxMTEuCisKKyAgICAgICAgVGVzdHM6IGV4 aXN0aW5nIFdlYktpdCB1bml0IHRlc3QgV2ViRnJhbWVUZXN0LkZpbmRJblBhZ2VNYXRjaFJlY3Rz CisKKyAgICAgICAgKiBkb20vUmFuZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmFuZ2U6OnRy YW5zZm9ybUZyaWVuZGx5Qm91bmRpbmdCb3gpOiBhZGQgY2FsbCB0byB1cGRhdGVMYXlvdXRJZ25v cmVQZW5kaW5nU3R5bGVzaGVldHMuCisKIDIwMTItMDgtMTMgIE1hcmlvIFNhbmNoZXogUHJhZGEg IDxtc2FuY2hlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEltcGxlbWVudGF0aW9uIG9m IGF0a19lZGl0YWJsZV90ZXh0X2luc2VydF90ZXh0IGlnbm9yZXMgJ2xlbmd0aCcgcGFyYW1ldGVy CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDA1YTBhMzdiM2Q3ZDZkNjA0MGU5ZjZhN2Q4 NGE5ZDYyZWMzZjEzMjMuLjFiMDFlMGU5OTQ0ZWM3OTljYjk0MWVlZGIzMzk1OGY3ZDdmZjlmNGMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDgtMTMg IExlYW5kcm8gR3JhY2lhIEdpbCAgPGxlYW5kcm9ncmFjaWFAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFtDaHJvbWl1bV0gRml4IG5pdHMgaW4gdGhlIGZpbmQtaW4tcGFnZSBtYXRjaCByZWN0cyBB UEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzODE3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBw YXRjaCBmaXhlcyBhIGZldyBwZW5kaW5nIG5pdHMgZnJvbSA5MzExMS4KKworICAgICAgICAqIHNy Yy9GaW5kSW5QYWdlQ29vcmRpbmF0ZXMuY3BwOiByZXBsYWNlIGEgcG9pbnRlciBieSBhIHJlZmVy ZW5jZSBpbiBhbiBvdXRwdXQgYXJndW1lbnQuCisgICAgICAgIChXZWJLaXQ6OnRvTm9ybWFsaXpl ZFJlY3QpOgorICAgICAgICAoV2ViS2l0OjpmaW5kSW5QYWdlUmVjdEZyb21BYnNvbHV0ZVJlY3Qp OgorCiAyMDEyLTA4LTEzICBQZXRlciBCZXZlcmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkLiAgUm9sbGVkIERFUFMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9kb20vUmFuZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL1JhbmdlLmNwcAppbmRleCBh ZGZiNDhlYjgyOTMxYjdiODQ0MGQxYWMxNmFhNmFjMzUzNzg1ZTViLi5jNmMyZDIyOGYyZWQxYjBi ZTRkYmI0OWI5MTk3YjQzNTJlODFmNDRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v UmFuZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9SYW5nZS5jcHAKQEAgLTE5NjMsMTIg KzE5NjMsMTYgQEAgRmxvYXRSZWN0IFJhbmdlOjpib3VuZGluZ1JlY3QoKSBjb25zdAogCiBGbG9h dFJlY3QgUmFuZ2U6OnRyYW5zZm9ybUZyaWVuZGx5Qm91bmRpbmdCb3goKSBjb25zdAogewotICAg IEZsb2F0UmVjdCByZXN1bHQ7CisgICAgaWYgKCFtX3N0YXJ0LmNvbnRhaW5lcigpKQorICAgICAg ICByZXR1cm4gRmxvYXRSZWN0KCk7CisKKyAgICBtX293bmVyRG9jdW1lbnQtPnVwZGF0ZUxheW91 dElnbm9yZVBlbmRpbmdTdHlsZXNoZWV0cygpOworCiAgICAgVmVjdG9yPEZsb2F0UXVhZD4gcXVh ZHM7CiAgICAgdGV4dFF1YWRzKHF1YWRzKTsKIAotICAgIGNvbnN0IHNpemVfdCBuID0gcXVhZHMu c2l6ZSgpOwotICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbjsgKytpKQorICAgIEZsb2F0UmVj dCByZXN1bHQ7CisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBxdWFkcy5zaXplKCk7ICsraSkK ICAgICAgICAgcmVzdWx0LnVuaXRlKHF1YWRzW2ldLmJvdW5kaW5nQm94KCkpOwogCiAgICAgcmV0 dXJuIHJlc3VsdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0ZpbmRJ blBhZ2VDb29yZGluYXRlcy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9GaW5kSW5Q YWdlQ29vcmRpbmF0ZXMuY3BwCmluZGV4IDYyZGE3YWY1OTRhMTM4NzdmYmIzYTM4MmE0NzhiZDEy MzI0YWE5ZDEuLmY5ZmYxOWMyYTBkZTViY2Y4ODUzZDBhNmNjMTg3MWM2MTM0YmMxMzkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0ZpbmRJblBhZ2VDb29yZGluYXRlcy5j cHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRmluZEluUGFnZUNvb3JkaW5hdGVz LmNwcApAQCAtNDgsMjEgKzQ4LDE5IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1l c3BhY2UgV2ViS2l0IHsKIAotc3RhdGljIEZsb2F0UmVjdCB0b05vcm1hbGl6ZWRSZWN0KGNvbnN0 IEZsb2F0UmVjdCYgYWJzb2x1dGVSZWN0LCBjb25zdCBSZW5kZXJPYmplY3QqIHJlbmRlcmVyLCBG bG9hdFJlY3QqIGNvbnRhaW5lckJvdW5kaW5nQm94ID0gMCkKK3N0YXRpYyBGbG9hdFJlY3QgdG9O b3JtYWxpemVkUmVjdChjb25zdCBGbG9hdFJlY3QmIGFic29sdXRlUmVjdCwgY29uc3QgUmVuZGVy T2JqZWN0KiByZW5kZXJlciwgRmxvYXRSZWN0JiBjb250YWluZXJCb3VuZGluZ0JveCkKIHsKICAg ICBBU1NFUlQocmVuZGVyZXIpOwogCiAgICAgY29uc3QgUmVuZGVyT2JqZWN0KiBjb250YWluZXIg PSByZW5kZXJlci0+Y29udGFpbmVyKCk7CiAgICAgaWYgKCFjb250YWluZXIpIHsKLSAgICAgICAg aWYgKGNvbnRhaW5lckJvdW5kaW5nQm94KQotICAgICAgICAgICAgKmNvbnRhaW5lckJvdW5kaW5n Qm94ID0gRmxvYXRSZWN0KCk7CisgICAgICAgIGNvbnRhaW5lckJvdW5kaW5nQm94ID0gRmxvYXRS ZWN0KCk7CiAgICAgICAgIHJldHVybiBGbG9hdFJlY3QoKTsKICAgICB9CiAKICAgICBGbG9hdFJl Y3Qgbm9ybWFsaXplZFJlY3QgPSBhYnNvbHV0ZVJlY3Q7CiAgICAgRmxvYXRSZWN0IGNvbnRhaW5l clJlY3QgPSBjb250YWluZXItPmFic29sdXRlQm91bmRpbmdCb3hSZWN0KCk7Ci0gICAgaWYgKGNv bnRhaW5lckJvdW5kaW5nQm94KQotICAgICAgICAqY29udGFpbmVyQm91bmRpbmdCb3ggPSBjb250 YWluZXJSZWN0OworICAgIGNvbnRhaW5lckJvdW5kaW5nQm94ID0gY29udGFpbmVyUmVjdDsKIAog ICAgIC8vIEZvciBSZW5kZXJCb3hlcyB3ZSB3YW50IHRvIG5vcm1hbGl6ZSBieSB0aGUgbWF4IGxh eW91dCBvdmVyZmxvdyBzaXplIGluc3RlYWQgb2Ygb25seSB0aGUgdmlzaWJsZSBib3VuZGluZyBi b3guCiAgICAgLy8gUXVhZHMgYW5kIHRoZWlyIGVuY2xvc2luZyBib3VuZGluZyBib3hlcyBuZWVk IHRvIGJlIHVzZWQgaW4gb3JkZXIgdG8ga2VlcCByZXN1bHRzIHRyYW5zZm9ybS1mcmllbmRseS4K QEAgLTEwMiw3ICsxMDAsNyBAQCBGbG9hdFJlY3QgZmluZEluUGFnZVJlY3RGcm9tQWJzb2x1dGVS ZWN0KGNvbnN0IEZsb2F0UmVjdCYgaW5wdXRSZWN0LCBjb25zdCBSZW5kZQogCiAgICAgLy8gTm9y bWFsaXplIHRoZSBpbnB1dCByZWN0IHRvIGl0cyBjb250YWluZXIsIHNhdmluZyB0aGUgY29udGFp bmVyIGJvdW5kaW5nIGJveCBmb3IgdGhlIGluY29taW5nIGxvb3AuCiAgICAgRmxvYXRSZWN0IHJl bmRlcmVyQm91bmRpbmdCb3g7Ci0gICAgRmxvYXRSZWN0IG5vcm1hbGl6ZWRSZWN0ID0gdG9Ob3Jt YWxpemVkUmVjdChpbnB1dFJlY3QsIHJlbmRlcmVyLCAmcmVuZGVyZXJCb3VuZGluZ0JveCk7Cisg ICAgRmxvYXRSZWN0IG5vcm1hbGl6ZWRSZWN0ID0gdG9Ob3JtYWxpemVkUmVjdChpbnB1dFJlY3Qs IHJlbmRlcmVyLCByZW5kZXJlckJvdW5kaW5nQm94KTsKICAgICByZW5kZXJlciA9IHJlbmRlcmVy LT5jb250YWluZXIoKTsKIAogICAgIC8vIEdvIHVwIGFjcm9zcyBmcmFtZXMuCkBAIC0xMTMsNyAr MTExLDcgQEAgRmxvYXRSZWN0IGZpbmRJblBhZ2VSZWN0RnJvbUFic29sdXRlUmVjdChjb25zdCBG bG9hdFJlY3QmIGlucHV0UmVjdCwgY29uc3QgUmVuZGUKIAogICAgICAgICAgICAgLy8gQ29tcG9z ZSB0aGUgbm9ybWFsaXplZCByZWN0cy4gVGhlIGFic29sdXRlIGJvdW5kaW5nIGJveCBvZiB0aGUg Y29udGFpbmVyIGlzIGNhbGN1bGF0ZWQgaW4gdG9Ob3JtYWxpemVkUmVjdAogICAgICAgICAgICAg Ly8gYW5kIGNhbiBiZSByZXVzZWQgZm9yIHRoZSBuZXh0IGl0ZXJhdGlvbiBvZiB0aGUgbG9vcC4K LSAgICAgICAgICAgIEZsb2F0UmVjdCBub3JtYWxpemVkQm94UmVjdCA9IHRvTm9ybWFsaXplZFJl Y3QocmVuZGVyZXJCb3VuZGluZ0JveCwgcmVuZGVyZXIsICZyZW5kZXJlckJvdW5kaW5nQm94KTsK KyAgICAgICAgICAgIEZsb2F0UmVjdCBub3JtYWxpemVkQm94UmVjdCA9IHRvTm9ybWFsaXplZFJl Y3QocmVuZGVyZXJCb3VuZGluZ0JveCwgcmVuZGVyZXIsIHJlbmRlcmVyQm91bmRpbmdCb3gpOwog ICAgICAgICAgICAgbm9ybWFsaXplZFJlY3Quc2NhbGUobm9ybWFsaXplZEJveFJlY3Qud2lkdGgo KSwgbm9ybWFsaXplZEJveFJlY3QuaGVpZ2h0KCkpOwogICAgICAgICAgICAgbm9ybWFsaXplZFJl Y3QubW92ZUJ5KG5vcm1hbGl6ZWRCb3hSZWN0LmxvY2F0aW9uKCkpOwogCg==