93803 2012-08-13 01:33:28 -0700 [V8] Move V8PerIsolateData::visitExternalStrings() to V8PerIsolateData.cpp 2012-08-13 19:24:11 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93095 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 693447 0 haraken 2012-08-13 01:33:28 -0700 In r125015, I forgot to move V8PerIsolateData::visitExternalStrings() to V8PerIsolateData.cpp. 693448 1 157938 haraken 2012-08-13 01:34:41 -0700 Created attachment 157938 Patch 694282 2 haraken 2012-08-13 17:41:19 -0700 Committed r125477: <http://trac.webkit.org/changeset/125477> 157938 2012-08-13 01:34:41 -0700 2012-08-13 19:24:11 -0700 Patch bug-93803-20120813173410.patch text/plain 3447 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWMzZjExMGM1YTc4Mzcx MmQ4NjQ4NTI2ODg2ZGNmMjc5ZTM5M2MyNy4uMWE0NGFmYjhlYmRkOTM4NGIzMDNiZmNlZDZiM2Qz MDQyNDZmN2M2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTEzICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1vdmUgVjhQ ZXJJc29sYXRlRGF0YTo6dmlzaXRFeHRlcm5hbFN0cmluZ3MoKSB0byBWOFBlcklzb2xhdGVEYXRh LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM4 MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBy MTI1MDE1LCBJIGZvcmdvdCB0byBtb3ZlIFY4UGVySXNvbGF0ZURhdGE6OnZpc2l0RXh0ZXJuYWxT dHJpbmdzKCkKKyAgICAgICAgdG8gVjhQZXJJc29sYXRlRGF0YS5jcHAuIFRoaXMgcGF0Y2ggbW92 ZXMgaXQuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAg ICAgICAqIGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHA6CisgICAgICAgICogYmluZGluZ3Mvdjgv VjhQZXJJc29sYXRlRGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNv cmU6OlY4UGVySXNvbGF0ZURhdGE6OnZpc2l0RXh0ZXJuYWxTdHJpbmdzKToKKwogMjAxMi0wOC0x MiAgUHJhdmluIEQgIDxwcmF2aW5kLjJrNEBnbWFpbC5jb20+CiAKICAgICAgICAgdGFibGUgY2Vs bC5jZWxsSW5kZXggc2hvdWxkIHJldHVybiAtMSBpZiB0aGVyZSBpcyBubyBwYXJlbnQgdGFibGUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCmluZGV4IGE1ZTk1YTg3YmZj MDU5Y2M1MDQ5YWY4MzBjNzZlZDFmYzNjNmM1N2MuLmU1MTc4MjdiMGZjZTQzNDgxYjVhMjVkZjE3 NjFlYzk2MmZjMmI3OTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 QmluZGluZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNw cApAQCAtNTIsMjcgKzUyLDYgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi0jaWYgRU5BQkxF KElOU1BFQ1RPUikKLXZvaWQgVjhQZXJJc29sYXRlRGF0YTo6dmlzaXRFeHRlcm5hbFN0cmluZ3Mo RXh0ZXJuYWxTdHJpbmdWaXNpdG9yKiB2aXNpdG9yKQotewotICAgIHY4OjpIYW5kbGVTY29wZSBo YW5kbGVTY29wZTsKLSAgICBjbGFzcyBWaXNpdG9ySW1wbCA6IHB1YmxpYyB2ODo6RXh0ZXJuYWxS ZXNvdXJjZVZpc2l0b3IgewotICAgIHB1YmxpYzoKLSAgICAgICAgVmlzaXRvckltcGwoRXh0ZXJu YWxTdHJpbmdWaXNpdG9yKiB2aXNpdG9yKSA6IG1fdmlzaXRvcih2aXNpdG9yKSB7IH0KLSAgICAg ICAgdmlydHVhbCB+VmlzaXRvckltcGwoKSB7IH0KLSAgICAgICAgdmlydHVhbCB2b2lkIFZpc2l0 RXh0ZXJuYWxTdHJpbmcodjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBzdHJpbmcpCi0gICAgICAgIHsK LSAgICAgICAgICAgIFdlYkNvcmVTdHJpbmdSZXNvdXJjZSogcmVzb3VyY2UgPSBzdGF0aWNfY2Fz dDxXZWJDb3JlU3RyaW5nUmVzb3VyY2UqPihzdHJpbmctPkdldEV4dGVybmFsU3RyaW5nUmVzb3Vy Y2UoKSk7Ci0gICAgICAgICAgICBpZiAocmVzb3VyY2UpCi0gICAgICAgICAgICAgICAgcmVzb3Vy Y2UtPnZpc2l0U3RyaW5ncyhtX3Zpc2l0b3IpOwotICAgICAgICB9Ci0gICAgcHJpdmF0ZToKLSAg ICAgICAgRXh0ZXJuYWxTdHJpbmdWaXNpdG9yKiBtX3Zpc2l0b3I7Ci0gICAgfSB2OFZpc2l0b3Io dmlzaXRvcik7Ci0gICAgdjg6OlY4OjpWaXNpdEV4dGVybmFsUmVzb3VyY2VzKCZ2OFZpc2l0b3Ip OwotfQotI2VuZGlmCi0KIHN0YXRpYyBTdHJpbmcgdjhOb25TdHJpbmdWYWx1ZVRvV2ViQ29yZVN0 cmluZyh2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gb2JqZWN0KQogewogICAgIEFTU0VSVCghb2JqZWN0 LT5Jc1N0cmluZygpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 UGVySXNvbGF0ZURhdGEuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQZXJJc29s YXRlRGF0YS5jcHAKaW5kZXggYjU3MDI2YTY2ZGY4ZDhlMmM3ZmRjZGJjMjc2ZjdlZjRjM2U4Yjcz MC4uYTdkYWJhYjMzODZiMThhZDQ4NGNjODcyZmUwZGU5NzVhN2I2MWNlNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQZXJJc29sYXRlRGF0YS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQZXJJc29sYXRlRGF0YS5jcHAKQEAgLTg0LDQgKzg0 LDI1IEBAIHZvaWQgVjhQZXJJc29sYXRlRGF0YTo6cmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5T2Jq ZWN0SW5mbyogbWVtb3J5T2JqZWN0SW5mbykgY29uCiAgICAgICAgIGluZm8uYWRkSW5zdHJ1bWVu dGVkTWVtYmVyKG1fZG9tRGF0YUxpc3RbaV0pOwogfQogCisjaWYgRU5BQkxFKElOU1BFQ1RPUikK K3ZvaWQgVjhQZXJJc29sYXRlRGF0YTo6dmlzaXRFeHRlcm5hbFN0cmluZ3MoRXh0ZXJuYWxTdHJp bmdWaXNpdG9yKiB2aXNpdG9yKQoreworICAgIHY4OjpIYW5kbGVTY29wZSBoYW5kbGVTY29wZTsK KyAgICBjbGFzcyBWaXNpdG9ySW1wbCA6IHB1YmxpYyB2ODo6RXh0ZXJuYWxSZXNvdXJjZVZpc2l0 b3IgeworICAgIHB1YmxpYzoKKyAgICAgICAgVmlzaXRvckltcGwoRXh0ZXJuYWxTdHJpbmdWaXNp dG9yKiB2aXNpdG9yKSA6IG1fdmlzaXRvcih2aXNpdG9yKSB7IH0KKyAgICAgICAgdmlydHVhbCB+ VmlzaXRvckltcGwoKSB7IH0KKyAgICAgICAgdmlydHVhbCB2b2lkIFZpc2l0RXh0ZXJuYWxTdHJp bmcodjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBzdHJpbmcpCisgICAgICAgIHsKKyAgICAgICAgICAg IFdlYkNvcmVTdHJpbmdSZXNvdXJjZSogcmVzb3VyY2UgPSBzdGF0aWNfY2FzdDxXZWJDb3JlU3Ry aW5nUmVzb3VyY2UqPihzdHJpbmctPkdldEV4dGVybmFsU3RyaW5nUmVzb3VyY2UoKSk7CisgICAg ICAgICAgICBpZiAocmVzb3VyY2UpCisgICAgICAgICAgICAgICAgcmVzb3VyY2UtPnZpc2l0U3Ry aW5ncyhtX3Zpc2l0b3IpOworICAgICAgICB9CisgICAgcHJpdmF0ZToKKyAgICAgICAgRXh0ZXJu YWxTdHJpbmdWaXNpdG9yKiBtX3Zpc2l0b3I7CisgICAgfSB2OFZpc2l0b3IodmlzaXRvcik7Cisg ICAgdjg6OlY4OjpWaXNpdEV4dGVybmFsUmVzb3VyY2VzKCZ2OFZpc2l0b3IpOworfQorI2VuZGlm CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK