93800 2012-08-13 00:23:59 -0700 WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close 2012-11-08 22:24:45 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keishi keishi tkent webkit.review.bot oldest_to_newest 693424 0 keishi 2012-08-13 00:23:59 -0700 ASSERTION FAILED: m_ptr ../../third_party/WebKit/Source/WTF/wtf/OwnPtr.h(64) : PtrType WTF::OwnPtr<WebCore::Page>::operator->() const [T = WebCore::Page] 1 0x10015b71 WTF::OwnPtr<WebCore::Page>::operator->() const 2 0x1013c7fd WebKit::WebPagePopupImpl::handleKeyEvent(WebCore::PlatformKeyboardEvent const&) 3 0x1018f974 WebKit::WebViewImpl::handleKeyEvent(WebKit::WebKeyboardEvent const&) 693426 1 157931 keishi 2012-08-13 00:29:46 -0700 Created attachment 157931 Patch 694356 2 157931 tkent 2012-08-13 18:26:38 -0700 Comment on attachment 157931 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157931&action=review > Source/WebKit/chromium/ChangeLog:8 > + Fix crash in WebPagePopupImpl::handleKeyEvent > + https://bugs.webkit.org/show_bug.cgi?id=93800 > + > + Reviewed by NOBODY (OOPS!). > + > + We need to check if WebPagePopupImpl::m_page is set. Would you explain how to reproduce the problem please? 694357 3 157931 tkent 2012-08-13 18:26:39 -0700 Comment on attachment 157931 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157931&action=review > Source/WebKit/chromium/ChangeLog:8 > + Fix crash in WebPagePopupImpl::handleKeyEvent > + https://bugs.webkit.org/show_bug.cgi?id=93800 > + > + Reviewed by NOBODY (OOPS!). > + > + We need to check if WebPagePopupImpl::m_page is set. Would you explain how to reproduce the problem please? 694459 4 keishi 2012-08-13 20:42:08 -0700 (In reply to comment #3) > Would you explain how to reproduce the problem please? It happened while bashing on the keyboard after closing the page popup, but I can't reproduce it now. 702404 5 157931 eric 2012-08-22 15:20:53 -0700 Comment on attachment 157931 Patch Cleared review? from attachment 157931 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 761684 6 keishi 2012-11-08 05:21:45 -0800 Reproduction method found http://code.google.com/p/chromium/issues/detail?id=160016 762517 7 keishi 2012-11-08 21:13:15 -0800 WebKit::WebPagePopupImpl::close() content::RenderWidget::Close() //PostNonNestableTask(RenderWidget::Close) content::RenderWidget::OnClose() // Send(ViewMsg_Close); content::RenderWidgetHostImpl::Shutdown() content::RenderWidgetHostViewMac::ShutdownHost() // PostTask(RenderWidgetHostViewMac::ShutdownHost) content::RenderWidgetHostViewMac::KillSelf() [RenderWidgetHostViewCocoa cancelChildPopups] [RenderWidgetHostViewCocoa scrollWheel:] [NSWindow sendEvent:] [ChromeEventProcessingWindow sendEvent:] [FramedBrowserWindow sendEvent:] [NSApplication sendEvent:] [BrowserCrApplication sendEvent:] [NSApplication run] 762523 8 173195 keishi 2012-11-08 21:21:14 -0800 Created attachment 173195 Patch 762537 9 173195 tkent 2012-11-08 21:33:29 -0800 Comment on attachment 173195 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173195&action=review > Source/WebKit/chromium/ChangeLog:8 > + We need to set m_closing tot true in WebPagePopupImpl::close so we won't access m_page in WebPagePopupImpl::handleKeyEvent. tot -> to? 762553 10 173202 keishi 2012-11-08 21:55:55 -0800 Created attachment 173202 Patch 762567 11 173202 webkit.review.bot 2012-11-08 22:24:42 -0800 Comment on attachment 173202 Patch Clearing flags on attachment: 173202 Committed r134009: <http://trac.webkit.org/changeset/134009> 762568 12 webkit.review.bot 2012-11-08 22:24:45 -0800 All reviewed patches have been landed. Closing bug. 157931 2012-08-13 00:29:46 -0700 2012-08-22 15:20:52 -0700 Patch bug-93800-20120813162915.patch text/plain 1497 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1Mzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDFlNWM2NGZkMDRiYTI2ZjhlNjFkODhjYjBkNmFmYjgxYmNiNGFhMGQuLmEyNDM5ZDE3MWQ3YTYw ZTIxNzdlMTAxZWM0YWFjZjIzY2U4Y2M4NzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDgtMTMgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtp dC5vcmc+CisKKyAgICAgICAgRml4IGNyYXNoIGluIFdlYlBhZ2VQb3B1cEltcGw6OmhhbmRsZUtl eUV2ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MzgwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl IG5lZWQgdG8gY2hlY2sgaWYgV2ViUGFnZVBvcHVwSW1wbDo6bV9wYWdlIGlzIHNldC4KKworICAg ICAgICAqIHNyYy9XZWJQYWdlUG9wdXBJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFn ZVBvcHVwSW1wbDo6aGFuZGxlS2V5RXZlbnQpOgorCiAyMDEyLTA4LTEyICBMZWFuZHJvIEdyYWNp YSBHaWwgIDxsZWFuZHJvZ3JhY2lhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1d IEltcGxlbWVudCB0aGUgZmluZC1pbi1wYWdlIG1hdGNoIHJlY3RzIEFQSQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGFnZVBvcHVwSW1wbC5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYWdlUG9wdXBJbXBsLmNwcAppbmRleCAxOGY1ZGUyMGE1 ZTBmZmFkMTJhMDcyMTc4NTBiMWZmZDhlODA4MGMxLi42MGMwMDBmNTc5Mjg0MDgxNDllYTg5ZTc2 MDU4Zjc3M2Y1ZDgzZWNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJQYWdlUG9wdXBJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQ YWdlUG9wdXBJbXBsLmNwcApAQCAtMjg0LDcgKzI4NCw3IEBAIGJvb2wgV2ViUGFnZVBvcHVwSW1w bDo6aGFuZGxlSW5wdXRFdmVudChjb25zdCBXZWJJbnB1dEV2ZW50JiBldmVudCkKIAogYm9vbCBX ZWJQYWdlUG9wdXBJbXBsOjpoYW5kbGVLZXlFdmVudChjb25zdCBQbGF0Zm9ybUtleWJvYXJkRXZl bnQmIGV2ZW50KQogewotICAgIGlmICghbV9wYWdlLT5tYWluRnJhbWUoKSB8fCAhbV9wYWdlLT5t YWluRnJhbWUoKS0+dmlldygpKQorICAgIGlmICghbV9wYWdlIHx8ICFtX3BhZ2UtPm1haW5GcmFt ZSgpIHx8ICFtX3BhZ2UtPm1haW5GcmFtZSgpLT52aWV3KCkpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKICAgICByZXR1cm4gbV9wYWdlLT5tYWluRnJhbWUoKS0+ZXZlbnRIYW5kbGVyKCktPmtleUV2 ZW50KGV2ZW50KTsKIH0K 173195 2012-11-08 21:21:14 -0800 2012-11-08 21:55:51 -0800 Patch bug-93800-20121109141922.patch text/plain 1448 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzOTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDAxMGYzNWI5YjIzMzI2Y2VmYWJjYjNkOGY2Nzc1M2RhYmE5OGMyNGIuLjU1MTlkZDYwYmYyNGRl NTlmNDliOWE5NTk3OTNlZDQxMWFjYThhYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMTEtMDggIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtp dC5vcmc+CisKKyAgICAgICAgV2ViUGFnZVBvcHVwSW1wbDo6aGFuZGxlS2V5RXZlbnQgaXMgY2Fs bGVkIGFmdGVyIFdlYlBhZ2VQb3B1cEltcGw6OmNsb3NlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzgwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG5lZWQgdG8gc2V0IG1fY2xvc2luZyB0b3QgdHJ1 ZSBpbiBXZWJQYWdlUG9wdXBJbXBsOjpjbG9zZSBzbyB3ZSB3b24ndCBhY2Nlc3MgbV9wYWdlIGlu IFdlYlBhZ2VQb3B1cEltcGw6OmhhbmRsZUtleUV2ZW50LgorCisgICAgICAgICogc3JjL1dlYlBh Z2VQb3B1cEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUG9wdXBJbXBsOjpjbG9z ZSk6IFNldCBtX2Nsb3NpbmcgdG8gdHJ1ZS4KKwogMjAxMi0xMS0wOCAgQWxlYyBGbGV0dCAgPGFs ZWNmbGV0dEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBzd2l0Y2ggZnJvbnRl bmQgdG8gdXNlIGludDY0X3QtYmFzZWQgcmVmZXJlbmNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViUGFnZVBvcHVwSW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJQYWdlUG9wdXBJbXBsLmNwcAppbmRleCAwMWNhY2RhMmFhZTk3YzkwNTk1 OWJkYTc1N2Y2ZDBmODA0ZjhhNTU5Li5kMTAwMjJhNTFiZjgwMjM1N2ZjZGJkOTkyOWY0Zjc1ZDk3 Mjc2MDU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYWdlUG9w dXBJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYWdlUG9wdXBJ bXBsLmNwcApAQCAtMzA0LDYgKzMwNCw3IEBAIHZvaWQgV2ViUGFnZVBvcHVwSW1wbDo6c2V0Rm9j dXMoYm9vbCBlbmFibGUpCiAKIHZvaWQgV2ViUGFnZVBvcHVwSW1wbDo6Y2xvc2UoKQogeworICAg IG1fY2xvc2luZyA9IHRydWU7CiAgICAgaWYgKG1fcGFnZSAmJiBtX3BhZ2UtPm1haW5GcmFtZSgp KQogICAgICAgICBtX3BhZ2UtPm1haW5GcmFtZSgpLT5sb2FkZXIoKS0+ZnJhbWVEZXRhY2hlZCgp OwogICAgIG1fcGFnZS5jbGVhcigpOwo= 173202 2012-11-08 21:55:55 -0800 2012-11-08 22:24:42 -0800 Patch bug-93800-20121109145403.patch text/plain 1444 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzOTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDAxMGYzNWI5YjIzMzI2Y2VmYWJjYjNkOGY2Nzc1M2RhYmE5OGMyNGIuLmNjYmNiY2JmYTVmMWE3 ZWY4ZDNjMDZiMGVmZTE4MDAzODQyZTIzMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMTEtMDggIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtp dC5vcmc+CisKKyAgICAgICAgV2ViUGFnZVBvcHVwSW1wbDo6aGFuZGxlS2V5RXZlbnQgaXMgY2Fs bGVkIGFmdGVyIFdlYlBhZ2VQb3B1cEltcGw6OmNsb3NlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzgwMAorCisgICAgICAgIFJldmlld2VkIGJ5IEtl bnQgVGFtdXJhLgorCisgICAgICAgIFdlIG5lZWQgdG8gc2V0IG1fY2xvc2luZyB0byB0cnVlIGlu IFdlYlBhZ2VQb3B1cEltcGw6OmNsb3NlIHNvIHdlIHdvbid0IGFjY2VzcyBtX3BhZ2UgaW4gV2Vi UGFnZVBvcHVwSW1wbDo6aGFuZGxlS2V5RXZlbnQuCisKKyAgICAgICAgKiBzcmMvV2ViUGFnZVBv cHVwSW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQb3B1cEltcGw6OmNsb3NlKTog U2V0IG1fY2xvc2luZyB0byB0cnVlLgorCiAyMDEyLTExLTA4ICBBbGVjIEZsZXR0ICA8YWxlY2Zs ZXR0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVkREI6IHN3aXRjaCBmcm9udGVuZCB0 byB1c2UgaW50NjRfdC1iYXNlZCByZWZlcmVuY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJQYWdlUG9wdXBJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlBhZ2VQb3B1cEltcGwuY3BwCmluZGV4IDAxY2FjZGEyYWFlOTdjOTA1OTU5YmRh NzU3ZjZkMGY4MDRmOGE1NTkuLmQxMDAyMmE1MWJmODAyMzU3ZmNkYmQ5OTI5ZjRmNzVkOTcyNzYw NTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBhZ2VQb3B1cElt cGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBhZ2VQb3B1cEltcGwu Y3BwCkBAIC0zMDQsNiArMzA0LDcgQEAgdm9pZCBXZWJQYWdlUG9wdXBJbXBsOjpzZXRGb2N1cyhi b29sIGVuYWJsZSkKIAogdm9pZCBXZWJQYWdlUG9wdXBJbXBsOjpjbG9zZSgpCiB7CisgICAgbV9j bG9zaW5nID0gdHJ1ZTsKICAgICBpZiAobV9wYWdlICYmIG1fcGFnZS0+bWFpbkZyYW1lKCkpCiAg ICAgICAgIG1fcGFnZS0+bWFpbkZyYW1lKCktPmxvYWRlcigpLT5mcmFtZURldGFjaGVkKCk7CiAg ICAgbV9wYWdlLmNsZWFyKCk7Cg==