93789 2012-08-12 16:18:03 -0700 REGRESSION(r125153): It broke the 'Unexpected no expected results' case 2012-11-07 07:01:27 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P1 Critical --- 93537 1 ossy webkit-unassigned galpeter lforschler ossy rniwa wsiegrist zherczeg oldest_to_newest 693338 0 ossy 2012-08-12 16:18:03 -0700 After this change if there is 'Unexpected no expected results', _parseNewRunWebKitTestsOutput dies with exception: (view as text) Traceback (most recent call last): File "/var/python/lib/python2.6/site-packages/twisted/internet/defer.py", line 290, in addCallbacks self._runCallbacks() File "/var/python/lib/python2.6/site-packages/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/var/python/lib/python2.6/site-packages/twisted/internet/defer.py", line 368, in callback self._startRunCallbacks(result) File "/var/python/lib/python2.6/site-packages/twisted/internet/defer.py", line 464, in _startRunCallbacks self._runCallbacks() --- <exception caught here> --- File "/var/python/lib/python2.6/site-packages/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/var/python/lib/python2.6/site-packages/buildbot/process/buildstep.py", line 800, in <lambda> d.addCallback(lambda res: self.commandComplete(cmd)) File "/var/buildbot/master.cfg", line 382, in commandComplete self._parseNewRunWebKitTestsOutput(logText) File "/var/buildbot/master.cfg", line 367, in _parseNewRunWebKitTestsOutput testFailures[name] = testFailures.get(name, 0) + int(match.group(1)) exceptions.ValueError: invalid literal for int() with base 10: 'no expected results found' It seems the regexp is broken. Could you check it, please? 693417 1 galpeter 2012-08-13 00:07:06 -0700 This regex is the culprit re.compile(r'(no expected results found|missing results)\s*:\s+\((\d+)\)') Because of the new parentheses the text is the first matching group. The text should be a non-capturing group, like this: re.compile(r'(?:no expected results found|missing results)\s*:\s+\((\d+)\)') 693420 2 ossy 2012-08-13 00:18:17 -0700 (In reply to comment #1) > This regex is the culprit > > re.compile(r'(no expected results found|missing results)\s*:\s+\((\d+)\)') > > Because of the new parentheses the text is the first matching group. The text should be a non-capturing group, like this: > > re.compile(r'(?:no expected results found|missing results)\s*:\s+\((\d+)\)') Could you upload a patch for it? ;-) 693427 3 157932 galpeter 2012-08-13 00:31:40 -0700 Created attachment 157932 regex fix Should fix it (TM) :) 693435 4 157932 ossy 2012-08-13 01:09:27 -0700 Comment on attachment 157932 regex fix LGTM,r=me. 693436 5 157932 ossy 2012-08-13 01:11:58 -0700 Comment on attachment 157932 regex fix Clearing flags on attachment: 157932 Committed r125396: <http://trac.webkit.org/changeset/125396> 693437 6 ossy 2012-08-13 01:12:04 -0700 All reviewed patches have been landed. Closing bug. 693442 7 ossy 2012-08-13 01:23:59 -0700 Lucas or Bill, could you restart the buildmaster again, please? (It seems automatic restart still doesn't work.) 694703 8 ossy 2012-08-14 02:09:50 -0700 (In reply to comment #7) > Lucas or Bill, could you restart the buildmaster again, please? > (It seems automatic restart still doesn't work.) ping? It is very important to restart the master, because now all bots throw exception when somebody lands a new test without expected file. And are you planning to enable automatic master restarting after a master.cfg change? 695192 9 lforschler 2012-08-14 11:29:20 -0700 Restarted master but ran into this issue: 2012-08-14 11:27:16-0700 [-] Unhandled Error Traceback (most recent call last): File "/var/python/lib/python2.6/site-packages/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/var/python/lib/python2.6/site-packages/twisted/internet/defer.py", line 916, in gotResult _deferGenerator(g, deferred) File "/var/python/lib/python2.6/site-packages/twisted/internet/defer.py", line 891, in _deferGenerator result = g.next() File "/var/python/lib/python2.6/site-packages/buildbot/master.py", line 166, in startService self.configFileName) --- <exception caught here> --- File "/var/python/lib/python2.6/site-packages/buildbot/config.py", line 144, in loadConfig exec f in localDict File "/var/buildbot/master.cfg", line 921, in <module> loadBuilderConfig(c) File "/var/buildbot/master.cfg", line 847, in loadBuilderConfig c['slaves'] = [BuildSlave(slave['name'], passwords[slave['name']], max_builds=1) for slave in config['slaves']] exceptions.KeyError: u'indt-mountainlion' 695193 10 lforschler 2012-08-14 11:30:22 -0700 I've rolled back until we can investigate the below. I'm not sure why the build master isn't auto-restarting... maybe because it failed to start. Hopefully Bill can investigate then when he returns from vacation. I will also look into it as time allows. 695202 11 lforschler 2012-08-14 11:39:36 -0700 it looks like we needed a passwords update. I've fixed that and restarted the master. Things appear to be running now. 760663 12 ossy 2012-11-07 07:01:27 -0800 It is fixed long time ago. 157932 2012-08-13 00:31:40 -0700 2012-08-13 01:11:58 -0700 regex fix bug_93789.patch text/plain 1576 galpeter ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDU0Njg0NGIuLmVjNzllZDQgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwpAQCAtMzUxLDcgKzM1MSw3IEBAIGNsYXNzIFJ1bldlYktpdFRlc3RzKHNoZWxsLlRl c3QpOgogICAgICAgICBleHByZXNzaW9ucyA9IFsKICAgICAgICAgICAgICgnZmxha2VzJywgcmUu Y29tcGlsZShyJ1tVdV1uZXhwZWN0ZWQgZmxha2luZXNzLis6P1xzKlwoKFxkKylcKScpKSwKICAg ICAgICAgICAgICgnbmV3IHBhc3NlcycsIHJlLmNvbXBpbGUocidFeHBlY3RlZCB0byAuKywgYnV0 IHBhc3NlZDpccytcKChcZCspXCknKSksCi0gICAgICAgICAgICAoJ21pc3NpbmcgcmVzdWx0cycs IHJlLmNvbXBpbGUocicobm8gZXhwZWN0ZWQgcmVzdWx0cyBmb3VuZHxtaXNzaW5nIHJlc3VsdHMp XHMqOlxzK1woKFxkKylcKScpKSwKKyAgICAgICAgICAgICgnbWlzc2luZyByZXN1bHRzJywgcmUu Y29tcGlsZShyJyg/Om5vIGV4cGVjdGVkIHJlc3VsdHMgZm91bmR8bWlzc2luZyByZXN1bHRzKVxz KjpccytcKChcZCspXCknKSksCiAgICAgICAgICAgICAoJ2ZhaWx1cmVzJywgcmUuY29tcGlsZShy J1JlZ3Jlc3Npb25zOiBbVXVdbmV4cGVjdGVkLis6P1xzKlwoKFxkKylcKScpKSwKICAgICAgICAg XQogICAgICAgICB0ZXN0RmFpbHVyZXMgPSB7fQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9n IGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDZlOWJjOGEuLjkyZDY5NTcgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAx Mi0wOC0xMyAgUGV0ZXIgR2FsICA8Z2FscGV0ZXJAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAg IFJFR1JFU1NJT04ocjEyNTE1Myk6IEl0IGJyb2tlIHRoZSAnVW5leHBlY3RlZCBubyBleHBlY3Rl ZCByZXN1bHRzJyBjYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05Mzc4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeCB0aGUgcmVnZXgsIHNvIHRoZSB0ZXh0IHdvbid0IGJlIGEgY2FwdHVyaW5nIGdy b3VwLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvbWFzdGVyLmNmZzoKKyAgICAgICAgKFJ1bldlYktpdFRlc3RzLl9wYXJzZU5ld1J1bldlYktp dFRlc3RzT3V0cHV0KToKKwogMjAxMi0wOC0xMiAgTU9SSVRBIEhhamltZSAgPG1vcnJpdGFAZ29v Z2xlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBhZGRlZCBhIHByb3h5IGFkZHJlc3MgdG8g Y29udHJpYnV0b3JzX3dob19hcmVfbm90X2NvbW1pdHRlcnMuCg==