93776 2012-08-12 00:36:02 -0700 CSSComputedStyleDeclaration::cssText() should use StringBuilder 2012-08-12 11:54:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin cmarcelo dglazkov macpherson menard webkit.review.bot oldest_to_newest 693187 0 benjamin 2012-08-12 00:36:02 -0700 String::append() is very inefficient when use like that. 693188 1 157891 benjamin 2012-08-12 00:43:53 -0700 Created attachment 157891 Patch 693189 2 157891 webkit.review.bot 2012-08-12 00:48:14 -0700 Comment on attachment 157891 Patch Attachment 157891 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13480440 693190 3 157892 benjamin 2012-08-12 01:03:12 -0700 Created attachment 157892 Patch 693193 4 157892 eric 2012-08-12 02:38:30 -0700 Comment on attachment 157892 Patch Yup. Do we have any microbenchmarks to show the speed win? 693214 5 157892 webkit.review.bot 2012-08-12 03:37:30 -0700 Comment on attachment 157892 Patch Clearing flags on attachment: 157892 Committed r125367: <http://trac.webkit.org/changeset/125367> 693215 6 webkit.review.bot 2012-08-12 03:37:35 -0700 All reviewed patches have been landed. Closing bug. 693303 7 benjamin 2012-08-12 11:54:41 -0700 > Yup. Do we have any microbenchmarks to show the speed win? Here is what I used to get the numbers: http://jsperf.com/csscomputedstyledeclaration-csstext 157891 2012-08-12 00:43:53 -0700 2012-08-12 01:03:08 -0700 Patch bug-93776-20120812004323.patch text/plain 2188 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MzU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkyOTMwMzkwNjQ4NDc3 OTU4ZGVkMmI0ZmY5NzFmMWJkZGRlYzdkNC4uZWNhMzliNDFhZDViMDEzZDg2MWIyMGM5NGEzMWRj NWFkYTE1MjgzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTEyICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBDU1NDb21wdXRl ZFN0eWxlRGVjbGFyYXRpb246OmNzc1RleHQoKSBzaG91bGQgdXNlIFN0cmluZ0J1aWxkZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNzc2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RyaW5nOjphcHBl bmQoKSBpcyBmYWlybHkgaW5lZmZpY2llbnQgd2hlbiB1c2VkIHRvIGNyZWF0ZSBhIGxvbmcgc3Ry aW5nIGJ5IGFwcGVuZGluZyBhIGxvdCBvZiBzbWFsbAorICAgICAgICBwaWVjZXMuIFN0cmluZ0J1 aWxkZXIgaXMgbW9yZSBhcHByb3JpYXRlIGZvciB0aGUga2luZCBvZiBvcGVyYXRpb25zIGRvbmUg YnkgQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uOjpjc3NUZXh0KCkuCisKKyAgICAgICAgVGhp cyBjaGFuZ2VzIG1ha2VzIENTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbjo6Y3NzVGV4dCgpIGFi b3V0IDYgdGltZXMgZmFzdGVyLgorCisgICAgICAgICogY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNs YXJhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRp b246OmNzc1RleHQpOgorCiAyMDEyLTA4LTExICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5A YXBwbGUuY29tPgogCiAgICAgICAgIERvIHRoZSBEZWNpbWFsTnVtYmVyIHRvIFN0cmluZyBjb252 ZXJzaW9uIG9uIDggYml0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1 dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRT dHlsZURlY2xhcmF0aW9uLmNwcAppbmRleCA3YTA1MDY4MmRmYmJiOTdlNTNlMzRjYmExMTU2NmJj OTNmYmQwMGVlLi40MWY0MTJhZjI3ZDUzMTA4MWMzNDQyYWQ1NWUzZjUyNWI2ZmY1Yjk2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNw cApAQCAtMTA2MSwxOCArMTA2MSwxOCBAQCB2b2lkIENTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlv bjo6ZGVyZWYoKQogCiBTdHJpbmcgQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uOjpjc3NUZXh0 KCkgY29uc3QKIHsKLSAgICBTdHJpbmcgcmVzdWx0KCIiKTsKKyAgICBTdHJpbmdCdWlsZGVyIHJl c3VsdDsKIAogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBudW1Db21wdXRlZFByb3BlcnRp ZXM7IGkrKykgewogICAgICAgICBpZiAoaSkKLSAgICAgICAgICAgIHJlc3VsdCArPSAiICI7Ci0g ICAgICAgIHJlc3VsdCArPSBnZXRQcm9wZXJ0eU5hbWUoY29tcHV0ZWRQcm9wZXJ0aWVzW2ldKTsK LSAgICAgICAgcmVzdWx0ICs9ICI6ICI7Ci0gICAgICAgIHJlc3VsdCArPSBnZXRQcm9wZXJ0eVZh bHVlKGNvbXB1dGVkUHJvcGVydGllc1tpXSk7Ci0gICAgICAgIHJlc3VsdCArPSAiOyI7CisgICAg ICAgICAgICByZXN1bHQuYXBwZW5kKCcgJyk7CisgICAgICAgIHJlc3VsdC5hcHBlbmQoZ2V0UHJv cGVydHlOYW1lKGNvbXB1dGVkUHJvcGVydGllc1tpXSkpOworICAgICAgICByZXN1bHQuYXBwZW5k KCI6ICIsIDIpOworICAgICAgICByZXN1bHQuYXBwZW5kKGdldFByb3BlcnR5VmFsdWUoY29tcHV0 ZWRQcm9wZXJ0aWVzW2ldKSk7CisgICAgICAgIHJlc3VsdC5hcHBlbmQoJzsnKTsKICAgICB9CiAK LSAgICByZXR1cm4gcmVzdWx0OworICAgIHJldHVybiByZXN1bHQudG9TdHJpbmcoKTsKIH0KIAog dm9pZCBDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb246OnNldENzc1RleHQoY29uc3QgU3RyaW5n JiwgRXhjZXB0aW9uQ29kZSYgZWMpCg== 157892 2012-08-12 01:03:12 -0700 2012-08-12 03:37:30 -0700 Patch bug-93776-20120812010241.patch text/plain 2412 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkyOTMwMzkwNjQ4NDc3 OTU4ZGVkMmI0ZmY5NzFmMWJkZGRlYzdkNC4uZWNhMzliNDFhZDViMDEzZDg2MWIyMGM5NGEzMWRj NWFkYTE1MjgzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTEyICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBDU1NDb21wdXRl ZFN0eWxlRGVjbGFyYXRpb246OmNzc1RleHQoKSBzaG91bGQgdXNlIFN0cmluZ0J1aWxkZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNzc2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RyaW5nOjphcHBl bmQoKSBpcyBmYWlybHkgaW5lZmZpY2llbnQgd2hlbiB1c2VkIHRvIGNyZWF0ZSBhIGxvbmcgc3Ry aW5nIGJ5IGFwcGVuZGluZyBhIGxvdCBvZiBzbWFsbAorICAgICAgICBwaWVjZXMuIFN0cmluZ0J1 aWxkZXIgaXMgbW9yZSBhcHByb3JpYXRlIGZvciB0aGUga2luZCBvZiBvcGVyYXRpb25zIGRvbmUg YnkgQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uOjpjc3NUZXh0KCkuCisKKyAgICAgICAgVGhp cyBjaGFuZ2VzIG1ha2VzIENTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbjo6Y3NzVGV4dCgpIGFi b3V0IDYgdGltZXMgZmFzdGVyLgorCisgICAgICAgICogY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNs YXJhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRp b246OmNzc1RleHQpOgorCiAyMDEyLTA4LTExICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5A YXBwbGUuY29tPgogCiAgICAgICAgIERvIHRoZSBEZWNpbWFsTnVtYmVyIHRvIFN0cmluZyBjb252 ZXJzaW9uIG9uIDggYml0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1 dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRT dHlsZURlY2xhcmF0aW9uLmNwcAppbmRleCA3YTA1MDY4MmRmYmJiOTdlNTNlMzRjYmExMTU2NmJj OTNmYmQwMGVlLi5iOTA3YWIzNTMxZGVlYTA3NTE3OWExZTMxOWMzZGE1YTcyODRmN2QyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNw cApAQCAtNTcsNiArNTcsNyBAQAogI2luY2x1ZGUgIlN0eWxlUHJvcGVydHlTaG9ydGhhbmQuaCIK ICNpbmNsdWRlICJXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZS5oIgogI2luY2x1ZGUgIldlYktpdEZv bnRGYW1pbHlOYW1lcy5oIgorI2luY2x1ZGUgPHd0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaD4KIAog I2lmIEVOQUJMRShDU1NfRVhDTFVTSU9OUykKICNpbmNsdWRlICJDU1NXcmFwU2hhcGVzLmgiCkBA IC0xMDYxLDE4ICsxMDYyLDE4IEBAIHZvaWQgQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uOjpk ZXJlZigpCiAKIFN0cmluZyBDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb246OmNzc1RleHQoKSBj b25zdAogewotICAgIFN0cmluZyByZXN1bHQoIiIpOworICAgIFN0cmluZ0J1aWxkZXIgcmVzdWx0 OwogCiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG51bUNvbXB1dGVkUHJvcGVydGllczsg aSsrKSB7CiAgICAgICAgIGlmIChpKQotICAgICAgICAgICAgcmVzdWx0ICs9ICIgIjsKLSAgICAg ICAgcmVzdWx0ICs9IGdldFByb3BlcnR5TmFtZShjb21wdXRlZFByb3BlcnRpZXNbaV0pOwotICAg ICAgICByZXN1bHQgKz0gIjogIjsKLSAgICAgICAgcmVzdWx0ICs9IGdldFByb3BlcnR5VmFsdWUo Y29tcHV0ZWRQcm9wZXJ0aWVzW2ldKTsKLSAgICAgICAgcmVzdWx0ICs9ICI7IjsKKyAgICAgICAg ICAgIHJlc3VsdC5hcHBlbmQoJyAnKTsKKyAgICAgICAgcmVzdWx0LmFwcGVuZChnZXRQcm9wZXJ0 eU5hbWUoY29tcHV0ZWRQcm9wZXJ0aWVzW2ldKSk7CisgICAgICAgIHJlc3VsdC5hcHBlbmQoIjog IiwgMik7CisgICAgICAgIHJlc3VsdC5hcHBlbmQoZ2V0UHJvcGVydHlWYWx1ZShjb21wdXRlZFBy b3BlcnRpZXNbaV0pKTsKKyAgICAgICAgcmVzdWx0LmFwcGVuZCgnOycpOwogICAgIH0KIAotICAg IHJldHVybiByZXN1bHQ7CisgICAgcmV0dXJuIHJlc3VsdC50b1N0cmluZygpOwogfQogCiB2b2lk IENTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbjo6c2V0Q3NzVGV4dChjb25zdCBTdHJpbmcmLCBF eGNlcHRpb25Db2RlJiBlYykK