93771 2012-08-11 17:52:26 -0700 Move CSS's propertyNameStrings[] to from the header to the cpp file 2012-08-12 03:39:39 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin cmarcelo jchaffraix kling macpherson menard webkit.review.bot oldest_to_newest 693156 0 benjamin 2012-08-11 17:52:26 -0700 propertyNameStrings[] should not be accessed directly. To ensure this, move the declaration to the cpp file. 693157 1 157881 benjamin 2012-08-11 17:56:49 -0700 Created attachment 157881 Patch 693158 2 benjamin 2012-08-11 17:57:39 -0700 This will make the initialization from literal easier. 693194 3 157881 eric 2012-08-12 02:39:13 -0700 Comment on attachment 157881 Patch OK. 693217 4 157881 webkit.review.bot 2012-08-12 03:39:35 -0700 Comment on attachment 157881 Patch Clearing flags on attachment: 157881 Committed r125368: <http://trac.webkit.org/changeset/125368> 693218 5 webkit.review.bot 2012-08-12 03:39:39 -0700 All reviewed patches have been landed. Closing bug. 157881 2012-08-11 17:56:49 -0700 2012-08-12 03:39:35 -0700 Patch bug-93771-20120811175620.patch text/plain 1926 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkyOTMwMzkwNjQ4NDc3 OTU4ZGVkMmI0ZmY5NzFmMWJkZGRlYzdkNC4uY2U4MWNmNWRmODVkZThlNzU2NzdjN2FhMTQ0MWQ5 ZTE3N2U4MjQxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTExICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBNb3ZlIENTUydz IHByb3BlcnR5TmFtZVN0cmluZ3NbXSB0byBmcm9tIHRoZSBoZWFkZXIgdG8gdGhlIGNwcCBmaWxl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Mzc3MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBuYW1l cyBvZiBwcm9wZXJ0eU5hbWVTdHJpbmdzW10gc2hvdWxkIG5ldmVyIGJlIGFjY2Vzc2VkIGRpcmVj dGx5LiBUaGUgZnVuY3Rpb24gZ2V0UHJvcGVydHlOYW1lKCkKKyAgICAgICAgcmV0dXJuIHRoZSBj b3JyZWN0IHN0cmluZyBvZiBwcm9wZXJ0eU5hbWVTdHJpbmdzLgorCisgICAgICAgIFRvIGVuc3Vy ZSB0aGUgdmFsdWVzIGFyZSBub3QgYWNjZXNzZWQgYnkgbWlzdGFrZSwgbW92ZSB0aGVtIGZyb20g dGhlIGhlYWRlciB0byB0aGUgaW1wbGVtZW50YXRpb24uCisKKyAgICAgICAgKiBjc3MvbWFrZXBy b3AucGw6CisKIDIwMTItMDgtMTEgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5j b20+CiAKICAgICAgICAgRG8gdGhlIERlY2ltYWxOdW1iZXIgdG8gU3RyaW5nIGNvbnZlcnNpb24g b24gOCBiaXRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXByb3AucGwgYi9T b3VyY2UvV2ViQ29yZS9jc3MvbWFrZXByb3AucGwKaW5kZXggYTViZmIwNjQ5YjAxMzY1OWEzYTA0 OTM0MjRlYzdiMTQwMmYzYzY1Yi4uMTlmOWE0YzUxOWE0YTNjZTIzMjI3NWE1ZDJmOTU5N2Y0Njc1 OGU2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL21ha2Vwcm9wLnBsCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9tYWtlcHJvcC5wbApAQCAtNzMsNiArNzMsMTUgQEAgcHJpbnQgR1BF UkYgPDwgIkVPRiI7CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKIG5hbWVzcGFj ZSBXZWJDb3JlIHsKK0VPRgorCitwcmludCBHUEVSRiAiY29uc3QgY2hhciogY29uc3QgcHJvcGVy dHlOYW1lU3RyaW5nc1tudW1DU1NQcm9wZXJ0aWVzXSA9IHtcbiI7Citmb3JlYWNoIG15ICRuYW1l IChAbmFtZXMpIHsKKyAgcHJpbnQgR1BFUkYgIiAgICBcIiRuYW1lXCIsXG4iOworfQorcHJpbnQg R1BFUkYgIn07XG5cbiI7CisKK3ByaW50IEdQRVJGIDw8ICJFT0YiOwogJX0KICVzdHJ1Y3QtdHlw ZQogc3RydWN0IFByb3BlcnR5OwpAQCAtMTkwLDEyICsxOTksNiBAQCBwcmludCBIRUFERVIgImNv bnN0IGludCBudW1DU1NQcm9wZXJ0aWVzID0gJG51bTtcbiI7CiBwcmludCBIRUFERVIgImNvbnN0 IGludCBsYXN0Q1NTUHJvcGVydHkgPSAkbGFzdDtcbiI7CiBwcmludCBIRUFERVIgImNvbnN0IHNp emVfdCBtYXhDU1NQcm9wZXJ0eU5hbWVMZW5ndGggPSAkbWF4TGVuO1xuIjsKIAotcHJpbnQgSEVB REVSICJjb25zdCBjaGFyKiBjb25zdCBwcm9wZXJ0eU5hbWVTdHJpbmdzWyRudW1dID0ge1xuIjsK LWZvcmVhY2ggbXkgJG5hbWUgKEBuYW1lcykgewotICBwcmludCBIRUFERVIgIlwiJG5hbWVcIixc biI7Ci19Ci1wcmludCBIRUFERVIgIn07XG4iOwotCiBwcmludCBIRUFERVIgPDwgIkVPRiI7CiAK IGNvbnN0IGNoYXIqIGdldFByb3BlcnR5TmFtZShDU1NQcm9wZXJ0eUlEKTsK