93756 2012-08-10 16:55:23 -0700 AudioContext::createMediaStreamSource() must create a provider for local MediaStreams 2012-11-26 09:24:21 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers abarth eric.carlson feature-media-reviews s.choi tommyw webkit.review.bot oldest_to_newest 692974 0 crogers 2012-08-10 16:55:23 -0700 AudioContext::createMediaStreamSource() must create a provider for local MediaStreams 692979 1 157839 crogers 2012-08-10 17:03:16 -0700 Created attachment 157839 Patch 692984 2 157839 abarth 2012-08-10 17:16:59 -0700 Comment on attachment 157839 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157839&action=review > Source/WebCore/Modules/mediastream/MediaStream.h:59 > + virtual bool isLocal() const { return false; } These sorts of functions tend to point to design problems, but I don't know enough about media stream to be able to give you any useful advice. > Source/WebCore/Modules/mediastream/MediaStream.h:65 > - > + Why add trailing whitespace? > Source/WebCore/Modules/webaudio/AudioContext.cpp:400 > - > + ditto > Source/WebCore/Modules/webaudio/AudioContext.cpp:410 > + provider = 0; I'd just initialize the pointer to 0 so as to avoid having uninitialized memory. > Source/WebCore/Modules/webaudio/AudioContext.cpp:414 > + node->setFormat(2, sampleRate()); 2 -> magic constant? 692990 3 157844 crogers 2012-08-10 17:33:44 -0700 Created attachment 157844 Patch 693003 4 157844 eric.carlson 2012-08-10 18:07:48 -0700 Comment on attachment 157844 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157844&action=review > Source/WebCore/Modules/webaudio/AudioContext.cpp:414 > + node->setFormat(2, sampleRate()); Can a media stream only ever have two channels? A comment explaining why and/or a FIXME would be helpful. 693012 5 crogers 2012-08-10 18:40:32 -0700 (In reply to comment #4) > (From update of attachment 157844 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157844&action=review > > > Source/WebCore/Modules/webaudio/AudioContext.cpp:414 > > + node->setFormat(2, sampleRate()); > > Can a media stream only ever have two channels? A comment explaining why and/or a FIXME would be helpful. Eric, thanks for the quick review. I'll add a comment/FIXME explaining this. Similar to HTMLMediaElement, a MediaStream could have an audio track with 1,2, or more channels. So ultimately, we'll want this to be more flexible to handle multi-channel audio devices etc. I'm just in the very early stages of bringing this to life in our implementation, so am making some initial restrictions. 694134 6 crogers 2012-08-13 15:03:53 -0700 Committed r125456: <http://trac.webkit.org/changeset/125456> 157839 2012-08-10 17:03:16 -0700 2012-08-10 17:33:41 -0700 Patch bug-93756-20120810170247.patch text/plain 3981 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjg4OGE0MzA3ODcyM2Vm N2MxMjY5YzRmMTY1MjllNjk2MmZlZWI0OS4uOTA2MTk0YmI4ODhkZDE2ZDEzZTFjMjA5ZjVhYjY4 ZDhlNWRlMDMzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTEwICBDaHJp cyBSb2dlcnMgIDxjcm9nZXJzQGdvb2dsZS5jb20+CisKKyAgICAgICAgQXVkaW9Db250ZXh0Ojpj cmVhdGVNZWRpYVN0cmVhbVNvdXJjZSgpIG11c3QgY3JlYXRlIGEgcHJvdmlkZXIgZm9yIGxvY2Fs IE1lZGlhU3RyZWFtcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTM3NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGVyZSBhcmUgdHdvIG1haW4ga2luZHMgb2YgTWVkaWFTdHJlYW1zIChsb2NhbCBhbmQg ZnJvbSByZW1vdGUgcGVlcnMpLgorICAgICAgICBJbnRlcm5hbGx5IHdlIG5lZWQgdG8ga25vdyB0 aGUgZGlmZmVyZW5jZSBzbyBhIE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlIHdpbGwgImp1c3Qg d29yayIuCisKKyAgICAgICAgVGVzdGVkIGJ5IGV4aXN0aW5nIHRlc3Q6IG1lZGlhc3RyZWFtYXVk aW9zb3VyY2Vub2RlLmh0bWwKKyAgICAgICAgRnVsbCB0ZXN0aW5nIGNhbiBvbmx5IGJlIHZlcmlm aWVkIGJ5IG1hbnVhbCB0ZXN0cy4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vTG9j YWxNZWRpYVN0cmVhbS5oOgorICAgICAgICAoTG9jYWxNZWRpYVN0cmVhbSk6CisgICAgICAgICog TW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS5oOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFTdHJlYW06OmlzTG9jYWwpOgorICAgICAgICAoTWVkaWFTdHJlYW0pOgorICAgICAgICAqIE1v ZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlv Q29udGV4dDo6Y3JlYXRlTWVkaWFTdHJlYW1Tb3VyY2UpOgorCiAyMDEyLTA4LTEwICBBbGxhbiBT YW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgogCiAgICAgICAgIFtUcmFu c2Zvcm1zXSBIaXQgdGVzdCBpc3N1ZSB3aXRoIGxhcmdlIHNjYWxlKCkgdHJhbnNmb3JtCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL0xvY2FsTWVkaWFTdHJl YW0uaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTG9jYWxNZWRpYVN0cmVh bS5oCmluZGV4IGU3NmQ0MzRmMTI1OGNjZThmYzA2YmMyNzNiNDQxMGY5ZjdhZWJhNDEuLjdjNDgx MDdiMTFiYzRlOTcyZDkzMTE3MTliOWIzYTYwMmQwNWUwZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTG9jYWxNZWRpYVN0cmVhbS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTG9jYWxNZWRpYVN0cmVhbS5oCkBAIC00MCw2 ICs0MCw5IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc3RvcCgpOwogCisgICAgLy8gTWVkaWFTdHJl YW0KKyAgICB2aXJ0dWFsIGJvb2wgaXNMb2NhbCgpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIHRy dWU7IH0KKwogICAgIC8vIEV2ZW50VGFyZ2V0CiAgICAgdmlydHVhbCBjb25zdCBBdG9taWNTdHJp bmcmIGludGVyZmFjZU5hbWUoKSBjb25zdCBPVkVSUklERTsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS5oIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS5oCmluZGV4IGJjZGQyNWRjNTRmYjAw MmQzOTc3NWIyNTY2NmU4N2ZkMWQyNjg2MzkuLjFlNDIwMGI2ODk0NzIyOTlhYThkY2JlZjljYzEx NGQ5ZjM2MTYwYzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJl YW0vTWVkaWFTdHJlYW0uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFt L01lZGlhU3RyZWFtLmgKQEAgLTU2LDExICs1NiwxMyBAQCBwdWJsaWM6CiAgICAgTWVkaWFTdHJl YW1UcmFja0xpc3QqIGF1ZGlvVHJhY2tzKCkgeyByZXR1cm4gbV9hdWRpb1RyYWNrcy5nZXQoKTsg fQogICAgIE1lZGlhU3RyZWFtVHJhY2tMaXN0KiB2aWRlb1RyYWNrcygpIHsgcmV0dXJuIG1fdmlk ZW9UcmFja3MuZ2V0KCk7IH0KIAorICAgIHZpcnR1YWwgYm9vbCBpc0xvY2FsKCkgY29uc3QgeyBy ZXR1cm4gZmFsc2U7IH0KKwogICAgIC8vIE1lZGlhU3RyZWFtRGVzY3JpcHRvck93bmVyCiAgICAg dmlydHVhbCB2b2lkIHN0cmVhbUVuZGVkKCkgT1ZFUlJJREU7CiAKICAgICBNZWRpYVN0cmVhbURl c2NyaXB0b3IqIGRlc2NyaXB0b3IoKSBjb25zdCB7IHJldHVybiBtX2Rlc2NyaXB0b3IuZ2V0KCk7 IH0KLQorICAgIAogICAgIC8vIEV2ZW50VGFyZ2V0CiAgICAgdmlydHVhbCBjb25zdCBBdG9taWNT dHJpbmcmIGludGVyZmFjZU5hbWUoKSBjb25zdCBPVkVSUklERTsKICAgICB2aXJ0dWFsIFNjcmlw dEV4ZWN1dGlvbkNvbnRleHQqIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSBjb25zdCBPVkVSUklE RTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250 ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNw cAppbmRleCBhYjhlMTcyMjg1MmUxMDVjNWIyMDUyZTUwMmY2OTk4NTY4M2Q5ZDhkLi4wNDQ1MjMy ODNiZWUzODNkM2I3YTA3ZGNhMWNmMTZkNDkzMWY4ODVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCkBAIC0zOTcsMTIgKzM5NywyMSBA QCBQYXNzUmVmUHRyPE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlPiBBdWRpb0NvbnRleHQ6OmNy ZWF0ZU1lZGlhU3RyZWFtU291cmNlKE1lZAogICAgICAgICBlYyA9IElOVkFMSURfU1RBVEVfRVJS OwogICAgICAgICByZXR1cm4gMDsKICAgICB9Ci0KKyAgICAKICAgICBBU1NFUlQoaXNNYWluVGhy ZWFkKCkpOwogICAgIGxhenlJbml0aWFsaXplKCk7CiAKLSAgICAvLyBGSVhNRTogRm9yIG5vdyB3 ZSBkb24ndCBnaXZlIGl0IGFuIEF1ZGlvU291cmNlUHJvdmlkZXIsIHNvIGl0IHdpbGwgb3V0cHV0 IHNpbGVuY2UuCi0gICAgUmVmUHRyPE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlPiBub2RlID0g TWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGU6OmNyZWF0ZSh0aGlzLCBtZWRpYVN0cmVhbSwgMCk7 CisgICAgQXVkaW9Tb3VyY2VQcm92aWRlciogcHJvdmlkZXI7CisKKyAgICBpZiAobWVkaWFTdHJl YW0tPmlzTG9jYWwoKSAmJiBtZWRpYVN0cmVhbS0+YXVkaW9UcmFja3MoKS0+bGVuZ3RoKCkpCisg ICAgICAgIHByb3ZpZGVyID0gZGVzdGluYXRpb24oKS0+bG9jYWxBdWRpb0lucHV0UHJvdmlkZXIo KTsKKyAgICBlbHNlIHsKKyAgICAgICAgLy8gRklYTUU6IGdldCBhIHByb3ZpZGVyIGZvciBub24t bG9jYWwgTWVkaWFTdHJlYW1zIChsaWtlIGZyb20gYSByZW1vdGUgcGVlcikuCisgICAgICAgIHBy b3ZpZGVyID0gMDsKKyAgICB9CisgICAgCisgICAgUmVmUHRyPE1lZGlhU3RyZWFtQXVkaW9Tb3Vy Y2VOb2RlPiBub2RlID0gTWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGU6OmNyZWF0ZSh0aGlzLCBt ZWRpYVN0cmVhbSwgcHJvdmlkZXIpOworICAgIG5vZGUtPnNldEZvcm1hdCgyLCBzYW1wbGVSYXRl KCkpOwogCiAgICAgcmVmTm9kZShub2RlLmdldCgpKTsgLy8gY29udGV4dCBrZWVwcyByZWZlcmVu Y2UgdW50aWwgbm9kZSBpcyBkaXNjb25uZWN0ZWQKICAgICByZXR1cm4gbm9kZTsK 157844 2012-08-10 17:33:44 -0700 2012-08-10 18:07:47 -0700 Patch bug-93756-20120810173314.patch text/plain 3662 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjg4OGE0MzA3ODcyM2Vm N2MxMjY5YzRmMTY1MjllNjk2MmZlZWI0OS4uOTA2MTk0YmI4ODhkZDE2ZDEzZTFjMjA5ZjVhYjY4 ZDhlNWRlMDMzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTEwICBDaHJp cyBSb2dlcnMgIDxjcm9nZXJzQGdvb2dsZS5jb20+CisKKyAgICAgICAgQXVkaW9Db250ZXh0Ojpj cmVhdGVNZWRpYVN0cmVhbVNvdXJjZSgpIG11c3QgY3JlYXRlIGEgcHJvdmlkZXIgZm9yIGxvY2Fs IE1lZGlhU3RyZWFtcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTM3NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGVyZSBhcmUgdHdvIG1haW4ga2luZHMgb2YgTWVkaWFTdHJlYW1zIChsb2NhbCBhbmQg ZnJvbSByZW1vdGUgcGVlcnMpLgorICAgICAgICBJbnRlcm5hbGx5IHdlIG5lZWQgdG8ga25vdyB0 aGUgZGlmZmVyZW5jZSBzbyBhIE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlIHdpbGwgImp1c3Qg d29yayIuCisKKyAgICAgICAgVGVzdGVkIGJ5IGV4aXN0aW5nIHRlc3Q6IG1lZGlhc3RyZWFtYXVk aW9zb3VyY2Vub2RlLmh0bWwKKyAgICAgICAgRnVsbCB0ZXN0aW5nIGNhbiBvbmx5IGJlIHZlcmlm aWVkIGJ5IG1hbnVhbCB0ZXN0cy4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vTG9j YWxNZWRpYVN0cmVhbS5oOgorICAgICAgICAoTG9jYWxNZWRpYVN0cmVhbSk6CisgICAgICAgICog TW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS5oOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFTdHJlYW06OmlzTG9jYWwpOgorICAgICAgICAoTWVkaWFTdHJlYW0pOgorICAgICAgICAqIE1v ZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlv Q29udGV4dDo6Y3JlYXRlTWVkaWFTdHJlYW1Tb3VyY2UpOgorCiAyMDEyLTA4LTEwICBBbGxhbiBT YW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgogCiAgICAgICAgIFtUcmFu c2Zvcm1zXSBIaXQgdGVzdCBpc3N1ZSB3aXRoIGxhcmdlIHNjYWxlKCkgdHJhbnNmb3JtCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL0xvY2FsTWVkaWFTdHJl YW0uaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTG9jYWxNZWRpYVN0cmVh bS5oCmluZGV4IGU3NmQ0MzRmMTI1OGNjZThmYzA2YmMyNzNiNDQxMGY5ZjdhZWJhNDEuLjdjNDgx MDdiMTFiYzRlOTcyZDkzMTE3MTliOWIzYTYwMmQwNWUwZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTG9jYWxNZWRpYVN0cmVhbS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTG9jYWxNZWRpYVN0cmVhbS5oCkBAIC00MCw2 ICs0MCw5IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc3RvcCgpOwogCisgICAgLy8gTWVkaWFTdHJl YW0KKyAgICB2aXJ0dWFsIGJvb2wgaXNMb2NhbCgpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIHRy dWU7IH0KKwogICAgIC8vIEV2ZW50VGFyZ2V0CiAgICAgdmlydHVhbCBjb25zdCBBdG9taWNTdHJp bmcmIGludGVyZmFjZU5hbWUoKSBjb25zdCBPVkVSUklERTsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS5oIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS5oCmluZGV4IGJjZGQyNWRjNTRmYjAw MmQzOTc3NWIyNTY2NmU4N2ZkMWQyNjg2MzkuLmZjOGQ2Njc5ZWM2N2Y5MjJmZTVmMjJlZjkyOTZh MzYxNTdjMTI3NzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJl YW0vTWVkaWFTdHJlYW0uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFt L01lZGlhU3RyZWFtLmgKQEAgLTU2LDYgKzU2LDggQEAgcHVibGljOgogICAgIE1lZGlhU3RyZWFt VHJhY2tMaXN0KiBhdWRpb1RyYWNrcygpIHsgcmV0dXJuIG1fYXVkaW9UcmFja3MuZ2V0KCk7IH0K ICAgICBNZWRpYVN0cmVhbVRyYWNrTGlzdCogdmlkZW9UcmFja3MoKSB7IHJldHVybiBtX3ZpZGVv VHJhY2tzLmdldCgpOyB9CiAKKyAgICB2aXJ0dWFsIGJvb2wgaXNMb2NhbCgpIGNvbnN0IHsgcmV0 dXJuIGZhbHNlOyB9CisKICAgICAvLyBNZWRpYVN0cmVhbURlc2NyaXB0b3JPd25lcgogICAgIHZp cnR1YWwgdm9pZCBzdHJlYW1FbmRlZCgpIE9WRVJSSURFOwogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5jcHAKaW5kZXggYWI4ZTE3MjI4NTJlMTA1 YzViMjA1MmU1MDJmNjk5ODU2ODNkOWQ4ZC4uZGM2ODdkODIyMjY4NjE0NTlhYTc2ZjZjMjUzMjA5 M2IyNmI1NGFmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9B dWRpb0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVk aW9Db250ZXh0LmNwcApAQCAtNDAxLDggKzQwMSwxNyBAQCBQYXNzUmVmUHRyPE1lZGlhU3RyZWFt QXVkaW9Tb3VyY2VOb2RlPiBBdWRpb0NvbnRleHQ6OmNyZWF0ZU1lZGlhU3RyZWFtU291cmNlKE1l ZAogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CiAgICAgbGF6eUluaXRpYWxpemUoKTsKIAot ICAgIC8vIEZJWE1FOiBGb3Igbm93IHdlIGRvbid0IGdpdmUgaXQgYW4gQXVkaW9Tb3VyY2VQcm92 aWRlciwgc28gaXQgd2lsbCBvdXRwdXQgc2lsZW5jZS4KLSAgICBSZWZQdHI8TWVkaWFTdHJlYW1B dWRpb1NvdXJjZU5vZGU+IG5vZGUgPSBNZWRpYVN0cmVhbUF1ZGlvU291cmNlTm9kZTo6Y3JlYXRl KHRoaXMsIG1lZGlhU3RyZWFtLCAwKTsKKyAgICBBdWRpb1NvdXJjZVByb3ZpZGVyKiBwcm92aWRl ciA9IDA7CisKKyAgICBpZiAobWVkaWFTdHJlYW0tPmlzTG9jYWwoKSAmJiBtZWRpYVN0cmVhbS0+ YXVkaW9UcmFja3MoKS0+bGVuZ3RoKCkpCisgICAgICAgIHByb3ZpZGVyID0gZGVzdGluYXRpb24o KS0+bG9jYWxBdWRpb0lucHV0UHJvdmlkZXIoKTsKKyAgICBlbHNlIHsKKyAgICAgICAgLy8gRklY TUU6IGdldCBhIHByb3ZpZGVyIGZvciBub24tbG9jYWwgTWVkaWFTdHJlYW1zIChsaWtlIGZyb20g YSByZW1vdGUgcGVlcikuCisgICAgICAgIHByb3ZpZGVyID0gMDsKKyAgICB9CisKKyAgICBSZWZQ dHI8TWVkaWFTdHJlYW1BdWRpb1NvdXJjZU5vZGU+IG5vZGUgPSBNZWRpYVN0cmVhbUF1ZGlvU291 cmNlTm9kZTo6Y3JlYXRlKHRoaXMsIG1lZGlhU3RyZWFtLCBwcm92aWRlcik7CisgICAgbm9kZS0+ c2V0Rm9ybWF0KDIsIHNhbXBsZVJhdGUoKSk7CiAKICAgICByZWZOb2RlKG5vZGUuZ2V0KCkpOyAv LyBjb250ZXh0IGtlZXBzIHJlZmVyZW5jZSB1bnRpbCBub2RlIGlzIGRpc2Nvbm5lY3RlZAogICAg IHJldHVybiBub2RlOwo=