93745 2012-08-10 14:45:48 -0700 no timeupdate events emitted for media controller 2012-08-10 16:50:58 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble eric.carlson feature-media-reviews webkit.review.bot oldest_to_newest 692888 0 jer.noble 2012-08-10 14:45:48 -0700 no timeupdate events emitted for media controller 692892 1 jer.noble 2012-08-10 14:47:10 -0700 <rdar://problem/11753267> 692896 2 jer.noble 2012-08-10 14:49:39 -0700 <rdar://problem/11753267> 692942 3 157828 jer.noble 2012-08-10 16:04:12 -0700 Created attachment 157828 Patch 692945 4 157828 eric.carlson 2012-08-10 16:11:03 -0700 Comment on attachment 157828 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157828&action=review > Source/WebCore/ChangeLog:13 > + Enforce the spec requirement that the timeupdate event is fired no more often > + than every 250ms. Doesn't it say to fire them *at least* every 250ms? > Source/WebCore/ChangeLog:17 > + Add a periodic firing timer to generat timeupdate events during playback. Nit: "generat" -> "generate" > Source/WebCore/ChangeLog:25 > + (MediaController::updatePlaybackState): Start and ntop the timeupdate timer. Nit: "ntop" -> "stop" 692954 5 jer.noble 2012-08-10 16:28:33 -0700 (In reply to comment #4) > (From update of attachment 157828 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157828&action=review > > > Source/WebCore/ChangeLog:13 > > + Enforce the spec requirement that the timeupdate event is fired no more often > > + than every 250ms. > > Doesn't it say to fire them *at least* every 250ms? Well, sort of. It actually says: "Every 15 to 250ms, or whenever the MediaController's media controller position changes, whichever happens least often, the user agent must queue a task to fire a simple event named timeupdate at the MediaController." So, no more often than "15 to 250ms", but no less often than "15 to 250ms". > > Source/WebCore/ChangeLog:17 > > + Add a periodic firing timer to generat timeupdate events during playback. > > Nit: "generat" -> "generate" Fixed. > > Source/WebCore/ChangeLog:25 > > + (MediaController::updatePlaybackState): Start and ntop the timeupdate timer. > > Nit: "ntop" -> "stop" Fixed. 692969 6 jer.noble 2012-08-10 16:50:58 -0700 Committed r125337: <http://trac.webkit.org/changeset/125337> 157828 2012-08-10 16:04:12 -0700 2012-08-10 16:11:03 -0700 Patch bug-93745-20120810160344.patch text/plain 7057 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjcxOTI2ZDA5N2IzY2Qx ZGYzZGUxMmFkZmExYzI2YTg4NGY3ZDZkMy4uNGIwOTYwMzdjNGI5MTI3OWJkZDRlMjMxYzA3ZWVl YzM3MzMzMjdjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDEyLTA4LTEwICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIG5vIHRpbWV1cGRhdGUgZXZl bnRzIGVtaXR0ZWQgZm9yIG1lZGlhIGNvbnRyb2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNzQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgR2VuZXJhdGUgdGltZXVwZGF0ZSBldmVudHMgd2hpbGUg dGhlIGN1cnJlbnQgcG9zaXRpb24gaXMgY2hhbmdpbmcuCisKKyAgICAgICAgVGVzdDogbWVkaWEv bWVkaWEtY29udHJvbGxlci10aW1ldXBkYXRlLmh0bWwKKworICAgICAgICBFbmZvcmNlIHRoZSBz cGVjIHJlcXVpcmVtZW50IHRoYXQgdGhlIHRpbWV1cGRhdGUgZXZlbnQgaXMgZmlyZWQgbm8gbW9y ZSBvZnRlbgorICAgICAgICB0aGFuIGV2ZXJ5IDI1MG1zLgorICAgICAgICAqIGh0bWwvTWVkaWFD b250cm9sbGVyLmNwcDoKKyAgICAgICAgKE1lZGlhQ29udHJvbGxlcjo6c2NoZWR1bGVUaW1ldXBk YXRlRXZlbnQpOgorCisgICAgICAgIEFkZCBhIHBlcmlvZGljIGZpcmluZyB0aW1lciB0byBnZW5l cmF0IHRpbWV1cGRhdGUgZXZlbnRzIGR1cmluZyBwbGF5YmFjay4KKyAgICAgICAgKiBodG1sL01l ZGlhQ29udHJvbGxlci5jcHA6CisgICAgICAgIChNZWRpYUNvbnRyb2xsZXI6OnN0YXJ0VGltZXVw ZGF0ZVRpbWVyKToKKyAgICAgICAgKE1lZGlhQ29udHJvbGxlcjo6dGltZXVwZGF0ZVRpbWVyRmly ZWQpOgorCisgICAgICAgICogaHRtbC9NZWRpYUNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoTWVk aWFDb250cm9sbGVyOjpNZWRpYUNvbnRyb2xsZXIpOiBJbml0aWFsaXplIG1fcHJldmlvdXNUaW1l dXBkYXRlVGltZS4KKyAgICAgICAgKE1lZGlhQ29udHJvbGxlcjo6c2V0Q3VycmVudFRpbWUpOiBD YWxsIHNjaGVkdWxlVGltZVVwZGF0ZUV2ZW50LgorICAgICAgICAoTWVkaWFDb250cm9sbGVyOjp1 cGRhdGVQbGF5YmFja1N0YXRlKTogU3RhcnQgYW5kIG50b3AgdGhlIHRpbWV1cGRhdGUgdGltZXIu CisgICAgICAgICogaHRtbC9NZWRpYUNvbnRyb2xsZXIuaDoKKyAgICAgICAgCiAyMDEyLTA4LTA5 ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSB0aGUgbmV3 IEFWUGxheWVySXRlbVZpZGVvT3V0cHV0IEFQSSBpbiBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5k YXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhQ29udHJvbGxlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhQ29udHJvbGxlci5jcHAKaW5kZXggMzlmZDA5 ZDRjZTJmNDQ3OGVhZmFmMTlmYTY1ZTRiZTk2N2EwOTFmZC4uZDM4ZjlkZGRhNzBjZGMyMDczMGM0 M2UxYmI2ZTQwNjE3Y2ZiZGFiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9NZWRp YUNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFDb250cm9sbGVy LmNwcApAQCAtNTYsNiArNTYsOCBAQCBNZWRpYUNvbnRyb2xsZXI6Ok1lZGlhQ29udHJvbGxlcihT Y3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0KQogICAgICwgbV9jbG9zZWRDYXB0aW9uc1Zp c2libGUoZmFsc2UpCiAgICAgLCBtX2Nsb2NrKENsb2NrOjpjcmVhdGUoKSkKICAgICAsIG1fc2Ny aXB0RXhlY3V0aW9uQ29udGV4dChjb250ZXh0KQorICAgICwgbV90aW1ldXBkYXRlVGltZXIodGhp cywgJk1lZGlhQ29udHJvbGxlcjo6dGltZXVwZGF0ZVRpbWVyRmlyZWQpCisgICAgLCBtX3ByZXZp b3VzVGltZXVwZGF0ZVRpbWUoMCkKIHsKIH0KIApAQCAtMTcxLDYgKzE3Myw4IEBAIHZvaWQgTWVk aWFDb250cm9sbGVyOjpzZXRDdXJyZW50VGltZShmbG9hdCB0aW1lLCBFeGNlcHRpb25Db2RlJiBj b2RlKQogICAgIC8vIFNlZWsgZWFjaCBzbGF2ZWQgbWVkaWEgZWxlbWVudCB0byB0aGUgbmV3IHBs YXliYWNrIHBvc2l0aW9uIHJlbGF0aXZlIHRvIHRoZSBtZWRpYSBlbGVtZW50IHRpbWVsaW5lLgog ICAgIGZvciAoc2l6ZV90IGluZGV4ID0gMDsgaW5kZXggPCBtX21lZGlhRWxlbWVudHMuc2l6ZSgp OyArK2luZGV4KQogICAgICAgICBtX21lZGlhRWxlbWVudHNbaW5kZXhdLT5zZWVrKHRpbWUsIGNv ZGUpOworCisgICAgc2NoZWR1bGVUaW1ldXBkYXRlRXZlbnQoKTsKIH0KIAogdm9pZCBNZWRpYUNv bnRyb2xsZXI6OnBsYXkoKQpAQCAtMzk1LDE0ICszOTksMTcgQEAgdm9pZCBNZWRpYUNvbnRyb2xs ZXI6OnVwZGF0ZVBsYXliYWNrU3RhdGUoKQogICAgIGNhc2UgV0FJVElORzoKICAgICAgICAgZXZl bnROYW1lID0gZXZlbnROYW1lcygpLndhaXRpbmdFdmVudDsKICAgICAgICAgbV9jbG9jay0+c3Rv cCgpOworICAgICAgICBtX3RpbWV1cGRhdGVUaW1lci5zdG9wKCk7CiAgICAgICAgIGJyZWFrOwog ICAgIGNhc2UgRU5ERUQ6CiAgICAgICAgIGV2ZW50TmFtZSA9IGV2ZW50TmFtZXMoKS5lbmRlZEV2 ZW50OwogICAgICAgICBtX2Nsb2NrLT5zdG9wKCk7CisgICAgICAgIG1fdGltZXVwZGF0ZVRpbWVy LnN0b3AoKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBQTEFZSU5HOgogICAgICAgICBldmVu dE5hbWUgPSBldmVudE5hbWVzKCkucGxheWluZ0V2ZW50OwogICAgICAgICBtX2Nsb2NrLT5zdGFy dCgpOworICAgICAgICBzdGFydFRpbWV1cGRhdGVUaW1lcigpOwogICAgICAgICBicmVhazsKICAg ICBkZWZhdWx0OgogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKQEAgLTYwNSw0ICs2MTIs MzMgQEAgY29uc3QgQXRvbWljU3RyaW5nJiBNZWRpYUNvbnRyb2xsZXI6OmludGVyZmFjZU5hbWUo KSBjb25zdAogICAgIHJldHVybiBldmVudE5hbWVzKCkuaW50ZXJmYWNlRm9yTWVkaWFDb250cm9s bGVyOwogfQogCisvLyBUaGUgc3BlYyBzYXlzIHRvIGZpcmUgcGVyaW9kaWMgdGltZXVwZGF0ZSBl dmVudHMgKHRob3NlIHNlbnQgd2hpbGUgcGxheWluZykgZXZlcnkKKy8vICIxNSB0byAyNTBtcyIs IHdlIGNob29zZSB0aGUgc2xvd2VzdCBmcmVxdWVuY3kKK3N0YXRpYyBjb25zdCBkb3VibGUgbWF4 VGltZXVwZGF0ZUV2ZW50RnJlcXVlbmN5ID0gMC4yNTsKKwordm9pZCBNZWRpYUNvbnRyb2xsZXI6 OnN0YXJ0VGltZXVwZGF0ZVRpbWVyKCkKK3sKKyAgICBpZiAobV90aW1ldXBkYXRlVGltZXIuaXNB Y3RpdmUoKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgbV90aW1ldXBkYXRlVGltZXIuc3RhcnRS ZXBlYXRpbmcobWF4VGltZXVwZGF0ZUV2ZW50RnJlcXVlbmN5KTsKK30KKwordm9pZCBNZWRpYUNv bnRyb2xsZXI6OnRpbWV1cGRhdGVUaW1lckZpcmVkKFRpbWVyPE1lZGlhQ29udHJvbGxlcj4qKQor eworICAgIHNjaGVkdWxlVGltZXVwZGF0ZUV2ZW50KCk7Cit9CisKK3ZvaWQgTWVkaWFDb250cm9s bGVyOjpzY2hlZHVsZVRpbWV1cGRhdGVFdmVudCgpCit7CisgICAgZG91YmxlIG5vdyA9IFdURjo6 Y3VycmVudFRpbWUoKTsKKyAgICBkb3VibGUgdGltZWRlbHRhID0gbm93IC0gbV9wcmV2aW91c1Rp bWV1cGRhdGVUaW1lOworCisgICAgaWYgKHRpbWVkZWx0YSA8IG1heFRpbWV1cGRhdGVFdmVudEZy ZXF1ZW5jeSkKKyAgICAgICAgcmV0dXJuOworCisgICAgc2NoZWR1bGVFdmVudChldmVudE5hbWVz KCkudGltZXVwZGF0ZUV2ZW50KTsKKyAgICBtX3ByZXZpb3VzVGltZXVwZGF0ZVRpbWUgPSBub3c7 Cit9CisKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYUNvbnRy b2xsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFDb250cm9sbGVyLmgKaW5kZXggZDMy YjcxMjc5NjFhZmRjYzA4MWQ1OTRmZWMyYmM4NzkzODM4NGQxZi4uZDI5M2NjYjFkZjEyM2JlNzRm NGJhODlkODM3NzRiNDlkY2JjMzE1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9N ZWRpYUNvbnRyb2xsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhQ29udHJvbGxl ci5oCkBAIC0xMjUsNiArMTI1LDkgQEAgcHJpdmF0ZToKICAgICB2b2lkIGFzeW5jRXZlbnRUaW1l ckZpcmVkKFRpbWVyPE1lZGlhQ29udHJvbGxlcj4qKTsKICAgICB2b2lkIGNsZWFyUG9zaXRpb25U aW1lckZpcmVkKFRpbWVyPE1lZGlhQ29udHJvbGxlcj4qKTsKICAgICBib29sIGhhc0VuZGVkKCkg Y29uc3Q7CisgICAgdm9pZCBzY2hlZHVsZVRpbWV1cGRhdGVFdmVudCgpOworICAgIHZvaWQgdGlt ZXVwZGF0ZVRpbWVyRmlyZWQoVGltZXI8TWVkaWFDb250cm9sbGVyPiopOworICAgIHZvaWQgc3Rh cnRUaW1ldXBkYXRlVGltZXIoKTsKIAogICAgIC8vIEV2ZW50VGFyZ2V0CiAgICAgdmlydHVhbCB2 b2lkIHJlZkV2ZW50VGFyZ2V0KCkgeyByZWYoKTsgfQpAQCAtMTUyLDYgKzE1NSw4IEBAIHByaXZh dGU6CiAgICAgYm9vbCBtX2Nsb3NlZENhcHRpb25zVmlzaWJsZTsKICAgICBQYXNzUmVmUHRyPENs b2NrPiBtX2Nsb2NrOwogICAgIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIG1fc2NyaXB0RXhlY3V0 aW9uQ29udGV4dDsKKyAgICBUaW1lcjxNZWRpYUNvbnRyb2xsZXI+IG1fdGltZXVwZGF0ZVRpbWVy OworICAgIGRvdWJsZSBtX3ByZXZpb3VzVGltZXVwZGF0ZVRpbWU7CiB9OwogCiB9IC8vIG5hbWVz cGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2RmYjBjYTRlOWY5NmYyYTQ4NWI3NzNhY2M1YmVmZmY2NDky NjMyYS4uYzUyNWQ3MzM5ZjgzZDMxNTZmNmEyN2Q1NjM2ZGUzYzYxOTA5NWU5MCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDEyLTA4LTEwICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29t PgorCisgICAgICAgIG5vIHRpbWV1cGRhdGUgZXZlbnRzIGVtaXR0ZWQgZm9yIG1lZGlhIGNvbnRy b2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkz NzQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmV3 IHRlc3QgY2hlY2tpbmcgdGhhdCB0aGUgdGltZXVwZGF0ZSBldmVudCBpcyBlbW1pdHRlZCBjb3Jy ZWN0bHkgZHVyaW5nIHBsYXliYWNrLgorCisgICAgICAgICogbWVkaWEvbWVkaWEtY29udHJvbGxl ci10aW1ldXBkYXRlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogbWVkaWEvbWVkaWEt Y29udHJvbGxlci10aW1ldXBkYXRlLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA4LTEwICBaYW4gRG9i ZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBHVEsg Z2FyZGVuaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtY29udHJvbGxl ci10aW1ldXBkYXRlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL21lZGlhL21lZGlhLWNvbnRy b2xsZXItdGltZXVwZGF0ZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYjIyMTAwNzkzZjkzMDQx NWM2NjdiZDNmMTQzN2VhMWQ3N2I3ZmM4OAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L21lZGlhL21lZGlhLWNvbnRyb2xsZXItdGltZXVwZGF0ZS1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSw1IEBACitFVkVOVChjYW5wbGF5KQorUlVOKHZpZGVvLnBsYXkpCitFVkVOVCh0aW1ldXBkYXRl KQorRU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtY29u dHJvbGxlci10aW1ldXBkYXRlLmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1jb250cm9s bGVyLXRpbWV1cGRhdGUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lNzI5MmVlNzQ3MjY3NDMwZTE5Yzc0ZmI1 MzI2Y2IzZjIyOWE2OGJjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvbWVk aWEtY29udHJvbGxlci10aW1ldXBkYXRlLmh0bWwKQEAgLTAsMCArMSwyOCBAQAorPCFET0NUWVBF IGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorICAgIDx0aXRsZT5NZWRpYUNvbnRyb2xsZXIgLSB0aW1l dXBkYXRlIHRlc3Q8L3RpdGxlPgorICAgIDxzY3JpcHQgc3JjPXZpZGVvLXRlc3QuanM+PC9zY3Jp cHQ+CisgICAgPHNjcmlwdCBzcmM9bWVkaWEtZmlsZS5qcz48L3NjcmlwdD4KKyAgICA8c2NyaXB0 PgorICAgICAgICB2YXIgdmlkZW87CisKKyAgICAgICAgdmFyIHN0YXJ0ID0gZnVuY3Rpb24oKSB7 CisgICAgICAgICAgICBmaW5kTWVkaWFFbGVtZW50KCk7CisgICAgICAgICAgICAKKyAgICAgICAg ICAgIHdhaXRGb3JFdmVudCgnY2FucGxheScsIGNhbnBsYXkpOworICAgICAgICAgICAgdmlkZW8u c3JjID0gZmluZE1lZGlhRmlsZSgidmlkZW8iLCAiY29udGVudC90ZXN0Iik7CisgICAgICAgIH07 CisgICAgICAgIAorICAgICAgICB2YXIgY2FucGxheSA9IGZ1bmN0aW9uKCkgeworICAgICAgICAg ICAgd2FpdEZvckV2ZW50QW5kRW5kKCd0aW1ldXBkYXRlJyk7CisgICAgICAgICAgICBydW4oJ3Zp ZGVvLnBsYXknKTsKKyAgICAgICAgfTsKKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5Pgor ICAgIDxib2R5IG9ubG9hZD0ic3RhcnQoKSI+CisgICAgICAgIDx2aWRlbyBpZD0idmlkZW8iIG1l ZGlhR3JvdXA9Imdyb3VwIiBjb250cm9scyBhdXRvcGxheT48L3ZpZGVvPgorICAgIDwvYm9keT4K KzwvYm9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==