93741 2012-08-10 13:46:42 -0700 Layout Test: plugins/nested-plugin-objects.html passes but causes subsequent test to fail on Windows, adding to skip list. 2012-08-10 19:20:51 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Windows 7 RESOLVED FIXED LayoutTestFailure P2 Normal --- 1 roger_fong roger_fong thorton tony webkit.review.bot oldest_to_newest 692858 0 roger_fong 2012-08-10 13:46:42 -0700 plugins/nested-plugin-objects.html passes but causes subsequent test to fail on Windows, like plugins/netscape-dom-access-and-reload.html or if I skip that test, then plugins/netscape-dom-access.html (the next test in the list) 692859 1 roger_fong 2012-08-10 13:47:15 -0700 Adding plugins/nested-plugin-objects.html to Windows skip list 692866 2 157806 roger_fong 2012-08-10 14:03:17 -0700 Created attachment 157806 patch 692881 3 157810 roger_fong 2012-08-10 14:31:49 -0700 Created attachment 157810 re-patch 692920 4 157821 roger_fong 2012-08-10 15:32:29 -0700 Created attachment 157821 Test-I changed nothing 692921 5 roger_fong 2012-08-10 15:33:20 -0700 What is wrong with this silly patch... I've updated my own code and then applied my own patch manually and everything is perfectly fine... Trying once more... 692982 6 157841 roger_fong 2012-08-10 17:12:57 -0700 Created attachment 157841 no comment 692983 7 157841 thorton 2012-08-10 17:15:38 -0700 Comment on attachment 157841 no comment Phew! 693029 8 157841 webkit.review.bot 2012-08-10 19:20:47 -0700 Comment on attachment 157841 no comment Clearing flags on attachment: 157841 Committed r125347: <http://trac.webkit.org/changeset/125347> 693030 9 webkit.review.bot 2012-08-10 19:20:51 -0700 All reviewed patches have been landed. Closing bug. 157806 2012-08-10 14:03:17 -0700 2012-08-10 14:31:49 -0700 patch 93741_patch.txt text/plain 1419 roger_fong SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNTMyMykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTEwICBSb2dlciBGb25nICA8cm9n ZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3Q6IHBsdWdpbnMvbmVzdGVk LXBsdWdpbi1vYmplY3RzLmh0bWwgcGFzc2VzIGJ1dCBjYXVzZXMgc3Vic2VxdWVudCB0ZXN0IHRv IGZhaWwgb24gV2luZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkzNzQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgcGx1Z2lucy9uZXN0ZWQtcGx1Z2luLW9iamVjdHMuaHRtbCBwYXNzZXMgYnV0IGNh dXNlcyBzdWJzZXF1ZW50IHRlc3QgdG8gZmFpbCBvbiBXaW5kb3dzLgorICAgICAgICBwbHVnaW5z L25ldHNjYXBlLWRvbS1hY2Nlc3MtYW5kLXJlbG9hZC5odG1sIGZhaWxzIGFzIGEgcmVzdWx0Lgor ICAgICAgICBPciBpZiBJIHNraXAgdGhhdCB0ZXN0LCB0aGVuIHBsdWdpbnMvbmV0c2NhcGUtZG9t LWFjY2Vzcy5odG1sIGZhaWxzICh0aGUgbmV4dCB0ZXN0IGluIHRoZSBsaXN0KS4KKworICAgICAg ICAqIHBsYXRmb3JtL3dpbi9Ta2lwcGVkOgorICAgICAgICBBZGRlZCBwbHVnaW5zL25lc3RlZC1w bHVnaW4tb2JqZWN0cy5odG1sIHRvIHNraXAgbGlzdC4KKyAgICAgICAgCiAyMDEyLTA4LTEwICBa YW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCBHVEsgZ2FyZGVuaW5nLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQJKHJldmlzaW9u IDEyNTE5MSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkCSh3b3JraW5nIGNv cHkpCkBAIC0xOTY5LDMgKzE5NjksNiBAQCBmYXN0L2Zvcm1zL3ZhbGlkYXRpb24tbWVzc2FnZS11 c2VyLW1vZGlmCiAKICMgVGhlIHRleHRJbnB1dENvbnRyb2xsZXIuc2V0Q29tcG9zaXRpb24oKSBp bXBsZW1lbnRhdGlvbiBpcyBtaXNzaW5nCiBmYXN0L2Zvcm1zL2lucHV0LXNldC1jb21wb3NpdGlv bi1zY3JvbGwuaHRtbAorCisjIFRoaXMgdGVzdCBjYXVzZXMgYW55IGZvbGxvd2luZyBwbHVnaW5z IHRlc3QgdG8gY3Jhc2gKK3BsdWdpbnMvbmVzdGVkLXBsdWdpbi1vYmplY3RzLmh0bWwK 157810 2012-08-10 14:31:49 -0700 2012-08-10 15:32:29 -0700 re-patch 93741_patch.txt text/plain 1419 roger_fong SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNTMyMykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTEwICBSb2dlciBGb25nICA8cm9n ZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3Q6IHBsdWdpbnMvbmVzdGVk LXBsdWdpbi1vYmplY3RzLmh0bWwgcGFzc2VzIGJ1dCBjYXVzZXMgc3Vic2VxdWVudCB0ZXN0IHRv IGZhaWwgb24gV2luZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkzNzQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgcGx1Z2lucy9uZXN0ZWQtcGx1Z2luLW9iamVjdHMuaHRtbCBwYXNzZXMgYnV0IGNh dXNlcyBzdWJzZXF1ZW50IHRlc3QgdG8gZmFpbCBvbiBXaW5kb3dzLgorICAgICAgICBwbHVnaW5z L25ldHNjYXBlLWRvbS1hY2Nlc3MtYW5kLXJlbG9hZC5odG1sIGZhaWxzIGFzIGEgcmVzdWx0Lgor ICAgICAgICBPciBpZiBJIHNraXAgdGhhdCB0ZXN0LCB0aGVuIHBsdWdpbnMvbmV0c2NhcGUtZG9t LWFjY2Vzcy5odG1sIGZhaWxzICh0aGUgbmV4dCB0ZXN0IGluIHRoZSBsaXN0KS4KKworICAgICAg ICAqIHBsYXRmb3JtL3dpbi9Ta2lwcGVkOgorICAgICAgICBBZGRlZCBwbHVnaW5zL25lc3RlZC1w bHVnaW4tb2JqZWN0cy5odG1sIHRvIHNraXAgbGlzdC4KKyAgICAgICAgCiAyMDEyLTA4LTEwICBa YW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCBHVEsgZ2FyZGVuaW5nLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQJKHJldmlzaW9u IDEyNTE5MSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkCSh3b3JraW5nIGNv cHkpCkBAIC0xOTY5LDMgKzE5NjksNiBAQCBmYXN0L2Zvcm1zL3ZhbGlkYXRpb24tbWVzc2FnZS11 c2VyLW1vZGlmCiAKICMgVGhlIHRleHRJbnB1dENvbnRyb2xsZXIuc2V0Q29tcG9zaXRpb24oKSBp bXBsZW1lbnRhdGlvbiBpcyBtaXNzaW5nCiBmYXN0L2Zvcm1zL2lucHV0LXNldC1jb21wb3NpdGlv bi1zY3JvbGwuaHRtbAorCisjIFRoaXMgdGVzdCBjYXVzZXMgYW55IGZvbGxvd2luZyBwbHVnaW5z IHRlc3QgdG8gY3Jhc2gKK3BsdWdpbnMvbmVzdGVkLXBsdWdpbi1vYmplY3RzLmh0bWwK 157821 2012-08-10 15:32:29 -0700 2012-08-10 17:12:57 -0700 Test-I changed nothing 93741_patch.txt text/plain 1419 roger_fong SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNTMyMykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTEwICBSb2dlciBGb25nICA8cm9n ZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3Q6IHBsdWdpbnMvbmVzdGVk LXBsdWdpbi1vYmplY3RzLmh0bWwgcGFzc2VzIGJ1dCBjYXVzZXMgc3Vic2VxdWVudCB0ZXN0IHRv IGZhaWwgb24gV2luZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkzNzQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgcGx1Z2lucy9uZXN0ZWQtcGx1Z2luLW9iamVjdHMuaHRtbCBwYXNzZXMgYnV0IGNh dXNlcyBzdWJzZXF1ZW50IHRlc3QgdG8gZmFpbCBvbiBXaW5kb3dzLgorICAgICAgICBwbHVnaW5z L25ldHNjYXBlLWRvbS1hY2Nlc3MtYW5kLXJlbG9hZC5odG1sIGZhaWxzIGFzIGEgcmVzdWx0Lgor ICAgICAgICBPciBpZiBJIHNraXAgdGhhdCB0ZXN0LCB0aGVuIHBsdWdpbnMvbmV0c2NhcGUtZG9t LWFjY2Vzcy5odG1sIGZhaWxzICh0aGUgbmV4dCB0ZXN0IGluIHRoZSBsaXN0KS4KKworICAgICAg ICAqIHBsYXRmb3JtL3dpbi9Ta2lwcGVkOgorICAgICAgICBBZGRlZCBwbHVnaW5zL25lc3RlZC1w bHVnaW4tb2JqZWN0cy5odG1sIHRvIHNraXAgbGlzdC4KKyAgICAgICAgCiAyMDEyLTA4LTEwICBa YW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCBHVEsgZ2FyZGVuaW5nLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQJKHJldmlzaW9u IDEyNTE5MSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkCSh3b3JraW5nIGNv cHkpCkBAIC0xOTY5LDMgKzE5NjksNiBAQCBmYXN0L2Zvcm1zL3ZhbGlkYXRpb24tbWVzc2FnZS11 c2VyLW1vZGlmCiAKICMgVGhlIHRleHRJbnB1dENvbnRyb2xsZXIuc2V0Q29tcG9zaXRpb24oKSBp bXBsZW1lbnRhdGlvbiBpcyBtaXNzaW5nCiBmYXN0L2Zvcm1zL2lucHV0LXNldC1jb21wb3NpdGlv bi1zY3JvbGwuaHRtbAorCisjIFRoaXMgdGVzdCBjYXVzZXMgYW55IGZvbGxvd2luZyBwbHVnaW5z IHRlc3QgdG8gY3Jhc2gKK3BsdWdpbnMvbmVzdGVkLXBsdWdpbi1vYmplY3RzLmh0bWwK 157841 2012-08-10 17:12:57 -0700 2012-08-10 19:20:47 -0700 no comment 93741_patch.txt text/plain 1424 roger_fong SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNTMzNykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTEwICBSb2dlciBGb25nICA8cm9n ZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3Q6IHBsdWdpbnMvbmVzdGVk LXBsdWdpbi1vYmplY3RzLmh0bWwgcGFzc2VzIGJ1dCBjYXVzZXMgc3Vic2VxdWVudCB0ZXN0IHRv IGZhaWwgb24gV2luZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkzNzQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgcGx1Z2lucy9uZXN0ZWQtcGx1Z2luLW9iamVjdHMuaHRtbCBwYXNzZXMgYnV0IGNh dXNlcyBzdWJzZXF1ZW50IHRlc3QgdG8gZmFpbCBvbiBXaW5kb3dzLgorICAgICAgICBwbHVnaW5z L25ldHNjYXBlLWRvbS1hY2Nlc3MtYW5kLXJlbG9hZC5odG1sIGZhaWxzIGFzIGEgcmVzdWx0Lgor ICAgICAgICBPciBpZiBJIHNraXAgdGhhdCB0ZXN0LCB0aGVuIHBsdWdpbnMvbmV0c2NhcGUtZG9t LWFjY2Vzcy5odG1sIGZhaWxzICh0aGUgbmV4dCB0ZXN0IGluIHRoZSBsaXN0KS4KKworICAgICAg ICAqIHBsYXRmb3JtL3dpbi9Ta2lwcGVkOgorICAgICAgICBBZGRlZCBwbHVnaW5zL25lc3RlZC1w bHVnaW4tb2JqZWN0cy5odG1sIHRvIHNraXAgbGlzdC4KKwogMjAxMi0wOC0xMCAgSmVyIE5vYmxl ICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBubyB0aW1ldXBkYXRlIGV2ZW50cyBl bWl0dGVkIGZvciBtZWRpYSBjb250cm9sbGVyCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93 aW4vU2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tpcHBl ZAkocmV2aXNpb24gMTI1MzM3KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQJ KHdvcmtpbmcgY29weSkKQEAgLTE5NzMsMyArMTk3Myw2IEBAIGZhc3QvZm9ybXMvaW5wdXQtc2V0 LWNvbXBvc2l0aW9uLXNjcm9sbC4KICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkzNjY3CiAjIFRlc3QgdGltZXMgb3V0CiBmYXN0L2Zvcm1zL3NlbGVjdC9tZW51bGlz dC1wb3B1cC1jcmFzaC5odG1sCisKKyMgVGhpcyB0ZXN0IGNhdXNlcyBhbnkgZm9sbG93aW5nIHBs dWdpbnMgdGVzdCB0byBjcmFzaAorcGx1Z2lucy9uZXN0ZWQtcGx1Z2luLW9iamVjdHMuaHRtbAo=