93738 2012-08-10 13:05:39 -0700 table cell.cellIndex should return -1 if there is no parent table 2012-08-12 11:14:50 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED HasReduction P2 Normal --- 0 Ms2ger pravind.2k4 eric jchaffraix pravind.2k4 rniwa robert webkit.review.bot oldest_to_newest 692830 0 Ms2ger 2012-08-10 13:05:39 -0700 See <http://w3c-test.org/html/tests/submission/Ms2ger/the-elements-of-html/tabular-data/attributes-common-to-td-and-th-elements/cellIndex.html>; spec was changed in <http://html5.org/tools/web-apps-tracker?from=7242&to=7243>. 693118 1 157874 pravind.2k4 2012-08-11 09:09:40 -0700 Created attachment 157874 Patch 693119 2 pravind.2k4 2012-08-11 09:13:17 -0700 A little off the topic... We have functions // FIXME: need to implement cellIndex int cellIndex() const { return 0; } void setCellIndex(int) { } in RenderTableCell.h ... Is this still required ? It does seem to be used anywhere... It was added in http://trac.webkit.org/browser/trunk/WebCore/khtml/dom/html_table.h?annotate=blame&rev=4 693197 3 157874 eric 2012-08-12 02:55:34 -0700 Comment on attachment 157874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157874&action=review It also appears we have a RenderTableCell::cellIndex() function which does nothing and probably shoudl be removed. > Source/WebCore/html/HTMLTableCellElement.cpp:73 > + int index = -1; > + if (!parentElement() || !parentElement()->hasTagName(trTag)) > + return index; > + > + index = 0; I would have jsut used "return -1" here, and left int index = 0; as it was. It saves you a line of typing. 693198 4 157874 eric 2012-08-12 02:56:25 -0700 Comment on attachment 157874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157874&action=review > LayoutTests/fast/table/cellIndex-of-cell-with-different-parents.html:33 > +shouldBeTrue('th_with_tbody_parent.cellIndex == -1'); This could read shouldBe("th_with_tbody_parent.cellIndex", "-1"); 693255 5 157894 pravind.2k4 2012-08-12 05:57:30 -0700 Created attachment 157894 Patch 693291 6 157894 eric 2012-08-12 11:01:54 -0700 Comment on attachment 157894 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157894&action=review Thanks! > Source/WebCore/html/HTMLTableCellElement.cpp:69 > int index = 0; We don't do K&R style anymore. This declaration could be inline, right before the for() below, but the patch overall is fine, and clearly the rest of this file needs a style cleanup some day anyway. 693294 7 157894 webkit.review.bot 2012-08-12 11:14:46 -0700 Comment on attachment 157894 Patch Clearing flags on attachment: 157894 Committed r125380: <http://trac.webkit.org/changeset/125380> 693295 8 webkit.review.bot 2012-08-12 11:14:50 -0700 All reviewed patches have been landed. Closing bug. 157874 2012-08-11 09:09:40 -0700 2012-08-12 05:57:25 -0700 Patch bug-93738-20120812030751.patch text/plain 6473 pravind.2k4 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTM1MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTExICBQcmF2aW4g RCAgPHByYXZpbmQuMms0QGdtYWlsLmNvbT4KKworICAgICAgICB0YWJsZSBjZWxsLmNlbGxJbmRl eCBzaG91bGQgcmV0dXJuIC0xIGlmIHRoZXJlIGlzIG5vIHBhcmVudCB0YWJsZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM3MzgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBY2NvcmRpbmcgdG8gdGhlIEhU TUw1IHNwZWMgdGhlIGNlbGxJbmRleCBvZiBhIHRhYmxlIGNlbGwodGQvdGgpIHdob3NlIHBhcmVu dCBpcyBub3QgYSB0YWJsZSByb3cKKyAgICAgICAgbXVzdCBiZSAtMS4gQ3VycmVudGx5IHdlIGFy ZSByZXR1cm5pbmcgemVyby4gVGhpcyBwYXRjaCBmaXhlcyB0aGlzIGJlaGF2aW9yLgorCisgICAg ICAgIFRlc3Q6IGZhc3QvdGFibGUvY2VsbEluZGV4LW9mLWNlbGwtd2l0aC1kaWZmZXJlbnQtcGFy ZW50cy5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxUYWJsZUNlbGxFbGVtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxUYWJsZUNlbGxFbGVtZW50OjpjZWxsSW5kZXgpOgorICAgICAg ICBJZiB0aGUgcGFyZW50IG9mIHRoZSBjZWxsIGlzIG5vdCBhIHRhYmxlIHJvdywgLTEgaXMgcmV0 dXJuZWQuIE90aGVyd2lzZSBhIHZhbHVlIGdyZWF0ZXIKKyAgICAgICAgdGhhbiBvciBlcXVhbCB0 byB6ZXJvIGlzIHJldHVybi4KKwogMjAxMi0wOC0xMSAgTGV2aSBXZWludHJhdWIgIDxsZXZpd0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgVHJhY2sgYmxvY2sncyBwb3NpdGlvbmVkIG9iamVjdHMg bGlrZSBwZXJjZW50LWhlaWdodCBkZXNjZW5kYW50cwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MVGFibGVDZWxsRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MVGFibGVDZWxsRWxlbWVudC5jcHAJKHJldmlzaW9uIDEyNTM1MikKKysrIFNvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTFRhYmxlQ2VsbEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC02Niw3ICs2NiwxMSBAQCBpbnQgSFRNTFRhYmxlQ2VsbEVsZW1lbnQ6OnJvd1NwYW4oKSBjb25z CiAKIGludCBIVE1MVGFibGVDZWxsRWxlbWVudDo6Y2VsbEluZGV4KCkgY29uc3QKIHsKLSAgICBp bnQgaW5kZXggPSAwOworICAgIGludCBpbmRleCA9IC0xOworICAgIGlmICghcGFyZW50RWxlbWVu dCgpIHx8ICFwYXJlbnRFbGVtZW50KCktPmhhc1RhZ05hbWUodHJUYWcpKQorICAgICAgICByZXR1 cm4gaW5kZXg7CisKKyAgICBpbmRleCA9IDA7CiAgICAgZm9yIChjb25zdCBOb2RlICogbm9kZSA9 IHByZXZpb3VzU2libGluZygpOyBub2RlOyBub2RlID0gbm9kZS0+cHJldmlvdXNTaWJsaW5nKCkp IHsKICAgICAgICAgaWYgKG5vZGUtPmhhc1RhZ05hbWUodGRUYWcpIHx8IG5vZGUtPmhhc1RhZ05h bWUodGhUYWcpKQogICAgICAgICAgICAgaW5kZXgrKzsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTM1 MikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEz IEBACisyMDEyLTA4LTExICBQcmF2aW4gRCAgPHByYXZpbmQuMms0QGdtYWlsLmNvbT4KKworICAg ICAgICB0YWJsZSBjZWxsLmNlbGxJbmRleCBzaG91bGQgcmV0dXJuIC0xIGlmIHRoZXJlIGlzIG5v IHBhcmVudCB0YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTM3MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGZhc3QvdGFibGUvY2VsbEluZGV4LW9mLWNlbGwtd2l0aC1kaWZmZXJlbnQtcGFyZW50 cy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGFibGUvY2VsbEluZGV4LW9m LWNlbGwtd2l0aC1kaWZmZXJlbnQtcGFyZW50cy5odG1sOiBBZGRlZC4KKwogMjAxMi0wOC0xMSAg TGV2aSBXZWludHJhdWIgIDxsZXZpd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVHJhY2sgYmxv Y2sncyBwb3NpdGlvbmVkIG9iamVjdHMgbGlrZSBwZXJjZW50LWhlaWdodCBjaGlsZHJlbgpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9jZWxsSW5kZXgtb2YtY2VsbC13aXRoLWRpZmZlcmVu dC1wYXJlbnRzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3Rh YmxlL2NlbGxJbmRleC1vZi1jZWxsLXdpdGgtZGlmZmVyZW50LXBhcmVudHMtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9jZWxsSW5kZXgtb2YtY2Vs bC13aXRoLWRpZmZlcmVudC1wYXJlbnRzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSwyMiBAQAorVGVzdGNhc2UgZm9yIGJ1ZyBodHRwOi8vd2Via2l0Lm9yZy9iLzkzNzM4IC4g VGhlIHRlc3RjYXNlIGNoZWNrcyBpZiB0aGUgY2VsbEluZGV4IG9mIGEgdGFibGUgY2VsbCh0ZC90 aCkgaXMgY29ycmVjdCB3aGVuIHRoZSBjZWxsIGlzIGluc2lkZSBkaWZmZXJlbnQgcGFyZW50cy4K KworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywg Zm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1RoZSBjZWxsSW5kZXggb2YgYSB0YWJs ZSBjZWxsICh0ZC90aCkgbXVzdCBiZSAtMSBpZiBpdHMgcGFyZW50IGlzIG90aGVyIHRoYW4gYSB0 YWJsZSByb3cuIE90aGVyd2lzZSB0aGUgY2VsbEluZGV4IG11c3QgYmUgYSB2YWx1ZSBncmVhdGVy IHRoYW4gb3IgZXF1YWwgdG8gMC4KK1BBU1MgdGhfd2l0aF9ub19wYXJlbnQuY2VsbEluZGV4ID09 IC0xIGlzIHRydWUKK1BBU1MgdGRfd2l0aF9ub19wYXJlbnQuY2VsbEluZGV4ID09IC0xIGlzIHRy dWUKK1BBU1MgdGhfd2l0aF90YWJsZV9wYXJlbnQuY2VsbEluZGV4ID09IC0xIGlzIHRydWUKK1BB U1MgdGRfd2l0aF90YWJsZV9wYXJlbnQuY2VsbEluZGV4ID09IC0xIGlzIHRydWUKK1BBU1MgdGhf d2l0aF90aGVhZF9wYXJlbnQuY2VsbEluZGV4ID09IC0xIGlzIHRydWUKK1BBU1MgdGRfd2l0aF90 aGVhZF9wYXJlbnQuY2VsbEluZGV4ID09IC0xIGlzIHRydWUKK1BBU1MgdGhfd2l0aF90Ym9keV9w YXJlbnQuY2VsbEluZGV4ID09IC0xIGlzIHRydWUKK1BBU1MgdGRfd2l0aF90Ym9keV9wYXJlbnQu Y2VsbEluZGV4ID09IC0xIGlzIHRydWUKK1BBU1MgdGhfd2l0aF90Zm9vdF9wYXJlbnQuY2VsbElu ZGV4ID09IC0xIGlzIHRydWUKK1BBU1MgdGRfd2l0aF90YWJsZV9wYXJlbnQuY2VsbEluZGV4ID09 IC0xIGlzIHRydWUKK1BBU1MgdGhfd2l0aF90cl9wYXJlbnQuY2VsbEluZGV4ID49IDAgaXMgdHJ1 ZQorUEFTUyB0ZF93aXRoX3RyX3BhcmVudC5jZWxsSW5kZXggPj0gMCBpcyB0cnVlCitQQVNTIHN1 Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC90YWJsZS9jZWxsSW5kZXgtb2YtY2VsbC13aXRoLWRpZmZlcmVudC1wYXJlbnRz Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9jZWxsSW5kZXgtb2Yt Y2VsbC13aXRoLWRpZmZlcmVudC1wYXJlbnRzLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9mYXN0L3RhYmxlL2NlbGxJbmRleC1vZi1jZWxsLXdpdGgtZGlmZmVyZW50LXBhcmVudHMu aHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw1MSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRt bD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+ PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbignVGVzdGNh c2UgZm9yIGJ1ZyA8YSBocmVmPSJodHRwOi8vd2Via2l0Lm9yZy9iLzkzNzM4Ij5odHRwOi8vd2Vi a2l0Lm9yZy9iLzkzNzM4IDwvYT4uIFwKK1RoZSB0ZXN0Y2FzZSBjaGVja3MgaWYgdGhlIGNlbGxJ bmRleCBvZiBhIHRhYmxlIGNlbGwodGQvdGgpIGlzIGNvcnJlY3Qgd2hlbiB0aGUgY2VsbCBpcyBp bnNpZGUgZGlmZmVyZW50IHBhcmVudHMuJyk7CisKK2RlYnVnKCdUaGUgY2VsbEluZGV4IG9mIGEg dGFibGUgY2VsbCAodGQvdGgpIG11c3QgYmUgLTEgaWYgaXRzIHBhcmVudCBpcyBvdGhlciB0aGFu IGEgdGFibGUgcm93LiBPdGhlcndpc2UgXAordGhlIGNlbGxJbmRleCBtdXN0IGJlIGEgdmFsdWUg Z3JlYXRlciB0aGFuIG9yIGVxdWFsIHRvIDAuJyk7CisKK3RoX3dpdGhfbm9fcGFyZW50ID0gZG9j dW1lbnQuY3JlYXRlRWxlbWVudCgidGgiKTsKK3Nob3VsZEJlVHJ1ZSgndGhfd2l0aF9ub19wYXJl bnQuY2VsbEluZGV4ID09IC0xJyk7Cit0ZF93aXRoX25vX3BhcmVudCA9IGRvY3VtZW50LmNyZWF0 ZUVsZW1lbnQoInRkIik7CitzaG91bGRCZVRydWUoJ3RkX3dpdGhfbm9fcGFyZW50LmNlbGxJbmRl eCA9PSAtMScpOworCit0YWJsZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRhYmxlIik7Cit0 aF93aXRoX3RhYmxlX3BhcmVudCA9IHRhYmxlLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoInRoIikpOworc2hvdWxkQmVUcnVlKCd0aF93aXRoX3RhYmxlX3BhcmVudC5jZWxsSW5k ZXggPT0gLTEnKTsKK3RkX3dpdGhfdGFibGVfcGFyZW50ID0gdGFibGUuYXBwZW5kQ2hpbGQoZG9j dW1lbnQuY3JlYXRlRWxlbWVudCgidGQiKSk7CitzaG91bGRCZVRydWUoJ3RkX3dpdGhfdGFibGVf cGFyZW50LmNlbGxJbmRleCA9PSAtMScpOworCit0aGVhZCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoInRoZWFkIik7Cit0aF93aXRoX3RoZWFkX3BhcmVudCA9IHRoZWFkLmFwcGVuZENoaWxkKGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoInRoIikpOworc2hvdWxkQmVUcnVlKCd0aF93aXRoX3RoZWFk X3BhcmVudC5jZWxsSW5kZXggPT0gLTEnKTsKK3RkX3dpdGhfdGhlYWRfcGFyZW50ID0gdGhlYWQu YXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgidGQiKSk7CitzaG91bGRCZVRydWUo J3RkX3dpdGhfdGhlYWRfcGFyZW50LmNlbGxJbmRleCA9PSAtMScpOworCit0Ym9keSA9IGRvY3Vt ZW50LmNyZWF0ZUVsZW1lbnQoInRib2R5Iik7Cit0aF93aXRoX3Rib2R5X3BhcmVudCA9IHRib2R5 LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRoIikpOworc2hvdWxkQmVUcnVl KCd0aF93aXRoX3Rib2R5X3BhcmVudC5jZWxsSW5kZXggPT0gLTEnKTsKK3RkX3dpdGhfdGJvZHlf cGFyZW50ID0gdGJvZHkuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgidGQiKSk7 CitzaG91bGRCZVRydWUoJ3RkX3dpdGhfdGJvZHlfcGFyZW50LmNlbGxJbmRleCA9PSAtMScpOwor Cit0Zm9vdCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRmb290Iik7Cit0aF93aXRoX3Rmb290 X3BhcmVudCA9IHRmb290LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRoIikp Oworc2hvdWxkQmVUcnVlKCd0aF93aXRoX3Rmb290X3BhcmVudC5jZWxsSW5kZXggPT0gLTEnKTsK K3RkX3dpdGhfdGZvb3RfcGFyZW50ID0gdGZvb3QuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgidGQiKSk7CitzaG91bGRCZVRydWUoJ3RkX3dpdGhfdGFibGVfcGFyZW50LmNlbGxJ bmRleCA9PSAtMScpOworCit0ciA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRyIik7Cit0aF93 aXRoX3RyX3BhcmVudCA9IHRyLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRo IikpOworc2hvdWxkQmVUcnVlKCd0aF93aXRoX3RyX3BhcmVudC5jZWxsSW5kZXggPj0gMCcpOwor dGRfd2l0aF90cl9wYXJlbnQgPSB0ci5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50 KCJ0ZCIpKTsKK3Nob3VsZEJlVHJ1ZSgndGRfd2l0aF90cl9wYXJlbnQuY2VsbEluZGV4ID49IDAn KTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3Qu anMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo= 157894 2012-08-12 05:57:30 -0700 2012-08-12 11:14:46 -0700 Patch bug-93738-20120812235540.patch text/plain 7727 pravind.2k4 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTM3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTEyICBQcmF2aW4g RCAgPHByYXZpbmQuMms0QGdtYWlsLmNvbT4KKworICAgICAgICB0YWJsZSBjZWxsLmNlbGxJbmRl eCBzaG91bGQgcmV0dXJuIC0xIGlmIHRoZXJlIGlzIG5vIHBhcmVudCB0YWJsZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM3MzgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBY2NvcmRpbmcgdG8gdGhlIEhU TUw1IHNwZWMgdGhlIGNlbGxJbmRleCBvZiBhIHRhYmxlIGNlbGwodGQvdGgpIHdob3NlIHBhcmVu dCBpcyBub3QgYSB0YWJsZSByb3cKKyAgICAgICAgbXVzdCBiZSAtMS4gQ3VycmVudGx5IHdlIGFy ZSByZXR1cm5pbmcgemVyby4gVGhpcyBwYXRjaCBmaXhlcyB0aGlzIGJlaGF2aW9yLiAKKworICAg ICAgICBUZXN0OiBmYXN0L3RhYmxlL2NlbGxJbmRleC1vZi1jZWxsLXdpdGgtZGlmZmVyZW50LXBh cmVudHMuaHRtbAorCisgICAgICAgICogaHRtbC9IVE1MVGFibGVDZWxsRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MVGFibGVDZWxsRWxlbWVudDo6Y2VsbEluZGV4KToKKyAgICAg ICAgICBJZiB0aGUgcGFyZW50IG9mIHRoZSBjZWxsIGlzIG5vdCBhIHRhYmxlIHJvdywgLTEgaXMg cmV0dXJuZWQuIE90aGVyd2lzZSBhIHZhbHVlIGdyZWF0ZXIKKyAgICAgICAgICB0aGFuIG9yIGVx dWFsIHRvIHplcm8gaXMgcmV0dXJuLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRhYmxl Q2VsbC5oOgorICAgICAgICAoUmVuZGVyVGFibGVDZWxsKToKKyAgICAgICAgIFJlbW92ZWQgZGVh ZCBjb2RlIGFuZCBtYWRlIG1pbm9yIHdlYmtpdCBzdHlsZSByZWxhdGVkIGZpeC4KKwogMjAxMi0w OC0xMiAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KIAogICAgICAg ICBTZXQgdGhlIGFjY2VzcyBxdWFsaWZpZXIgb2YgdHdvIG1ldGhvZHMgdG8gcXVlcnkgZnJhbWUg c3BlY2lmaWMgaW5mbyBvZiBCaXRtYXBJbWFnZSB0byBwcm90ZWN0ZWQuCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxUYWJsZUNlbGxFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxUYWJsZUNlbGxFbGVtZW50LmNwcAkocmV2aXNpb24gMTI1MzUy KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGFibGVDZWxsRWxlbWVudC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTY3LDYgKzY3LDkgQEAgaW50IEhUTUxUYWJsZUNlbGxFbGVtZW50Ojpyb3dT cGFuKCkgY29ucwogaW50IEhUTUxUYWJsZUNlbGxFbGVtZW50OjpjZWxsSW5kZXgoKSBjb25zdAog ewogICAgIGludCBpbmRleCA9IDA7CisgICAgaWYgKCFwYXJlbnRFbGVtZW50KCkgfHwgIXBhcmVu dEVsZW1lbnQoKS0+aGFzVGFnTmFtZSh0clRhZykpCisgICAgICAgIHJldHVybiAtMTsKKwogICAg IGZvciAoY29uc3QgTm9kZSAqIG5vZGUgPSBwcmV2aW91c1NpYmxpbmcoKTsgbm9kZTsgbm9kZSA9 IG5vZGUtPnByZXZpb3VzU2libGluZygpKSB7CiAgICAgICAgIGlmIChub2RlLT5oYXNUYWdOYW1l KHRkVGFnKSB8fCBub2RlLT5oYXNUYWdOYW1lKHRoVGFnKSkKICAgICAgICAgICAgIGluZGV4Kys7 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5oCShyZXZp c2lvbiAxMjUzNTIpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxs LmgJKHdvcmtpbmcgY29weSkKQEAgLTM4LDExICszOCw3IEBAIGVudW0gSW5jbHVkZUJvcmRlckNv bG9yT3JOb3QgeyBEb05vdEluY2wKIGNsYXNzIFJlbmRlclRhYmxlQ2VsbCA6IHB1YmxpYyBSZW5k ZXJCbG9jayB7CiBwdWJsaWM6CiAgICAgZXhwbGljaXQgUmVuZGVyVGFibGVDZWxsKE5vZGUqKTsK LQotICAgIC8vIEZJWE1FOiBuZWVkIHRvIGltcGxlbWVudCBjZWxsSW5kZXgKLSAgICBpbnQgY2Vs bEluZGV4KCkgY29uc3QgeyByZXR1cm4gMDsgfQotICAgIHZvaWQgc2V0Q2VsbEluZGV4KGludCkg eyB9Ci0KKyAgICAKICAgICB1bnNpZ25lZCBjb2xTcGFuKCkgY29uc3Q7CiAgICAgdW5zaWduZWQg cm93U3BhbigpIGNvbnN0OwogCkBAIC0xMTYsNyArMTEyLDcgQEAgcHVibGljOgogICAgIHZpcnR1 YWwgTGF5b3V0VW5pdCBwYWRkaW5nTGVmdCgpIGNvbnN0IE9WRVJSSURFOwogICAgIHZpcnR1YWwg TGF5b3V0VW5pdCBwYWRkaW5nUmlnaHQoKSBjb25zdCBPVkVSUklERTsKICAgICAKLSAgICAvLyBG SVhNRTogRm9yIG5vdyB3ZSBqdXN0IGFzc3VtZSB0aGUgY2VsbCBoYXMgdGhlIHNhbWUgYmxvY2sg ZmxvdyBkaXJlY3Rpb24gYXMgdGhlIHRhYmxlLiAgSXQncyBsaWtlbHkgd2UnbGwKKyAgICAvLyBG SVhNRTogRm9yIG5vdyB3ZSBqdXN0IGFzc3VtZSB0aGUgY2VsbCBoYXMgdGhlIHNhbWUgYmxvY2sg ZmxvdyBkaXJlY3Rpb24gYXMgdGhlIHRhYmxlLiBJdCdzIGxpa2VseSB3ZSdsbAogICAgIC8vIGNy ZWF0ZSBhbiBleHRyYSBhbm9ueW1vdXMgUmVuZGVyQmxvY2sgdG8gaGFuZGxlIG1peGluZyBkaXJl Y3Rpb25hbGl0eSBhbnl3YXksIGluIHdoaWNoIGNhc2Ugd2UgY2FuIGxvY2sKICAgICAvLyB0aGUg YmxvY2sgZmxvdyBkaXJlY3Rpb25hbGl0eSBvZiB0aGUgY2VsbHMgdG8gdGhlIHRhYmxlJ3MgZGly ZWN0aW9uYWxpdHkuCiAgICAgdmlydHVhbCBMYXlvdXRVbml0IHBhZGRpbmdCZWZvcmUoKSBjb25z dCBPVkVSUklERTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTM3NCkKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA4LTEyICBQcmF2 aW4gRCAgPHByYXZpbmQuMms0QGdtYWlsLmNvbT4KKworICAgICAgICB0YWJsZSBjZWxsLmNlbGxJ bmRleCBzaG91bGQgcmV0dXJuIC0xIGlmIHRoZXJlIGlzIG5vIHBhcmVudCB0YWJsZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM3MzgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvdGFibGUvY2Vs bEluZGV4LW9mLWNlbGwtd2l0aC1kaWZmZXJlbnQtcGFyZW50cy1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvdGFibGUvY2VsbEluZGV4LW9mLWNlbGwtd2l0aC1kaWZmZXJlbnQt cGFyZW50cy5odG1sOiBBZGRlZC4KKwogMjAxMi0wOC0xMiAgVGFrYXNoaSBTYWthbW90byAgPHRh c2FrQGdvb2dsZS5jb20+CiAKICAgICAgICAgd2Via2l0IGZhaWxzIElFVEMgbmFtZXNwYWNlcy9w cmVmaXgtMDA3LnhtbApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9jZWxsSW5kZXgtb2Yt Y2VsbC13aXRoLWRpZmZlcmVudC1wYXJlbnRzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L3RhYmxlL2NlbGxJbmRleC1vZi1jZWxsLXdpdGgtZGlmZmVyZW50LXBh cmVudHMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC90YWJs ZS9jZWxsSW5kZXgtb2YtY2VsbC13aXRoLWRpZmZlcmVudC1wYXJlbnRzLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKQEAgLTAsMCArMSwyMiBAQAorVGVzdGNhc2UgZm9yIGJ1ZyBodHRwOi8vd2Vi a2l0Lm9yZy9iLzkzNzM4IC4gVGhlIHRlc3RjYXNlIGNoZWNrcyBpZiB0aGUgY2VsbEluZGV4IG9m IGEgdGFibGUgY2VsbCh0ZC90aCkgaXMgY29ycmVjdCB3aGVuIHRoZSBjZWxsIGlzIGluc2lkZSBk aWZmZXJlbnQgcGFyZW50cy4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9m ICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1RoZSBj ZWxsSW5kZXggb2YgYSB0YWJsZSBjZWxsICh0ZC90aCkgbXVzdCBiZSAtMSBpZiBpdHMgcGFyZW50 IGlzIG90aGVyIHRoYW4gYSB0YWJsZSByb3cuIE90aGVyd2lzZSB0aGUgY2VsbEluZGV4IG11c3Qg YmUgYSB2YWx1ZSBncmVhdGVyIHRoYW4gb3IgZXF1YWwgdG8gMC4KK1BBU1MgdGhfd2l0aF9ub19w YXJlbnQuY2VsbEluZGV4IGlzIC0xCitQQVNTIHRkX3dpdGhfbm9fcGFyZW50LmNlbGxJbmRleCBp cyAtMQorUEFTUyB0aF93aXRoX3RhYmxlX3BhcmVudC5jZWxsSW5kZXggaXMgLTEKK1BBU1MgdGRf d2l0aF90YWJsZV9wYXJlbnQuY2VsbEluZGV4IGlzIC0xCitQQVNTIHRoX3dpdGhfdGhlYWRfcGFy ZW50LmNlbGxJbmRleCBpcyAtMQorUEFTUyB0ZF93aXRoX3RoZWFkX3BhcmVudC5jZWxsSW5kZXgg aXMgLTEKK1BBU1MgdGhfd2l0aF90Ym9keV9wYXJlbnQuY2VsbEluZGV4IGlzIC0xCitQQVNTIHRk X3dpdGhfdGJvZHlfcGFyZW50LmNlbGxJbmRleCBpcyAtMQorUEFTUyB0aF93aXRoX3Rmb290X3Bh cmVudC5jZWxsSW5kZXggaXMgLTEKK1BBU1MgdGRfd2l0aF90YWJsZV9wYXJlbnQuY2VsbEluZGV4 IGlzIC0xCitQQVNTIGZpcnN0X2NlbGxfdGhfd2l0aF90cl9wYXJlbnQuY2VsbEluZGV4IGlzIDAK K1BBU1Mgc2Vjb25kX2NlbGxfdGRfd2l0aF90cl9wYXJlbnQuY2VsbEluZGV4IGlzIDEKK1BBU1Mg c3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L3RhYmxlL2NlbGxJbmRleC1vZi1jZWxsLXdpdGgtZGlmZmVyZW50LXBhcmVu dHMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2NlbGxJbmRleC1v Zi1jZWxsLXdpdGgtZGlmZmVyZW50LXBhcmVudHMuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91 dFRlc3RzL2Zhc3QvdGFibGUvY2VsbEluZGV4LW9mLWNlbGwtd2l0aC1kaWZmZXJlbnQtcGFyZW50 cy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUxIEBACis8IURPQ1RZUEUgaHRtbD4KKzxo dG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpz Ij48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCdUZXN0 Y2FzZSBmb3IgYnVnIDxhIGhyZWY9Imh0dHA6Ly93ZWJraXQub3JnL2IvOTM3MzgiPmh0dHA6Ly93 ZWJraXQub3JnL2IvOTM3MzggPC9hPi4gXAorVGhlIHRlc3RjYXNlIGNoZWNrcyBpZiB0aGUgY2Vs bEluZGV4IG9mIGEgdGFibGUgY2VsbCh0ZC90aCkgaXMgY29ycmVjdCB3aGVuIHRoZSBjZWxsIGlz IGluc2lkZSBkaWZmZXJlbnQgcGFyZW50cy4nKTsKKworZGVidWcoJ1RoZSBjZWxsSW5kZXggb2Yg YSB0YWJsZSBjZWxsICh0ZC90aCkgbXVzdCBiZSAtMSBpZiBpdHMgcGFyZW50IGlzIG90aGVyIHRo YW4gYSB0YWJsZSByb3cuIE90aGVyd2lzZSBcCit0aGUgY2VsbEluZGV4IG11c3QgYmUgYSB2YWx1 ZSBncmVhdGVyIHRoYW4gb3IgZXF1YWwgdG8gMC4nKTsKKwordGhfd2l0aF9ub19wYXJlbnQgPSBk b2N1bWVudC5jcmVhdGVFbGVtZW50KCJ0aCIpOworc2hvdWxkQmUoJ3RoX3dpdGhfbm9fcGFyZW50 LmNlbGxJbmRleCcsICctMScpOwordGRfd2l0aF9ub19wYXJlbnQgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCJ0ZCIpOworc2hvdWxkQmUoJ3RkX3dpdGhfbm9fcGFyZW50LmNlbGxJbmRleCcsICct MScpOworCit0YWJsZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRhYmxlIik7Cit0aF93aXRo X3RhYmxlX3BhcmVudCA9IHRhYmxlLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo InRoIikpOworc2hvdWxkQmUoJ3RoX3dpdGhfdGFibGVfcGFyZW50LmNlbGxJbmRleCcsICctMScp OwordGRfd2l0aF90YWJsZV9wYXJlbnQgPSB0YWJsZS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVh dGVFbGVtZW50KCJ0ZCIpKTsKK3Nob3VsZEJlKCd0ZF93aXRoX3RhYmxlX3BhcmVudC5jZWxsSW5k ZXgnLCAnLTEnKTsKKwordGhlYWQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJ0aGVhZCIpOwor dGhfd2l0aF90aGVhZF9wYXJlbnQgPSB0aGVhZC5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVF bGVtZW50KCJ0aCIpKTsKK3Nob3VsZEJlKCd0aF93aXRoX3RoZWFkX3BhcmVudC5jZWxsSW5kZXgn LCAnLTEnKTsKK3RkX3dpdGhfdGhlYWRfcGFyZW50ID0gdGhlYWQuYXBwZW5kQ2hpbGQoZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgidGQiKSk7CitzaG91bGRCZSgndGRfd2l0aF90aGVhZF9wYXJlbnQu Y2VsbEluZGV4JywgJy0xJyk7CisKK3Rib2R5ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgidGJv ZHkiKTsKK3RoX3dpdGhfdGJvZHlfcGFyZW50ID0gdGJvZHkuYXBwZW5kQ2hpbGQoZG9jdW1lbnQu Y3JlYXRlRWxlbWVudCgidGgiKSk7CitzaG91bGRCZSgndGhfd2l0aF90Ym9keV9wYXJlbnQuY2Vs bEluZGV4JywgJy0xJyk7Cit0ZF93aXRoX3Rib2R5X3BhcmVudCA9IHRib2R5LmFwcGVuZENoaWxk KGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRkIikpOworc2hvdWxkQmUoJ3RkX3dpdGhfdGJvZHlf cGFyZW50LmNlbGxJbmRleCcsICctMScpOworCit0Zm9vdCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoInRmb290Iik7Cit0aF93aXRoX3Rmb290X3BhcmVudCA9IHRmb290LmFwcGVuZENoaWxkKGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoInRoIikpOworc2hvdWxkQmUoJ3RoX3dpdGhfdGZvb3RfcGFy ZW50LmNlbGxJbmRleCcsICctMScpOwordGRfd2l0aF90Zm9vdF9wYXJlbnQgPSB0Zm9vdC5hcHBl bmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJ0ZCIpKTsKK3Nob3VsZEJlKCd0ZF93aXRo X3RhYmxlX3BhcmVudC5jZWxsSW5kZXgnLCAnLTEnKTsKKwordHIgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCJ0ciIpOworZmlyc3RfY2VsbF90aF93aXRoX3RyX3BhcmVudCA9IHRyLmFwcGVuZENo aWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRoIikpOworc2hvdWxkQmUoJ2ZpcnN0X2NlbGxf dGhfd2l0aF90cl9wYXJlbnQuY2VsbEluZGV4JywgJzAnKTsKK3NlY29uZF9jZWxsX3RkX3dpdGhf dHJfcGFyZW50ID0gdHIuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgidGQiKSk7 CitzaG91bGRCZSgnc2Vjb25kX2NlbGxfdGRfd2l0aF90cl9wYXJlbnQuY2VsbEluZGV4JywgJzEn KTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3Qu anMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=