93737 2012-08-10 12:43:18 -0700 Improved RuleData packing on some 32-bit platforms 2012-08-10 15:42:12 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fmalita fmalita cmarcelo kling koivisto macpherson menard webkit.review.bot oldest_to_newest 692819 0 fmalita 2012-08-10 12:43:18 -0700 Certain 32-bit platforms use an 8-byte alignment for uint64_t (as exposed by the build breakage after http://trac.webkit.org/changeset/125294). To avoid wasting 4 bytes per object due to alignment, we can use two naturally-aligning unsigned integers instead. 692822 1 157795 fmalita 2012-08-10 12:47:27 -0700 Created attachment 157795 Patch 692870 2 157795 kling 2012-08-10 14:08:02 -0700 Comment on attachment 157795 Patch r=me, thanks for the fix! 692925 3 157795 webkit.review.bot 2012-08-10 15:42:07 -0700 Comment on attachment 157795 Patch Clearing flags on attachment: 157795 Committed r125333: <http://trac.webkit.org/changeset/125333> 692926 4 webkit.review.bot 2012-08-10 15:42:12 -0700 All reviewed patches have been landed. Closing bug. 157795 2012-08-10 12:47:27 -0700 2012-08-10 15:42:07 -0700 Patch bug-93737-20120810154658.patch text/plain 2705 fmalita U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjg4OGE0MzA3ODcyM2Vm N2MxMjY5YzRmMTY1MjllNjk2MmZlZWI0OS4uMWI4NGFhMTgxZDkxYTY1YWI0MWFiYzExYmQxN2Y0 ZTI1N2JkYWU3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTEwICBGbG9y aW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW1wcm92ZWQgUnVs ZURhdGEgcGFja2luZyBvbiBzb21lIDMyLWJpdCBwbGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNzM3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2VydGFpbiAzMi1iaXQgcGxhcmZvcm1zIHVz ZSBhbiA4LWJ5dGUgYWxpZ25tZW50IGZvciB1aW50NjRfdC4gV2UgY2FuIHNhdmUgNCBieXRlcyBw ZXIKKyAgICAgICAgb2JqZWN0IG9uIHRoZXNlIHBsYXRmb3JtcyBieSB1c2luZyB0d28gbmF0dXJh bGx5LWFsaWduaW5nIHVuc2lnbmVkIGludHMgaW5zdGVhZC4KKworICAgICAgICAqIGNzcy9TdHls ZVJlc29sdmVyLmNwcDoKKyAgICAgICAgKFJ1bGVEYXRhKToKKyAgICAgICAgKFNhbWVTaXplQXNS dWxlRGF0YSk6CisKIDIwMTItMDgtMTAgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmpl bnNlbkBub2tpYS5jb20+CiAKICAgICAgICAgW1RyYW5zZm9ybXNdIEhpdCB0ZXN0IGlzc3VlIHdp dGggbGFyZ2Ugc2NhbGUoKSB0cmFuc2Zvcm0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9TdHlsZVJlc29sdmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNw cAppbmRleCA2NmRhMGI0NmFmYzE0M2I3NGFmMGE3ODNmMTgwNzExY2ZmZjRiMzUyLi5mZjkyMTNh YThkNjNlOTNlN2JjYWQ1YzE5YzhmYTc1NzYxY2VkZDA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxl UmVzb2x2ZXIuY3BwCkBAIC0yMjMsMjYgKzIyMywyNyBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAg ICAgU3R5bGVSdWxlKiBtX3J1bGU7Ci0gICAgdWludDY0X3QgbV9zZWxlY3RvckluZGV4IDogMTI7 CisgICAgdW5zaWduZWQgbV9zZWxlY3RvckluZGV4IDogMTI7CiAgICAgLy8gVGhpcyBudW1iZXIg d2FzIHBpY2tlZCBmYWlybHkgYXJiaXRyYXJpbHkuIFdlIGNhbiBwcm9iYWJseSBsb3dlciBpdCBp ZiB3ZSBuZWVkIHRvLgogICAgIC8vIFNvbWUgc2ltcGxlIHRlc3Rpbmcgc2hvd2VkIDwxMDAsMDAw IFJ1bGVEYXRhJ3Mgb24gbGFyZ2Ugc2l0ZXMuCi0gICAgdWludDY0X3QgbV9wb3NpdGlvbiA6IDIw OwotICAgIHVpbnQ2NF90IG1fc3BlY2lmaWNpdHkgOiAyNDsKLSAgICB1aW50NjRfdCBtX2hhc0Zh c3RDaGVja2FibGVTZWxlY3RvciA6IDE7Ci0gICAgdWludDY0X3QgbV9oYXNNdWx0aXBhcnRTZWxl Y3RvciA6IDE7Ci0gICAgdWludDY0X3QgbV9oYXNSaWdodG1vc3RTZWxlY3Rvck1hdGNoaW5nSFRN TEJhc2VkT25SdWxlSGFzaCA6IDE7Ci0gICAgdWludDY0X3QgbV9jb250YWluc1VuY29tbW9uQXR0 cmlidXRlU2VsZWN0b3IgOiAxOwotICAgIHVpbnQ2NF90IG1fbGlua01hdGNoVHlwZSA6IDI7IC8v ICBTZWxlY3RvckNoZWNrZXI6OkxpbmtNYXRjaE1hc2sKLSAgICB1aW50NjRfdCBtX2hhc0RvY3Vt ZW50U2VjdXJpdHlPcmlnaW4gOiAxOwotICAgIHVpbnQ2NF90IG1faXNJblJlZ2lvblJ1bGUgOiAx OworICAgIHVuc2lnbmVkIG1fcG9zaXRpb24gOiAyMDsKKyAgICB1bnNpZ25lZCBtX3NwZWNpZmlj aXR5IDogMjQ7CisgICAgdW5zaWduZWQgbV9oYXNGYXN0Q2hlY2thYmxlU2VsZWN0b3IgOiAxOwor ICAgIHVuc2lnbmVkIG1faGFzTXVsdGlwYXJ0U2VsZWN0b3IgOiAxOworICAgIHVuc2lnbmVkIG1f aGFzUmlnaHRtb3N0U2VsZWN0b3JNYXRjaGluZ0hUTUxCYXNlZE9uUnVsZUhhc2ggOiAxOworICAg IHVuc2lnbmVkIG1fY29udGFpbnNVbmNvbW1vbkF0dHJpYnV0ZVNlbGVjdG9yIDogMTsKKyAgICB1 bnNpZ25lZCBtX2xpbmtNYXRjaFR5cGUgOiAyOyAvLyAgU2VsZWN0b3JDaGVja2VyOjpMaW5rTWF0 Y2hNYXNrCisgICAgdW5zaWduZWQgbV9oYXNEb2N1bWVudFNlY3VyaXR5T3JpZ2luIDogMTsKKyAg ICB1bnNpZ25lZCBtX2lzSW5SZWdpb25SdWxlIDogMTsKICAgICAvLyBVc2UgcGxhaW4gYXJyYXkg aW5zdGVhZCBvZiBhIFZlY3RvciB0byBtaW5pbWl6ZSBtZW1vcnkgb3ZlcmhlYWQuCiAgICAgdW5z aWduZWQgbV9kZXNjZW5kYW50U2VsZWN0b3JJZGVudGlmaWVySGFzaGVzW21heGltdW1JZGVudGlm aWVyQ291bnRdOwogfTsKICAgICAKIHN0cnVjdCBTYW1lU2l6ZUFzUnVsZURhdGEgewogICAgIHZv aWQqIGE7Ci0gICAgdWludDY0X3QgYjsKLSAgICB1bnNpZ25lZCBjWzRdOworICAgIHVuc2lnbmVk IGI7CisgICAgdW5zaWduZWQgYzsKKyAgICB1bnNpZ25lZCBkWzRdOwogfTsKIAogQ09NUElMRV9B U1NFUlQoc2l6ZW9mKFJ1bGVEYXRhKSA9PSBzaXplb2YoU2FtZVNpemVBc1J1bGVEYXRhKSwgUnVs ZURhdGFfc2hvdWxkX3N0YXlfc21hbGwpOwo=