93723 2012-08-10 08:30:09 -0700 [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files 2012-08-29 06:09:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED NRWT P2 Normal --- 64491 1 kkristof kkristof abarth bank dpranke kadam ojan ossy szledan webkit.review.bot oldest_to_newest 692560 0 kkristof 2012-08-10 08:30:09 -0700 Now the nrwt doesn't warn if a test from the skipped list doesn't exist. 692733 1 dpranke 2012-08-10 11:36:38 -0700 seems reasonable and a trivial change (test_expectations.py:889) 695955 2 158558 kkristof 2012-08-15 06:33:46 -0700 Created attachment 158558 proposed fix 696176 3 158558 dpranke 2012-08-15 11:18:48 -0700 Comment on attachment 158558 proposed fix expectation_for_skipped_test() won't set .warnings, so it seems unlikely that this branch would ever execute. Also, checking for one warning and then printing another seems like a bad idea. You should just test if the file (or directory) exists here and add a warning directly (or add that code into expectation_for_skipped_test(). Also, this change needs a test. 706361 4 160986 kkristof 2012-08-28 08:14:13 -0700 Created attachment 160986 proposed fix 706622 5 160986 dpranke 2012-08-28 12:35:10 -0700 Comment on attachment 160986 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=160986&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:96 > + _log.warning('The following test %s from the Skipped list doesn\'t exists!' % test_name) Nit: "exist", not "exists", and I wouldn't use an exclamation point. 707390 6 kkristof 2012-08-29 06:09:50 -0700 Committed r126992: <http://trac.webkit.org/changeset/126992> 158558 2012-08-15 06:33:46 -0700 2012-08-28 08:14:13 -0700 proposed fix check.patch text/plain 1396 kkristof ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzZjEy ODcyLi5iOTBiNzViIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDgtMTUgIEtyaXN0w7NmIEtvc3p0ecOzICA8 a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtOUldUXSBUaGUgbnJ3dCBzaG91 bGQgY2hlY2sgdGhlIGNvbnRlbnRzIG9mIHRoZSBza2lwcGVkIGZpbGVzIHdpdGggLS1saW50LXRl c3QtZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTkzNzIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnMu cHk6CisgICAgICAgIChUZXN0RXhwZWN0YXRpb25zLmFkZF9za2lwcGVkX3Rlc3RzKToKKwogMjAx Mi0wOC0xNSAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgog CiAgICAgICAgIFtXSzJdIEFkZCBzdXBwb3J0IGZvciBXZWIgSW50ZW50cyBNZXNzYWdlUG9ydHMK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90 ZXN0X2V4cGVjdGF0aW9ucy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weQppbmRleCBiYWI3NDE4Li4wY2MzMjQwIDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9l eHBlY3RhdGlvbnMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv bW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CkBAIC04NzksNCArODc5LDYgQEAgY2xhc3MgVGVz dEV4cGVjdGF0aW9ucyhvYmplY3QpOgogCiAgICAgICAgIGZvciB0ZXN0X25hbWUgaW4gdGVzdHNf dG9fc2tpcDoKICAgICAgICAgICAgIGV4cGVjdGF0aW9uX2xpbmUgPSBzZWxmLl9wYXJzZXIuZXhw ZWN0YXRpb25fZm9yX3NraXBwZWRfdGVzdCh0ZXN0X25hbWUpCisgICAgICAgICAgICBpZiAnUGF0 aCBkb2VzIG5vdCBleGlzdC4nIGluIGV4cGVjdGF0aW9uX2xpbmUud2FybmluZ3M6CisgICAgICAg ICAgICAgICAgX2xvZy53YXJuaW5nKCJTa2lwcGVkIGxpc3QgY29udGFpbmVkICclcycsIGJ1dCBu byBmaWxlIG9mIHRoYXQgbmFtZSBjb3VsZCBiZSBmb3VuZCIgJSBleHBlY3RhdGlvbl9saW5lLm5h bWUpCiAgICAgICAgICAgICBzZWxmLl9tb2RlbC5hZGRfZXhwZWN0YXRpb25fbGluZShleHBlY3Rh dGlvbl9saW5lLCBpbl9za2lwcGVkPVRydWUpCg== 160986 2012-08-28 08:14:13 -0700 2012-08-28 12:35:10 -0700 proposed fix check.patch text/plain 3111 kkristof ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiZThm Y2VjLi4xODM5ODMwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDgtMjggIEtyaXN0w7NmIEtvc3p0ecOzICA8 a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtOUldUXSBUaGUgbnJ3dCBzaG91 bGQgY2hlY2sgdGhlIGNvbnRlbnRzIG9mIHRoZSBza2lwcGVkIGZpbGVzIHdpdGggLS1saW50LXRl c3QtZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTkzNzIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnMu cHk6CisgICAgICAgIChUZXN0RXhwZWN0YXRpb25QYXJzZXIuZXhwZWN0YXRpb25fZm9yX3NraXBw ZWRfdGVzdCk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxz L3Rlc3RfZXhwZWN0YXRpb25zX3VuaXR0ZXN0LnB5OgorICAgICAgICAoU2tpcHBlZFRlc3RzLnRl c3Rfc2tpcHBlZF9lbnRyeV9kb250X2V4aXN0KToKKwogMjAxMi0wOC0yOCAgR2Fib3IgUmFwY3Nh bnlpICA8cmdhYm9yQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBLZWVwIFFUX1FQQV9QTEFU Rk9STV9QTFVHSU5fUEFUSCBlbnZpcm9ubWVudCB2YXJpYWJsZSBpbiBOUldUCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3Rh dGlvbnMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVz dF9leHBlY3RhdGlvbnMucHkKaW5kZXggYjAyYmFmMy4uZThjZmJhMyAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25z LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0 X2V4cGVjdGF0aW9ucy5weQpAQCAtOTIsNiArOTIsOCBAQCBjbGFzcyBUZXN0RXhwZWN0YXRpb25Q YXJzZXIob2JqZWN0KToKICAgICAgICAgcmV0dXJuIGV4cGVjdGF0aW9uX2xpbmVzCiAKICAgICBk ZWYgZXhwZWN0YXRpb25fZm9yX3NraXBwZWRfdGVzdChzZWxmLCB0ZXN0X25hbWUpOgorICAgICAg ICBpZiBub3Qgc2VsZi5fcG9ydC50ZXN0X2V4aXN0cyh0ZXN0X25hbWUpOgorICAgICAgICAgICAg X2xvZy53YXJuaW5nKCdUaGUgZm9sbG93aW5nIHRlc3QgJXMgZnJvbSB0aGUgU2tpcHBlZCBsaXN0 IGRvZXNuXCd0IGV4aXN0cyEnICUgdGVzdF9uYW1lKQogICAgICAgICBleHBlY3RhdGlvbl9saW5l ID0gVGVzdEV4cGVjdGF0aW9uTGluZSgpCiAgICAgICAgIGV4cGVjdGF0aW9uX2xpbmUub3JpZ2lu YWxfc3RyaW5nID0gdGVzdF9uYW1lCiAgICAgICAgIGV4cGVjdGF0aW9uX2xpbmUubW9kaWZpZXJz ID0gW1Rlc3RFeHBlY3RhdGlvblBhcnNlci5EVU1NWV9CVUdfTU9ESUZJRVIsIFRlc3RFeHBlY3Rh dGlvblBhcnNlci5TS0lQX01PRElGSUVSXQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zX3VuaXR0ZXN0LnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRp b25zX3VuaXR0ZXN0LnB5CmluZGV4IDZjNzQwYmEuLjM5YTlhOGEgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9uc191 bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2Rl bHMvdGVzdF9leHBlY3RhdGlvbnNfdW5pdHRlc3QucHkKQEAgLTMwLDYgKzMwLDcgQEAKIGltcG9y dCB1bml0dGVzdAogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5ob3N0X21vY2sgaW1wb3J0IE1vY2tI b3N0Citmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0ub3V0cHV0Y2FwdHVyZSBpbXBvcnQgT3V0 cHV0Q2FwdHVyZQogCiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5tb2RlbHMudGVzdF9jb25m aWd1cmF0aW9uIGltcG9ydCAqCiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5tb2RlbHMudGVz dF9leHBlY3RhdGlvbnMgaW1wb3J0ICoKQEAgLTMwMiw2ICszMDMsMTggQEAgY2xhc3MgU2tpcHBl ZFRlc3RzKEJhc2UpOgogICAgICAgICBzZWxmLmNoZWNrKGV4cGVjdGF0aW9ucz0nJywgb3ZlcnJp ZGVzPSdCVUdYIDogZmFpbHVyZXMvZXhwZWN0ZWQvdGV4dC5odG1sID0gVEVYVFxuJywKICAgICAg ICAgICAgICAgICAgICBza2lwcz1bJ2ZhaWx1cmVzL2V4cGVjdGVkJ10pCiAKKyAgICBkZWYgdGVz dF9za2lwcGVkX2VudHJ5X2RvbnRfZXhpc3Qoc2VsZik6CisgICAgICAgIHBvcnQgPSBNb2NrSG9z dCgpLnBvcnRfZmFjdG9yeS5nZXQoJ3F0JykKKyAgICAgICAgZXhwZWN0YXRpb25zX2RpY3QgPSBP cmRlcmVkRGljdCgpCisgICAgICAgIGV4cGVjdGF0aW9uc19kaWN0WydleHBlY3RhdGlvbnMnXSA9 ICcnCisgICAgICAgIHBvcnQuZXhwZWN0YXRpb25zX2RpY3QgPSBsYW1iZGE6IGV4cGVjdGF0aW9u c19kaWN0CisgICAgICAgIHBvcnQuc2tpcHBlZF9sYXlvdXRfdGVzdHMgPSBsYW1iZGEgdGVzdHM6 IHNldChbJ2Zvby9iYXIvYmF6Lmh0bWwnXSkKKyAgICAgICAgY2FwdHVyZSA9IE91dHB1dENhcHR1 cmUoKQorICAgICAgICBjYXB0dXJlLmNhcHR1cmVfb3V0cHV0KCkKKyAgICAgICAgZXhwID0gVGVz dEV4cGVjdGF0aW9ucyhwb3J0KQorICAgICAgICBfLCBfLCBsb2dzID0gY2FwdHVyZS5yZXN0b3Jl X291dHB1dCgpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoJ1RoZSBmb2xsb3dpbmcgdGVzdCBm b28vYmFyL2Jhei5odG1sIGZyb20gdGhlIFNraXBwZWQgbGlzdCBkb2VzblwndCBleGlzdHMhXG4n LCBsb2dzKQorCiAKIGNsYXNzIEV4cGVjdGF0aW9uU3ludGF4VGVzdHMoQmFzZSk6CiAgICAgZGVm IHRlc3RfbWlzc2luZ19leHBlY3RhdGlvbihzZWxmKToK