93694 2012-08-10 00:25:28 -0700 FileWriter fails with assertion when trying to write empty Blob 2012-08-14 21:01:36 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kinuko kinuko abarth ericu levin tkent oldest_to_newest 692277 0 kinuko 2012-08-10 00:25:28 -0700 FileWriter fails with assertion when trying to write empty Blob Renderer crashed with message: > ASSERTION FAILED: bytes + m_bytesWritten > 0 > third_party/WebKit/Source/WebCore/fileapi/FileWriter.cpp(182) : virtual void WebCore::FileWriter::didWrite(long long int, bool) 692310 1 157660 kinuko 2012-08-10 00:53:02 -0700 Created attachment 157660 Patch 692313 2 kinuko 2012-08-10 00:53:53 -0700 Made a quick fix. EricU: can you take the first look? Thanks! 695675 3 kinuko 2012-08-14 19:39:59 -0700 Adding some more reviewers. Can someone take a look at this tiny change? Thanks! 695680 4 157660 tkent 2012-08-14 19:47:39 -0700 Comment on attachment 157660 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157660&action=review > LayoutTests/fast/filesystem/file-writer-empty-blob.html:4 > +<html> > + <head> > + <title>File Writer with empty Blob</title> Inconsistent indentation > LayoutTests/fast/filesystem/resources/file-writer-empty-blob.js:28 > +setupAndRunTest(2*1024*1024, 'file-writer-empty-blob', runTest); Need spaces before and after '*' > LayoutTests/fast/filesystem/workers/file-writer-empty-blob.html:4 > +<html> > + <head> > + <title>File Writer with empty Blob in Worker</title> inconsistent indentation 695691 5 kinuko 2012-08-14 20:16:24 -0700 Thanks kent-san! Will fix before submitting. 695713 6 kinuko 2012-08-14 21:01:36 -0700 Committed r125643: <http://trac.webkit.org/changeset/125643> 157660 2012-08-10 00:53:02 -0700 2012-08-14 19:47:39 -0700 Patch bug-93694-20120810165234.patch text/plain 6876 kinuko U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGY3NjJkMDM4MDNlYWE1 YTdlYzgxODRhM2Q0Nzc0NTk1NzljZDdjMy4uOWQ2NDg5MDlmNWE0MGRiZTgyMGE1N2Y3MGVmMDk3 NzI5NTEyN2FlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTEwICBLaW51 a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaWxlV3JpdGVyIGZh aWxzIHdpdGggYXNzZXJ0aW9uIHdoZW4gdHJ5aW5nIHRvIHdyaXRlIGVtcHR5IEJsb2IKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNjk0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaWYgdGhlIGdpdmVuIGRh dGEgc2l6ZSBpcyB6ZXJvIChpLmUuIG1fYnl0ZXNUb1dyaXRlIGlzIHplcm8pIHRoZSBhc3NlcnRp b24gJ2J5dGVzICsgbV9ieXRlc1dyaXR0ZW4gPiAwJyBzaG91bGQgbm90IGJlIHRlc3RlZC4KKwor ICAgICAgICBUZXN0czogZmFzdC9maWxlc3lzdGVtL2ZpbGUtd3JpdGVyLWVtcHR5LWJsb2IuaHRt bAorICAgICAgICAgICAgICAgZmFzdC9maWxlc3lzdGVtL3dvcmtlcnMvZmlsZS13cml0ZXItZW1w dHktYmxvYi5odG1sCisKKyAgICAgICAgKiBNb2R1bGVzL2ZpbGVzeXN0ZW0vRmlsZVdyaXRlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpGaWxlV3JpdGVyOjpkaWRXcml0ZSk6CisKIDIwMTItMDgt MDggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUkVH UkVTU0lPTihyMTI1MDQ2KTogQnJlYWtzIGRlYnVnIGJ1aWxkIChhc3NlcnRpb24gaW4gcHJvdG9j b2wgdHlwZSBjaGVja3MpIChSZXF1ZXN0ZWQgYnkgcGZlbGRtYW4gb24gI3dlYmtpdCkuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZpbGVzeXN0ZW0vRmlsZVdyaXRlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZpbGVzeXN0ZW0vRmlsZVdyaXRlci5jcHAKaW5kZXgg ZWNiNDQ3NWQwZWVjM2ZjNTM4YTllODlkMTZkYzY3NDYxMGU1ZmI2ZC4uNTJiY2JhNzUzMTVhZWQy OGUzMDJkNDRlNzJhNzFhNWIyNzFmYmU0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9maWxlc3lzdGVtL0ZpbGVXcml0ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvZmlsZXN5c3RlbS9GaWxlV3JpdGVyLmNwcApAQCAtMTg4LDcgKzE4OCw3IEBAIHZvaWQgRmls ZVdyaXRlcjo6ZGlkV3JpdGUobG9uZyBsb25nIGJ5dGVzLCBib29sIGNvbXBsZXRlKQogICAgIEFT U0VSVChtX3JlYWR5U3RhdGUgPT0gV1JJVElORyk7CiAgICAgQVNTRVJUKG1fdHJ1bmNhdGVMZW5n dGggPT0gLTEpOwogICAgIEFTU0VSVChtX29wZXJhdGlvbkluUHJvZ3Jlc3MgPT0gT3BlcmF0aW9u V3JpdGUpOwotICAgIEFTU0VSVChieXRlcyArIG1fYnl0ZXNXcml0dGVuID4gMCk7CisgICAgQVNT RVJUKCFtX2J5dGVzVG9Xcml0ZSB8fCBieXRlcyArIG1fYnl0ZXNXcml0dGVuID4gMCk7CiAgICAg QVNTRVJUKGJ5dGVzICsgbV9ieXRlc1dyaXR0ZW4gPD0gbV9ieXRlc1RvV3JpdGUpOwogICAgIG1f Ynl0ZXNXcml0dGVuICs9IGJ5dGVzOwogICAgIEFTU0VSVCgobV9ieXRlc1dyaXR0ZW4gPT0gbV9i eXRlc1RvV3JpdGUpIHx8ICFjb21wbGV0ZSk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOWY0YzdiMzYxMTRiMTgzNjYzZmVk ZGMxMDFhNTYwN2ZiOGQwODUxNS4uZDA3M2ZlYzZkMmJkZWMzY2VkNjM0NjgzM2QzYzliMzQ4MWYy Y2RkMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTEwICBLaW51a28gWWFzdWRhICA8 a2ludWtvQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaWxlV3JpdGVyIGZhaWxzIHdpdGggYXNz ZXJ0aW9uIHdoZW4gdHJ5aW5nIHRvIHdyaXRlIGVtcHR5IEJsb2IKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNjk0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaWYgdGhlIGdpdmVuIGRhdGEgc2l6ZSBpcyB6 ZXJvIChpLmUuIG1fYnl0ZXNUb1dyaXRlIGlzIHplcm8pIHRoZSBhc3NlcnRpb24gJ2J5dGVzICsg bV9ieXRlc1dyaXR0ZW4gPiAwJyBzaG91bGQgbm90IGJlIHRlc3RlZC4KKworICAgICAgICAqIGZh c3QvZmlsZXN5c3RlbS9maWxlLXdyaXRlci1lbXB0eS1ibG9iLWV4cGVjdGVkLnR4dDogQWRkZWQu CisgICAgICAgICogZmFzdC9maWxlc3lzdGVtL2ZpbGUtd3JpdGVyLWVtcHR5LWJsb2IuaHRtbDog QWRkZWQuCisgICAgICAgICogZmFzdC9maWxlc3lzdGVtL3Jlc291cmNlcy9maWxlLXdyaXRlci1l bXB0eS1ibG9iLmpzOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2ZpbGVzeXN0ZW0vd29ya2Vycy9m aWxlLXdyaXRlci1lbXB0eS1ibG9iLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFz dC9maWxlc3lzdGVtL3dvcmtlcnMvZmlsZS13cml0ZXItZW1wdHktYmxvYi5odG1sOiBBZGRlZC4K KwogMjAxMi0wOC0wOCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSRUdSRVNTSU9OKHIxMjUwNDYpOiBCcmVha3MgZGVidWcgYnVpbGQgKGFzc2VydGlv biBpbiBwcm90b2NvbCB0eXBlIGNoZWNrcykgKFJlcXVlc3RlZCBieSBwZmVsZG1hbiBvbiAjd2Vi a2l0KS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZmlsZXN5c3RlbS9maWxlLXdyaXRl ci1lbXB0eS1ibG9iLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZmlsZXN5c3RlbS9m aWxlLXdyaXRlci1lbXB0eS1ibG9iLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wOTIwYjBiMzJi ZmI1NThhNzcxNDk3OWY2Mjk0MGYwMGM3ZjRmMjRlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9maWxlc3lzdGVtL2ZpbGUtd3JpdGVyLWVtcHR5LWJsb2ItZXhwZWN0ZWQudHh0 CkBAIC0wLDAgKzEsMTAgQEAKK1Rlc3QgdGhhdCBGaWxlV3JpdGVyIHdvcmtzIHdpdGhvdXQgY3Jh c2ggd2hlbiB0cnlpbmcgdG8gd3JpdGUgYW4gZW1wdHkgYmxvYi4KKworT24gc3VjY2VzcywgeW91 IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1Qg Q09NUExFVEUiLgorCitzdGFydGluZyB0ZXN0CitQQVNTIFN1Y2Nlc3NmdWxseSB3cm90ZSBibG9i LgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZmlsZXN5c3RlbS9maWxlLXdyaXRlci1lbXB0eS1i bG9iLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2ZpbGVzeXN0ZW0vZmlsZS13cml0ZXItZW1wdHkt YmxvYi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjAxYTU2YTcxODJlZGU0MmJlNjE4ZjBiMGY2MTBmYTUxMDhm MDk3MzQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2ZpbGVzeXN0ZW0vZmls ZS13cml0ZXItZW1wdHktYmxvYi5odG1sCkBAIC0wLDAgKzEsMTUgQEAKKzwhRE9DVFlQRSBIVE1M PgorPGh0bWw+CisgPGhlYWQ+CisgICAgPHRpdGxlPkZpbGUgV3JpdGVyIHdpdGggZW1wdHkgQmxv YjwvdGl0bGU+CisgICAgPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5q cyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9InJlc291cmNlcy9maWxlLXdyaXRlci11dGls cy5qcyI+PC9zY3JpcHQ+CisgPC9oZWFkPgorIDxib2R5PgorICAgIDxkaXYgaWQ9ImRlc2NyaXB0 aW9uIj48L2Rpdj4KKyAgICA8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKyAgICA8c2NyaXB0IHNy Yz0icmVzb3VyY2VzL2ZpbGUtd3JpdGVyLWVtcHR5LWJsb2IuanMiPjwvc2NyaXB0PgorICAgIDxz Y3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKyA8 L2JvZHk+Cis8L2h0bWw+CisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZmlsZXN5c3Rl bS9yZXNvdXJjZXMvZmlsZS13cml0ZXItZW1wdHktYmxvYi5qcyBiL0xheW91dFRlc3RzL2Zhc3Qv ZmlsZXN5c3RlbS9yZXNvdXJjZXMvZmlsZS13cml0ZXItZW1wdHktYmxvYi5qcwpuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li5jYzVlMmQwYzhiNzU3MjVhNzZlZGRjMjQyMDM5M2RjY2FiNWZiM2I5Ci0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9maWxlc3lzdGVtL3Jlc291cmNlcy9maWxlLXdyaXRlci1l bXB0eS1ibG9iLmpzCkBAIC0wLDAgKzEsMjkgQEAKK2lmICh0aGlzLmltcG9ydFNjcmlwdHMpIHsK KyAgICBpbXBvcnRTY3JpcHRzKCdmcy13b3JrZXItY29tbW9uLmpzJyk7CisgICAgaW1wb3J0U2Ny aXB0cygnLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzJyk7CisgICAgaW1wb3J0U2Ny aXB0cygnZmlsZS13cml0ZXItdXRpbHMuanMnKTsKK30KKworZGVzY3JpcHRpb24oIlRlc3QgdGhh dCBGaWxlV3JpdGVyIHdvcmtzIHdpdGhvdXQgY3Jhc2ggd2hlbiB0cnlpbmcgdG8gd3JpdGUgYW4g ZW1wdHkgYmxvYi4iKTsKKwordmFyIGZpbGVFbnRyeTsKKworZnVuY3Rpb24gb25UZXN0U3VjY2Vz cygpIHsKKyAgICB0ZXN0UGFzc2VkKCJTdWNjZXNzZnVsbHkgd3JvdGUgYmxvYi4iKTsKKyAgICBj bGVhblVwKCk7Cit9CisKK2Z1bmN0aW9uIHN0YXJ0V3JpdGUod3JpdGVyKSB7CisgICAgdmFyIGJs b2IgPSBuZXcgQmxvYihbIiJdKTsKKyAgICB3cml0ZXIub25lcnJvciA9IG9uRXJyb3I7CisgICAg d3JpdGVyLm9ud3JpdGVlbmQgPSBvblRlc3RTdWNjZXNzOworICAgIHdyaXRlci53cml0ZShibG9i KTsKK30KKworZnVuY3Rpb24gcnVuVGVzdCh1bnVzZWRGaWxlRW50cnksIGZpbGVXcml0ZXIpIHsK KyAgICBzdGFydFdyaXRlKGZpbGVXcml0ZXIpOworICAgIGdjKCk7Cit9Cit2YXIganNUZXN0SXNB c3luYyA9IHRydWU7CitzZXR1cEFuZFJ1blRlc3QoMioxMDI0KjEwMjQsICdmaWxlLXdyaXRlci1l bXB0eS1ibG9iJywgcnVuVGVzdCk7CisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZmls ZXN5c3RlbS93b3JrZXJzL2ZpbGUtd3JpdGVyLWVtcHR5LWJsb2ItZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvZmFzdC9maWxlc3lzdGVtL3dvcmtlcnMvZmlsZS13cml0ZXItZW1wdHktYmxvYi1l eHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYWY2YWE2ZTc2MzQzMDM4NGE1YmQxYzI4NTAyNjA4NDky NmY5OGY5MgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZmlsZXN5c3RlbS93 b3JrZXJzL2ZpbGUtd3JpdGVyLWVtcHR5LWJsb2ItZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTEg QEAKK1tXb3JrZXJdIFRlc3QgdGhhdCBGaWxlV3JpdGVyIHdvcmtzIHdpdGhvdXQgY3Jhc2ggd2hl biB0cnlpbmcgdG8gd3JpdGUgYW4gZW1wdHkgYmxvYi4KKworT24gc3VjY2VzcywgeW91IHdpbGwg c2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExF VEUiLgorCitTdGFydGluZyB3b3JrZXI6IC4uL3Jlc291cmNlcy9maWxlLXdyaXRlci1lbXB0eS1i bG9iLmpzCitbV29ya2VyXSBzdGFydGluZyB0ZXN0CitQQVNTIFtXb3JrZXJdIFN1Y2Nlc3NmdWxs eSB3cm90ZSBibG9iLgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENP TVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZmlsZXN5c3RlbS93b3JrZXJz L2ZpbGUtd3JpdGVyLWVtcHR5LWJsb2IuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZmlsZXN5c3Rl bS93b3JrZXJzL2ZpbGUtd3JpdGVyLWVtcHR5LWJsb2IuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jYTUwYTgy ZTYzNmZhNDU4ZTU4MzQ1OWZlMWNhYmVlZjMyZjcyZDg3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9maWxlc3lzdGVtL3dvcmtlcnMvZmlsZS13cml0ZXItZW1wdHktYmxvYi5o dG1sCkBAIC0wLDAgKzEsMTUgQEAKKzwhRE9DVFlQRSBIVE1MPgorPGh0bWw+CisgPGhlYWQ+Cisg ICAgPHRpdGxlPkZpbGUgV3JpdGVyIHdpdGggZW1wdHkgQmxvYiBpbiBXb3JrZXI8L3RpdGxlPgor ICAgIDxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2Ny aXB0PgorIDwvaGVhZD4KKyA8Ym9keT4KKyAgICA8ZGl2IGlkPSJkZXNjcmlwdGlvbiI+PC9kaXY+ CisgICAgPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisgICAgPHNjcmlwdD4KKyAgICAgICAgc3Rh cnRXb3JrZXIoIi4uL3Jlc291cmNlcy9maWxlLXdyaXRlci1lbXB0eS1ibG9iLmpzIik7CisgICAg PC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBv c3QuanMiPjwvc2NyaXB0PgorIDwvYm9keT4KKzwvaHRtbD4K