93682 2012-08-09 20:27:47 -0700 [V8] Remove collectIsolatedContexts() from V8Proxy 2012-08-10 08:20:25 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85330 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 692149 0 haraken 2012-08-09 20:27:47 -0700 We want to remove V8Proxy. In this bug we remove V8Proxy::collectIsolatedContexts(). 692152 1 157624 haraken 2012-08-09 20:29:28 -0700 Created attachment 157624 Patch 692318 2 157624 abarth 2012-08-10 00:58:19 -0700 Comment on attachment 157624 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157624&action=review > Source/WebCore/bindings/v8/V8Proxy.cpp:670 > void V8Proxy::collectIsolatedContexts(Vector<std::pair<ScriptState*, SecurityOrigin*> >& result) > { Should we remove the function itself? 692504 3 157719 haraken 2012-08-10 06:00:40 -0700 Created attachment 157719 patch for landing 692546 4 157719 webkit.review.bot 2012-08-10 08:16:38 -0700 Comment on attachment 157719 patch for landing Clearing flags on attachment: 157719 Committed r125279: <http://trac.webkit.org/changeset/125279> 157624 2012-08-09 20:29:28 -0700 2012-08-10 08:20:14 -0700 Patch bug-93682-20120810122900.patch text/plain 3341 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjFlMWViY2Q0ZWE2NzYz M2QyYjEwNzk3ODQwOThiOWM2M2I3ZjVmOC4uZWE0MjcwYmRmNjFhYzU2ODYxNDIwODJlOTI5YjI3 N2YxOWY3NGEwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTA5ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbW92ZSBj b2xsZWN0SXNvbGF0ZWRDb250ZXh0cygpIGZyb20gVjhQcm94eQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM2ODIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB3YW50IHRvIHJlbW92ZSBWOFByb3h5LiBU aGlzIHBhdGNoIHJlbW92ZXMgVjhQcm94eTo6Y29sbGVjdElzb2xhdGVkQ29udGV4dHMoKS4KKwor ICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmlu ZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRD b250cm9sbGVyOjpjb2xsZWN0SXNvbGF0ZWRDb250ZXh0cyk6CisgICAgICAgICogYmluZGluZ3Mv djgvVjhQcm94eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOFByb3h5Ojpjb2xsZWN0SXNvbGF0 ZWRDb250ZXh0cyk6CisKIDIwMTItMDgtMDkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KIAogICAgICAgICBTYW5kYm94aW5nIHZpZXcgc291cmNlIGRvY3VtZW50cyBpcyBpbmVmZmVj dGl2ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJv bGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNw cAppbmRleCAxZTMzZTJhZjFlZDY2YmQ0NjZmZDEwYTZjYzg0MmExZDcwNWFkNDViLi5hNzEzODAy MTdlM2YyYjFiNTQ1MDg0YTE5NGEyMDFmY2U3YTkxZjkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcApAQCAtNDQyLDcgKzQ0MiwxNyBAQCB2 b2lkIFNjcmlwdENvbnRyb2xsZXI6OnNldENhcHR1cmVDYWxsU3RhY2tGb3JVbmNhdWdodEV4Y2Vw dGlvbnMoYm9vbCB2YWx1ZSkKIAogdm9pZCBTY3JpcHRDb250cm9sbGVyOjpjb2xsZWN0SXNvbGF0 ZWRDb250ZXh0cyhWZWN0b3I8c3RkOjpwYWlyPFNjcmlwdFN0YXRlKiwgU2VjdXJpdHlPcmlnaW4q PiA+JiByZXN1bHQpCiB7Ci0gICAgbV9wcm94eS0+Y29sbGVjdElzb2xhdGVkQ29udGV4dHMocmVz dWx0KTsKKyAgICB2ODo6SGFuZGxlU2NvcGUgaGFuZGxlU2NvcGU7CisgICAgZm9yIChJc29sYXRl ZFdvcmxkTWFwOjppdGVyYXRvciBpdCA9IG1fcHJveHktPmlzb2xhdGVkV29ybGRzKCkuYmVnaW4o KTsgaXQgIT0gbV9wcm94eS0+aXNvbGF0ZWRXb3JsZHMoKS5lbmQoKTsgKytpdCkgeworICAgICAg ICBWOElzb2xhdGVkQ29udGV4dCogaXNvbGF0ZWRDb250ZXh0ID0gaXQtPnNlY29uZDsKKyAgICAg ICAgaWYgKCFpc29sYXRlZENvbnRleHQtPnNlY3VyaXR5T3JpZ2luKCkpCisgICAgICAgICAgICBj b250aW51ZTsKKyAgICAgICAgdjg6OkhhbmRsZTx2ODo6Q29udGV4dD4gdjhDb250ZXh0ID0gaXNv bGF0ZWRDb250ZXh0LT5jb250ZXh0KCk7CisgICAgICAgIGlmICh2OENvbnRleHQuSXNFbXB0eSgp KQorICAgICAgICAgICAgY29udGludWU7CisgICAgICAgIFNjcmlwdFN0YXRlKiBzY3JpcHRTdGF0 ZSA9IFNjcmlwdFN0YXRlOjpmb3JDb250ZXh0KHY4OjpMb2NhbDx2ODo6Q29udGV4dD46Ok5ldyh2 OENvbnRleHQpKTsKKyAgICAgICAgcmVzdWx0LmFwcGVuZChzdGQ6OnBhaXI8U2NyaXB0U3RhdGUq LCBTZWN1cml0eU9yaWdpbio+KHNjcmlwdFN0YXRlLCBpc29sYXRlZENvbnRleHQtPnNlY3VyaXR5 T3JpZ2luKCkpKTsKKyAgICB9CiB9CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OFByb3h5LmNwcAppbmRleCBiNjM3ZDRkNWJhMmFhMWQ2MTM2ZmFmNDU3OGYzMDgyZWNmMmIzZjE0 Li4wZTkxZTIzZDE1MDI2NDkxNGIyZDczZjZiYjdiZDIyZmM4OWEwM2UyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcApAQCAtNjY4LDE3ICs2NjgsNiBAQCBpbnQgVjhQcm94 eTo6Y29udGV4dERlYnVnSWQodjg6OkhhbmRsZTx2ODo6Q29udGV4dD4gY29udGV4dCkKIAogdm9p ZCBWOFByb3h5Ojpjb2xsZWN0SXNvbGF0ZWRDb250ZXh0cyhWZWN0b3I8c3RkOjpwYWlyPFNjcmlw dFN0YXRlKiwgU2VjdXJpdHlPcmlnaW4qPiA+JiByZXN1bHQpCiB7Ci0gICAgdjg6OkhhbmRsZVNj b3BlIGhhbmRsZVNjb3BlOwotICAgIGZvciAoSXNvbGF0ZWRXb3JsZE1hcDo6aXRlcmF0b3IgaXQg PSBtX2lzb2xhdGVkV29ybGRzLmJlZ2luKCk7IGl0ICE9IG1faXNvbGF0ZWRXb3JsZHMuZW5kKCk7 ICsraXQpIHsKLSAgICAgICAgVjhJc29sYXRlZENvbnRleHQqIGlzb2xhdGVkQ29udGV4dCA9IGl0 LT5zZWNvbmQ7Ci0gICAgICAgIGlmICghaXNvbGF0ZWRDb250ZXh0LT5zZWN1cml0eU9yaWdpbigp KQotICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+ IHY4Q29udGV4dCA9IGlzb2xhdGVkQ29udGV4dC0+Y29udGV4dCgpOwotICAgICAgICBpZiAodjhD b250ZXh0LklzRW1wdHkoKSkKLSAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICBTY3JpcHRT dGF0ZSogc2NyaXB0U3RhdGUgPSBTY3JpcHRTdGF0ZTo6Zm9yQ29udGV4dCh2ODo6TG9jYWw8djg6 OkNvbnRleHQ+OjpOZXcodjhDb250ZXh0KSk7Ci0gICAgICAgIHJlc3VsdC5hcHBlbmQoc3RkOjpw YWlyPFNjcmlwdFN0YXRlKiwgU2VjdXJpdHlPcmlnaW4qPihzY3JpcHRTdGF0ZSwgaXNvbGF0ZWRD b250ZXh0LT5zZWN1cml0eU9yaWdpbigpKSk7Ci0gICAgfQogfQogCiB2ODo6TG9jYWw8djg6OkNv bnRleHQ+IHRvVjhDb250ZXh0KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIGNvbnN0 IFdvcmxkQ29udGV4dEhhbmRsZSYgd29ybGRDb250ZXh0KQo= 157719 2012-08-10 06:00:40 -0700 2012-08-10 08:16:38 -0700 patch for landing bug-93682-20120810220011.patch text/plain 4069 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjFlMWViY2Q0ZWE2NzYz M2QyYjEwNzk3ODQwOThiOWM2M2I3ZjVmOC4uMDRmZDQ5NGYyM2U5ZGZjZTA5NmI4NjM1MDEyMTUw ZjIyYmIzYWRiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTA5ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbW92ZSBj b2xsZWN0SXNvbGF0ZWRDb250ZXh0cygpIGZyb20gVjhQcm94eQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM2ODIKKworICAgICAgICBSZXZpZXdlZCBi eSBBZGFtIEJhcnRoLgorCisgICAgICAgIFdlIHdhbnQgdG8gcmVtb3ZlIFY4UHJveHkuIFRoaXMg cGF0Y2ggcmVtb3ZlcyBWOFByb3h5Ojpjb2xsZWN0SXNvbGF0ZWRDb250ZXh0cygpLgorCisgICAg ICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5n cy92OC9TY3JpcHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRy b2xsZXI6OmNvbGxlY3RJc29sYXRlZENvbnRleHRzKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9W OFByb3h5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4UHJveHk6OmNvbGxlY3RJc29sYXRlZENv bnRleHRzKToKKwogMjAxMi0wOC0wOSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgog CiAgICAgICAgIFNhbmRib3hpbmcgdmlldyBzb3VyY2UgZG9jdW1lbnRzIGlzIGluZWZmZWN0aXZl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwCmlu ZGV4IDFlMzNlMmFmMWVkNjZiZDQ2NmZkMTBhNmNjODQyYTFkNzA1YWQ0NWIuLmE3MTM4MDIxN2Uz ZjJiMWI1NDUwODRhMTk0YTIwMWZjZTdhOTFmOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwCkBAIC00NDIsNyArNDQyLDE3IEBAIHZvaWQg U2NyaXB0Q29udHJvbGxlcjo6c2V0Q2FwdHVyZUNhbGxTdGFja0ZvclVuY2F1Z2h0RXhjZXB0aW9u cyhib29sIHZhbHVlKQogCiB2b2lkIFNjcmlwdENvbnRyb2xsZXI6OmNvbGxlY3RJc29sYXRlZENv bnRleHRzKFZlY3RvcjxzdGQ6OnBhaXI8U2NyaXB0U3RhdGUqLCBTZWN1cml0eU9yaWdpbio+ID4m IHJlc3VsdCkKIHsKLSAgICBtX3Byb3h5LT5jb2xsZWN0SXNvbGF0ZWRDb250ZXh0cyhyZXN1bHQp OworICAgIHY4OjpIYW5kbGVTY29wZSBoYW5kbGVTY29wZTsKKyAgICBmb3IgKElzb2xhdGVkV29y bGRNYXA6Oml0ZXJhdG9yIGl0ID0gbV9wcm94eS0+aXNvbGF0ZWRXb3JsZHMoKS5iZWdpbigpOyBp dCAhPSBtX3Byb3h5LT5pc29sYXRlZFdvcmxkcygpLmVuZCgpOyArK2l0KSB7CisgICAgICAgIFY4 SXNvbGF0ZWRDb250ZXh0KiBpc29sYXRlZENvbnRleHQgPSBpdC0+c2Vjb25kOworICAgICAgICBp ZiAoIWlzb2xhdGVkQ29udGV4dC0+c2VjdXJpdHlPcmlnaW4oKSkKKyAgICAgICAgICAgIGNvbnRp bnVlOworICAgICAgICB2ODo6SGFuZGxlPHY4OjpDb250ZXh0PiB2OENvbnRleHQgPSBpc29sYXRl ZENvbnRleHQtPmNvbnRleHQoKTsKKyAgICAgICAgaWYgKHY4Q29udGV4dC5Jc0VtcHR5KCkpCisg ICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgU2NyaXB0U3RhdGUqIHNjcmlwdFN0YXRlID0g U2NyaXB0U3RhdGU6OmZvckNvbnRleHQodjg6OkxvY2FsPHY4OjpDb250ZXh0Pjo6TmV3KHY4Q29u dGV4dCkpOworICAgICAgICByZXN1bHQuYXBwZW5kKHN0ZDo6cGFpcjxTY3JpcHRTdGF0ZSosIFNl Y3VyaXR5T3JpZ2luKj4oc2NyaXB0U3RhdGUsIGlzb2xhdGVkQ29udGV4dC0+c2VjdXJpdHlPcmln aW4oKSkpOworICAgIH0KIH0KICNlbmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9WOFByb3h5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJv eHkuY3BwCmluZGV4IGI2MzdkNGQ1YmEyYWExZDYxMzZmYWY0NTc4ZjMwODJlY2YyYjNmMTQuLmIw NmU0OWEyZDMzNGM0ZjZmYjM5ZDRlYWY3ZWEzMDU0YWViY2Y0OTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4UHJveHkuY3BwCkBAIC02NjYsMjEgKzY2Niw2IEBAIGludCBWOFByb3h5Ojpj b250ZXh0RGVidWdJZCh2ODo6SGFuZGxlPHY4OjpDb250ZXh0PiBjb250ZXh0KQogICAgIHJldHVy biBhdG9pKGNvbW1hICsgMSk7CiB9CiAKLXZvaWQgVjhQcm94eTo6Y29sbGVjdElzb2xhdGVkQ29u dGV4dHMoVmVjdG9yPHN0ZDo6cGFpcjxTY3JpcHRTdGF0ZSosIFNlY3VyaXR5T3JpZ2luKj4gPiYg cmVzdWx0KQotewotICAgIHY4OjpIYW5kbGVTY29wZSBoYW5kbGVTY29wZTsKLSAgICBmb3IgKElz b2xhdGVkV29ybGRNYXA6Oml0ZXJhdG9yIGl0ID0gbV9pc29sYXRlZFdvcmxkcy5iZWdpbigpOyBp dCAhPSBtX2lzb2xhdGVkV29ybGRzLmVuZCgpOyArK2l0KSB7Ci0gICAgICAgIFY4SXNvbGF0ZWRD b250ZXh0KiBpc29sYXRlZENvbnRleHQgPSBpdC0+c2Vjb25kOwotICAgICAgICBpZiAoIWlzb2xh dGVkQ29udGV4dC0+c2VjdXJpdHlPcmlnaW4oKSkKLSAgICAgICAgICAgIGNvbnRpbnVlOwotICAg ICAgICB2ODo6SGFuZGxlPHY4OjpDb250ZXh0PiB2OENvbnRleHQgPSBpc29sYXRlZENvbnRleHQt PmNvbnRleHQoKTsKLSAgICAgICAgaWYgKHY4Q29udGV4dC5Jc0VtcHR5KCkpCi0gICAgICAgICAg ICBjb250aW51ZTsKLSAgICAgICAgU2NyaXB0U3RhdGUqIHNjcmlwdFN0YXRlID0gU2NyaXB0U3Rh dGU6OmZvckNvbnRleHQodjg6OkxvY2FsPHY4OjpDb250ZXh0Pjo6TmV3KHY4Q29udGV4dCkpOwot ICAgICAgICByZXN1bHQuYXBwZW5kKHN0ZDo6cGFpcjxTY3JpcHRTdGF0ZSosIFNlY3VyaXR5T3Jp Z2luKj4oc2NyaXB0U3RhdGUsIGlzb2xhdGVkQ29udGV4dC0+c2VjdXJpdHlPcmlnaW4oKSkpOwot ICAgIH0KLX0KLQogdjg6OkxvY2FsPHY4OjpDb250ZXh0PiB0b1Y4Q29udGV4dChTY3JpcHRFeGVj dXRpb25Db250ZXh0KiBjb250ZXh0LCBjb25zdCBXb3JsZENvbnRleHRIYW5kbGUmIHdvcmxkQ29u dGV4dCkKIHsKICAgICBpZiAoY29udGV4dC0+aXNEb2N1bWVudCgpKSB7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOFByb3h5LmgKaW5kZXggODI3MmNkMmE5N2JiMDIyZTI2NmY1OWViZWYwMDRhN2Zk ZDA1NWU1MC4uYjZmNDdkNWViNzBhYzBjYTNiOTdkMjgyYWRlNTI5ZWU4YmRkOTE0MyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaApAQCAtMTcwLDcgKzE3MCw2IEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIAogICAgICAgICBib29sIHNldENvbnRleHREZWJ1Z0lkKGludCBpZCk7CiAg ICAgICAgIHN0YXRpYyBpbnQgY29udGV4dERlYnVnSWQodjg6OkhhbmRsZTx2ODo6Q29udGV4dD4p OwotICAgICAgICB2b2lkIGNvbGxlY3RJc29sYXRlZENvbnRleHRzKFZlY3RvcjxzdGQ6OnBhaXI8 U2NyaXB0U3RhdGUqLCBTZWN1cml0eU9yaWdpbio+ID4mKTsKIAogICAgICAgICAvLyBSZWdpc3Rl cnMgYSB2OCBleHRlbnNpb24gdG8gYmUgYXZhaWxhYmxlIG9uIHdlYnBhZ2VzLiBXaWxsIG9ubHkK ICAgICAgICAgLy8gYWZmZWN0IHY4IGNvbnRleHRzIGluaXRpYWxpemVkIGFmdGVyIHRoaXMgY2Fs bC4gVGFrZXMgb3duZXJzaGlwIG9mCg==