93663 2012-08-09 15:45:51 -0700 Crash exiting from HTML5 FS mode to normal mode via ESC key 2012-08-13 16:30:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble oldest_to_newest 691937 0 jer.noble 2012-08-09 15:45:51 -0700 Crash exiting from HTML5 FS mode to normal mode via ESC key 691943 1 157568 jer.noble 2012-08-09 15:50:10 -0700 Created attachment 157568 Patch 692839 2 jer.noble 2012-08-10 13:16:59 -0700 Committed r125319: <http://trac.webkit.org/changeset/125319> 694124 3 157568 darin 2012-08-13 14:55:06 -0700 Comment on attachment 157568 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157568&action=review > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:-148 > - _watchdogTimer = adoptNS([NSTimer scheduledTimerWithTimeInterval:DefaultWatchdogTimerInterval target:self selector:@selector(exitFullScreen) userInfo:nil repeats:NO]); Or you could just take out the adoptNS and do a straight assignment. That would also work. 694207 4 jer.noble 2012-08-13 16:30:38 -0700 (In reply to comment #3) > (From update of attachment 157568 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157568&action=review > > > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:-148 > > - _watchdogTimer = adoptNS([NSTimer scheduledTimerWithTimeInterval:DefaultWatchdogTimerInterval target:self selector:@selector(exitFullScreen) userInfo:nil repeats:NO]); > > Or you could just take out the adoptNS and do a straight assignment. That would also work. I considered that, but I was simultaneously getting rid of the autorelease. 157568 2012-08-09 15:50:10 -0700 2012-08-13 14:55:06 -0700 Patch bug-93663-20120809154943.patch text/plain 2061 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzBiYzhhNTQwODg1ZWM0 Mjk4ZWEzYTcyZTQ0NDg2MjEyY2IxYWY2NS4uZjg5ZGQ5MDg2YWVhN2VhZDM1ZjE4M2FlMjkwYjhk NGYyOGY1Yzg0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTA5ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGV4aXRpbmcgZnJv bSBIVE1MNSBGUyBtb2RlIHRvIG5vcm1hbCBtb2RlIHZpYSBFU0Mga2V5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzY2MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENyYXNoIGlzIGR1ZSB0byBhIHJlZmNv dW50IHVuZGVycnVuIHdpdGggX3dhdGNoZG9nVGltZXIgZHVlIHRvIGFkb3B0aW5nIGFuIGF1dG9y ZWxlYXNlZCBOU1RpbWVyLgorICAgICAgICBVc2UgdGhlIG5vbi1hdXRvcmVsZWFzZWQgTlNUaW1l ciBjcmVhdGlvbiBtZXRob2QgYW5kIG1hbnVhbGx5IGFkZCB0byB0aGUgbWFpbiBOU1J1bkxvb3Au CisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIu bW06CisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgY2FuY2VsT3BlcmF0 aW9uOl0pOgorCiAyMDEyLTA4LTA4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5j b20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogQ3Jhc2ggd2hlbiBwbHVnLWluIGluaXRpYWxpemF0 aW9uIGZhaWxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVs bFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFj L1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0KaW5kZXggNTI5M2M0ODg5MWYxMTZkOTNm YzI3ZjM4MWQzMjY1OWViMGQ1MmRhMy4uYjVmYzAxMmM5ODQ1MGI5YmE3NzgxNDlhZTg4YWNlNTEy ZTNmOWIxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Z1bGxT Y3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9t YWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQpAQCAtMTQ0LDggKzE0NCwxMCBAQCBz dGF0aWMgTlNSZWN0IGNvbnZlcnRSZWN0VG9TY3JlZW4oTlNXaW5kb3cgKndpbmRvdywgTlNSZWN0 IHJlY3QpCiAKICAgICAvLyBJZiB0aGUgcGFnZSBkb2Vzbid0IHJlc3BvbmQgaW4gRGVmYXVsdFdh dGNoZG9nVGltZXJJbnRlcnZhbCBzZWNvbmRzLCBpdCBjb3VsZCBiZSBiZWNhdXNlCiAgICAgLy8g dGhlIFdlYlByb2Nlc3MgaGFzIGh1bmcsIHNvIGV4aXQgYW55d2F5LgotICAgIGlmICghX3dhdGNo ZG9nVGltZXIpCi0gICAgICAgIF93YXRjaGRvZ1RpbWVyID0gYWRvcHROUyhbTlNUaW1lciBzY2hl ZHVsZWRUaW1lcldpdGhUaW1lSW50ZXJ2YWw6RGVmYXVsdFdhdGNoZG9nVGltZXJJbnRlcnZhbCB0 YXJnZXQ6c2VsZiBzZWxlY3RvcjpAc2VsZWN0b3IoZXhpdEZ1bGxTY3JlZW4pIHVzZXJJbmZvOm5p bCByZXBlYXRzOk5PXSk7CisgICAgaWYgKCFfd2F0Y2hkb2dUaW1lcikgeworICAgICAgICBfd2F0 Y2hkb2dUaW1lciA9IGFkb3B0TlMoW1tOU1RpbWVyIGFsbG9jXSBpbml0V2l0aEZpcmVEYXRlOm5p bCBpbnRlcnZhbDpEZWZhdWx0V2F0Y2hkb2dUaW1lckludGVydmFsIHRhcmdldDpzZWxmIHNlbGVj dG9yOkBzZWxlY3RvcihleGl0RnVsbFNjcmVlbikgdXNlckluZm86bmlsIHJlcGVhdHM6Tk9dKTsK KyAgICAgICAgW1tOU1J1bkxvb3AgbWFpblJ1bkxvb3BdIGFkZFRpbWVyOl93YXRjaGRvZ1RpbWVy LmdldCgpIGZvck1vZGU6TlNEZWZhdWx0UnVuTG9vcE1vZGVdOworICAgIH0KIH0KIAogI3ByYWdt YSBtYXJrIC0K