<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>93657</bug_id>
          
          <creation_ts>2012-08-09 14:24:09 -0700</creation_ts>
          <short_desc>Recommend the use of https and mention git on building/checkout.html</short_desc>
          <delta_ts>2012-08-22 15:40:53 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Ryosuke Niwa">rniwa</assigned_to>
          <cc>abarth</cc>
    
    <cc>darin</cc>
    
    <cc>eric</cc>
    
    <cc>lforschler</cc>
    
    <cc>mjs</cc>
    
    <cc>mrowe</cc>
    
    <cc>wsiegrist</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>691845</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-08-09 14:24:09 -0700</bug_when>
    <thetext>Recommend the use of https and mention git on building/checkout.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>691850</commentid>
    <comment_count>1</comment_count>
      <attachid>157549</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-08-09 14:25:24 -0700</bug_when>
    <thetext>Created attachment 157549
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>691866</commentid>
    <comment_count>2</comment_count>
      <attachid>157549</attachid>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2012-08-09 14:38:02 -0700</bug_when>
    <thetext>Comment on attachment 157549
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157549&amp;action=review

&gt; Websites/webkit.org/building/checkout.html:42
&gt; +&lt;a href=&quot;http://nightly.webkit.org/files/WebKit-SVN-source.tar.bz2&quot;&gt;http://nightly.webkit.org/files/WebKit-SVN-source.tar.bz2&lt;/a&gt;.  It is updated every six hours. Note the archived checkout uses http connection. We recommend running the following command to use https instead:&lt;/p&gt;

When you&apos;re referring to HTTP and HTTPS in the instructions it would be clearer to do so using uppercase since they are initialisms.

&gt; Websites/webkit.org/building/checkout.html:67
&gt; +&lt;h2&gt;Checkout Out with Git&lt;/h2&gt;

You have an extra word in here.

&gt; Websites/webkit.org/building/checkout.html:84
&gt; +&lt;p&gt;If you want to be able to commit changes to the Subversion repository, or just want to check out branches that aren&apos;t contained in WebKit.git, you will need track the Subversion repository. To do that, inform git-svn of the location of the WebKit SVN repository, and update the branch that git-svn uses to track the Subversion repository so that it will re-use the history that we&apos;ve already cloned from git.webkit.org rather than trying to fetch it all from Subversion:&lt;/p&gt;
&gt; +&lt;p class=&quot;code&quot;&gt;
&gt; +cd WebKit
&gt; +git svn init --prefix=origin/ -T trunk https://svn.webkit.org/repository/webkit
&gt; +git config --replace svn-remote.svn.fetch trunk:refs/remotes/origin/master
&gt; +&lt;/p&gt;
&gt; +&lt;p&gt;This will add the following section to your .git/config:&lt;/p&gt;
&gt; +&lt;p class=&quot;code&quot;&gt;
&gt; +[svn-remote &quot;svn&quot;]
&gt; +    url = https://svn.webkit.org/repository/webkit
&gt; +    fetch = trunk:refs/remotes/origin/master
&gt; +&lt;/p&gt;
&gt; +&lt;p&gt;You can then run the following command to have git-svn rebuild its metadata from your local repository, and to pull any recent commits from the WebKit SVN repository.&lt;/p&gt;
&gt; +&lt;p class=&quot;code&quot;&gt;   git svn fetch&lt;/p&gt;

Would it make sense to just point people interested in committing from Git to &lt;http://trac.webkit.org/wiki/UsingGitWithWebKit#Checkout&gt; rather than duplicating the instructions here?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>691874</commentid>
    <comment_count>3</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-08-09 14:46:29 -0700</bug_when>
    <thetext>Good points. Uploading a new patch now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>691876</commentid>
    <comment_count>4</comment_count>
      <attachid>157556</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-08-09 14:48:48 -0700</bug_when>
    <thetext>Created attachment 157556
Updated per Mark&apos;s comment</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>691881</commentid>
    <comment_count>5</comment_count>
      <attachid>157556</attachid>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2012-08-09 14:54:00 -0700</bug_when>
    <thetext>Comment on attachment 157556
Updated per Mark&apos;s comment

View in context: https://bugs.webkit.org/attachment.cgi?id=157556&amp;action=review

r=me with the described changes.

&gt; Websites/webkit.org/building/checkout.html:11
&gt; +&lt;div id=&quot;title&quot;&gt;
&gt; +&lt;h1&gt;The WebKit Open Source Project&lt;/h1&gt;
&gt; +&lt;/div&gt;
&gt; +
&gt; +&lt;div id=&quot;icon&quot;&gt;&lt;/div&gt;
&gt; +
&gt; +&lt;div id=&quot;content&quot;&gt;

These bits shouldn&apos;t be here.

&gt; Websites/webkit.org/building/checkout.html:42
&gt; +&lt;a href=&quot;http://nightly.webkit.org/files/WebKit-SVN-source.tar.bz2&quot;&gt;http://nightly.webkit.org/files/WebKit-SVN-source.tar.bz2&lt;/a&gt;.  It is updated every six hours. Note the archived checkout uses HTTP connection. We recommend running the following command to use HTTPS instead:&lt;/p&gt;

&quot;the archived checkout uses HTTP connection&quot; should be &quot;the archived checkout uses *an* HTTP connection&quot;

&gt; Websites/webkit.org/building/checkout.html:71
&gt; +&lt;p&gt;If you want to be able to commit changes to the Subversion repository, or just want to check out branches that aren&apos;t contained in WebKit.git, you will need track the Subversion repository. To do this and working with other tools on a Git checkout, read &lt;a href=&quot;http://trac.webkit.org/wiki/UsingGitWithWebKit&quot;&gt;the wiki page&lt;/a&gt;.&lt;/p&gt;

The last sentence here reads very awkwardly. I&apos;d suggest rephrasing it to something like:
For information about this, and other aspects of using Git with WebKit, read the wiki page.

The wiki link could also point to https://trac.webkit.org/ too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>691886</commentid>
    <comment_count>6</comment_count>
      <attachid>157556</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-08-09 14:57:02 -0700</bug_when>
    <thetext>Comment on attachment 157556
Updated per Mark&apos;s comment

View in context: https://bugs.webkit.org/attachment.cgi?id=157556&amp;action=review

&gt;&gt; Websites/webkit.org/building/checkout.html:11
&gt;&gt; +&lt;div id=&quot;content&quot;&gt;
&gt; 
&gt; These bits shouldn&apos;t be here.

Oops, removed.

&gt;&gt; Websites/webkit.org/building/checkout.html:42
&gt;&gt; +&lt;a href=&quot;http://nightly.webkit.org/files/WebKit-SVN-source.tar.bz2&quot;&gt;http://nightly.webkit.org/files/WebKit-SVN-source.tar.bz2&lt;/a&gt;.  It is updated every six hours. Note the archived checkout uses HTTP connection. We recommend running the following command to use HTTPS instead:&lt;/p&gt;
&gt; 
&gt; &quot;the archived checkout uses HTTP connection&quot; should be &quot;the archived checkout uses *an* HTTP connection&quot;

Fixed.

&gt;&gt; Websites/webkit.org/building/checkout.html:71
&gt;&gt; +&lt;p&gt;If you want to be able to commit changes to the Subversion repository, or just want to check out branches that aren&apos;t contained in WebKit.git, you will need track the Subversion repository. To do this and working with other tools on a Git checkout, read &lt;a href=&quot;http://trac.webkit.org/wiki/UsingGitWithWebKit&quot;&gt;the wiki page&lt;/a&gt;.&lt;/p&gt;
&gt; 
&gt; The last sentence here reads very awkwardly. I&apos;d suggest rephrasing it to something like:
&gt; For information about this, and other aspects of using Git with WebKit, read the wiki page.
&gt; 
&gt; The wiki link could also point to https://trac.webkit.org/ too.

Yeah, I couldn&apos;t phrase it right. Thanks for the suggestion. Fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>691891</commentid>
    <comment_count>7</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-08-09 14:57:39 -0700</bug_when>
    <thetext>Committed r125208: &lt;http://trac.webkit.org/changeset/125208&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>691894</commentid>
    <comment_count>8</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-08-09 14:59:42 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; The wiki link could also point to https://trac.webkit.org/ too.

Oops, missed this comment. Fixed in http://trac.webkit.org/changeset/125210.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>702403</commentid>
    <comment_count>9</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2012-08-22 15:20:27 -0700</bug_when>
    <thetext>It seems like this change hasn&apos;t been propagated to the live site?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>702458</commentid>
    <comment_count>10</comment_count>
    <who name="William Siegrist">wsiegrist</who>
    <bug_when>2012-08-22 15:40:53 -0700</bug_when>
    <thetext>There was a problem with the auto-updating on the new hardware. I fixed it and updated the website.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>157549</attachid>
            <date>2012-08-09 14:25:24 -0700</date>
            <delta_ts>2012-08-09 14:48:45 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-93657-20120809142456.patch</filename>
            <type>text/plain</type>
            <size>5306</size>
            <attacher name="Ryosuke Niwa">rniwa</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNp
dGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjUyMDIpCisrKyBXZWJzaXRlcy93
ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEy
LTA4LTA5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlY29t
bWVuZCB0aGUgdXNlIG9mIGh0dHBzIGFuZCBtZW50aW9uIGdpdCBvbiBidWlsZGluZy9jaGVja291
dC5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05
MzY1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo
aXMgcGFnZSB3YXMgcXVpdGUgb3V0LWRhdGVkLiBTdG9wIG1lbnRpb25pbmcgYWJvdXQgaG93IHRv
IGluc3RhbGwgc3VidmVyc2lvbiBvbiBPUyBYIDEwLjQKKyAgICAgICAgYmVjYXVzZSB0aGUgcGFy
YWdyYXBoIHJpZ2h0IGFib3ZlIGl0IHJlZmVycyB0byBidWxpZGluZy90b29scy5odG1sIGZvciB0
aGF0LgorCisgICAgICAgIFJlY29tbWVuZCB0aGUgdXNlIG9mIGh0dHBzIGNvbm5lY3Rpb24gZm9y
IHRoZSBTdWJ2ZXJzaW9uIGNoZWNrb3V0IGFuZCBhbHNvIG1lbnRpb24gaG93IHRvCisgICAgICAg
IGNoZWNrb3V0IHVzaW5nIGEgR2l0IGNsaWVudC4KKworICAgICAgICAqIGJ1aWxkaW5nL2NoZWNr
b3V0Lmh0bWw6CisKIDIwMTItMDctMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K
IAogICAgICAgICBXcml0aW5nIGEgYmxvZyBwb3N0IGZvciBuZXcgcmV2aWV3ZXJzIGRvZXNuJ3Qg
YWRkIHZhbHVlIHRvIHRoZSBibG9nCkluZGV4OiBXZWJzaXRlcy93ZWJraXQub3JnL2J1aWxkaW5n
L2NoZWNrb3V0Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvd2Via2l0Lm9yZy9idWlsZGlu
Zy9jaGVja291dC5odG1sCShyZXZpc2lvbiAxMjUxOTQpCisrKyBXZWJzaXRlcy93ZWJraXQub3Jn
L2J1aWxkaW5nL2NoZWNrb3V0Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTIsMjEgKzIsMjYgQEAK
ICR0aXRsZSA9ICJHZXR0aW5nIHRoZSBDb2RlIjsKIGluY2x1ZGUoIi4uL2hlYWRlci5pbmMiKTsK
ID8+Cis8ZGl2IGlkPSJ0aXRsZSI+Cis8aDE+VGhlIFdlYktpdCBPcGVuIFNvdXJjZSBQcm9qZWN0
PC9oMT4KKzwvZGl2PgorCis8ZGl2IGlkPSJpY29uIj48L2Rpdj4KKworPGRpdiBpZD0iY29udGVu
dCI+CiA8aDI+R2V0dGluZyBXZWJLaXQ8L2gyPgogPHA+VG8gZG93bmxvYWQgYSBwcmUtYnVpbHQg
YnVuZGxlIGNvbnRhaW5pbmcgdGhlIGxhdGVzdCBXZWJLaXQsIHZpc2l0IDxhIGhyZWY9Imh0dHA6
Ly9uaWdodGx5LndlYmtpdC5vcmcvIj5XZWJLaXQgTmlnaHRseSBCdWlsZHM8L2E+LjwvcD4KIAog
PGgyPkJyb3dzaW5nIHRoZSBDb2RlPC9oMj4KLTxwPlRvIGJyb3dzZSB0aGUgc291cmNlIGNvZGUg
b25saW5lLCB2aXNpdCA8YSBocmVmPSJodHRwOi8vdHJhYy53ZWJraXQub3JnL2Jyb3dzZXIiPldl
YktpdCBUcmFjPC9hPi4KKzxwPlRvIGJyb3dzZSB0aGUgc291cmNlIGNvZGUgb25saW5lLCB2aXNp
dCA8YSBocmVmPSJodHRwczovL3RyYWMud2Via2l0Lm9yZy9icm93c2VyIj5XZWJLaXQgVHJhYzwv
YT4uCiAKLTxoMj5DaGVja2luZyBPdXQ8L2gyPgotPHA+VG8gd29yayB3aXRoIHRoZSBXZWJLaXQg
c291cmNlIHRyZWUsIHlvdSB3aWxsIG5lZWQgYSBTdWJ2ZXJzaW9uIGNsaWVudCBpbnN0YWxsZWQu
Cis8aDI+Q2hlY2tpbmcgT3V0IHdpdGggU3VidmVyc2lvbjwvaDI+Cis8cD5UbyB3b3JrIHdpdGgg
dGhlIFdlYktpdCBzb3VyY2UgdHJlZSwgeW91IHdpbGwgbmVlZCBhIFN1YnZlcnNpb24gb3IgYSBH
aXQgY2xpZW50IGluc3RhbGxlZC4KIFNlZSA8YSBocmVmPSJ0b29scy5odG1sIj5JbnN0YWxsaW5n
IERldmVsb3BlciBUb29sczwvYT4gZm9yIGluZm9ybWF0aW9uIG9uIGhvdwogdG8gaW5zdGFsbCBT
dWJ2ZXJzaW9uLjwvcD4KIDxkaXYgY2xhc3M9Im1hYy1pbnN0cnVjdGlvbnMiPgogPGg0Pk1hYyBP
UyBYPC9oND4KIDxvbD4KLTxsaT48cD5JbnN0YWxsIGEgU3VidmVyc2lvbiBDbGllbnQ8L3A+Ci08
cD5TdWJ2ZXJzaW9uIChzdm4pIGlzIHRoZSBzb3VyY2UgY29kZSBtYW5hZ2VtZW50IHRvb2wgdXNl
ZCBieSB0aGUgV2ViS2l0IE9wZW4gU291cmNlIFByb2plY3QuIEEgPGEgaHJlZj0iaHR0cDovL2hv
bWVwYWdlLm1hYy5jb20vaGlpcmVtL3N2a2J1aWxkcy5odG1sIj5TdWJ2ZXJzaW9uIDEuNCBjbGll
bnQgZm9yIE1hYyBPUyBYIDEwLjQ8L2E+IGlzIGF2YWlsYWJsZS48L3A+CiA8bGk+PHA+T3BlbiBU
ZXJtaW5hbDwvcD4KIDxwPlRlcm1pbmFsIHJlc2lkZXMgaW4gL0FwcGxpY2F0aW9ucy9VdGlsaXRp
ZXMuIFRoZSBGaW5kZXIgR28gbWVudSBwcm92aWRlcyBhIHF1aWNrIHdheSB0byBuYXZpZ2F0ZSB0
aGVyZS48L3A+CiA8L29sPgpAQCAtMzIsOSArMzcsMTAgQEAgdG8gaW5zdGFsbCBTdWJ2ZXJzaW9u
LjwvcD4KIAogPG9sPgogPGxpPjxwPlR5cGUgdGhpcyBjb21tYW5kIHRvIGNoZWNrIG91dCB0aGUg
V2ViS2l0IHNvdXJjZSB0cmVlOjwvcD4KLTxwIGNsYXNzPSJjb2RlIj5zdm4gY2hlY2tvdXQgaHR0
cDovL3N2bi53ZWJraXQub3JnL3JlcG9zaXRvcnkvd2Via2l0L3RydW5rIFdlYktpdDwvcD4KKzxw
IGNsYXNzPSJjb2RlIj5zdm4gY2hlY2tvdXQgaHR0cHM6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0
b3J5L3dlYmtpdC90cnVuayBXZWJLaXQ8L3A+CiA8cD5BbHRlcm5hdGl2ZWx5IHlvdSBjYW4gZG93
bmxvYWQgYSBzbmFwc2hvdCBvZiB0aGUgV2ViS2l0IHNvdXJjZSB0cmVlIGZyb20gCi08YSBocmVm
PSJodHRwOi8vbmlnaHRseS53ZWJraXQub3JnL2ZpbGVzL1dlYktpdC1TVk4tc291cmNlLnRhci5i
ejIiPmh0dHA6Ly9uaWdodGx5LndlYmtpdC5vcmcvZmlsZXMvV2ViS2l0LVNWTi1zb3VyY2UudGFy
LmJ6MjwvYT4uICBJdCBpcyB1cGRhdGVkIGV2ZXJ5IHNpeCBob3Vycy48L3A+Cis8YSBocmVmPSJo
dHRwOi8vbmlnaHRseS53ZWJraXQub3JnL2ZpbGVzL1dlYktpdC1TVk4tc291cmNlLnRhci5iejIi
Pmh0dHA6Ly9uaWdodGx5LndlYmtpdC5vcmcvZmlsZXMvV2ViS2l0LVNWTi1zb3VyY2UudGFyLmJ6
MjwvYT4uICBJdCBpcyB1cGRhdGVkIGV2ZXJ5IHNpeCBob3Vycy4gTm90ZSB0aGUgYXJjaGl2ZWQg
Y2hlY2tvdXQgdXNlcyBodHRwIGNvbm5lY3Rpb24uIFdlIHJlY29tbWVuZCBydW5uaW5nIHRoZSBm
b2xsb3dpbmcgY29tbWFuZCB0byB1c2UgaHR0cHMgaW5zdGVhZDo8L3A+Cis8cCBjbGFzcz0iY29k
ZSI+c3ZuIHN3aXRjaCAtLXJlbG9jYXRlIGh0dHA6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0b3J5
L3dlYmtpdC90cnVuayBodHRwczovL3N2bi53ZWJraXQub3JnL3JlcG9zaXRvcnkvd2Via2l0L3Ry
dW5rPC9wPgogPC9saT4KIDwvb2w+CiAKQEAgLTU4LDYgKzY0LDI2IEBAIGRvd25sb2FkIGFkZGl0
aW9uYWwgbGlicmFyaWVzIHRoYXQgYXJlIG4KIDxwPk9uY2UgeW91IGhhdmUgYSBjdXJyZW50IHRy
ZWUsIHRoZSBuZXh0IHN0ZXAgaXMKIDxhIGhyZWY9ImJ1aWxkLmh0bWwiPmJ1aWxkaW5nIFdlYktp
dDwvYT4uPC9wPgogCis8aDI+Q2hlY2tvdXQgT3V0IHdpdGggR2l0PC9oMj4KKzxwPlRvIHdvcmsg
d2l0aCB0aGUgV2ViS2l0IHNvdXJjZSB0cmVlIHVzaW5nIGEgR2l0IGNsaWVudCwgaW5zdGFsbCBh
IEdpdCBjbGllbnQgd2l0aCBTdWJ2ZXJzaW9uIHN1cHBvcnQgYW5kIHJ1biB0aGUgZm9sbG93aW5n
IGNvbW1hbmQgb24geW91ciB0ZXJtaW5hbDo8L3A+Cis8cCBjbGFzcz0iY29kZSI+Z2l0IGNsb25l
IGdpdDovL2dpdC53ZWJraXQub3JnL1dlYktpdC5naXQgV2ViS2l0PC9wPgorCis8cD5JZiB5b3Ug
d2FudCB0byBiZSBhYmxlIHRvIGNvbW1pdCBjaGFuZ2VzIHRvIHRoZSBTdWJ2ZXJzaW9uIHJlcG9z
aXRvcnksIG9yIGp1c3Qgd2FudCB0byBjaGVjayBvdXQgYnJhbmNoZXMgdGhhdCBhcmVuJ3QgY29u
dGFpbmVkIGluIFdlYktpdC5naXQsIHlvdSB3aWxsIG5lZWQgdHJhY2sgdGhlIFN1YnZlcnNpb24g
cmVwb3NpdG9yeS4gVG8gZG8gdGhhdCwgaW5mb3JtIGdpdC1zdm4gb2YgdGhlIGxvY2F0aW9uIG9m
IHRoZSBXZWJLaXQgU1ZOIHJlcG9zaXRvcnksIGFuZCB1cGRhdGUgdGhlIGJyYW5jaCB0aGF0IGdp
dC1zdm4gdXNlcyB0byB0cmFjayB0aGUgU3VidmVyc2lvbiByZXBvc2l0b3J5IHNvIHRoYXQgaXQg
d2lsbCByZS11c2UgdGhlIGhpc3RvcnkgdGhhdCB3ZSd2ZSBhbHJlYWR5IGNsb25lZCBmcm9tIGdp
dC53ZWJraXQub3JnIHJhdGhlciB0aGFuIHRyeWluZyB0byBmZXRjaCBpdCBhbGwgZnJvbSBTdWJ2
ZXJzaW9uOjwvcD4KKzxwIGNsYXNzPSJjb2RlIj4KK2NkIFdlYktpdAorZ2l0IHN2biBpbml0IC0t
cHJlZml4PW9yaWdpbi8gLVQgdHJ1bmsgaHR0cHM6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0b3J5
L3dlYmtpdAorZ2l0IGNvbmZpZyAtLXJlcGxhY2Ugc3ZuLXJlbW90ZS5zdm4uZmV0Y2ggdHJ1bms6
cmVmcy9yZW1vdGVzL29yaWdpbi9tYXN0ZXIKKzwvcD4KKzxwPlRoaXMgd2lsbCBhZGQgdGhlIGZv
bGxvd2luZyBzZWN0aW9uIHRvIHlvdXIgLmdpdC9jb25maWc6PC9wPgorPHAgY2xhc3M9ImNvZGUi
PgorW3N2bi1yZW1vdGUgInN2biJdCisgICAgdXJsID0gaHR0cHM6Ly9zdm4ud2Via2l0Lm9yZy9y
ZXBvc2l0b3J5L3dlYmtpdAorICAgIGZldGNoID0gdHJ1bms6cmVmcy9yZW1vdGVzL29yaWdpbi9t
YXN0ZXIKKzwvcD4KKzxwPllvdSBjYW4gdGhlbiBydW4gdGhlIGZvbGxvd2luZyBjb21tYW5kIHRv
IGhhdmUgZ2l0LXN2biByZWJ1aWxkIGl0cyBtZXRhZGF0YSBmcm9tIHlvdXIgbG9jYWwgcmVwb3Np
dG9yeSwgYW5kIHRvIHB1bGwgYW55IHJlY2VudCBjb21taXRzIGZyb20gdGhlIFdlYktpdCBTVk4g
cmVwb3NpdG9yeS48L3A+Cis8cCBjbGFzcz0iY29kZSI+ICAgZ2l0IHN2biBmZXRjaDwvcD4KKzxw
PlJlYWQgYWJvdXQgbW9yZSBvbiA8YSBocmVmPSJodHRwOi8vdHJhYy53ZWJraXQub3JnL3dpa2kv
VXNpbmdHaXRXaXRoV2ViS2l0Ij50aGUgd2lraSBwYWdlPC9hPi48L3A+CisKIDxoMj5LZWVwaW5n
IHVwIHRvIERhdGU8L2gyPgogPHA+QXQgYW55IHRpbWUsIHlvdSBjYW4gcmVydW4gdGhlIDxjb2Rl
PnVwZGF0ZS13ZWJraXQ8L2NvZGU+IHNjcmlwdCB0byB1cGRhdGUKIHlvdXIgc291cmNlIHRyZWUu
PC9wPgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>157556</attachid>
            <date>2012-08-09 14:48:48 -0700</date>
            <delta_ts>2012-08-09 14:57:02 -0700</delta_ts>
            <desc>Updated per Mark&apos;s comment</desc>
            <filename>bug-93657-20120809144821.patch</filename>
            <type>text/plain</type>
            <size>4450</size>
            <attacher name="Ryosuke Niwa">rniwa</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNp
dGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjUyMDIpCisrKyBXZWJzaXRlcy93
ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEy
LTA4LTA5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlY29t
bWVuZCB0aGUgdXNlIG9mIGh0dHBzIGFuZCBtZW50aW9uIGdpdCBvbiBidWlsZGluZy9jaGVja291
dC5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05
MzY1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo
aXMgcGFnZSB3YXMgcXVpdGUgb3V0LWRhdGVkLiBTdG9wIG1lbnRpb25pbmcgYWJvdXQgaG93IHRv
IGluc3RhbGwgc3VidmVyc2lvbiBvbiBPUyBYIDEwLjQKKyAgICAgICAgYmVjYXVzZSB0aGUgcGFy
YWdyYXBoIHJpZ2h0IGFib3ZlIGl0IHJlZmVycyB0byBidWxpZGluZy90b29scy5odG1sIGZvciB0
aGF0LgorCisgICAgICAgIFJlY29tbWVuZCB0aGUgdXNlIG9mIEhUVFBTIGNvbm5lY3Rpb24gZm9y
IHRoZSBTdWJ2ZXJzaW9uIGNoZWNrb3V0IGFuZCBhbHNvIG1lbnRpb24gaG93IHRvCisgICAgICAg
IGNoZWNrb3V0IHVzaW5nIGEgR2l0IGNsaWVudC4KKworICAgICAgICAqIGJ1aWxkaW5nL2NoZWNr
b3V0Lmh0bWw6CisKIDIwMTItMDctMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K
IAogICAgICAgICBXcml0aW5nIGEgYmxvZyBwb3N0IGZvciBuZXcgcmV2aWV3ZXJzIGRvZXNuJ3Qg
YWRkIHZhbHVlIHRvIHRoZSBibG9nCkluZGV4OiBXZWJzaXRlcy93ZWJraXQub3JnL2J1aWxkaW5n
L2NoZWNrb3V0Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvd2Via2l0Lm9yZy9idWlsZGlu
Zy9jaGVja291dC5odG1sCShyZXZpc2lvbiAxMjUxOTQpCisrKyBXZWJzaXRlcy93ZWJraXQub3Jn
L2J1aWxkaW5nL2NoZWNrb3V0Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTIsMjEgKzIsMjYgQEAK
ICR0aXRsZSA9ICJHZXR0aW5nIHRoZSBDb2RlIjsKIGluY2x1ZGUoIi4uL2hlYWRlci5pbmMiKTsK
ID8+Cis8ZGl2IGlkPSJ0aXRsZSI+Cis8aDE+VGhlIFdlYktpdCBPcGVuIFNvdXJjZSBQcm9qZWN0
PC9oMT4KKzwvZGl2PgorCis8ZGl2IGlkPSJpY29uIj48L2Rpdj4KKworPGRpdiBpZD0iY29udGVu
dCI+CiA8aDI+R2V0dGluZyBXZWJLaXQ8L2gyPgogPHA+VG8gZG93bmxvYWQgYSBwcmUtYnVpbHQg
YnVuZGxlIGNvbnRhaW5pbmcgdGhlIGxhdGVzdCBXZWJLaXQsIHZpc2l0IDxhIGhyZWY9Imh0dHA6
Ly9uaWdodGx5LndlYmtpdC5vcmcvIj5XZWJLaXQgTmlnaHRseSBCdWlsZHM8L2E+LjwvcD4KIAog
PGgyPkJyb3dzaW5nIHRoZSBDb2RlPC9oMj4KLTxwPlRvIGJyb3dzZSB0aGUgc291cmNlIGNvZGUg
b25saW5lLCB2aXNpdCA8YSBocmVmPSJodHRwOi8vdHJhYy53ZWJraXQub3JnL2Jyb3dzZXIiPldl
YktpdCBUcmFjPC9hPi4KKzxwPlRvIGJyb3dzZSB0aGUgc291cmNlIGNvZGUgb25saW5lLCB2aXNp
dCA8YSBocmVmPSJodHRwczovL3RyYWMud2Via2l0Lm9yZy9icm93c2VyIj5XZWJLaXQgVHJhYzwv
YT4uCiAKLTxoMj5DaGVja2luZyBPdXQ8L2gyPgotPHA+VG8gd29yayB3aXRoIHRoZSBXZWJLaXQg
c291cmNlIHRyZWUsIHlvdSB3aWxsIG5lZWQgYSBTdWJ2ZXJzaW9uIGNsaWVudCBpbnN0YWxsZWQu
Cis8aDI+Q2hlY2tpbmcgT3V0IHdpdGggU3VidmVyc2lvbjwvaDI+Cis8cD5UbyB3b3JrIHdpdGgg
dGhlIFdlYktpdCBzb3VyY2UgdHJlZSwgeW91IHdpbGwgbmVlZCBhIFN1YnZlcnNpb24gb3IgYSBH
aXQgY2xpZW50IGluc3RhbGxlZC4KIFNlZSA8YSBocmVmPSJ0b29scy5odG1sIj5JbnN0YWxsaW5n
IERldmVsb3BlciBUb29sczwvYT4gZm9yIGluZm9ybWF0aW9uIG9uIGhvdwogdG8gaW5zdGFsbCBT
dWJ2ZXJzaW9uLjwvcD4KIDxkaXYgY2xhc3M9Im1hYy1pbnN0cnVjdGlvbnMiPgogPGg0Pk1hYyBP
UyBYPC9oND4KIDxvbD4KLTxsaT48cD5JbnN0YWxsIGEgU3VidmVyc2lvbiBDbGllbnQ8L3A+Ci08
cD5TdWJ2ZXJzaW9uIChzdm4pIGlzIHRoZSBzb3VyY2UgY29kZSBtYW5hZ2VtZW50IHRvb2wgdXNl
ZCBieSB0aGUgV2ViS2l0IE9wZW4gU291cmNlIFByb2plY3QuIEEgPGEgaHJlZj0iaHR0cDovL2hv
bWVwYWdlLm1hYy5jb20vaGlpcmVtL3N2a2J1aWxkcy5odG1sIj5TdWJ2ZXJzaW9uIDEuNCBjbGll
bnQgZm9yIE1hYyBPUyBYIDEwLjQ8L2E+IGlzIGF2YWlsYWJsZS48L3A+CiA8bGk+PHA+T3BlbiBU
ZXJtaW5hbDwvcD4KIDxwPlRlcm1pbmFsIHJlc2lkZXMgaW4gL0FwcGxpY2F0aW9ucy9VdGlsaXRp
ZXMuIFRoZSBGaW5kZXIgR28gbWVudSBwcm92aWRlcyBhIHF1aWNrIHdheSB0byBuYXZpZ2F0ZSB0
aGVyZS48L3A+CiA8L29sPgpAQCAtMzIsOSArMzcsMTAgQEAgdG8gaW5zdGFsbCBTdWJ2ZXJzaW9u
LjwvcD4KIAogPG9sPgogPGxpPjxwPlR5cGUgdGhpcyBjb21tYW5kIHRvIGNoZWNrIG91dCB0aGUg
V2ViS2l0IHNvdXJjZSB0cmVlOjwvcD4KLTxwIGNsYXNzPSJjb2RlIj5zdm4gY2hlY2tvdXQgaHR0
cDovL3N2bi53ZWJraXQub3JnL3JlcG9zaXRvcnkvd2Via2l0L3RydW5rIFdlYktpdDwvcD4KKzxw
IGNsYXNzPSJjb2RlIj5zdm4gY2hlY2tvdXQgaHR0cHM6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0
b3J5L3dlYmtpdC90cnVuayBXZWJLaXQ8L3A+CiA8cD5BbHRlcm5hdGl2ZWx5IHlvdSBjYW4gZG93
bmxvYWQgYSBzbmFwc2hvdCBvZiB0aGUgV2ViS2l0IHNvdXJjZSB0cmVlIGZyb20gCi08YSBocmVm
PSJodHRwOi8vbmlnaHRseS53ZWJraXQub3JnL2ZpbGVzL1dlYktpdC1TVk4tc291cmNlLnRhci5i
ejIiPmh0dHA6Ly9uaWdodGx5LndlYmtpdC5vcmcvZmlsZXMvV2ViS2l0LVNWTi1zb3VyY2UudGFy
LmJ6MjwvYT4uICBJdCBpcyB1cGRhdGVkIGV2ZXJ5IHNpeCBob3Vycy48L3A+Cis8YSBocmVmPSJo
dHRwOi8vbmlnaHRseS53ZWJraXQub3JnL2ZpbGVzL1dlYktpdC1TVk4tc291cmNlLnRhci5iejIi
Pmh0dHA6Ly9uaWdodGx5LndlYmtpdC5vcmcvZmlsZXMvV2ViS2l0LVNWTi1zb3VyY2UudGFyLmJ6
MjwvYT4uICBJdCBpcyB1cGRhdGVkIGV2ZXJ5IHNpeCBob3Vycy4gTm90ZSB0aGUgYXJjaGl2ZWQg
Y2hlY2tvdXQgdXNlcyBIVFRQIGNvbm5lY3Rpb24uIFdlIHJlY29tbWVuZCBydW5uaW5nIHRoZSBm
b2xsb3dpbmcgY29tbWFuZCB0byB1c2UgSFRUUFMgaW5zdGVhZDo8L3A+Cis8cCBjbGFzcz0iY29k
ZSI+c3ZuIHN3aXRjaCAtLXJlbG9jYXRlIGh0dHA6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0b3J5
L3dlYmtpdC90cnVuayBodHRwczovL3N2bi53ZWJraXQub3JnL3JlcG9zaXRvcnkvd2Via2l0L3Ry
dW5rPC9wPgogPC9saT4KIDwvb2w+CiAKQEAgLTU4LDYgKzY0LDEyIEBAIGRvd25sb2FkIGFkZGl0
aW9uYWwgbGlicmFyaWVzIHRoYXQgYXJlIG4KIDxwPk9uY2UgeW91IGhhdmUgYSBjdXJyZW50IHRy
ZWUsIHRoZSBuZXh0IHN0ZXAgaXMKIDxhIGhyZWY9ImJ1aWxkLmh0bWwiPmJ1aWxkaW5nIFdlYktp
dDwvYT4uPC9wPgogCis8aDI+Q2hlY2tpbmcgT3V0IHdpdGggR2l0PC9oMj4KKzxwPlRvIHdvcmsg
d2l0aCB0aGUgV2ViS2l0IHNvdXJjZSB0cmVlIHVzaW5nIGEgR2l0IGNsaWVudCwgaW5zdGFsbCBh
IEdpdCBjbGllbnQgd2l0aCBTdWJ2ZXJzaW9uIHN1cHBvcnQgYW5kIHJ1biB0aGUgZm9sbG93aW5n
IGNvbW1hbmQgb24geW91ciB0ZXJtaW5hbDo8L3A+Cis8cCBjbGFzcz0iY29kZSI+Z2l0IGNsb25l
IGdpdDovL2dpdC53ZWJraXQub3JnL1dlYktpdC5naXQgV2ViS2l0PC9wPgorCis8cD5JZiB5b3Ug
d2FudCB0byBiZSBhYmxlIHRvIGNvbW1pdCBjaGFuZ2VzIHRvIHRoZSBTdWJ2ZXJzaW9uIHJlcG9z
aXRvcnksIG9yIGp1c3Qgd2FudCB0byBjaGVjayBvdXQgYnJhbmNoZXMgdGhhdCBhcmVuJ3QgY29u
dGFpbmVkIGluIFdlYktpdC5naXQsIHlvdSB3aWxsIG5lZWQgdHJhY2sgdGhlIFN1YnZlcnNpb24g
cmVwb3NpdG9yeS4gVG8gZG8gdGhpcyBhbmQgd29ya2luZyB3aXRoIG90aGVyIHRvb2xzIG9uIGEg
R2l0IGNoZWNrb3V0LCByZWFkIDxhIGhyZWY9Imh0dHA6Ly90cmFjLndlYmtpdC5vcmcvd2lraS9V
c2luZ0dpdFdpdGhXZWJLaXQiPnRoZSB3aWtpIHBhZ2U8L2E+LjwvcD4KKwogPGgyPktlZXBpbmcg
dXAgdG8gRGF0ZTwvaDI+CiA8cD5BdCBhbnkgdGltZSwgeW91IGNhbiByZXJ1biB0aGUgPGNvZGU+
dXBkYXRlLXdlYmtpdDwvY29kZT4gc2NyaXB0IHRvIHVwZGF0ZQogeW91ciBzb3VyY2UgdHJlZS48
L3A+Cg==
</data>
<flag name="review"
          id="167480"
          type_id="1"
          status="+"
          setter="mrowe"
    />
          </attachment>
      

    </bug>

</bugzilla>