93610 2012-08-09 05:23:16 -0700 [V8] V8Utilities::throwTypeMismatchException() should use setDOMException() 2012-08-09 19:17:27 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85330 1 haraken haraken abarth dglazkov japhet webkit.review.bot oldest_to_newest 691414 0 haraken 2012-08-09 05:23:16 -0700 Given that V8Utilities::throwTypeMismatchException() throws a DOM exception, we should use setDOMException() instead of throwError(). 691423 1 157446 haraken 2012-08-09 05:26:37 -0700 Created attachment 157446 Patch 691515 2 157446 abarth 2012-08-09 09:46:46 -0700 Comment on attachment 157446 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157446&action=review > Source/WebCore/bindings/v8/V8Utilities.cpp:197 > -void throwTypeMismatchException(v8::Isolate* isolate) > +void setTypeMismatchException(v8::Isolate* isolate) > { > - V8Proxy::throwError(V8Proxy::GeneralError, "TYPE_MISMATCH_ERR: DOM Exception 17", isolate); > + V8Proxy::setDOMException(TYPE_MISMATCH_ERR, isolate); > } Presumably we should just inline this function into it's one caller. 691576 3 157446 webkit.review.bot 2012-08-09 10:44:32 -0700 Comment on attachment 157446 Patch Attachment 157446 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13460593 691879 4 haraken 2012-08-09 14:52:14 -0700 (In reply to comment #2) > > +void setTypeMismatchException(v8::Isolate* isolate) > > { > > - V8Proxy::throwError(V8Proxy::GeneralError, "TYPE_MISMATCH_ERR: DOM Exception 17", isolate); > > + V8Proxy::setDOMException(TYPE_MISMATCH_ERR, isolate); > > } > > Presumably we should just inline this function into it's one caller. I tried it but it's not easy to resolve circular dependency. V8Proxy.h includes V8Utilities.h. So V8Utilities.h cannot call V8Proxy::xxx(). 691986 5 157579 haraken 2012-08-09 16:48:39 -0700 Created attachment 157579 patch for landing 692108 6 157579 webkit.review.bot 2012-08-09 19:14:10 -0700 Comment on attachment 157579 patch for landing Clearing flags on attachment: 157579 Committed r125236: <http://trac.webkit.org/changeset/125236> 157446 2012-08-09 05:26:37 -0700 2012-08-09 19:17:18 -0700 Patch bug-93610-20120809212610.patch text/plain 2444 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2UwYjg5NmY0MjRlNGY3 OGFkOTVhNDA1ZTFiMmVhZjY3ZGM3ZGJlNy4uMDBhYWM4OTdjMGVhMTg4Y2VhOWJhOGY4OTdhYjA4 MGE5ZmEwOTNhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTA5ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFY4VXRpbGl0 aWVzOjp0aHJvd1R5cGVNaXNtYXRjaEV4Y2VwdGlvbigpIHNob3VsZCB1c2Ugc2V0RE9NRXhjZXB0 aW9uKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkz NjEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR2l2 ZW4gdGhhdCBWOFV0aWxpdGllczo6dGhyb3dUeXBlTWlzbWF0Y2hFeGNlcHRpb24oKSB0aHJvd3Mg YSBET00gZXhjZXB0aW9uLAorICAgICAgICB3ZSBzaG91bGQgdXNlIHNldERPTUV4Y2VwdGlvbigp IGluc3RlYWQgb2YgdGhyb3dFcnJvcigpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWxzbyByZW5h bWVzIHRocm93VHlwZU1pc21hdGNoRXhjZXB0aW9uKCkgdG8gc2V0VHlwZU1pc21hdGNoRXhjZXB0 aW9uKCkuCisKKyAgICAgICAgTm8gdGVzdHMuIEkgY291bGRuJ3QgZmlndXJlIG91dCBob3cgdG8g dHJpZ2dlciB0aGUgY2FsbCBwYXRoLgorICAgICAgICBFaXRoZXIgd2F5IHRoaXMgaXMganVzdCBh IG1pbm9yIGNoYW5nZSBvZiBlcnJvciBtZXNzYWdlLgorCisgICAgICAgICogYmluZGluZ3Mvdjgv VjhVdGlsaXRpZXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c2V0VHlwZU1pc21hdGNoRXhjZXB0 aW9uKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFV0aWxpdGllcy5oOgorICAgICAgICAoV2Vi Q29yZTo6Y3JlYXRlRnVuY3Rpb25Pbmx5Q2FsbGJhY2spOgorCiAyMDEyLTA4LTA5ICBBcmtvIFNh aGEgIDxhcmtvQG1vdG9yb2xhLmNvbT4KIAogICAgICAgICBNaWNyb2RhdGE6IEhUTUxQcm9wZXJ0 aWVzQ29sbGVjdGlvbiBkb2VzIG5vdCBjb250YWluIGFsbCBwcm9wZXJ0aWVzIHdoZW4gaXRlbSBp cyBub3QgYXR0YWNoZWQgdG8gdGhlIERPTSB0cmVlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhVdGlsaXRpZXMuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhVdGlsaXRpZXMuY3BwCmluZGV4IDRkYWFmOThhYjUxOGUyNjZjZGEwOGEyZWI2ZmZmYTU4 ZDVmNjc2M2EuLjk0YzU2MDZmMTdkZDE5YjEyZDEwYzg1ZDA2ZmFhYmIxMWMxZTMxNjMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFV0aWxpdGllcy5jcHAKQEAgLTE5MSw5ICsxOTEs OSBAQCBTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBnZXRTY3JpcHRFeGVjdXRpb25Db250ZXh0KCkK ICAgICByZXR1cm4gMDsKIH0KIAotdm9pZCB0aHJvd1R5cGVNaXNtYXRjaEV4Y2VwdGlvbih2ODo6 SXNvbGF0ZSogaXNvbGF0ZSkKK3ZvaWQgc2V0VHlwZU1pc21hdGNoRXhjZXB0aW9uKHY4OjpJc29s YXRlKiBpc29sYXRlKQogewotICAgIFY4UHJveHk6OnRocm93RXJyb3IoVjhQcm94eTo6R2VuZXJh bEVycm9yLCAiVFlQRV9NSVNNQVRDSF9FUlI6IERPTSBFeGNlcHRpb24gMTciLCBpc29sYXRlKTsK KyAgICBWOFByb3h5OjpzZXRET01FeGNlcHRpb24oVFlQRV9NSVNNQVRDSF9FUlIsIGlzb2xhdGUp OwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOFV0aWxpdGllcy5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhVdGlsaXRpZXMuaAppbmRleCA0YzExMDkwOWZjODE1YzcyM2YzMGYzZjcxN2U3MzY3ZmYxOTU1 MzE3Li5kNjcxM2ZiMjNjZDVmNDY3MGNkYzNkOTU0OWJlOGNkMTQ4NDhmYWFkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFV0aWxpdGllcy5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmgKQEAgLTEwMiw3ICsxMDIsNyBAQCBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgaWYgKCF2YWx1ZS0+SXNGdW5jdGlvbigpKSB7CiAg ICAgICAgICAgICBzdWNjZWVkZWQgPSBmYWxzZTsKLSAgICAgICAgICAgIHRocm93VHlwZU1pc21h dGNoRXhjZXB0aW9uKGlzb2xhdGUpOworICAgICAgICAgICAgc2V0VHlwZU1pc21hdGNoRXhjZXB0 aW9uKGlzb2xhdGUpOwogICAgICAgICAgICAgcmV0dXJuIDA7CiAgICAgICAgIH0KIAo= 157579 2012-08-09 16:48:39 -0700 2012-08-09 19:14:10 -0700 patch for landing bug-93610-20120810084811.patch text/plain 2718 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2UwYjg5NmY0MjRlNGY3 OGFkOTVhNDA1ZTFiMmVhZjY3ZGM3ZGJlNy4uYWU2ODVmNmE0YjQyZDhlMDQzMzg2NjQ4MDVkZTMy NmM4NTIxNmRmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTA5ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFY4VXRpbGl0 aWVzOjp0aHJvd1R5cGVNaXNtYXRjaEV4Y2VwdGlvbigpIHNob3VsZCB1c2Ugc2V0RE9NRXhjZXB0 aW9uKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkz NjEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KKworICAgICAgICBHaXZlbiB0 aGF0IFY4VXRpbGl0aWVzOjp0aHJvd1R5cGVNaXNtYXRjaEV4Y2VwdGlvbigpIHRocm93cyBhIERP TSBleGNlcHRpb24sCisgICAgICAgIHdlIHNob3VsZCB1c2Ugc2V0RE9NRXhjZXB0aW9uKCkgaW5z dGVhZCBvZiB0aHJvd0Vycm9yKCkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhbHNvIHJlbmFtZXMg dGhyb3dUeXBlTWlzbWF0Y2hFeGNlcHRpb24oKSB0byBzZXRUeXBlTWlzbWF0Y2hFeGNlcHRpb24o KS4KKworICAgICAgICBObyB0ZXN0cy4gSSBjb3VsZG4ndCBmaWd1cmUgb3V0IGhvdyB0byB0cmln Z2VyIHRoZSBjYWxsIHBhdGguCisgICAgICAgIEVpdGhlciB3YXkgdGhpcyBpcyBqdXN0IGEgbWlu b3IgY2hhbmdlIG9mIGVycm9yIG1lc3NhZ2UuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFV0 aWxpdGllcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzZXRUeXBlTWlzbWF0Y2hFeGNlcHRpb24p OgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmg6CisgICAgICAgIChXZWJDb3Jl OjpjcmVhdGVGdW5jdGlvbk9ubHlDYWxsYmFjayk6CisKIDIwMTItMDgtMDkgIEFya28gU2FoYSAg PGFya29AbW90b3JvbGEuY29tPgogCiAgICAgICAgIE1pY3JvZGF0YTogSFRNTFByb3BlcnRpZXND b2xsZWN0aW9uIGRvZXMgbm90IGNvbnRhaW4gYWxsIHByb3BlcnRpZXMgd2hlbiBpdGVtIGlzIG5v dCBhdHRhY2hlZCB0byB0aGUgRE9NIHRyZWUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9WOFV0aWxpdGllcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OFV0aWxpdGllcy5jcHAKaW5kZXggNGRhYWY5OGFiNTE4ZTI2NmNkYTA4YTJlYjZmZmZhNThkNWY2 NzYzYS4uOTRjNTYwNmYxN2RkMTliMTJkMTBjODVkMDZmYWFiYjExYzFlMzE2MyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhVdGlsaXRpZXMuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmNwcApAQCAtMTkxLDkgKzE5MSw5IEBA IFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGdldFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKQogICAg IHJldHVybiAwOwogfQogCi12b2lkIHRocm93VHlwZU1pc21hdGNoRXhjZXB0aW9uKHY4OjpJc29s YXRlKiBpc29sYXRlKQordm9pZCBzZXRUeXBlTWlzbWF0Y2hFeGNlcHRpb24odjg6Oklzb2xhdGUq IGlzb2xhdGUpCiB7Ci0gICAgVjhQcm94eTo6dGhyb3dFcnJvcihWOFByb3h5OjpHZW5lcmFsRXJy b3IsICJUWVBFX01JU01BVENIX0VSUjogRE9NIEV4Y2VwdGlvbiAxNyIsIGlzb2xhdGUpOworICAg IFY4UHJveHk6OnNldERPTUV4Y2VwdGlvbihUWVBFX01JU01BVENIX0VSUiwgaXNvbGF0ZSk7CiB9 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFV0 aWxpdGllcy5oCmluZGV4IDRjMTEwOTA5ZmM4MTVjNzIzZjMwZjNmNzE3ZTczNjdmZjE5NTUzMTcu LjRlOGMyN2E3N2Q4N2EzN2U0MzE4ODhkYjg1YzFjYjE2NzM0MzJlYTcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmgKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhVdGlsaXRpZXMuaApAQCAtNjAsNyArNjAsNyBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKICAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBnZXRTY3JpcHRFeGVjdXRp b25Db250ZXh0KCk7CiAKLSAgICB2b2lkIHRocm93VHlwZU1pc21hdGNoRXhjZXB0aW9uKHY4OjpJ c29sYXRlKik7CisgICAgdm9pZCBzZXRUeXBlTWlzbWF0Y2hFeGNlcHRpb24odjg6Oklzb2xhdGUq KTsKIAogICAgIGVudW0gQ2FsbGJhY2tBbGxvd2VkVmFsdWVGbGFnIHsKICAgICAgICAgQ2FsbGJh Y2tBbGxvd1VuZGVmaW5lZCA9IDEsCkBAIC0xMDIsNyArMTAyLDcgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogCiAgICAgICAgIGlmICghdmFsdWUtPklzRnVuY3Rpb24oKSkgewogICAgICAgICAgICAg c3VjY2VlZGVkID0gZmFsc2U7Ci0gICAgICAgICAgICB0aHJvd1R5cGVNaXNtYXRjaEV4Y2VwdGlv bihpc29sYXRlKTsKKyAgICAgICAgICAgIHNldFR5cGVNaXNtYXRjaEV4Y2VwdGlvbihpc29sYXRl KTsKICAgICAgICAgICAgIHJldHVybiAwOwogICAgICAgICB9CiAK