93601 2012-08-09 02:11:42 -0700 [BlackBerry] Tap highlight flashes checkerboard after pinch zoom 2012-08-12 16:01:39 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson manyoso mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 691366 0 anilsson 2012-08-09 02:11:42 -0700 Until we do a more comprehensive improvement in AC checkerboarding, I have a workaround for this specific problem. PR 189895 692464 1 157708 anilsson 2012-08-10 05:00:47 -0700 Created attachment 157708 Patch 692569 2 157708 tonikitoo 2012-08-10 08:41:35 -0700 Comment on attachment 157708 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157708&action=review I will r+ to sync up downstream and upstream, but please consider my comment as a follow-up, if you agree. > Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.cpp:165 > + // This layer is typically small enough that we can afford to cache all tiles and never > + // risk checkerboarding. > + return true; it can be big enough: think of a <a><img/></a> on facebook. If zoomed in it easily takes the whole screen. Should we have a threshold? 692662 3 anilsson 2012-08-10 10:41:34 -0700 (In reply to comment #2) > (From update of attachment 157708 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157708&action=review > > I will r+ to sync up downstream and upstream, but please consider my comment as a follow-up, if you agree. > > > Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.cpp:165 > > + // This layer is typically small enough that we can afford to cache all tiles and never > > + // risk checkerboarding. > > + return true; > > it can be big enough: think of a <a><img/></a> on facebook. If zoomed in it easily takes the whole screen. Should we have a threshold? Taking up the whole screen is not so bad, the inspector highlight was taking up the whole content size. But it is possible to design a web pag that has a huuge link so we get a highlight that takes up the whole content size. So we need to do something eventually. 693336 4 157708 webkit.review.bot 2012-08-12 16:01:35 -0700 Comment on attachment 157708 Patch Clearing flags on attachment: 157708 Committed r125382: <http://trac.webkit.org/changeset/125382> 693337 5 webkit.review.bot 2012-08-12 16:01:39 -0700 All reviewed patches have been landed. Closing bug. 157708 2012-08-10 05:00:47 -0700 2012-08-12 16:01:35 -0700 Patch bug-93601-20120810140019.patch text/plain 2772 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA2ZWVkZWQyMWRiZTNkMTMzMDQ0ODVjYzM0YjJlZjU4ZDcwNmViY2E1Li43Y2I2MDlhZGYx MDdkMDk1NjBiYjAwODQ2MjM5YjFjMzE1ZDhhYjliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0wOC0wOSAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxz c29uQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFRhcCBoaWdobGlnaHQgZmxhc2hl cyBjaGVja2VyYm9hcmQgYWZ0ZXIgcGluY2ggem9vbQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM2MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSB0aGUgdGFwIGhpZ2hsaWdodCBpcyB1c3VhbGx5 IHJhdGhlciBzbWFsbCwgd2UgY2FuIHJlaW1wbGVtZW50CisgICAgICAgIEdyYXBoaWNzTGF5ZXJD bGllbnQ6OmNvbnRlbnRzVmlzaWJsZSgpIHRvIGFsd2F5cyByZXR1cm4gdHJ1ZSBpbiBvcmRlcgor ICAgICAgICB0byBrZWVwIGFsbCBBQyBsYXllciB0aWxlcyBjYWNoZWQgYWxsIHRoZSB0aW1lLgor CisgICAgICAgIFBSIDE4OTg5NQorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9EZWZhdWx0VGFw SGlnaGxpZ2h0LmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6RGVmYXVsdFRhcEhp Z2hsaWdodDo6Y29udGVudHNWaXNpYmxlKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgICog V2ViS2l0U3VwcG9ydC9EZWZhdWx0VGFwSGlnaGxpZ2h0Lmg6CisgICAgICAgIChEZWZhdWx0VGFw SGlnaGxpZ2h0KToKKwogMjAxMi0wOC0wOCAgSmFja3kgSmlhbmcgIDx6aGFqaWFuZ0ByaW0uY29t PgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBJbXBsZW1lbnQgYWJvdXQ6bWVtb3J5LWxpdmUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RlZmF1bHRU YXBIaWdobGlnaHQuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQv RGVmYXVsdFRhcEhpZ2hsaWdodC5jcHAKaW5kZXggNWI4ZWViNWI1MTdiZTk4ODdjZmY0YWViNjFm YmI0N2IwZjkyOGNhMS4uZjA2MjYzYWU3N2QyMWFlZjVkNGFkZmFjNGI2OWI3NjIxNTc2ZTk1NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRGVmYXVs dFRhcEhpZ2hsaWdodC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvRGVmYXVsdFRhcEhpZ2hsaWdodC5jcHAKQEAgLTE1OCw2ICsxNTgsMTMgQEAgYm9vbCBE ZWZhdWx0VGFwSGlnaGxpZ2h0OjpzaG93UmVwYWludENvdW50ZXIoY29uc3QgR3JhcGhpY3NMYXll ciogbGF5ZXIpIGNvbnN0CiAgICAgcmV0dXJuIG1fcGFnZS0+c2hvd1JlcGFpbnRDb3VudGVyKGxh eWVyKTsKIH0KIAorYm9vbCBEZWZhdWx0VGFwSGlnaGxpZ2h0Ojpjb250ZW50c1Zpc2libGUoY29u c3QgR3JhcGhpY3NMYXllciosIGNvbnN0IEludFJlY3QmIGNvbnRlbnRSZWN0KSBjb25zdAorewor ICAgIC8vIFRoaXMgbGF5ZXIgaXMgdHlwaWNhbGx5IHNtYWxsIGVub3VnaCB0aGF0IHdlIGNhbiBh ZmZvcmQgdG8gY2FjaGUgYWxsIHRpbGVzIGFuZCBuZXZlcgorICAgIC8vIHJpc2sgY2hlY2tlcmJv YXJkaW5nLgorICAgIHJldHVybiB0cnVlOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKIH0g Ly8gbmFtZXNwYWNlIEJsYWNrQmVycnkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L1dlYktpdFN1cHBvcnQvRGVmYXVsdFRhcEhpZ2hsaWdodC5oIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRGVmYXVsdFRhcEhpZ2hsaWdodC5oCmluZGV4IGMw NGY2Mzc3YzIyMDU3NzcxMjk1ZDZjNGRiMDZiOGFlMzM3NDEzYmYuLmEzNDA3MGY0N2JiN2VkNDMx NjdiNDJlNzBmMTQwYWY4ZDI1NzAzY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L0RlZmF1bHRUYXBIaWdobGlnaHQuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9EZWZhdWx0VGFwSGlnaGxpZ2h0LmgKQEAgLTU4 LDYgKzU4LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBwYWludENvbnRlbnRzKGNvbnN0 IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqLCBXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQmLCBXZWJD b3JlOjpHcmFwaGljc0xheWVyUGFpbnRpbmdQaGFzZSwgY29uc3QgV2ViQ29yZTo6SW50UmVjdCYg aW5DbGlwKTsKICAgICB2aXJ0dWFsIGJvb2wgc2hvd0RlYnVnQm9yZGVycyhjb25zdCBXZWJDb3Jl OjpHcmFwaGljc0xheWVyKikgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIHNob3dSZXBhaW50Q291 bnRlcihjb25zdCBXZWJDb3JlOjpHcmFwaGljc0xheWVyKikgY29uc3Q7CisgICAgdmlydHVhbCBi b29sIGNvbnRlbnRzVmlzaWJsZShjb25zdCBXZWJDb3JlOjpHcmFwaGljc0xheWVyKiwgY29uc3Qg V2ViQ29yZTo6SW50UmVjdCYgY29udGVudFJlY3QpIGNvbnN0OwogCiBwcml2YXRlOgogICAgIERl ZmF1bHRUYXBIaWdobGlnaHQoV2ViUGFnZVByaXZhdGUqKTsK