93600 2012-08-09 02:03:48 -0700 [GTK] Default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides default result 2012-08-13 03:36:07 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson webkit.review.bot xan.lopez oldest_to_newest 691363 0 mrobinson 2012-08-09 02:03:48 -0700 Since the default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides the default value, which means that the delete interface still appears. 691386 1 157436 mrobinson 2012-08-09 05:06:20 -0700 Created attachment 157436 Patch 691413 2 157436 xan.lopez 2012-08-09 05:22:51 -0700 Comment on attachment 157436 Patch Hrm, should we change the thing in the class struct to be a dummy pointer? 691419 3 mrobinson 2012-08-09 05:25:40 -0700 Do you mean should_allow_editing_action? If so, it's used by other editing signals, so we have to keep it around. 691425 4 157436 xan.lopez 2012-08-09 05:27:52 -0700 Comment on attachment 157436 Patch I see! r=me 691612 5 157436 webkit.review.bot 2012-08-09 11:08:31 -0700 Comment on attachment 157436 Patch Rejecting attachment 157436 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13473043 693502 6 157436 webkit.review.bot 2012-08-13 03:36:03 -0700 Comment on attachment 157436 Patch Clearing flags on attachment: 157436 Committed r125407: <http://trac.webkit.org/changeset/125407> 693503 7 webkit.review.bot 2012-08-13 03:36:07 -0700 All reviewed patches have been landed. Closing bug. 157436 2012-08-09 05:06:20 -0700 2012-08-13 03:36:03 -0700 Patch bug-93600-20120809140552.patch text/plain 2082 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggYTQ4Y2M1MDFm OTJlZWFmY2MxNTllZDUzYmUxMzczZGQxYTU2MjA0OS4uMTFkMTdkNGIxM2FiMjUxZTk1YWMxZjYy YjA4NjQ4OTQ2ZGZjYzVhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEy LTA4LTA5ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXSBEZWZhdWx0IHNpZ25hbCBoYW5kbGVyIGZvciBXZWJLaXRXZWJWaWV3OjpzaG91bGQt c2hvdy1kZWxldGUtaW50ZXJmYWNlLWZvci1lbGVtZW50IG92ZXJyaWRlcyBkZWZhdWx0IHJlc3Vs dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM2MDAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnN0ZWFk IG9mIHVzaW5nIHRoZSBkZWZhdWx0IGVkaXRpbmcgc2lnbmFsIGhhbmRsZXIgZm9yIDo6c2hvdWxk LXNob3ctZGVsZXRlLWludGVyZmFjZS1mb3ItZWxlbWVudCwKKyAgICAgICAgZG8gbm90IHVzZSBh IGRlZmF1bHQgc2lnbmFsIGhhbmRsZXIuIFRoaXMgbWVhbnMgdGhhdCB0aGUgcmVzdWx0IG9mIHRo ZSBzaWduYWwgZGVmYXVsdHMgdG8gRkFMU0UsCisgICAgICAgIHdoaWNoIGlzIHRoZSBleHBlY3Rl ZCB2YWx1ZSB0byBlbnN1cmUgdGhhdCB0aGUgZGVsZXRlIGludGVyZmFjZSBpcyBub3Qgc2hvd24u CisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6CisgICAgICAgICh3ZWJraXRf d2ViX3ZpZXdfY2xhc3NfaW5pdCk6IERvIG5vdCBpbnN0YWxsIGEgZGVmYXVsdCBzaWduYWwgaGFu ZGxlci4KKwogMjAxMi0wOC0wNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp YS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4IEdUSysgYnVpbGQgd2l0aCBHVEsyIGFm dGVyIHIxMjA5MTguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2Vidmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAK aW5kZXggODg3MDcyMTE2MTk5Zjc3NzhkYTc0ZTUyNDEyNjBiMGVjYWQ1YjVjZi4uY2RhZDlhYjYw ZTIyMjU4ZDRiNDUxY2FiZTVhODQwZGFmNTZjNWEyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtMjY1NSw3ICsyNjU1LDcgQEAgc3RhdGljIHZvaWQg d2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQoV2ViS2l0V2ViVmlld0NsYXNzKiB3ZWJWaWV3Q2xh c3MpCiAKICAgICB3ZWJraXRfd2ViX3ZpZXdfc2lnbmFsc1tTSE9VTERfU0hPV19ERUxFVEVfSU5U RVJGQUNFX0ZPUl9FTEVNRU5UXSA9IGdfc2lnbmFsX25ldygic2hvdWxkLXNob3ctZGVsZXRlLWlu dGVyZmFjZS1mb3ItZWxlbWVudCIsCiAgICAgICAgIEdfVFlQRV9GUk9NX0NMQVNTKHdlYlZpZXdD bGFzcyksIHN0YXRpY19jYXN0PEdTaWduYWxGbGFncz4oR19TSUdOQUxfUlVOX0xBU1QgfCBHX1NJ R05BTF9BQ1RJT04pLAotICAgICAgICBHX1NUUlVDVF9PRkZTRVQoV2ViS2l0V2ViVmlld0NsYXNz LCBzaG91bGRfYWxsb3dfZWRpdGluZ19hY3Rpb24pLCBnX3NpZ25hbF9hY2N1bXVsYXRvcl9maXJz dF93aW5zLCAwLAorICAgICAgICAwLCBnX3NpZ25hbF9hY2N1bXVsYXRvcl9maXJzdF93aW5zLCAw LAogICAgICAgICB3ZWJraXRfbWFyc2hhbF9CT09MRUFOX19PQkpFQ1QsIEdfVFlQRV9CT09MRUFO LCAxLCBXRUJLSVRfVFlQRV9ET01fSFRNTF9FTEVNRU5UKTsKIAogICAgIHdlYmtpdF93ZWJfdmll d19zaWduYWxzW1NIT1VMRF9DSEFOR0VfU0VMRUNURURfUkFOR0VdID0gZ19zaWduYWxfbmV3KCJz aG91bGQtY2hhbmdlLXNlbGVjdGVkLXJhbmdlIiwK