93588 2012-08-09 01:01:26 -0700 [BlackBerry] use MediaPlayer::userAgent() in MediaPlayerPrivateBlackBerry to avoid layering violation 2012-08-12 21:35:59 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93324 1 jonathan.dong.webkit jonathan.dong.webkit charles.wei eric.carlson feature-media-reviews mfeil mifenton rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 691314 0 jonathan.dong.webkit 2012-08-09 01:01:26 -0700 In BlackBerry porting we should use MediaPlayer::userAgent() in class MediaPlayerPrivate instead of retrieving the user agent string via the abstraction layer breaking way. 691324 1 157414 jonathan.dong.webkit 2012-08-09 01:08:28 -0700 Created attachment 157414 Patch 691540 2 157414 tonikitoo 2012-08-09 10:14:20 -0700 Comment on attachment 157414 Patch I think it looks ok. 691550 3 157414 webkit.review.bot 2012-08-09 10:21:07 -0700 Comment on attachment 157414 Patch Rejecting attachment 157414 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13458718 692487 4 157714 jonathan.dong.webkit 2012-08-10 05:34:19 -0700 Created attachment 157714 Patch 693344 5 157714 charles.wei 2012-08-12 17:15:39 -0700 Comment on attachment 157714 Patch commit. 693370 6 157714 webkit.review.bot 2012-08-12 21:35:55 -0700 Comment on attachment 157714 Patch Clearing flags on attachment: 157714 Committed r125388: <http://trac.webkit.org/changeset/125388> 693371 7 webkit.review.bot 2012-08-12 21:35:59 -0700 All reviewed patches have been landed. Closing bug. 157414 2012-08-09 01:08:28 -0700 2012-08-10 05:34:13 -0700 Patch bug-93588-20120809160800.patch text/plain 3138 jonathan.dong.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTFmZmVlMmIxMGFjZTcy MWI2ZjJjOWQ5ZGNhNmYxYzMzOWY0Njg3YS4uYTk5YmMxNjA5M2JlNzMxNDY5MmM5MWM5Y2FmMzRh NWRiYTQ2MWQyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTA5ICBKb25h dGhhbiBEb25nICA8am9uYXRoYW4uZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAg W0JsYWNrQmVycnldIHVzZSBNZWRpYVBsYXllcjo6dXNlckFnZW50KCkgaW4gTWVkaWFQbGF5ZXJQ cml2YXRlQmxhY2tCZXJyeSB0byBhdm9pZCBsYXllcmluZyB2aW9sYXRpb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNTg4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlZCBoZWxwZXIgZnVuY3Rp b24gTWVkaWFQbGF5ZXJQcml2YXRlOjp1c2VyQWdlbnQoKSB3aGljaCBoYXMKKyAgICAgICAgaW50 cm9kdWNlZCBhYnN0cmFjdGlvbiBsYXllcmluZyB2aW9sYXRpb24gYW5kIHJlcGxhY2VkIHdpdGgK KyAgICAgICAgTWVkaWFQbGF5ZXI6OnVzZXJBZ2VudCgpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cyBzaW5jZSB0aGVyZSdzIG5vIGZ1bmN0aW9uYWwgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6bG9hZCk6CisKIDIwMTItMDgt MDggIEFya28gU2FoYSAgPGFya29AbW90b3JvbGEuY29tPgogCiAgICAgICAgIE1pY3JvZGF0YTog UHJvcGVydHlOb2RlTGlzdCBjYWNoZSBzaG91bGQgYmUgaW52YWxpZGF0ZWQgb24gaWQgYXR0cmli dXRlIGNoYW5nZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNr QmVycnkuY3BwCmluZGV4IDI3ZmRmNjQ5MTBkNDQ3MjhjM2UxYTQ4MTUzMGM0Y2U4OTg2OThmNzYu LjlkNmI0NzRmYzI1NGQ5MzYxNmNhZDM4ZmZkOGI2ZWJjOTMzYTJlODQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2 YXRlQmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv YmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmNwcApAQCAtMTYwLDkgKzE2 MCw5IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlOjpsb2FkKGNvbnN0IFN0cmluZyYgdXJsKQog ICAgIGlmICghdXJsLmlzRW1wdHkoKSkKICAgICAgICAgY29va2llUGFpcnMgPSBjb29raWVNYW5h Z2VyKCkuZ2V0Q29va2llKEtVUkwoUGFyc2VkVVJMU3RyaW5nLCB1cmwudXRmOCgpLmRhdGEoKSks IFdpdGhIdHRwT25seUNvb2tpZXMpOwogICAgIGlmICghY29va2llUGFpcnMuaXNFbXB0eSgpICYm IGNvb2tpZVBhaXJzLnV0ZjgoKS5kYXRhKCkpCi0gICAgICAgIG1fcGxhdGZvcm1QbGF5ZXItPmxv YWQobW9kaWZpZWRVcmwudXRmOCgpLmRhdGEoKSwgdXNlckFnZW50KG1vZGlmaWVkVXJsKS51dGY4 KCkuZGF0YSgpLCBjb29raWVQYWlycy51dGY4KCkuZGF0YSgpKTsKKyAgICAgICAgbV9wbGF0Zm9y bVBsYXllci0+bG9hZChtb2RpZmllZFVybC51dGY4KCkuZGF0YSgpLCBtX3dlYkNvcmVQbGF5ZXIt PnVzZXJBZ2VudCgpLnV0ZjgoKS5kYXRhKCksIGNvb2tpZVBhaXJzLnV0ZjgoKS5kYXRhKCkpOwog ICAgIGVsc2UKLSAgICAgICAgbV9wbGF0Zm9ybVBsYXllci0+bG9hZChtb2RpZmllZFVybC51dGY4 KCkuZGF0YSgpLCB1c2VyQWdlbnQobW9kaWZpZWRVcmwpLnV0ZjgoKS5kYXRhKCksIDApOworICAg ICAgICBtX3BsYXRmb3JtUGxheWVyLT5sb2FkKG1vZGlmaWVkVXJsLnV0ZjgoKS5kYXRhKCksIG1f d2ViQ29yZVBsYXllci0+dXNlckFnZW50KCkudXRmOCgpLmRhdGEoKSwgMCk7CiB9CiAKIHZvaWQg TWVkaWFQbGF5ZXJQcml2YXRlOjpjYW5jZWxMb2FkKCkKQEAgLTM0OCwyMCArMzQ4LDYgQEAgTWVk aWFQbGF5ZXI6Ok1vdmllTG9hZFR5cGUgTWVkaWFQbGF5ZXJQcml2YXRlOjptb3ZpZUxvYWRUeXBl KCkgY29uc3QKICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8TWVkaWFQbGF5ZXI6Ok1vdmllTG9hZFR5 cGU+KG1fcGxhdGZvcm1QbGF5ZXItPm1vdmllTG9hZFR5cGUoKSk7CiB9CiAKLS8vIFRoaXMgZnVu Y3Rpb24gcmV0dXJucyB0aGUgdXNlciBhZ2VudCBzdHJpbmcgYXNzb2NpYXRlZCB3aXRoIHRoZQot Ly8gZnJhbWUgbG9hZGVyIGNsaWVudCBvZiBvdXIgSFRNTE1lZGlhRWxlbWVudC4gVGhlIGNhbGwg YmVsb3cgd2lsbAotLy8gZW5kIHVwIGluIEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6dXNl ckFnZW50KCkuCi1TdHJpbmcgTWVkaWFQbGF5ZXJQcml2YXRlOjp1c2VyQWdlbnQoY29uc3QgU3Ry aW5nJiB1cmwpIGNvbnN0Ci17Ci0gICAgSFRNTE1lZGlhRWxlbWVudCogZWxlbWVudCA9IHN0YXRp Y19jYXN0PEhUTUxNZWRpYUVsZW1lbnQqPihtX3dlYkNvcmVQbGF5ZXItPm1lZGlhUGxheWVyQ2xp ZW50KCkpOwotICAgIERvY3VtZW50KiB0b3Bkb2MgPSBlbGVtZW50LT5kb2N1bWVudCgpLT50b3BE b2N1bWVudCgpOwotICAgIEFTU0VSVCh0b3Bkb2MtPmZyYW1lKCkpOwotICAgIEFTU0VSVCh0b3Bk b2MtPmZyYW1lKCktPmxvYWRlcigpKTsKLSAgICBpZiAodG9wZG9jLT5mcmFtZSgpKQotICAgICAg ICByZXR1cm4gdG9wZG9jLT5mcmFtZSgpLT5sb2FkZXIoKS0+dXNlckFnZW50KEtVUkwoS1VSTCgp LCB1cmwpKTsKLSAgICByZXR1cm4gU3RyaW5nKCk7Ci19Ci0KIHZvaWQgTWVkaWFQbGF5ZXJQcml2 YXRlOjpyZXNpemVTb3VyY2VEaW1lbnNpb25zKCkKIHsKICAgICBpZiAoIW1fd2ViQ29yZVBsYXll cikK 157714 2012-08-10 05:34:19 -0700 2012-08-12 21:35:55 -0700 Patch bug-93588-20120810203350.patch text/plain 3163 jonathan.dong.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODMzMDM3MDMzYzFmNzJh MzZmMzRlNDc0MjU1YmUwNzQ5MTY1MThjNS4uZWZlOGEzODg4NGQ5NTk2NGVlNDM1MDMzYjNlNGY3 OTE5ZjVmN2NmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTEwICBKb25h dGhhbiBEb25nICA8am9uYXRoYW4uZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAg W0JsYWNrQmVycnldIHVzZSBNZWRpYVBsYXllcjo6dXNlckFnZW50KCkgaW4gTWVkaWFQbGF5ZXJQ cml2YXRlQmxhY2tCZXJyeSB0byBhdm9pZCBsYXllcmluZyB2aW9sYXRpb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNTg4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgQW50b25pbyBHb21lcy4KKworICAgICAgICBSZW1vdmVkIGhlbHBlciBmdW5jdGlv biBNZWRpYVBsYXllclByaXZhdGU6OnVzZXJBZ2VudCgpIHdoaWNoIGhhcworICAgICAgICBpbnRy b2R1Y2VkIGFic3RyYWN0aW9uIGxheWVyaW5nIHZpb2xhdGlvbiBhbmQgcmVwbGFjZWQgd2l0aAor ICAgICAgICBNZWRpYVBsYXllcjo6dXNlckFnZW50KCkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz IHNpbmNlIHRoZXJlJ3Mgbm8gZnVuY3Rpb25hbCBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpsb2FkKToKKwogMjAxMi0wOC0x MCAgTWlobmVhIE92aWRlbmllICA8bWlobmVhQGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NTIFJl Z2lvbnNdIHJlZ2lvbi1vdmVyZmxvdzogYnJlYWsgc3RpbGwgcmVuZGVycyB0aGUgY29udGVudCB0 aGF0IGRvZXMgbm90IGZpdCBpbiB0aGUgbGFzdCByZWdpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0ZUJs YWNrQmVycnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJy eS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmNwcAppbmRleCAyN2ZkZjY0OTEwZDQ0NzI4 YzNlMWE0ODE1MzBjNGNlODk4Njk4Zjc2Li45ZDZiNDc0ZmMyNTRkOTM2MTZjYWQzOGZmZDhiNmVi YzkzM2EyZTg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9i bGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxh Y2tCZXJyeS5jcHAKQEAgLTE2MCw5ICsxNjAsOSBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6 bG9hZChjb25zdCBTdHJpbmcmIHVybCkKICAgICBpZiAoIXVybC5pc0VtcHR5KCkpCiAgICAgICAg IGNvb2tpZVBhaXJzID0gY29va2llTWFuYWdlcigpLmdldENvb2tpZShLVVJMKFBhcnNlZFVSTFN0 cmluZywgdXJsLnV0ZjgoKS5kYXRhKCkpLCBXaXRoSHR0cE9ubHlDb29raWVzKTsKICAgICBpZiAo IWNvb2tpZVBhaXJzLmlzRW1wdHkoKSAmJiBjb29raWVQYWlycy51dGY4KCkuZGF0YSgpKQotICAg ICAgICBtX3BsYXRmb3JtUGxheWVyLT5sb2FkKG1vZGlmaWVkVXJsLnV0ZjgoKS5kYXRhKCksIHVz ZXJBZ2VudChtb2RpZmllZFVybCkudXRmOCgpLmRhdGEoKSwgY29va2llUGFpcnMudXRmOCgpLmRh dGEoKSk7CisgICAgICAgIG1fcGxhdGZvcm1QbGF5ZXItPmxvYWQobW9kaWZpZWRVcmwudXRmOCgp LmRhdGEoKSwgbV93ZWJDb3JlUGxheWVyLT51c2VyQWdlbnQoKS51dGY4KCkuZGF0YSgpLCBjb29r aWVQYWlycy51dGY4KCkuZGF0YSgpKTsKICAgICBlbHNlCi0gICAgICAgIG1fcGxhdGZvcm1QbGF5 ZXItPmxvYWQobW9kaWZpZWRVcmwudXRmOCgpLmRhdGEoKSwgdXNlckFnZW50KG1vZGlmaWVkVXJs KS51dGY4KCkuZGF0YSgpLCAwKTsKKyAgICAgICAgbV9wbGF0Zm9ybVBsYXllci0+bG9hZChtb2Rp ZmllZFVybC51dGY4KCkuZGF0YSgpLCBtX3dlYkNvcmVQbGF5ZXItPnVzZXJBZ2VudCgpLnV0Zjgo KS5kYXRhKCksIDApOwogfQogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6Y2FuY2VsTG9hZCgp CkBAIC0zNDgsMjAgKzM0OCw2IEBAIE1lZGlhUGxheWVyOjpNb3ZpZUxvYWRUeXBlIE1lZGlhUGxh eWVyUHJpdmF0ZTo6bW92aWVMb2FkVHlwZSgpIGNvbnN0CiAgICAgcmV0dXJuIHN0YXRpY19jYXN0 PE1lZGlhUGxheWVyOjpNb3ZpZUxvYWRUeXBlPihtX3BsYXRmb3JtUGxheWVyLT5tb3ZpZUxvYWRU eXBlKCkpOwogfQogCi0vLyBUaGlzIGZ1bmN0aW9uIHJldHVybnMgdGhlIHVzZXIgYWdlbnQgc3Ry aW5nIGFzc29jaWF0ZWQgd2l0aCB0aGUKLS8vIGZyYW1lIGxvYWRlciBjbGllbnQgb2Ygb3VyIEhU TUxNZWRpYUVsZW1lbnQuIFRoZSBjYWxsIGJlbG93IHdpbGwKLS8vIGVuZCB1cCBpbiBGcmFtZUxv YWRlckNsaWVudEJsYWNrQmVycnk6OnVzZXJBZ2VudCgpLgotU3RyaW5nIE1lZGlhUGxheWVyUHJp dmF0ZTo6dXNlckFnZW50KGNvbnN0IFN0cmluZyYgdXJsKSBjb25zdAotewotICAgIEhUTUxNZWRp YUVsZW1lbnQqIGVsZW1lbnQgPSBzdGF0aWNfY2FzdDxIVE1MTWVkaWFFbGVtZW50Kj4obV93ZWJD b3JlUGxheWVyLT5tZWRpYVBsYXllckNsaWVudCgpKTsKLSAgICBEb2N1bWVudCogdG9wZG9jID0g ZWxlbWVudC0+ZG9jdW1lbnQoKS0+dG9wRG9jdW1lbnQoKTsKLSAgICBBU1NFUlQodG9wZG9jLT5m cmFtZSgpKTsKLSAgICBBU1NFUlQodG9wZG9jLT5mcmFtZSgpLT5sb2FkZXIoKSk7Ci0gICAgaWYg KHRvcGRvYy0+ZnJhbWUoKSkKLSAgICAgICAgcmV0dXJuIHRvcGRvYy0+ZnJhbWUoKS0+bG9hZGVy KCktPnVzZXJBZ2VudChLVVJMKEtVUkwoKSwgdXJsKSk7Ci0gICAgcmV0dXJuIFN0cmluZygpOwot fQotCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6cmVzaXplU291cmNlRGltZW5zaW9ucygpCiB7 CiAgICAgaWYgKCFtX3dlYkNvcmVQbGF5ZXIpCg==