9358 2006-06-08 07:35:36 -0700 REGRESSION: Assertion failure in HTMLInputElement::setValueFromRenderer (value == constrainValue(value)) when deleting all text 2006-06-30 12:04:31 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED data:text/html,<input value="X"> Regression P1 Normal --- 1 mitz webkit-unassigned aapo-bugzilla adele ap darin ddkilzer ian justin.garcia sullivan oldest_to_newest 45141 0 mitz 2006-06-08 07:35:36 -0700 I hit this assert when I try to delete the X in the field using the delete key: ASSERTION FAILED: value == constrainValue(value) (WebCore/html/HTMLInputElement.cpp:1068 void WebCore::HTMLInputElement::setValueFromRenderer(const WebCore::String&)) 45142 1 mitz 2006-06-08 07:55:08 -0700 The root cause seems to be that now when you delete the last character, a <br> placeholder is inserted. 45160 2 justin.garcia 2006-06-08 11:40:47 -0700 Look like textContent returns "\n" for a br even if its collapsed. value = "\n" and constrainValue(value) = "". 45249 3 ddkilzer 2006-06-10 08:20:53 -0700 Grrr! I Just ran into this on Bugzilla's simple search page, and it killed my browser! 45515 4 ddkilzer 2006-06-13 15:47:01 -0700 This is also a regression (so to speak). 45517 5 ddkilzer 2006-06-13 15:47:22 -0700 *** Bug 9429 has been marked as a duplicate of this bug. *** 46628 6 mitz 2006-06-22 02:38:22 -0700 *** Bug 9542 has been marked as a duplicate of this bug. *** 47727 7 9089 ddkilzer 2006-06-29 08:18:30 -0700 Created attachment 9089 Patch v1 (no changelog; no test) I crash from this assertion daily on my debug build.  Tell me what's wrong with this patch so it can be fixed properly.  :) 47737 8 9089 darin 2006-06-29 08:30:09 -0700 Comment on attachment 9089 Patch v1 (no changelog; no test) It's driving me crazy too! This is an acceptable workaround for the problem, but not the right way to fix the problem. I don't want an extra call to constrainValue here in the production code in the long term. I'd prefer isEmpty() to length() == 0, and I'd like a comment here that explains exactly why we need a special case. Perhaps a better way to do it would be to add code like this before the assert:     // Workaround for bug where trailing \n is included in the result of textContent.     // <URL of a new bug report>      if (value == "\n")         value = ""; 47804 9 ddkilzer 2006-06-29 23:50:52 -0700 (In reply to comment #8) >     // Workaround for bug where trailing \n is included in the result of > textContent. >     // <URL of a new bug report> Bug 9661 filed for the follow-up issue. 47834 10 9106 ddkilzer 2006-06-30 08:42:26 -0700 Created attachment 9106 Patch v2 Patch v2 includes ChangeLogs, a layout test, and addresses Darin's comments. 47835 11 ddkilzer 2006-06-30 08:43:13 -0700 (In reply to comment #10) > Patch v2 includes ChangeLogs, a layout test, and addresses Darin's comments. It also passed all layout tests. 47847 12 9106 darin 2006-06-30 11:12:16 -0700 Comment on attachment 9106 Patch v2 OK. r=me 47854 13 ddkilzer 2006-06-30 12:04:31 -0700 Committed revision 15111! 9089 2006-06-29 08:18:30 -0700 2006-06-30 08:42:26 -0700 Patch v1 (no changelog; no test) bug-9358-v1.diff text/plain 690 ddkilzer SW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAJKHJldmlzaW9uIDE1MDkxKQorKysgV2Vi Q29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDg5LDkg KzEwODksOSBAQCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnNldFZhbHVlKGNvbnN0IFN0CiB2b2lk IEhUTUxJbnB1dEVsZW1lbnQ6OnNldFZhbHVlRnJvbVJlbmRlcmVyKGNvbnN0IFN0cmluZyYgdmFs dWUpCiB7CiAgICAgLy8gUmVuZGVyZXIgYW5kIG91ciBldmVudCBoYW5kbGVyIGFyZSByZXNwb25z aWJsZSBmb3IgY29uc3RyYWluaW5nIHZhbHVlcy4KLSAgICBBU1NFUlQodmFsdWUgPT0gY29uc3Ry YWluVmFsdWUodmFsdWUpKTsKKyAgICBBU1NFUlQodmFsdWUgPT0gY29uc3RyYWluVmFsdWUodmFs dWUpIHx8IGNvbnN0cmFpblZhbHVlKHZhbHVlKS5sZW5ndGgoKSA9PSAwKTsKIAotICAgIG1fdmFs dWUgPSB2YWx1ZTsKKyAgICBtX3ZhbHVlID0gY29uc3RyYWluVmFsdWUodmFsdWUpOwogICAgIHNl dFZhbHVlTWF0Y2hlc1JlbmRlcmVyKCk7CiAKICAgICAvLyBGaXJlIHRoZSAiaW5wdXQiIERPTSBl dmVudC4K 9106 2006-06-30 08:42:26 -0700 2006-06-30 11:12:16 -0700 Patch v2 bug-9358-v2.diff text/plain 5325 ddkilzer SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1MTA3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDYtMDYtMzAgIERhdmlkIEtpbHplciAgPGRk a2lsemVyQGtpbHplci5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgLSBUZXN0IGZvciBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hv d19idWcuY2dpP2lkPTkzNTgKKyAgICAgICAgICBSRUdSRVNTSU9OOiBBc3NlcnRpb24gZmFpbHVy ZSBpbiBIVE1MSW5wdXRFbGVtZW50OjpzZXRWYWx1ZUZyb21SZW5kZXJlcgorICAgICAgICAgICh2 YWx1ZSA9PSBjb25zdHJhaW5WYWx1ZSh2YWx1ZSkpIHdoZW4gZGVsZXRpbmcgYWxsIHRleHQKKwor ICAgICAgICAqIGVkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLWFsbC10ZXh0LWluLXRleHQtZmllbGQt YXNzZXJ0aW9uLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9kZWxldGlu Zy9kZWxldGUtYWxsLXRleHQtaW4tdGV4dC1maWVsZC1hc3NlcnRpb24uaHRtbDogQWRkZWQuCisK IDIwMDYtMDYtMjkgIFNhbSBXZWluaWcgIDxzYW0ud2VpbmlnQGdtYWlsLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBIeWF0dC4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvZGVsZXRpbmcv ZGVsZXRlLWFsbC10ZXh0LWluLXRleHQtZmllbGQtYXNzZXJ0aW9uLWV4cGVjdGVkLnR4dAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1hbGwtdGV4dC1p bi10ZXh0LWZpZWxkLWFzc2VydGlvbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9lZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1hbGwtdGV4dC1pbi10ZXh0LWZpZWxkLWFz c2VydGlvbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTEgQEAKK0VESVRJ TkcgREVMRUdBVEU6IHdlYlZpZXdEaWRDaGFuZ2VTZWxlY3Rpb246V2ViVmlld0RpZENoYW5nZVNl bGVjdGlvbk5vdGlmaWNhdGlvbgorRURJVElORyBERUxFR0FURTogc2hvdWxkQ2hhbmdlU2VsZWN0 ZWRET01SYW5nZTpyYW5nZSBmcm9tIDAgb2YgI3RleHQgPiBESVYgdG8gMSBvZiAjdGV4dCA+IERJ ViB0b0RPTVJhbmdlOnJhbmdlIGZyb20gMCBvZiAjdGV4dCA+IERJViB0byAxIG9mICN0ZXh0ID4g RElWIGFmZmluaXR5Ok5TU2VsZWN0aW9uQWZmaW5pdHlEb3duc3RyZWFtIHN0aWxsU2VsZWN0aW5n OkZBTFNFCitFRElUSU5HIERFTEVHQVRFOiBzaG91bGRDaGFuZ2VTZWxlY3RlZERPTVJhbmdlOihu dWxsKSB0b0RPTVJhbmdlOnJhbmdlIGZyb20gMCBvZiBESVYgdG8gMCBvZiBESVYgYWZmaW5pdHk6 TlNTZWxlY3Rpb25BZmZpbml0eURvd25zdHJlYW0gc3RpbGxTZWxlY3Rpbmc6RkFMU0UKK0VESVRJ TkcgREVMRUdBVEU6IHdlYlZpZXdEaWRDaGFuZ2VTZWxlY3Rpb246V2ViVmlld0RpZENoYW5nZVNl bGVjdGlvbk5vdGlmaWNhdGlvbgorRURJVElORyBERUxFR0FURTogd2ViVmlld0RpZENoYW5nZTpX ZWJWaWV3RGlkQ2hhbmdlTm90aWZpY2F0aW9uCitCdWcgOTM1ODogUkVHUkVTU0lPTjogQXNzZXJ0 aW9uIGZhaWx1cmUgaW4gSFRNTElucHV0RWxlbWVudDo6c2V0VmFsdWVGcm9tUmVuZGVyZXIgKHZh bHVlID09IGNvbnN0cmFpblZhbHVlKHZhbHVlKSkgd2hlbiBkZWxldGluZyBhbGwgdGV4dAoraHR0 cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05MzU4CisKK0Fzc2Vy dGlvbiBmYWlscyB3aGVuIGFsbCBjaGFyYWN0ZXJzIGFyZSBkZWxldGVkOiAKK1NVQ0NFU1MgaWYg dGhlIHRlc3QgZGlkbid0IGNyYXNoIGFuZCB5b3Ugc2VlIHRoaXMgbWVzc2FnZS4KKwpJbmRleDog TGF5b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy9kZWxldGUtYWxsLXRleHQtaW4tdGV4dC1maWVs ZC1hc3NlcnRpb24uaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2RlbGV0 aW5nL2RlbGV0ZS1hbGwtdGV4dC1pbi10ZXh0LWZpZWxkLWFzc2VydGlvbi5odG1sCShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy9kZWxldGUtYWxsLXRleHQtaW4t dGV4dC1maWVsZC1hc3NlcnRpb24uaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzMCBAQAor PGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy KSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgIGxheW91 dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKK30KKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9 Ii4uL2VkaXRpbmcuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8ZGl2PkJ1ZyA5MzU4 OiBSRUdSRVNTSU9OOiBBc3NlcnRpb24gZmFpbHVyZSBpbiBIVE1MSW5wdXRFbGVtZW50OjpzZXRW YWx1ZUZyb21SZW5kZXJlciAodmFsdWUgPT0gY29uc3RyYWluVmFsdWUodmFsdWUpKSB3aGVuIGRl bGV0aW5nIGFsbCB0ZXh0PC9kaXY+Cis8ZGl2PjxhIGhyZWY9Imh0dHA6Ly9idWd6aWxsYS5vcGVu ZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM1OCI+aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3 aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05MzU4PC9hPjwvZGl2PgorPGRpdj48YnI+PC9kaXY+Cis8 Zm9ybT4KK0Fzc2VydGlvbiBmYWlscyB3aGVuIGFsbCBjaGFyYWN0ZXJzIGFyZSBkZWxldGVkOiA8 aW5wdXQgdHlwZT0idGV4dCIgaWQ9InQiIHZhbHVlPSJYIj4KKzwvZm9ybT4KKzxzY3JpcHQ+Citk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgidCIpLmZvY3VzKCk7Citkb2N1bWVudC5leGVjQ29tbWFu ZCgiU2VsZWN0QWxsIik7Citkb2N1bWVudC5leGVjQ29tbWFuZCgiRGVsZXRlIik7Cis8L3Njcmlw dD4KKzxkaXY+U1VDQ0VTUyBpZiB0aGUgdGVzdCBkaWRuJ3QgY3Jhc2ggYW5kIHlvdSBzZWUgdGhp cyBtZXNzYWdlLjwvZGl2PgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs ZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCkKK30KKzwvc2NyaXB0 PgorPGJvZHk+Cis8L2h0bWw+CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUxMDcpCisrKyBXZWJDb3JlL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDA2LTA2LTMwICBEYXZpZCBLaWx6 ZXIgIDxkZGtpbHplckBraWx6ZXIubmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIC0gRml4IGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTM1OAorICAgICAgICAgIFJFR1JFU1NJT046IEFzc2VydGlvbiBmYWls dXJlIGluIEhUTUxJbnB1dEVsZW1lbnQ6OnNldFZhbHVlRnJvbVJlbmRlcmVyCisgICAgICAgICAg KHZhbHVlID09IGNvbnN0cmFpblZhbHVlKHZhbHVlKSkgd2hlbiBkZWxldGluZyBhbGwgdGV4dAor CisgICAgICAgIFRlc3Q6IGVkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLWFsbC10ZXh0LWluLXRleHQt ZmllbGQtYXNzZXJ0aW9uLmh0bWwKKworICAgICAgICBCdWcgOTY2MSBmaWxlZCB0byBmaXggdGhl IGZvbGxvdy11cCBpc3N1ZToKKyAgICAgICAgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3Jn L3Nob3dfYnVnLmNnaT9pZD05NjYxCisgICAgICAgIHRleHRDb250ZW50IHJldHVybnMgIlxuIiBm b3IgYSA8YnI+IGV2ZW4gaWYgaXQgaXMgY29sbGFwc2VkCisKKyAgICAgICAgKiBodG1sL0hUTUxJ bnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6c2V0 VmFsdWVGcm9tUmVuZGVyZXIpOiBXb3JrIGFyb3VuZCAiXG4iIHZhbHVlCisgICAgICAgIHdoZW4g YWxsIGNoYXJhY3RlcnMgYXJlIGRlbGV0ZWQgZnJvbSBhIHRleHQgZmllbGQuCisKIDIwMDYtMDYt MzAgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdAbWl0enBldHRlbC5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgVGltIEguCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVu dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCShy ZXZpc2lvbiAxNTEwNikKKysrIFdlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTA4OSw5ICsxMDg5LDE2IEBAIHZvaWQgSFRNTElucHV0RWxlbWVudDo6 c2V0VmFsdWUoY29uc3QgU3QKIHZvaWQgSFRNTElucHV0RWxlbWVudDo6c2V0VmFsdWVGcm9tUmVu ZGVyZXIoY29uc3QgU3RyaW5nJiB2YWx1ZSkKIHsKICAgICAvLyBSZW5kZXJlciBhbmQgb3VyIGV2 ZW50IGhhbmRsZXIgYXJlIHJlc3BvbnNpYmxlIGZvciBjb25zdHJhaW5pbmcgdmFsdWVzLgotICAg IEFTU0VSVCh2YWx1ZSA9PSBjb25zdHJhaW5WYWx1ZSh2YWx1ZSkpOworICAgIEFTU0VSVCh2YWx1 ZSA9PSBjb25zdHJhaW5WYWx1ZSh2YWx1ZSkgfHwgY29uc3RyYWluVmFsdWUodmFsdWUpLmlzRW1w dHkoKSk7CisKKyAgICAvLyBXb3JrYXJvdW5kIGZvciBidWcgd2hlcmUgdHJhaWxpbmcgXG4gaXMg aW5jbHVkZWQgaW4gdGhlIHJlc3VsdCBvZiB0ZXh0Q29udGVudC4KKyAgICAvLyBUaGUgYXNzZXJ0 IG1hY3JvIGFib3ZlIG1heSBhbHNvIGJlIHNpbXBsaWZpZWQgdG86ICB2YWx1ZSA9PSBjb25zdHJh aW5WYWx1ZSh2YWx1ZSkKKyAgICAvLyBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hv d19idWcuY2dpP2lkPTk2NjEKKyAgICBpZiAodmFsdWUgPT0gIlxuIikKKyAgICAgICAgbV92YWx1 ZSA9ICIiOworICAgIGVsc2UKKyAgICAgICAgbV92YWx1ZSA9IHZhbHVlOwogCi0gICAgbV92YWx1 ZSA9IHZhbHVlOwogICAgIHNldFZhbHVlTWF0Y2hlc1JlbmRlcmVyKCk7CiAKICAgICAvLyBGaXJl IHRoZSAiaW5wdXQiIERPTSBldmVudC4K