93572 2012-08-08 19:59:11 -0700 Append the unit in place when generating the text value of a CSSPrimitiveValue 2012-08-09 16:50:12 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin cmarcelo macpherson menard webkit.review.bot oldest_to_newest 691128 0 benjamin 2012-08-08 19:59:11 -0700 Append the unit in place when generating the text value of a CSSPrimitiveValue 691150 1 157379 benjamin 2012-08-08 20:33:41 -0700 Created attachment 157379 Patch 691384 2 157379 kling 2012-08-09 05:02:52 -0700 Comment on attachment 157379 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157379&action=review r=me, great idea. > Source/WebCore/css/CSSPrimitiveValue.cpp:835 > - StringBuffer<UChar> buffer(decimal.bufferLengthForStringDecimal()); > + StringBuffer<UChar> buffer(decimal.bufferLengthForStringDecimal() + suffixLength); Could this also be made to use LChar/8-bit strings? 691581 3 benjamin 2012-08-09 10:46:50 -0700 > > Source/WebCore/css/CSSPrimitiveValue.cpp:835 > > - StringBuffer<UChar> buffer(decimal.bufferLengthForStringDecimal()); > > + StringBuffer<UChar> buffer(decimal.bufferLengthForStringDecimal() + suffixLength); > > Could this also be made to use LChar/8-bit strings? Yep, I had been thinking the exact same thing when writing that :) 691990 4 benjamin 2012-08-09 16:50:12 -0700 Committed r125221: <http://trac.webkit.org/changeset/125221> 157379 2012-08-08 20:33:41 -0700 2012-08-09 05:02:52 -0700 Patch bug-93572-20120808203315.patch text/plain 6968 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDZhZjAwZmYxN2Q1M2Nm OWVhZTRmOWU4ZmE3MzQ1NjRlNGM3MjI3My4uYjA5N2JjOGM2YzQ0MzUyZDEzYmI3ZDM3NGI1MTRh ODhiMGMyNWI0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA4LTA4ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIEFwcGVuZCB0aGUg dW5pdCBpbiBwbGFjZSB3aGVuIGdlbmVyYXRpbmcgdGhlIHRleHQgdmFsdWUgb2YgYSBDU1NQcmlt aXRpdmVWYWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTM1NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBQcmV2aW91c2x5LCB0aGUgdW5pdHMgd2VyZSBhZGRlZCB0byB0aGUgZm9ybWF0dGVkIG51bWJl ciBieSB0aGUgb3BlcmF0b3IrLiBUaGlzIHdvdWxkIGNyZWF0ZQorICAgICAgICBhIG5ldyBXVEY6 OlN0cmluZyBmb3IgdGhlIHVuaXQsIHRoZW4gdXNlIFN0cmluZzo6YXBwZW5kKCkgdG8gYWRkIGl0 IHRvIHRoZSBudW1iZXIuCisKKyAgICAgICAgVGhpcyB3YXMgaW5lZmZlY3RpdmUgYmVjYXVzZSBp dCByZXF1aXJlZCBvbmUgbWFsbG9jIGZvciB0aGUgdW5pdCwgZm9sbG93ZWQgYnkgYSByZWFsbG9j ICsgY29weWluZworICAgICAgICB0aGUgYnl0ZXMuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRz IGhhbmRsaW5nIGZvciB0aGUgdW5pdCBkaXJlY3RseSBpbiBmb3JtYXROdW1iZXIoKSBzbyB0aGF0 IHdlIG9ubHkgZG8gb25lIG1hbGxvYworICAgICAgICBhbmQgYXBwZW5kIHRoZSB1bml0cyBpbiBw bGFjZS4KKworICAgICAgICBBdm9pZGluZyB0aGUgaW50ZXJtZWRpYXRlIHN0cmluZyBpcyBib3Ro IG1vcmUgZWZmaWNpZW50ICg5JSBmYXN0ZXIgYXMgc2VlbiBmcm9tIEphdmFTY3JpcHQpCisgICAg ICAgIGFuZCBnZW5lcmF0ZSBtb3JlIGNvbXBhY3QgY29kZSAofjhrYiBsZXNzIGNvZGUgb24geDg2 XzY0KS4KKworICAgICAgICAqIGNzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpmb3JtYXROdW1iZXIpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUHJpbWl0aXZlVmFs dWU6OmN1c3RvbUNzc1RleHQpOgorCiAyMDEyLTA4LTA4ICBCZXRoIERha2luICA8YmRha2luQGFw cGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTMzOTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1 ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwCmluZGV4IDE2 NzY3MWE0NGFkN2JmNjMyNzgyYmY2MWU0MzdjZDJjYWI3ZDFhYWYuLmU0MGRkY2QyNjJjZjZiY2Qw ZmYwYzc5NDQ5YjQxYmQzZGUwYzkzYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQcmltaXRpdmVWYWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2 ZVZhbHVlLmNwcApAQCAtODI4LDE3ICs4MjgsMjYgQEAgUGFpciogQ1NTUHJpbWl0aXZlVmFsdWU6 OmdldFBhaXJWYWx1ZShFeGNlcHRpb25Db2RlJiBlYykgY29uc3QKICAgICByZXR1cm4gbV92YWx1 ZS5wYWlyOwogfQogCi1zdGF0aWMgU3RyaW5nIGZvcm1hdE51bWJlcihkb3VibGUgbnVtYmVyKQor c3RhdGljIFN0cmluZyBmb3JtYXROdW1iZXIoZG91YmxlIG51bWJlciwgY29uc3QgY2hhciogc3Vm Zml4LCB1bnNpZ25lZCBzdWZmaXhMZW5ndGgpCiB7CiAgICAgRGVjaW1hbE51bWJlciBkZWNpbWFs KG51bWJlcik7CiAKLSAgICBTdHJpbmdCdWZmZXI8VUNoYXI+IGJ1ZmZlcihkZWNpbWFsLmJ1ZmZl ckxlbmd0aEZvclN0cmluZ0RlY2ltYWwoKSk7CisgICAgU3RyaW5nQnVmZmVyPFVDaGFyPiBidWZm ZXIoZGVjaW1hbC5idWZmZXJMZW5ndGhGb3JTdHJpbmdEZWNpbWFsKCkgKyBzdWZmaXhMZW5ndGgp OwogICAgIHVuc2lnbmVkIGxlbmd0aCA9IGRlY2ltYWwudG9TdHJpbmdEZWNpbWFsKGJ1ZmZlci5j aGFyYWN0ZXJzKCksIGJ1ZmZlci5sZW5ndGgoKSk7Ci0gICAgQVNTRVJUX1VOVVNFRChsZW5ndGgs IGxlbmd0aCA9PSBidWZmZXIubGVuZ3RoKCkpOworICAgIEFTU0VSVChsZW5ndGggKyBzdWZmaXhM ZW5ndGggPT0gYnVmZmVyLmxlbmd0aCgpKTsKKworICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkg PCBzdWZmaXhMZW5ndGg7ICsraSkKKyAgICAgICAgYnVmZmVyW2xlbmd0aCArIGldID0gc3VmZml4 W2ldOwogCiAgICAgcmV0dXJuIFN0cmluZzo6YWRvcHQoYnVmZmVyKTsKIH0KIAordGVtcGxhdGUg PHVuc2lnbmVkIGNoYXJhY3RlckNvdW50PgorQUxXQVlTX0lOTElORSBzdGF0aWMgU3RyaW5nIGZv cm1hdE51bWJlcihkb3VibGUgbnVtYmVyLCBjb25zdCBjaGFyICgmY2hhcmFjdGVycylbY2hhcmFj dGVyQ291bnRdKQoreworICAgIHJldHVybiBmb3JtYXROdW1iZXIobnVtYmVyLCBjaGFyYWN0ZXJz LCBjaGFyYWN0ZXJDb3VudCAtIDEpOworfQorCiBTdHJpbmcgQ1NTUHJpbWl0aXZlVmFsdWU6OmN1 c3RvbUNzc1RleHQoKSBjb25zdAogewogICAgIC8vIEZJWE1FOiByZXR1cm4gdGhlIG9yaWdpbmFs IHZhbHVlIGluc3RlYWQgb2YgYSBnZW5lcmF0ZWQgb25lIChlLmcuIGNvbG9yCkBAIC04NTYsNzIg Kzg2NSw3MiBAQCBTdHJpbmcgQ1NTUHJpbWl0aXZlVmFsdWU6OmN1c3RvbUNzc1RleHQoKSBjb25z dAogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgQ1NTX05VTUJFUjoKICAgICAgICAg Y2FzZSBDU1NfUEFSU0VSX0lOVEVHRVI6Ci0gICAgICAgICAgICB0ZXh0ID0gZm9ybWF0TnVtYmVy KG1fdmFsdWUubnVtKTsKKyAgICAgICAgICAgIHRleHQgPSBmb3JtYXROdW1iZXIobV92YWx1ZS5u dW0sICIiKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIENTU19QRVJDRU5UQUdF OgotICAgICAgICAgICAgdGV4dCA9IGZvcm1hdE51bWJlcihtX3ZhbHVlLm51bSkgKyAiJSI7Cisg ICAgICAgICAgICB0ZXh0ID0gZm9ybWF0TnVtYmVyKG1fdmFsdWUubnVtLCAiJSIpOwogICAgICAg ICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgQ1NTX0VNUzoKLSAgICAgICAgICAgIHRleHQgPSBm b3JtYXROdW1iZXIobV92YWx1ZS5udW0pICsgImVtIjsKKyAgICAgICAgICAgIHRleHQgPSBmb3Jt YXROdW1iZXIobV92YWx1ZS5udW0sICJlbSIpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg IGNhc2UgQ1NTX0VYUzoKLSAgICAgICAgICAgIHRleHQgPSBmb3JtYXROdW1iZXIobV92YWx1ZS5u dW0pICsgImV4IjsKKyAgICAgICAgICAgIHRleHQgPSBmb3JtYXROdW1iZXIobV92YWx1ZS5udW0s ICJleCIpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgQ1NTX1JFTVM6Ci0gICAg ICAgICAgICB0ZXh0ID0gZm9ybWF0TnVtYmVyKG1fdmFsdWUubnVtKSArICJyZW0iOworICAgICAg ICAgICAgdGV4dCA9IGZvcm1hdE51bWJlcihtX3ZhbHVlLm51bSwgInJlbSIpOwogICAgICAgICAg ICAgYnJlYWs7CiAgICAgICAgIGNhc2UgQ1NTX1BYOgotICAgICAgICAgICAgdGV4dCA9IGZvcm1h dE51bWJlcihtX3ZhbHVlLm51bSkgKyAicHgiOworICAgICAgICAgICAgdGV4dCA9IGZvcm1hdE51 bWJlcihtX3ZhbHVlLm51bSwgInB4Iik7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2Fz ZSBDU1NfQ006Ci0gICAgICAgICAgICB0ZXh0ID0gZm9ybWF0TnVtYmVyKG1fdmFsdWUubnVtKSAr ICJjbSI7CisgICAgICAgICAgICB0ZXh0ID0gZm9ybWF0TnVtYmVyKG1fdmFsdWUubnVtLCAiY20i KTsKICAgICAgICAgICAgIGJyZWFrOwogI2lmIEVOQUJMRShDU1NfSU1BR0VfUkVTT0xVVElPTikK ICAgICAgICAgY2FzZSBDU1NfRFBQWDoKLSAgICAgICAgICAgIHRleHQgPSBmb3JtYXROdW1iZXIo bV92YWx1ZS5udW0pICsgImRwcHgiOworICAgICAgICAgICAgdGV4dCA9IGZvcm1hdE51bWJlciht X3ZhbHVlLm51bSwgImRwcHgiKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIENT U19EUEk6Ci0gICAgICAgICAgICB0ZXh0ID0gZm9ybWF0TnVtYmVyKG1fdmFsdWUubnVtKSArICJk cGkiOworICAgICAgICAgICAgdGV4dCA9IGZvcm1hdE51bWJlcihtX3ZhbHVlLm51bSwgImRwaSIp OwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgQ1NTX0RQQ006Ci0gICAgICAgICAg ICB0ZXh0ID0gZm9ybWF0TnVtYmVyKG1fdmFsdWUubnVtKSArICJkcGNtIjsKKyAgICAgICAgICAg IHRleHQgPSBmb3JtYXROdW1iZXIobV92YWx1ZS5udW0sICJkcGNtIik7CiAgICAgICAgICAgICBi cmVhazsKICNlbmRpZgogICAgICAgICBjYXNlIENTU19NTToKLSAgICAgICAgICAgIHRleHQgPSBm b3JtYXROdW1iZXIobV92YWx1ZS5udW0pICsgIm1tIjsKKyAgICAgICAgICAgIHRleHQgPSBmb3Jt YXROdW1iZXIobV92YWx1ZS5udW0sICJtbSIpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg IGNhc2UgQ1NTX0lOOgotICAgICAgICAgICAgdGV4dCA9IGZvcm1hdE51bWJlcihtX3ZhbHVlLm51 bSkgKyAiaW4iOworICAgICAgICAgICAgdGV4dCA9IGZvcm1hdE51bWJlcihtX3ZhbHVlLm51bSwg ImluIik7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBDU1NfUFQ6Ci0gICAgICAg ICAgICB0ZXh0ID0gZm9ybWF0TnVtYmVyKG1fdmFsdWUubnVtKSArICJwdCI7CisgICAgICAgICAg ICB0ZXh0ID0gZm9ybWF0TnVtYmVyKG1fdmFsdWUubnVtLCAicHQiKTsKICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICBjYXNlIENTU19QQzoKLSAgICAgICAgICAgIHRleHQgPSBmb3JtYXROdW1i ZXIobV92YWx1ZS5udW0pICsgInBjIjsKKyAgICAgICAgICAgIHRleHQgPSBmb3JtYXROdW1iZXIo bV92YWx1ZS5udW0sICJwYyIpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgQ1NT X0RFRzoKLSAgICAgICAgICAgIHRleHQgPSBmb3JtYXROdW1iZXIobV92YWx1ZS5udW0pICsgImRl ZyI7CisgICAgICAgICAgICB0ZXh0ID0gZm9ybWF0TnVtYmVyKG1fdmFsdWUubnVtLCAiZGVnIik7 CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBDU1NfUkFEOgotICAgICAgICAgICAg dGV4dCA9IGZvcm1hdE51bWJlcihtX3ZhbHVlLm51bSkgKyAicmFkIjsKKyAgICAgICAgICAgIHRl eHQgPSBmb3JtYXROdW1iZXIobV92YWx1ZS5udW0sICJyYWQiKTsKICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICBjYXNlIENTU19HUkFEOgotICAgICAgICAgICAgdGV4dCA9IGZvcm1hdE51bWJl cihtX3ZhbHVlLm51bSkgKyAiZ3JhZCI7CisgICAgICAgICAgICB0ZXh0ID0gZm9ybWF0TnVtYmVy KG1fdmFsdWUubnVtLCAiZ3JhZCIpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2Ug Q1NTX01TOgotICAgICAgICAgICAgdGV4dCA9IGZvcm1hdE51bWJlcihtX3ZhbHVlLm51bSkgKyAi bXMiOworICAgICAgICAgICAgdGV4dCA9IGZvcm1hdE51bWJlcihtX3ZhbHVlLm51bSwgIm1zIik7 CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBDU1NfUzoKLSAgICAgICAgICAgIHRl eHQgPSBmb3JtYXROdW1iZXIobV92YWx1ZS5udW0pICsgInMiOworICAgICAgICAgICAgdGV4dCA9 IGZvcm1hdE51bWJlcihtX3ZhbHVlLm51bSwgInMiKTsKICAgICAgICAgICAgIGJyZWFrOwogICAg ICAgICBjYXNlIENTU19IWjoKLSAgICAgICAgICAgIHRleHQgPSBmb3JtYXROdW1iZXIobV92YWx1 ZS5udW0pICsgImh6IjsKKyAgICAgICAgICAgIHRleHQgPSBmb3JtYXROdW1iZXIobV92YWx1ZS5u dW0sICJoeiIpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgQ1NTX0tIWjoKLSAg ICAgICAgICAgIHRleHQgPSBmb3JtYXROdW1iZXIobV92YWx1ZS5udW0pICsgImtoeiI7CisgICAg ICAgICAgICB0ZXh0ID0gZm9ybWF0TnVtYmVyKG1fdmFsdWUubnVtLCAia2h6Iik7CiAgICAgICAg ICAgICBicmVhazsKICAgICAgICAgY2FzZSBDU1NfVFVSTjoKLSAgICAgICAgICAgIHRleHQgPSBm b3JtYXROdW1iZXIobV92YWx1ZS5udW0pICsgInR1cm4iOworICAgICAgICAgICAgdGV4dCA9IGZv cm1hdE51bWJlcihtX3ZhbHVlLm51bSwgInR1cm4iKTsKICAgICAgICAgICAgIGJyZWFrOwogICAg ICAgICBjYXNlIENTU19ESU1FTlNJT046CiAgICAgICAgICAgICAvLyBGSVhNRQpAQCAtMTExMywx MyArMTEyMiwxMyBAQCBTdHJpbmcgQ1NTUHJpbWl0aXZlVmFsdWU6OmN1c3RvbUNzc1RleHQoKSBj b25zdAogICAgICAgICAgICAgdGV4dCA9IG1fdmFsdWUuc2hhcGUtPmNzc1RleHQoKTsKICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIENTU19WVzoKLSAgICAgICAgICAgIHRleHQgPSBm b3JtYXROdW1iZXIobV92YWx1ZS5udW0pICsgInZ3IjsKKyAgICAgICAgICAgIHRleHQgPSBmb3Jt YXROdW1iZXIobV92YWx1ZS5udW0sICJ2dyIpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg IGNhc2UgQ1NTX1ZIOgotICAgICAgICAgICAgdGV4dCA9IGZvcm1hdE51bWJlcihtX3ZhbHVlLm51 bSkgKyAidmgiOworICAgICAgICAgICAgdGV4dCA9IGZvcm1hdE51bWJlcihtX3ZhbHVlLm51bSwg InZoIik7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBDU1NfVk1JTjoKLSAgICAg ICAgICAgIHRleHQgPSBmb3JtYXROdW1iZXIobV92YWx1ZS5udW0pICsgInZtaW4iOworICAgICAg ICAgICAgdGV4dCA9IGZvcm1hdE51bWJlcihtX3ZhbHVlLm51bSwgInZtaW4iKTsKICAgICAgICAg ICAgIGJyZWFrOwogI2lmIEVOQUJMRShDU1NfVkFSSUFCTEVTKQogICAgICAgICBjYXNlIENTU19W QVJJQUJMRV9OQU1FOgo=