93548 2012-08-08 16:28:23 -0700 [BlackBerry] Fix "-fPIC" define in the BlackBerry build 2012-08-08 17:18:21 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 mxie webkit-unassigned gyuyoung.kim rakuco rwlbuis tonikitoo webkit.review.bot oldest_to_newest 690893 0 mxie 2012-08-08 16:28:23 -0700 In the current CMake release (version 2.8.5), ${CMAKE_SHARED_LIBRARY_C_FLAGS} and ${CMAKE_SHARED_LIBRARY_CXX_FLAGS} is set to empty (See cmake/Modules/Platform/QNX.cmake) This breaks the assumption which WebKit CMake build system makes in Source/cmake/WebKitHelper.cmake 690908 1 157331 mxie 2012-08-08 16:38:46 -0700 Created attachment 157331 Patch 690910 2 157331 rwlbuis 2012-08-08 16:39:25 -0700 Comment on attachment 157331 Patch LGTM. 690981 3 157331 webkit.review.bot 2012-08-08 17:18:16 -0700 Comment on attachment 157331 Patch Clearing flags on attachment: 157331 Committed r125121: <http://trac.webkit.org/changeset/125121> 690982 4 webkit.review.bot 2012-08-08 17:18:21 -0700 All reviewed patches have been landed. Closing bug. 157331 2012-08-08 16:38:46 -0700 2012-08-08 17:18:16 -0700 Patch bug-93548-20120808193820.patch text/plain 1810 mxie U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0JsYWNrQmVycnkuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0JsYWNrQmVycnkuY21h a2UKaW5kZXggMTk3ZDEwZTUxZDU4Zjc1N2RiOTVlNWUzYjkzOWFjNmU3ZmViMWNlZS4uNDhkNzhk ODMyZWY0YWMyYzJlNTM2MDY3MTkzZjhmNTU1MjQ1NmVjNiAxMDA2NDQKLS0tIGEvU291cmNlL2Nt YWtlL09wdGlvbnNCbGFja0JlcnJ5LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQmxh Y2tCZXJyeS5jbWFrZQpAQCAtOTYsNiArOTYsMTEgQEAgRklORF9TVEFHSU5HX0xJQlJBUlkoUFJP RklMSU5HX0xJQlJBUlkgcHJvZmlsaW5nUykKIEZJTkRfU1RBR0lOR19MSUJSQVJZKExJQl9JTlBV VF9VVElMSVRJRVMgaW5wdXRfdXRpbGl0aWVzKQogRklORF9TVEFHSU5HX0xJQlJBUlkoT1RTX0xJ QlJBUlkgb3RzKQogCisjIEFkZCAiLWZQSUMiIHRvIENNQUtFX1NIQVJFRF9MSUJSQVJZX0NfRkxB R1MgYW5kIENNQUtFX1NIQVJFRF9MSUJSQVJZX0NYWF9GTEFHUworIyBUaGlzIGlzIGJlY2F1c2Ug Ii1mUElDIiBpcyBub3QgaW5jbHVkZWQgaW4gdGhlIGRlZmF1bHQgZGVmaW5lcyB1bmRlciBNb2R1 bGVzL1BsYXRmb3JtL1FOWC5jbWFrZQorU0VUKENNQUtFX1NIQVJFRF9MSUJSQVJZX0NfRkxBR1Mg Ii1mUElDICR7Q01BS0VfU0hBUkVEX0xJQlJBUllfQ19GTEFHU30iKQorU0VUKENNQUtFX1NIQVJF RF9MSUJSQVJZX0NYWF9GTEFHUyAiLWZQSUMgJHtDTUFLRV9TSEFSRURfTElCUkFSWV9DWFhfRkxB R1N9IikKKwogIyBTaG93IHVucmVzb2x2ZWQgc3ltYm9scyB3aGVuIGRvaW5nIHRoZSBmaW5hbCBz aGFyZWQgb2JqZWN0IGxpbmsKIElGIChQUk9GSUxJTkcpCiAgICAgU0VUKEJMQUNLQkVSUllfTElO S19GTEFHUyAiLVdsLC16LGRlZnMgLVdsLC16cmVscm8gLVdsLC1FIikKZGlmZiAtLWdpdCBhL0No YW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5MjdlODkzZDY2YjdhMmVkMTcwOThkZWYyZDYzOTRm NTM0YWNlOGY1Li5lYzM5OWQ0NThiNDRhZjM0OTAyZjcwZDUzNDliZTkxYzVhNTg3MzY3IDEwMDY0 NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTIt MDgtMDggIE1pbmcgWGllICA8bXhpZUByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBG aXggIi1mUElDIiBkZWZpbmUgaW4gdGhlIEJsYWNrQmVycnkgYnVpbGQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNTQ4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gdGhlIGN1cnJlbnQgQ01ha2UgcmVs ZWFzZSAodmVyc2lvbiAyLjguNSksICR7Q01BS0VfU0hBUkVECisgICAgICAgIF9MSUJSQVJZX0Nf RkxBR1N9IGFuZCAke0NNQUtFX1NIQVJFRF9MSUJSQVJZX0NYWF9GTEFHU30gaXMKKyAgICAgICAg c2V0IHRvIGVtcHR5IChTZWUgY21ha2UvTW9kdWxlcy9QbGF0Zm9ybS9RTlguY21ha2UpCisKKyAg ICAgICAgVGhpcyBicmVha3MgdGhlIGFzc3VtcHRpb24gd2hpY2ggV2ViS2l0IENNYWtlIGJ1aWxk IHN5c3RlbSAKKyAgICAgICAgbWFrZXMgaW4gU291cmNlL2NtYWtlL1dlYktpdEhlbHBlci5jbWFr ZQorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNCbGFja0JlcnJ5LmNtYWtlOgorCiAy MDEyLTA4LTA4ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1N0cmVhbWVyXSAwLjExIGJ1aWxkIGJyb2tlbiAoYWdhaW4pCg==