93535 2012-08-08 15:08:11 -0700 [chromium/mac] Map NSEventPhaseMayBegin appropriately on 10.8 2012-11-06 11:57:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 asvitkine asvitkine dglazkov thakis webkit.review.bot oldest_to_newest 690798 0 asvitkine 2012-08-08 15:08:11 -0700 [chromium/mac] Map NSEventPhaseMayBegin appropriately on 10.8 690802 1 157307 asvitkine 2012-08-08 15:11:50 -0700 Created attachment 157307 Patch 690808 2 asvitkine 2012-08-08 15:14:31 -0700 Nico: Please review the change. Dimitri: Will need you approval (assuming Nico still isn't a reviewer). 690813 3 157307 thakis 2012-08-08 15:21:42 -0700 Comment on attachment 157307 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157307&action=review LGTM, thanks for doing this. (Bug 79868 has some background.) > Source/WebKit/chromium/src/mac/WebInputEventFactory.mm:57 > +#if __MAC_OS_X_VERSION_MAX_ALLOWED < 1080 https://developer.apple.com/library/mac/#documentation/Cocoa/Reference/ApplicationKit/Classes/nsevent_Class/Reference/Reference.html doesn't mention this for 10.8 either , so maybe omit the #if completely? 690820 4 157307 asvitkine 2012-08-08 15:27:59 -0700 Comment on attachment 157307 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157307&action=review >> Source/WebKit/chromium/src/mac/WebInputEventFactory.mm:57 >> +#if __MAC_OS_X_VERSION_MAX_ALLOWED < 1080 > > https://developer.apple.com/library/mac/#documentation/Cocoa/Reference/ApplicationKit/Classes/nsevent_Class/Reference/Reference.html doesn't mention this for 10.8 either , so maybe omit the #if completely? It's in the 10.8 SDK NSEvent.h header though... Wouldn't omitting it result in a build error when building against the 10.8 SDK? (Or do compilers ignore multiply-defined enums with same values these days like they do with typedefs?) 690829 5 thakis 2012-08-08 15:32:36 -0700 (In reply to comment #4) > (From update of attachment 157307 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157307&action=review > > >> Source/WebKit/chromium/src/mac/WebInputEventFactory.mm:57 > >> +#if __MAC_OS_X_VERSION_MAX_ALLOWED < 1080 > > > > https://developer.apple.com/library/mac/#documentation/Cocoa/Reference/ApplicationKit/Classes/nsevent_Class/Reference/Reference.html doesn't mention this for 10.8 either , so maybe omit the #if completely? > > It's in the 10.8 SDK NSEvent.h header though... Ah ok, then it's correct as is (I don't have a 10.8 SDK at hand to check). > > Wouldn't omitting it result in a build error when building against the 10.8 SDK? (Or do compilers ignore multiply-defined enums with same values these days like they do with typedefs?) No, multiply-defined enums are an error. I assumed the documentation would match the header. Silly me. 690834 6 157307 dglazkov 2012-08-08 15:34:56 -0700 Comment on attachment 157307 Patch rs=me 691012 7 157307 webkit.review.bot 2012-08-08 17:40:52 -0700 Comment on attachment 157307 Patch Clearing flags on attachment: 157307 Committed r125125: <http://trac.webkit.org/changeset/125125> 691013 8 webkit.review.bot 2012-08-08 17:40:56 -0700 All reviewed patches have been landed. Closing bug. 759939 9 asvitkine 2012-11-06 11:57:23 -0800 For historical purposes, this fixed http://crbug.com/139553. 157307 2012-08-08 15:11:50 -0700 2012-08-08 17:40:52 -0700 Patch bug-93535-20120808181122.patch text/plain 2820 asvitkine U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MDg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDZmNGNmYjhiNDQ1MWFkY2ZhMDk3YzRkOTcxOTQ1ODk5MGZkYzgwNTcuLjMzMTlkYjMwNDg5Yjlh MzlmMjMyMWQ4NWNiYTM1MjYzMGMyMjc0MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDgtMDggIEFsZXhlaSBTdml0a2luZSAgPGFzdml0a2luZUBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtL21hY10gTWFwIE5TRXZlbnRQaGFzZU1h eUJlZ2luIGFwcHJvcHJpYXRlbHkgb24gMTAuOAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM1MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIGVuYWJsZXMgcHV0dGluZyB0d28gZmluZ2VycyBvbiB0 aGUgdHJhY2sgcGFkIHRvIHNob3cgb3ZlcmxheSBzY3JvbGwgYmFycyBvbiAxMC44Ky4KKworICAg ICAgICAqIHNyYy9tYWMvV2ViSW5wdXRFdmVudEZhY3RvcnkubW06CisgICAgICAgIChXZWJLaXQ6 OnBoYXNlRm9yTlNFdmVudFBoYXNlKToKKwogMjAxMi0wOC0wNyAgSmFtZXMgUm9iaW5zb24gIDxq YW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gT25seSB1c2UgcHVibGlj IFBsYXRmb3JtIEFQSSBpbiBOb25Db21wb3NpdGVkQ29udGVudEhvc3QKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL21hYy9XZWJJbnB1dEV2ZW50RmFjdG9yeS5tbSBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL21hYy9XZWJJbnB1dEV2ZW50RmFjdG9yeS5tbQppbmRl eCBlMWI5NGE2NDA0MjdjZjNlYmM4M2M2Nzc3ODJmMTA4ZTk5ZjMzODI5Li5iYWJiMWY2Y2NlNzlm NDk3ODhkN2ZiZGUyNTUzMDYyN2YxMzQ4OGE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9tYWMvV2ViSW5wdXRFdmVudEZhY3RvcnkubW0KKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvbWFjL1dlYklucHV0RXZlbnRGYWN0b3J5Lm1tCkBAIC00Myw4ICs0Myw3 IEBAIGVudW0gewogICAgIE5TRXZlbnRQaGFzZVN0YXRpb25hcnkgID0gMHgxIDw8IDEsCiAgICAg TlNFdmVudFBoYXNlQ2hhbmdlZCAgICAgPSAweDEgPDwgMiwKICAgICBOU0V2ZW50UGhhc2VFbmRl ZCAgICAgICA9IDB4MSA8PCAzLAotICAgIE5TRXZlbnRQaGFzZUNhbmNlbGxlZCAgID0gMHgxIDw8 IDQsCi0gICAgTlNFdmVudFBoYXNlTWF5QmVnaW4gICAgPSAweDEgPDwgNQorICAgIE5TRXZlbnRQ aGFzZUNhbmNlbGxlZCAgID0gMHgxIDw8IDQKIH07CiB0eXBlZGVmIE5TVUludGVnZXIgTlNFdmVu dFBoYXNlOwogCkBAIC01NSw2ICs1NCwxNSBAQCB0eXBlZGVmIE5TVUludGVnZXIgTlNFdmVudFBo YXNlOwogCiAjZW5kaWYgIC8vIF9fTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dFRCA8IDEwNzAK IAorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dFRCA8IDEwODAKKworLy8gQWRkaXRp b25hbCBNb3VudGFpbiBMaW9uIEFQSXMuCitlbnVtIHsKKyAgICBOU0V2ZW50UGhhc2VNYXlCZWdp biAgICA9IDB4MSA8PCA1Cit9OworCisjZW5kaWYgIC8vIF9fTUFDX09TX1hfVkVSU0lPTl9NQVhf QUxMT1dFRCA8IDEwODAKKwogLy8gRG8gbm90IF9fTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dF RCBoZXJlIGJlY2F1c2Ugb2YgYSBidWcgaW4gdGhlIDEwLjUgU0RLLAogLy8gc2VlIDxodHRwOi8v bGlzdHMud2Via2l0Lm9yZy9waXBlcm1haWwvd2Via2l0LWRldi8yMDEyLUp1bHkvMDIxNDQyLmh0 bWw+LgogI2lmIE1BQ19PU19YX1ZFUlNJT05fTUFYX0FMTE9XRUQgPD0gMTA1MApAQCAtNzU5LDcg Kzc2Nyw3IEBAIFdlYk1vdXNlRXZlbnQgV2ViSW5wdXRFdmVudEZhY3Rvcnk6Om1vdXNlRXZlbnQo TlNFdmVudCogZXZlbnQsIE5TVmlldyogdmlldykKIAogc3RhdGljIFdlYk1vdXNlV2hlZWxFdmVu dDo6UGhhc2UgcGhhc2VGb3JOU0V2ZW50UGhhc2UoTlNFdmVudFBoYXNlIGV2ZW50UGhhc2UpCiB7 Ci0gICAgdWludDMyX3QgcGhhc2UgPSBXZWJNb3VzZVdoZWVsRXZlbnQ6OlBoYXNlTm9uZTsgCisg ICAgdWludDMyX3QgcGhhc2UgPSBXZWJNb3VzZVdoZWVsRXZlbnQ6OlBoYXNlTm9uZTsKICAgICBp ZiAoZXZlbnRQaGFzZSAmIE5TRXZlbnRQaGFzZUJlZ2FuKQogICAgICAgICBwaGFzZSB8PSBXZWJN b3VzZVdoZWVsRXZlbnQ6OlBoYXNlQmVnYW47CiAgICAgaWYgKGV2ZW50UGhhc2UgJiBOU0V2ZW50 UGhhc2VTdGF0aW9uYXJ5KQpAQCAtNzcwLDYgKzc3OCw4IEBAIHN0YXRpYyBXZWJNb3VzZVdoZWVs RXZlbnQ6OlBoYXNlIHBoYXNlRm9yTlNFdmVudFBoYXNlKE5TRXZlbnRQaGFzZSBldmVudFBoYXNl KQogICAgICAgICBwaGFzZSB8PSBXZWJNb3VzZVdoZWVsRXZlbnQ6OlBoYXNlRW5kZWQ7CiAgICAg aWYgKGV2ZW50UGhhc2UgJiBOU0V2ZW50UGhhc2VDYW5jZWxsZWQpCiAgICAgICAgIHBoYXNlIHw9 IFdlYk1vdXNlV2hlZWxFdmVudDo6UGhhc2VDYW5jZWxsZWQ7CisgICAgaWYgKGV2ZW50UGhhc2Ug JiBOU0V2ZW50UGhhc2VNYXlCZWdpbikKKyAgICAgICAgcGhhc2UgfD0gV2ViTW91c2VXaGVlbEV2 ZW50OjpQaGFzZU1heUJlZ2luOwogICAgIHJldHVybiBzdGF0aWNfY2FzdDxXZWJNb3VzZVdoZWVs RXZlbnQ6OlBoYXNlPihwaGFzZSk7CiB9CiAK