93532 2012-08-08 14:56:32 -0700 Make isTransparentSilverlightBackgroundValue handle all the possible transparent colors 2012-08-08 17:25:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca darin oldest_to_newest 690780 0 andersca 2012-08-08 14:56:32 -0700 Make isTransparentSilverlightBackgroundValue handle all the possible transparent colors 690791 1 157305 andersca 2012-08-08 15:01:34 -0700 Created attachment 157305 Patch 690797 2 157305 simon.fraser 2012-08-08 15:07:21 -0700 Comment on attachment 157305 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157305&action=review > Source/WebKit2/ChangeLog:6 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). oops > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:-554 > - // FIXME: We should handle all the cases from http://msdn.microsoft.com/en-us/library/cc838148(VS.95).aspx here I'd like this url to remain in the comment so I can see where this crazy "ScRGB" stuff comes from. 690805 3 andersca 2012-08-08 15:12:50 -0700 Committed r125098: <http://trac.webkit.org/changeset/125098> 690994 4 darin 2012-08-08 17:25:03 -0700 Patch that was landed has a comment with the word "forumat" in it. 157305 2012-08-08 15:01:34 -0700 2012-08-08 15:07:20 -0700 Patch bug-93532-20120808150109.patch text/plain 3743 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzRhMjhlYmQ2MWUzYjRl OGM3M2M5MDI1NTM2ZjNiYWM1NDRkYzkxZi4uZWVmOTVkOGMzODgyNDhkZmU1ZDJkZGU3YjBhOGMx ODM3YTcxMjZlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTA4LTA4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgTWFrZSBpc1RyYW5z cGFyZW50U2lsdmVybGlnaHRCYWNrZ3JvdW5kVmFsdWUgaGFuZGxlIGFsbCB0aGUgcG9zc2libGUg dHJhbnNwYXJlbnQgY29sb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MzUzMgorCisgICAgICAgIEFkZGl0aW9uYWwgaW5mb3JtYXRpb24gb2YgdGhl IGNoYW5nZSBzdWNoIGFzIGFwcHJvYWNoLCByYXRpb25hbGUuIFBsZWFzZSBhZGQgcGVyLWZ1bmN0 aW9uIGRlc2NyaXB0aW9ucyBiZWxvdyAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9Q bHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcDoKKyAgICAgICAgKFdlYktpdDo6aXNU cmFuc3BhcmVudFNpbHZlcmxpZ2h0QmFja2dyb3VuZFZhbHVlKToKKyAgICAgICAgQ2hlY2sgZm9y IGFsbCB0aGUgcG9zc2libGUgdHJhbnNwYXJlbnQgY29sb3JzIGFuZCBhc3N1bWUgdGhhdCB0aGUg Y29sb3IgaXMgb3BhcXVlIG90aGVyd2lzZS4KKworICAgICAgICAoV2ViS2l0OjpOZXRzY2FwZVBs dWdpbjo6aW5pdGlhbGl6ZSk6CisgICAgICAgIFBhc3MgdGhlIGxvd2VyY2FzZSBzdHJpbmcgdG8g aXNUcmFuc3BhcmVudFNpbHZlcmxpZ2h0QmFja2dyb3VuZFZhbHVlLgorCisyMDEyLTA4LTA4ICBB bmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgTWFrZSB0aGUg U2lsdmVybGlnaHQgQ0FPcGVuR0xMYXllciBvcGFxdWUgaWYgd2Uga25vdyB0aGUgcGx1Zy1pbiBj b250ZW50cyBpcyBvcGFxdWUgdG8gcmVkdWNlIGJsZW5kaW5nCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzUwOAogICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMTIwNTY3NjU+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdp bnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcAppbmRleCBhODZlNTgzNmYzMzhk MDdkOWE0Y2RhY2FlYzU5OTUwOWRiMjEyM2NjLi41NzRjNjMzYzA0NjEwZDc4OTYwNzY1ODM5ODcx YzhjNWUxZTQ5YTcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdp bnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5jcHAKQEAgLTU0OSwxNCArNTQ5 LDMyIEBAIGJvb2wgTmV0c2NhcGVQbHVnaW46OmFsbG93UG9wdXBzKCkgY29uc3QKIH0KIAogI2lm IFBMVUdJTl9BUkNISVRFQ1RVUkUoTUFDKQotc3RhdGljIGJvb2wgaXNUcmFuc3BhcmVudFNpbHZl cmxpZ2h0QmFja2dyb3VuZFZhbHVlKGNvbnN0IFN0cmluZyYgYmFja2dyb3VuZFZhbHVlKQorc3Rh dGljIGJvb2wgaXNUcmFuc3BhcmVudFNpbHZlcmxpZ2h0QmFja2dyb3VuZFZhbHVlKGNvbnN0IFN0 cmluZyYgbG93ZXJjYXNlQmFja2dyb3VuZFZhbHVlKQogewotICAgIC8vIEZJWE1FOiBXZSBzaG91 bGQgaGFuZGxlIGFsbCB0aGUgY2FzZXMgZnJvbSBodHRwOi8vbXNkbi5taWNyb3NvZnQuY29tL2Vu LXVzL2xpYnJhcnkvY2M4MzgxNDgoVlMuOTUpLmFzcHggaGVyZQotICAgIC8vIGluc3RlYWQgb2Yg anVzdCBoYXJkLWNvZGluZyBibGFjay4KLSAgICBpZiAoYmFja2dyb3VuZFZhbHVlID09ICIjMDAw MDAwIikKLSAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGlmIChsb3dlcmNhc2VCYWNrZ3JvdW5k VmFsdWUuc3RhcnRzV2l0aCgnIycpKSB7CisgICAgICAgIGlmIChsb3dlcmNhc2VCYWNrZ3JvdW5k VmFsdWUubGVuZ3RoKCkgPT0gNSAmJiBsb3dlcmNhc2VCYWNrZ3JvdW5kVmFsdWVbMV0gIT0gJ2Yn KSB7CisgICAgICAgICAgICAvLyBBbiA4LWJpdCBSR0IgdmFsdWUgd2l0aCBhbHBoYSB0cmFuc3Bh cmVuY3ksIGluIHRoZSBmb3JtICNBUkdCLgorICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAg ICAgIH0KIAotICAgIHJldHVybiB0cnVlOworICAgICAgICBpZiAobG93ZXJjYXNlQmFja2dyb3Vu ZFZhbHVlLmxlbmd0aCgpID09IDkgJiYgIShsb3dlcmNhc2VCYWNrZ3JvdW5kVmFsdWVbMV0gPT0g J2YnICYmIGxvd2VyY2FzZUJhY2tncm91bmRWYWx1ZVsyXSA9PSAnZicpKSB7CisgICAgICAgICAg ICAvLyBBIDE2LWJpdCBSR0IgdmFsdWUgd2l0aCBhbHBoYSB0cmFuc3BhcmVuY3ksIGluIHRoZSBm b3JtICNBQVJSR0dCQi4KKyAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgICAgICB9CisgICAg fSBlbHNlIGlmIChsb3dlcmNhc2VCYWNrZ3JvdW5kVmFsdWUuc3RhcnRzV2l0aCgic2MjIikpIHsK KyAgICAgICAgVmVjdG9yPFN0cmluZz4gY29tcG9uZW50czsKKyAgICAgICAgbG93ZXJjYXNlQmFj a2dyb3VuZFZhbHVlLnN1YnN0cmluZygzKS5zcGxpdCgiLCIsIGNvbXBvbmVudHMpOworCisgICAg ICAgIC8vIEFuIFNjUkdCIHZhbHVlIHdpdGggYWxwaGEgdHJhbnNwYXJlbmN5LCBpbiB0aGUgZm9y bSBzYyNBLFIsRyxCLgorICAgICAgICBpZiAoY29tcG9uZW50cy5zaXplKCkgPT0gNCkgeworICAg ICAgICAgICAgaWYgKGNvbXBvbmVudHNbMF0udG9Eb3VibGUoKSA8IDEpCisgICAgICAgICAgICAg ICAgcmV0dXJuIHRydWU7CisgICAgICAgIH0KKyAgICB9IGVsc2UgaWYgKGxvd2VyY2FzZUJhY2tn cm91bmRWYWx1ZSA9PSAidHJhbnNwYXJlbnQiKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKworICAg IC8vIFRoaXMgaXMgYW4gb3BhcXVlIGNvbG9yLgorICAgIHJldHVybiBmYWxzZTsKIH0KICNlbmRp ZgogCkBAIC01OTYsNyArNjE0LDcgQEAgYm9vbCBOZXRzY2FwZVBsdWdpbjo6aW5pdGlhbGl6ZShj b25zdCBQYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzKQogICAgIGlmIChtX3BsdWdpbk1vZHVsZS0+cGx1 Z2luUXVpcmtzKCkuY29udGFpbnMoUGx1Z2luUXVpcmtzOjpNYWtlT3BhcXVlVW5sZXNzVHJhbnNw YXJlbnRTaWx2ZXJsaWdodEJhY2tncm91bmRBdHRyaWJ1dGVFeGlzdHMpKSB7CiAgICAgICAgIGZv ciAoc2l6ZV90IGkgPSAwOyBpIDwgcGFyYW1ldGVycy5uYW1lcy5zaXplKCk7ICsraSkgewogICAg ICAgICAgICAgaWYgKGVxdWFsSWdub3JpbmdDYXNlKHBhcmFtZXRlcnMubmFtZXNbaV0sICJiYWNr Z3JvdW5kIikpIHsKLSAgICAgICAgICAgICAgICBzZXRJc1RyYW5zcGFyZW50KGlzVHJhbnNwYXJl bnRTaWx2ZXJsaWdodEJhY2tncm91bmRWYWx1ZShwYXJhbWV0ZXJzLnZhbHVlc1tpXSkpOworICAg ICAgICAgICAgICAgIHNldElzVHJhbnNwYXJlbnQoaXNUcmFuc3BhcmVudFNpbHZlcmxpZ2h0QmFj a2dyb3VuZFZhbHVlKHBhcmFtZXRlcnMudmFsdWVzW2ldLmxvd2VyKCkpKTsKICAgICAgICAgICAg ICAgICBicmVhazsKICAgICAgICAgICAgIH0KICAgICAgICAgfQo=