93529 2012-08-08 14:48:13 -0700 [WK2] MiniBrowser crashes on quit if any windows were previously closed 2012-08-08 16:48:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 690766 0 ap 2012-08-08 14:48:13 -0700 Steps to reproduce: start MiniBrowser, close its window, quit it. 690895 1 157327 ap 2012-08-08 16:29:11 -0700 Created attachment 157327 proposed fix 690921 2 ap 2012-08-08 16:48:11 -0700 Committed <http://trac.webkit.org/changeset/125113>. 157327 2012-08-08 16:29:11 -0700 2012-08-08 16:36:57 -0700 proposed fix CloseWindow.txt text/plain 6443 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyNTEwNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDMxIEBACisyMDEyLTA4LTA4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFtXSzJdIE1pbmlCcm93c2VyIGNyYXNoZXMgb24gcXVpdCBpZiBhbnkgd2lu ZG93cyB3ZXJlIHByZXZpb3VzbHkgY2xvc2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05MzUyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvbWFjL0FwcERlbGVnYXRlLmg6CisgICAg ICAgICogTWluaUJyb3dzZXIvbWFjL0FwcERlbGVnYXRlLm06CisgICAgICAgICgtW0Jyb3dzZXJB cHBEZWxlZ2F0ZSBpbml0XSk6CisgICAgICAgICgtW0Jyb3dzZXJBcHBEZWxlZ2F0ZSBuZXdXaW5k b3c6XSk6CisgICAgICAgICgtW0Jyb3dzZXJBcHBEZWxlZ2F0ZSBicm93c2VyV2luZG93V2lsbENs b3NlOl0pOgorICAgICAgICAoLVtCcm93c2VyQXBwRGVsZWdhdGUgYXBwbGljYXRpb25XaWxsVGVy bWluYXRlOl0pOgorICAgICAgICAoLVtCcm93c2VyQXBwRGVsZWdhdGUgZnJvbnRtb3N0QnJvd3Nl cldpbmRvd0NvbnRyb2xsZXJdKToKKyAgICAgICAgVHJhY2sgYnJvd3NlciB3aW5kb3dzIGV4cGxp Y2l0bHksIG5vdCByZWx5aW5nIG9uIFtOU0FwcCB3aW5kb3dzXS4gQ2xvc2VkIHdpbmRvd3MKKyAg ICAgICAgYXJlIG5vdCBhdXRvbWF0aWNhbGx5IHJlbW92ZWQgZnJvbSB0aGUgbGlzdCB1bnRpbCBk ZWFsbG9jYXRlZCwgc28gYSByZWZjb3VudGluZworICAgICAgICBlcnJvciBjYW4gcmVzdWx0IGlu IHdvcmtpbmcgb24gYSBjbG9zZWQgd2luZG93LgorCisgICAgICAgICogTWluaUJyb3dzZXIvbWFj L0Jyb3dzZXJXaW5kb3dDb250cm9sbGVyLm06CisgICAgICAgICgtW0Jyb3dzZXJXaW5kb3dDb250 cm9sbGVyIGRlYWxsb2NdKTogTW92ZWQgY29kZSBmcm9tIC13aW5kb3dXaWxsQ2xvc2U6IGhlcmUu CisgICAgICAgIFJlbGVhc2luZyBkYXRhIG1lbWJlcnMgaXMgLWRlYWxsb2MncyBqb2IuCisgICAg ICAgICgtW0Jyb3dzZXJXaW5kb3dDb250cm9sbGVyIHdpbmRvd1dpbGxDbG9zZTpdKTogTm90aWZ5 IEJyb3dzZXJBcHBEZWxlZ2F0ZSB0aGF0CisgICAgICAgIHRoZSB3aW5kb3cgaXMgbm8gbG9uZ2Vy IG9wZW4uIEF1dG9yZWxlYXNlIHNlbGYsIG1ha2luZyBzdXJlIHRoYXQgV0tWaWV3IGFuZAorICAg ICAgICB0aGVuIFdlYlBhZ2VQcm94eSBnZXQgcmVsZWFzZWQuCisgICAgICAgICgtW0Jyb3dzZXJX aW5kb3dDb250cm9sbGVyIGFwcGxpY2F0aW9uVGVybWluYXRpbmddKTogRG9uJ3QgcmVsZWFzZSBf d2ViVmlldy5wYWdlUmVmLgorICAgICAgICBXS1ZpZXcgaXMgcmVzcG9uc2libGUgZm9yIGl0cyBs aWZldGltZS4KKyAgICAgICAgKGNsb3NlUGFnZSk6IERpdHRvLgorCiAyMDEyLTA4LTA4ICBYaWFu emh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVt LUFuZHJvaWRdIEFwcGx5IGFsbCBMaW51eCBsYXlvdXQgdGVzdCBleHBlY3RhdGlvbnMKSW5kZXg6 IFRvb2xzL01pbmlCcm93c2VyL21hYy9BcHBEZWxlZ2F0ZS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L01pbmlCcm93c2VyL21hYy9BcHBEZWxlZ2F0ZS5oCShyZXZpc2lvbiAxMjUwNzYpCisrKyBUb29s cy9NaW5pQnJvd3Nlci9tYWMvQXBwRGVsZWdhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtMzQsMTAg KzM0LDEzIEBAIEBpbnRlcmZhY2UgQnJvd3NlckFwcERlbGVnYXRlIDogTlNPYmplY3QKICAgICBX S0NvbnRleHRSZWYgX3RocmVhZENvbnRleHQ7CiAgICAgV0tDb250ZXh0UmVmIF9wcm9jZXNzQ29u dGV4dDsKICAgICBXS1BhZ2VHcm91cFJlZiBfcGFnZUdyb3VwOworICAgIE5TTXV0YWJsZVNldCAq X2Jyb3dzZXJXaW5kb3dzOwogfQogCiAtIChXS0NvbnRleHRSZWYpZ2V0Q3VycmVudENvbnRleHQ7 CiAKKy0gKHZvaWQpYnJvd3NlcldpbmRvd1dpbGxDbG9zZTooTlNXaW5kb3cgKil3aW5kb3c7CisK IC0gKElCQWN0aW9uKXNldFNoYXJlZFByb2Nlc3NQcm9jZXNzTW9kZWw6KGlkKXNlbmRlcjsKIC0g KElCQWN0aW9uKXNldFNoYXJlZFRocmVhZFByb2Nlc3NNb2RlbDooaWQpc2VuZGVyOwogLSAoSUJB Y3Rpb24pc2hvd1N0YXRpc3RpY3NXaW5kb3c6KGlkKXNlbmRlcjsKSW5kZXg6IFRvb2xzL01pbmlC cm93c2VyL21hYy9BcHBEZWxlZ2F0ZS5tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL01pbmlCcm93c2Vy L21hYy9BcHBEZWxlZ2F0ZS5tCShyZXZpc2lvbiAxMjUwNzYpCisrKyBUb29scy9NaW5pQnJvd3Nl ci9tYWMvQXBwRGVsZWdhdGUubQkod29ya2luZyBjb3B5KQpAQCAtMTUzLDYgKzE1Myw4IEBAIC0g KGlkKWluaXQKICAgICAgICAgV0tTdHJpbmdSZWYgcGFnZUdyb3VwSWRlbnRpZmllciA9IFdLU3Ry aW5nQ3JlYXRlV2l0aENGU3RyaW5nKENGU1RSKCJNaW5pQnJvd3NlciIpKTsKICAgICAgICAgX3Bh Z2VHcm91cCA9IFdLUGFnZUdyb3VwQ3JlYXRlV2l0aElkZW50aWZpZXIocGFnZUdyb3VwSWRlbnRp Zmllcik7CiAgICAgICAgIFdLUmVsZWFzZShwYWdlR3JvdXBJZGVudGlmaWVyKTsKKworICAgICAg ICBfYnJvd3NlcldpbmRvd3MgPSBbW05TTXV0YWJsZVNldCBhbGxvY10gaW5pdF07CiAgICAgfQog CiAgICAgcmV0dXJuIHNlbGY7CkBAIC0xNjIsMTAgKzE2NCwxNiBAQCAtIChJQkFjdGlvbiluZXdX aW5kb3c6KGlkKXNlbmRlcgogewogICAgIEJyb3dzZXJXaW5kb3dDb250cm9sbGVyICpjb250cm9s bGVyID0gW1tCcm93c2VyV2luZG93Q29udHJvbGxlciBhbGxvY10gaW5pdFdpdGhDb250ZXh0Oltz ZWxmIGdldEN1cnJlbnRDb250ZXh0XSBwYWdlR3JvdXA6X3BhZ2VHcm91cF07CiAgICAgW1tjb250 cm9sbGVyIHdpbmRvd10gbWFrZUtleUFuZE9yZGVyRnJvbnQ6c2VuZGVyXTsKKyAgICBbX2Jyb3dz ZXJXaW5kb3dzIGFkZE9iamVjdDpbY29udHJvbGxlciB3aW5kb3ddXTsKICAgICAKICAgICBbY29u dHJvbGxlciBsb2FkVVJMU3RyaW5nOmRlZmF1bHRVUkxdOwogfQogCistICh2b2lkKWJyb3dzZXJX aW5kb3dXaWxsQ2xvc2U6KE5TV2luZG93ICopd2luZG93Cit7CisgICAgW19icm93c2VyV2luZG93 cyByZW1vdmVPYmplY3Q6d2luZG93XTsKK30KKwogLSAoV0tDb250ZXh0UmVmKWdldEN1cnJlbnRD b250ZXh0CiB7CiAgICAgcmV0dXJuIChfY3VycmVudFByb2Nlc3NNb2RlbCA9PSBrUHJvY2Vzc01v ZGVsU2hhcmVkU2Vjb25kYXJ5VGhyZWFkKSA/IF90aHJlYWRDb250ZXh0IDogX3Byb2Nlc3NDb250 ZXh0OwpAQCAtMjE1LDEzICsyMjMsMTEgQEAgLSAodm9pZClhcHBsaWNhdGlvbkRpZEZpbmlzaExh dW5jaGluZzooTgogCiAtICh2b2lkKWFwcGxpY2F0aW9uV2lsbFRlcm1pbmF0ZTooTlNOb3RpZmlj YXRpb24gKilub3RpZmljYXRpb24KIHsKLSAgICBOU0FycmF5KiB3aW5kb3dzID0gW05TQXBwIHdp bmRvd3NdOwotICAgIGZvciAoTlNXaW5kb3cqIHdpbmRvdyBpbiB3aW5kb3dzKSB7CisgICAgZm9y IChOU1dpbmRvdyogd2luZG93IGluIF9icm93c2VyV2luZG93cykgewogICAgICAgICBpZCBkZWxl Z2F0ZSA9IFt3aW5kb3cgZGVsZWdhdGVdOwotICAgICAgICBpZiAoW2RlbGVnYXRlIGlzS2luZE9m Q2xhc3M6W0Jyb3dzZXJXaW5kb3dDb250cm9sbGVyIGNsYXNzXV0pIHsKLSAgICAgICAgICAgIEJy b3dzZXJXaW5kb3dDb250cm9sbGVyICpjb250cm9sbGVyID0gKEJyb3dzZXJXaW5kb3dDb250cm9s bGVyICopZGVsZWdhdGU7Ci0gICAgICAgICAgICBbY29udHJvbGxlciBhcHBsaWNhdGlvblRlcm1p bmF0aW5nXTsKLSAgICAgICAgfQorICAgICAgICBhc3NlcnQoW2RlbGVnYXRlIGlzS2luZE9mQ2xh c3M6W0Jyb3dzZXJXaW5kb3dDb250cm9sbGVyIGNsYXNzXV0pOworICAgICAgICBCcm93c2VyV2lu ZG93Q29udHJvbGxlciAqY29udHJvbGxlciA9IChCcm93c2VyV2luZG93Q29udHJvbGxlciAqKWRl bGVnYXRlOworICAgICAgICBbY29udHJvbGxlciBhcHBsaWNhdGlvblRlcm1pbmF0aW5nXTsKICAg ICB9CiAKICAgICBXS1JlbGVhc2UoX3Byb2Nlc3NDb250ZXh0KTsKQEAgLTIzMyw4ICsyMzksMTAg QEAgLSAoQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIgKilmcm9udG1vc3RCcgogICAgIE5TQXJyYXkq IHdpbmRvd3MgPSBbTlNBcHAgd2luZG93c107CiAgICAgZm9yIChOU1dpbmRvdyogd2luZG93IGlu IHdpbmRvd3MpIHsKICAgICAgICAgaWQgZGVsZWdhdGUgPSBbd2luZG93IGRlbGVnYXRlXTsKLSAg ICAgICAgaWYgKFtkZWxlZ2F0ZSBpc0tpbmRPZkNsYXNzOltCcm93c2VyV2luZG93Q29udHJvbGxl ciBjbGFzc11dKQotICAgICAgICAgICAgcmV0dXJuIChCcm93c2VyV2luZG93Q29udHJvbGxlciAq KWRlbGVnYXRlOworICAgICAgICBhc3NlcnQoW2RlbGVnYXRlIGlzS2luZE9mQ2xhc3M6W0Jyb3dz ZXJXaW5kb3dDb250cm9sbGVyIGNsYXNzXV0pOworICAgICAgICBCcm93c2VyV2luZG93Q29udHJv bGxlciAqY29udHJvbGxlciA9IChCcm93c2VyV2luZG93Q29udHJvbGxlciAqKWRlbGVnYXRlOwor ICAgICAgICBhc3NlcnQoW19icm93c2VyV2luZG93cyBjb250YWluc09iamVjdDpbY29udHJvbGxl ciB3aW5kb3ddXSk7CisgICAgICAgIHJldHVybiBjb250cm9sbGVyOwogICAgIH0KIAogICAgIHJl dHVybiAwOwpJbmRleDogVG9vbHMvTWluaUJyb3dzZXIvbWFjL0Jyb3dzZXJXaW5kb3dDb250cm9s bGVyLm0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvTWluaUJyb3dzZXIvbWFjL0Jyb3dzZXJXaW5kb3dD b250cm9sbGVyLm0JKHJldmlzaW9uIDEyNTA3NikKKysrIFRvb2xzL01pbmlCcm93c2VyL21hYy9C cm93c2VyV2luZG93Q29udHJvbGxlci5tCSh3b3JraW5nIGNvcHkpCkBAIC0yNSw2ICsyNSw3IEBA CiAKICNpbXBvcnQgIkJyb3dzZXJXaW5kb3dDb250cm9sbGVyLmgiCiAKKyNpbXBvcnQgIkFwcERl bGVnYXRlLmgiCiAjaW1wb3J0IDxXZWJLaXQyL1dLUGFnZVByaXZhdGUuaD4KICNpbXBvcnQgPFdl YktpdDIvV0tTdHJpbmdDRi5oPgogI2ltcG9ydCA8V2ViS2l0Mi9XS1VSTENGLmg+CkBAIC01OCw3 ICs1OSwxMCBAQCAtIChpZClpbml0V2l0aENvbnRleHQ6KFdLQ29udGV4dFJlZiljb250CiAKIC0g KHZvaWQpZGVhbGxvYwogewotICAgIGFzc2VydCghX2NvbnRleHQpOworICAgIFdLUmVsZWFzZShf Y29udGV4dCk7CisgICAgV0tSZWxlYXNlKF9wYWdlR3JvdXApOworICAgIFtfd2ViVmlldyByZWxl YXNlXTsKKwogICAgIFtzdXBlciBkZWFsbG9jXTsKIH0KIApAQCAtMTYzLDE2ICsxNjcsMTQgQEAg LSAoQk9PTCl3aW5kb3dTaG91bGRDbG9zZTooaWQpc2VuZGVyCiAKIC0gKHZvaWQpd2luZG93V2ls bENsb3NlOihOU05vdGlmaWNhdGlvbiAqKW5vdGlmaWNhdGlvbgogewotICAgIFdLUmVsZWFzZShf Y29udGV4dCk7Ci0gICAgX2NvbnRleHQgPSAwOwotICAgIFdLUmVsZWFzZShfcGFnZUdyb3VwKTsK LSAgICBfcGFnZUdyb3VwID0gMDsKKyAgICBbKEJyb3dzZXJBcHBEZWxlZ2F0ZSAqKVtOU0FwcCBk ZWxlZ2F0ZV0gYnJvd3NlcldpbmRvd1dpbGxDbG9zZTpbc2VsZiB3aW5kb3ddXTsKKyAgICBbc2Vs ZiBhdXRvcmVsZWFzZV07CiB9CiAKIC0gKHZvaWQpYXBwbGljYXRpb25UZXJtaW5hdGluZwogewor ICAgIC8vIEZJWE1FOiBXaHkgYXJlIHdlIGJvdGhlcmluZyB0byBjbG9zZSB0aGUgcGFnZT8gVGhp cyBkb2Vzbid0IGV2ZW4gcHJldmVudCBMRUFLIG91dHB1dC4KICAgICBXS1BhZ2VDbG9zZShfd2Vi Vmlldy5wYWdlUmVmKTsKLSAgICBXS1JlbGVhc2UoX3dlYlZpZXcucGFnZVJlZik7CiB9CiAKICNk ZWZpbmUgRGVmYXVsdE1pbmltdW1ab29tRmFjdG9yICguNSkKQEAgLTQyNiw3ICs0MjgsNiBAQCBz dGF0aWMgdm9pZCBjbG9zZVBhZ2UoV0tQYWdlUmVmIHBhZ2UsIGNvCiAgICAgTE9HKEAiY2xvc2VQ YWdlIik7CiAgICAgV0tQYWdlQ2xvc2UocGFnZSk7CiAgICAgW1soQnJvd3NlcldpbmRvd0NvbnRy b2xsZXIgKiljbGllbnRJbmZvIHdpbmRvd10gY2xvc2VdOwotICAgIFdLUmVsZWFzZShwYWdlKTsK IH0KIAogc3RhdGljIHZvaWQgcnVuSmF2YVNjcmlwdEFsZXJ0KFdLUGFnZVJlZiBwYWdlLCBXS1N0 cmluZ1JlZiBtZXNzYWdlLCBXS0ZyYW1lUmVmIGZyYW1lLCBjb25zdCB2b2lkKiBjbGllbnRJbmZv KQo=