93526 2012-08-08 14:29:06 -0700 Avoid backing store on layers created for CoreAnimation plugins 2012-08-08 17:38:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser andersca bdakin dino eric simon.fraser thorton webkit-bug-importer webkit.review.bot oldest_to_newest 690742 0 simon.fraser 2012-08-08 14:29:06 -0700 Avoid backing store on layers created for CoreAnimation plugins 690747 1 157299 simon.fraser 2012-08-08 14:31:36 -0700 Created attachment 157299 Patch 690749 2 simon.fraser 2012-08-08 14:32:26 -0700 <rdar://problem/12052828> 690792 3 157299 dino 2012-08-08 15:02:03 -0700 Comment on attachment 157299 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157299&action=review > Source/WebCore/ChangeLog:8 > + We create a compositing layer for <emebed> objects whose plug-in supports typo emembedebed 690810 4 simon.fraser 2012-08-08 15:17:57 -0700 http://trac.webkit.org/changeset/125101 690823 5 scherkus 2012-08-08 15:28:37 -0700 Committed r125102: <http://trac.webkit.org/changeset/125102> 690995 6 157299 darin 2012-08-08 17:25:36 -0700 Comment on attachment 157299 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157299&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:913 > + if (renderObject->isReplaced() && !isCompositedPlugin(renderObject)) > + return false; Wrong indentation on this return statement. 157299 2012-08-08 14:31:36 -0700 2012-08-08 17:25:36 -0700 Patch bug-93526-20120808143111.patch text/plain 5898 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0Nzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWRjZDZlMWFiZWI1MzA4 OWVlOWU3MDYxYWYxMzU0NjRlZWZmZGVlYi4uYTg3YzFmY2RkODNkZGFjM2IwZGJhYzEyNmNlMTcx YmM2NGZhM2MwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTA4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIGJhY2tp bmcgc3RvcmUgb24gbGF5ZXJzIGNyZWF0ZWQgZm9yIENvcmVBbmltYXRpb24gcGx1Z2lucworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM1MjYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBjcmVhdGUgYSBj b21wb3NpdGluZyBsYXllciBmb3IgPGVtZWJlZD4gb2JqZWN0cyB3aG9zZSBwbHVnLWluIHN1cHBv cnRzCisgICAgICAgIHRoZSBDb3JlQW5pbWF0aW9uIHJlbmRlcmluZyBtb2RlbC4gV2hlbiB0aGUg ZW1iZWQncyByZW5kZXJlciBpcyBub3Qgc3R5bGVkLAorICAgICAgICB3ZSBjYW4gYXZvaWQgYWxs b2NhdGluZyBiYWNraW5nIHN0b3JlIGZvciBpdC4KKworICAgICAgICBUZXN0OiBjb21wb3NpdGlu Zy9wbHVnaW5zL25vLWJhY2tpbmctc3RvcmUuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjppc0NvbXBvc2l0ZWRQbHVn aW4pOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjppc1NpbXBsZUNvbnRh aW5lckNvbXBvc2l0aW5nTGF5ZXIpOgorCiAyMDEyLTA4LTA2ICBBbmRyZWFzIEtsaW5nICA8a2xp bmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBTaW1wbGlmeSBDU1NPTSBzdHlsZSBkZWNsYXJhdGlv bidzIGdyYWJiaW5nIGF0IGludGVybmFscy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQmFja2luZy5jcHAKaW5kZXggZTExMGE0ZDVkNTBhYTlmYWEwMTY4ZGI4MmI5 NDQ4YTU3MjAxMjVhOC4uMjVlMjc0NTI4ZDY1ZjExODI0MjNmYzUwOGJmODk2YTY2MGMyMzU4MiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAK QEAgLTg5NSwxNiArODk1LDIzIEBAIGJvb2wgUmVuZGVyTGF5ZXJCYWNraW5nOjpwYWludHNDaGls ZHJlbigpIGNvbnN0CiAgICAgcmV0dXJuIGZhbHNlOwogfQogCitzdGF0aWMgYm9vbCBpc0NvbXBv c2l0ZWRQbHVnaW4oUmVuZGVyT2JqZWN0KiByZW5kZXJlcikKK3sKKyAgICByZXR1cm4gcmVuZGVy ZXItPmlzRW1iZWRkZWRPYmplY3QoKSAmJiB0b1JlbmRlckVtYmVkZGVkT2JqZWN0KHJlbmRlcmVy KS0+YWxsb3dzQWNjZWxlcmF0ZWRDb21wb3NpdGluZygpOworfQorCiAvLyBBICJzaW1wbGUgY29u dGFpbmVyIGxheWVyIiBpcyBhIFJlbmRlckxheWVyIHdoaWNoIGhhcyBubyB2aXNpYmxlIGNvbnRl bnQgdG8gcmVuZGVyLgogLy8gSXQgbWF5IGhhdmUgbm8gY2hpbGRyZW4sIG9yIGFsbCBpdHMgY2hp bGRyZW4gbWF5IGJlIHRoZW1zZWx2ZXMgY29tcG9zaXRlZC4KIC8vIFRoaXMgaXMgYSB1c2VmdWwg b3B0aW1pemF0aW9uLCBiZWNhdXNlIGl0IGFsbG93cyB1cyB0byBhdm9pZCBhbGxvY2F0aW5nIGJh Y2tpbmcgc3RvcmUuCiBib29sIFJlbmRlckxheWVyQmFja2luZzo6aXNTaW1wbGVDb250YWluZXJD b21wb3NpdGluZ0xheWVyKCkgY29uc3QKIHsKICAgICBSZW5kZXJPYmplY3QqIHJlbmRlck9iamVj dCA9IHJlbmRlcmVyKCk7Ci0gICAgaWYgKHJlbmRlck9iamVjdC0+aXNSZXBsYWNlZCgpIHx8ICAg ICAgIC8vIHJlcGxhY2VkIG9iamVjdHMgYXJlIG5vdCBjb250YWluZXJzCi0gICAgICAgIHJlbmRl ck9iamVjdC0+aGFzTWFzaygpKSAgICAgICAgICAgIC8vIG1hc2tzIHJlcXVpcmUgc3BlY2lhbCB0 cmVhdG1lbnQKKyAgICBpZiAocmVuZGVyT2JqZWN0LT5oYXNNYXNrKCkpIC8vIG1hc2tzIHJlcXVp cmUgc3BlY2lhbCB0cmVhdG1lbnQKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgaWYgKHJl bmRlck9iamVjdC0+aXNSZXBsYWNlZCgpICYmICFpc0NvbXBvc2l0ZWRQbHVnaW4ocmVuZGVyT2Jq ZWN0KSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAKICAgICBpZiAocGFpbnRzQm94 RGVjb3JhdGlvbnMoKSB8fCBwYWludHNDaGlsZHJlbigpKQogICAgICAgICByZXR1cm4gZmFsc2U7 CiAgICAgCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggZWEwMmRhNmM2NTIyMjhkODgzZTViNWJkNmY1ZjMyYzQ1OWVhMDgzZi4u OGI5ODEwYjlhYzI5ZmQyZDMzYTIzOThmNTkwNjRjZDg0MWMxNDBhYiAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDEyLTA4LTA4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29t PgorCisgICAgICAgIEF2b2lkIGJhY2tpbmcgc3RvcmUgb24gbGF5ZXJzIGNyZWF0ZWQgZm9yIENv cmVBbmltYXRpb24gcGx1Z2lucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTM1MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUZXN0IGZvciBiYWNraW5nIHN0b3JlIG9uIENvcmVBbmltYXRpb24tYmFzZWQg cGx1Z2lucyBpbiB2YXJpb3VzCisgICAgICAgIGNvbmZpZ3VyYXRpb25zLgorCisgICAgICAgICog Y29tcG9zaXRpbmcvcGx1Z2lucy9uby1iYWNraW5nLXN0b3JlLWV4cGVjdGVkLnR4dDogQWRkZWQu CisgICAgICAgICogY29tcG9zaXRpbmcvcGx1Z2lucy9uby1iYWNraW5nLXN0b3JlLmh0bWw6IEFk ZGVkLgorCiAyMDEyLTA4LTA2ICBBbmRyZWkgUG9lbmFydSAgPHBvZW5hcnVAYWRvYmUuY29tPgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFByb3RvY29sOiBBZGQgIm5hbWVkRmxvd0NyZWF0ZWQi IGFuZCAibmFtZWRGbG93UmVtb3ZlZCIgZXZlbnRzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9j b21wb3NpdGluZy9wbHVnaW5zL25vLWJhY2tpbmctc3RvcmUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvY29tcG9zaXRpbmcvcGx1Z2lucy9uby1iYWNraW5nLXN0b3JlLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi5lNzc3NmQ3ODg1MzgyMDc5MDY5YTYzY2I4NDAwYjllNjFhNTJjY2YyCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvcGx1Z2lucy9uby1iYWNraW5n LXN0b3JlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDI2IEBACisgICAgICAKKyhHcmFwaGljc0xh eWVyCisgIChib3VuZHMgODAwLjAwIDYwMC4wMCkKKyAgKGNoaWxkcmVuIDEKKyAgICAoR3JhcGhp Y3NMYXllcgorICAgICAgKGJvdW5kcyA4MDAuMDAgNjAwLjAwKQorICAgICAgKGNoaWxkcmVuIDMK KyAgICAgICAgKEdyYXBoaWNzTGF5ZXIKKyAgICAgICAgICAocG9zaXRpb24gMTQyLjAwIDIwLjAw KQorICAgICAgICAgIChib3VuZHMgMTAwLjAwIDEwMC4wMCkKKyAgICAgICAgKQorICAgICAgICAo R3JhcGhpY3NMYXllcgorICAgICAgICAgIChwb3NpdGlvbiAyNjYuMDAgMjAuMDApCisgICAgICAg ICAgKGJvdW5kcyAxMDAuMDAgMTAwLjAwKQorICAgICAgICAgIChkcmF3c0NvbnRlbnQgMSkKKyAg ICAgICAgKQorICAgICAgICAoR3JhcGhpY3NMYXllcgorICAgICAgICAgIChwb3NpdGlvbiAzOTAu MDAgMTguMDApCisgICAgICAgICAgKGJvdW5kcyAxMDIuMDAgMTAyLjAwKQorICAgICAgICAgIChk cmF3c0NvbnRlbnQgMSkKKyAgICAgICAgKQorICAgICAgKQorICAgICkKKyAgKQorKQorCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9wbHVnaW5zL25vLWJhY2tpbmctc3RvcmUu aHRtbCBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3BsdWdpbnMvbm8tYmFja2luZy1zdG9yZS5o dG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLmRhNGUwZGUwNWQ0NzU0MTkyNDM5OTE5Nzg4NjlhYjFhYTYxNjAxYmUK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9wbHVnaW5zL25vLWJh Y2tpbmctc3RvcmUuaHRtbApAQCAtMCwwICsxLDQyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1s PgorPGhlYWQ+CisgIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIgbWVkaWE9InNjcmVlbiI+CisgICAg ZW1iZWQgeworICAgICAgbWFyZ2luOiAxMHB4OworICAgIH0KKyAgPC9zdHlsZT4KKyAgPHNjcmlw dCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0Zi04Ij4KKyAgICBpZiAod2luZG93 LnRlc3RSdW5uZXIpIHsKKyAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgICAg IHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworICAgIH0KKworICAgIGZ1bmN0aW9uIGRvVGVz dCgpCisgICAgeworICAgICAgICAvLyBOZWVkIHRvIHdhaXQgZm9yIGNvbXBvc2l0aW5nIGxheWVy cyB0byBiZSB1cGRhdGVkLiBGSVhNRSByZW1vdmUuCisgICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0 KGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAg ICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2xheWVycycpLmlubmVySFRNTCA9 IHRlc3RSdW5uZXIubGF5ZXJUcmVlQXNUZXh0KCk7CisgICAgICAgICAgICAgICAgdGVzdFJ1bm5l ci5ub3RpZnlEb25lKCk7CisgICAgICAgICAgICB9CisgICAgICAgIH0sIDApCisgICAgfQorICAg IHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgZG9UZXN0LCBmYWxzZSk7CisgIDwvc2Ny aXB0PgorPC9oZWFkPgorPGJvZHk+CisgIAorICAgIDwhLS0gTm90IGxheWVyLWJhY2tlZCAtLT4K KyAgICA8ZW1iZWQgdHlwZT0iYXBwbGljYXRpb24veC13ZWJraXQtdGVzdC1uZXRzY2FwZSIgd2lk dGg9IjEwMCIgaGVpZ2h0PSIxMDAiPgorCisgICAgPCEtLSBMYXllci1iYWNrZWQsIG5vIG5lZWQg Zm9yIGJhY2tpbmcgc3RvcmUgLS0+CisgICAgPGVtYmVkIHR5cGU9ImFwcGxpY2F0aW9uL3gtd2Vi a2l0LXRlc3QtbmV0c2NhcGUiIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiBkcmF3aW5nbW9kZWw9 ImNvcmVhbmltYXRpb24iPgorCisgICAgPCEtLSBCb3RoIHRoZXNlIG5lZWQgYmFja2luZyBzdG9y ZSAtLT4KKyAgICA8ZW1iZWQgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6IGJsdWU7IiB0eXBlPSJh cHBsaWNhdGlvbi94LXdlYmtpdC10ZXN0LW5ldHNjYXBlIiB3aWR0aD0iMTAwIiBoZWlnaHQ9IjEw MCIgZHJhd2luZ21vZGVsPSJjb3JlYW5pbWF0aW9uIj4KKyAgICA8ZW1iZWQgc3R5bGU9ImJvcmRl cjogMXB4IHNvbGlkIGJsYWNrOyIgdHlwZT0iYXBwbGljYXRpb24veC13ZWJraXQtdGVzdC1uZXRz Y2FwZSIgd2lkdGg9IjEwMCIgaGVpZ2h0PSIxMDAiIGRyYXdpbmdtb2RlbD0iY29yZWFuaW1hdGlv biI+CisKKyAgICA8cHJlIGlkPSJsYXllcnMiPkxheWVyIHRyZWUgYXBwZWFycyBoZXJlIGluIERS VC48L3ByZT4KKzwvYm9keT4KKzwvaHRtbD4K