93517 2012-08-08 13:54:44 -0700 Horizontal scrollbar appears in the month-year selector of input[type=date] 2012-08-10 09:16:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kevers kevers keishi rjkroege tkent webkit.review.bot oldest_to_newest 690693 0 kevers 2012-08-08 13:54:44 -0700 Horizontal scrollbar appears in the month-year selector of input[type=date] 690709 1 157289 kevers 2012-08-08 14:11:19 -0700 Created attachment 157289 Patch 690719 2 kevers 2012-08-08 14:16:45 -0700 Horizontal scrollbar reported on Chrome with a Japanese UI on Windows 7. 691056 3 157289 tkent 2012-08-08 18:22:34 -0700 Comment on attachment 157289 Patch LGTM. FYI: WebCore/Resources/colorSuggestionPicker.js has a code to get the scrollbar width. We had better share some code with it. 691611 4 kevers 2012-08-09 11:07:42 -0700 Several other functions could be shared between colorSuggestionPicker.js and calendarPicker.js as well such as $() bind() and createElement(). OK with a separate patch to consolidate the common utility functions into a separate js file? 691977 5 tkent 2012-08-09 16:33:07 -0700 > OK with a separate patch to consolidate the common utility functions into a separate js file? Yes. It's not your responsibility. The patch in this bug is ok as is. 692590 6 157289 webkit.review.bot 2012-08-10 09:16:15 -0700 Comment on attachment 157289 Patch Clearing flags on attachment: 157289 Committed r125289: <http://trac.webkit.org/changeset/125289> 692591 7 webkit.review.bot 2012-08-10 09:16:19 -0700 All reviewed patches have been landed. Closing bug. 157289 2012-08-08 14:11:19 -0700 2012-08-10 09:16:15 -0700 Patch bug-93517-20120808171053.patch text/plain 3750 kevers U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGUyNTRkMzBjNzBmYTg1 ZWM0MmY2NTNhNGFkMzJlZWVkMTkyOTllZi4uMDU0NDFhMTdmYTE1NTczZmI4NjI5NGZhYmIzOTAx MDU2MTYxZjVjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTA4ICBLZXZp biBFbGxpcyAgPGtldmVyc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSG9yaXpvbnRhbCBzY3Jv bGxiYXIgYXBwZWFycyBpbiB0aGUgbW9udGgteWVhciBzZWxlY3RvciBvZiBpbnB1dFt0eXBlPWRh dGVdCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzUx NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0 ZSBzaXplIG9mIHRoZSBtb250aC15ZWFyIHNlbGVjdG9yIHBvcHVwIHRvIGFjY291bnQgZm9yIHRo ZQorICAgICAgICB3aWR0aCBvZiB0aGUgdmVydGljYWwgc2Nyb2xsYmFyIGJlaW5nIHBsYXRmb3Jt IGRlcGVuZGVudC4KKworICAgICAgICAqIFJlc291cmNlcy9jYWxlbmRhclBpY2tlci5jc3M6Cisg ICAgICAgICgubW9udGgtc2VsZWN0b3ItcG9wdXApOiBTdXBwcmVzcyBob3Jpem9udGFsIHNjcm9s bGluZy4KKyAgICAgICAgKiBSZXNvdXJjZXMvY2FsZW5kYXJQaWNrZXIuanM6CisgICAgICAgIChZ ZWFyTW9udGhDb250cm9sbGVyLnByb3RvdHlwZS5hdHRhY2hUbyk6IEFkZCBhIHNpemVyIGVsZW1l bnQgdG8gZmFjaWxpdGF0ZSBkZXRlcm1pbmluZyB0aGUgc2Nyb2xsYmFyIHdpZHRoLgorICAgICAg ICAoWWVhck1vbnRoQ29udHJvbGxlci5wcm90b3R5cGUuX3Nob3dQb3B1cCk6IFVzZSBjb21wdXRl ZCBzY3JvbGxiYXIgd2lkdGggZm9yIHBvcHVwIHJlc2l6aW5nLgorCiAyMDEyLTA4LTA4ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHN0b3JlIGxhc3QgZXZhbHVhdGlvbiByZXN1bHQgaW4gJF8KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL1Jlc291cmNlcy9jYWxlbmRhclBpY2tlci5jc3MgYi9Tb3VyY2UvV2ViQ29yZS9S ZXNvdXJjZXMvY2FsZW5kYXJQaWNrZXIuY3NzCmluZGV4IGUyMjBiMWM5MmE3NTAzNmU5NjlkNTUy ZGMzZGFlYjg3YzZkOTZmNjcuLjcyMWMxMWU5YmFhZjEzZTQzMjY4N2E0ZGI5ZTJiNjFkNmMyODY1 MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNlcy9jYWxlbmRhclBpY2tlci5j c3MKKysrIGIvU291cmNlL1dlYkNvcmUvUmVzb3VyY2VzL2NhbGVuZGFyUGlja2VyLmNzcwpAQCAt ODIsNyArODIsNyBAQCBib2R5IHsKIH0KIAogLm1vbnRoLXNlbGVjdG9yLXBvcHVwIHsKLSAgICAt d2Via2l0LWJveC1zaXppbmc6IGJvcmRlci1ib3g7CisgICAgLXdlYmtpdC1ib3gtc2l6aW5nOiBj b250ZW50LWJveDsKICAgICAtd2Via2l0LWJveC1zaGFkb3c6CiAgICAgICAgIDAgMCAwIDFweCBy Z2JhKDAsMCwwLDAuMSksCiAgICAgICAgIDAgNXB4IDFweCAxcHggcmdiYSgwLDAsMCwwLjEpLApA QCAtOTEsNiArOTEsNyBAQCBib2R5IHsKICAgICBiYWNrZ3JvdW5kOiAjZmZmOwogICAgIGRpc3Bs YXk6IG5vbmU7CiAgICAgbWF4LWhlaWdodDogMTAuOGVtOworICAgIG92ZXJmbG93LXg6IGhpZGRl bjsKICAgICBvdmVyZmxvdy15OiBhdXRvOwogICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKICAgICB3 aGl0ZS1zcGFjZTogbm93cmFwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUmVzb3VyY2Vz L2NhbGVuZGFyUGlja2VyLmpzIGIvU291cmNlL1dlYkNvcmUvUmVzb3VyY2VzL2NhbGVuZGFyUGlj a2VyLmpzCmluZGV4IDgzNDNiMDk3MTc1YzliZWQ2MTA3ZDEyMGNkOWQ4MWRmMWQ2ZTAyZjYuLjQy ZmUwNzIzNDIwNmYyY2I4Zjc4NTc2Njk5Zjc5NzJmNWQwMDBmMDEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL1Jlc291cmNlcy9jYWxlbmRhclBpY2tlci5qcworKysgYi9Tb3VyY2UvV2ViQ29y ZS9SZXNvdXJjZXMvY2FsZW5kYXJQaWNrZXIuanMKQEAgLTUxLDYgKzUxLDcgQEAgdmFyIENsYXNz TmFtZXMgPSB7CiAgICAgTW9udGhTZWxlY3RvclBvcHVwOiAibW9udGgtc2VsZWN0b3ItcG9wdXAi LAogICAgIE1vbnRoU2VsZWN0b3JQb3B1cENvbnRlbnRzOiAibW9udGgtc2VsZWN0b3ItcG9wdXAt Y29udGVudHMiLAogICAgIE1vbnRoU2VsZWN0b3JQb3B1cEVudHJ5OiAibW9udGgtc2VsZWN0b3It cG9wdXAtZW50cnkiLAorICAgIE1vbnRoU2VsZWN0b3JQb3B1cFNpemVyOiAibW9udGgtc2VsZWN0 b3ItcG9wdXAtc2l6ZXIiLAogICAgIE1vbnRoU2VsZWN0b3JXYWxsOiAibW9udGgtc2VsZWN0b3It d2FsbCIsCiAgICAgTm9Gb2N1c1Jpbmc6ICJuby1mb2N1cy1yaW5nIiwKICAgICBOb3RUaGlzTW9u dGg6ICJub3QtdGhpcy1tb250aCIsCkBAIC00NDMsNiArNDQ0LDkgQEAgWWVhck1vbnRoQ29udHJv bGxlci5wcm90b3R5cGUuYXR0YWNoVG8gPSBmdW5jdGlvbihtYWluKSB7CiAgICAgdGhpcy5fbW9u dGhQb3B1cC50YWJJbmRleCA9IDA7CiAgICAgdGhpcy5fbW9udGhQb3B1cENvbnRlbnRzID0gY3Jl YXRlRWxlbWVudCgiZGl2IiwgQ2xhc3NOYW1lcy5Nb250aFNlbGVjdG9yUG9wdXBDb250ZW50cyk7 CiAgICAgdGhpcy5fbW9udGhQb3B1cC5hcHBlbmRDaGlsZCh0aGlzLl9tb250aFBvcHVwQ29udGVu dHMpOworICAgIC8vIFNpemVyIHVzZWQgdG8gZGV0ZXJtaW5lIHRoZSB3aWR0aCBvZiB0aGUgdmll d3BvcnQgaW4gdGhlIHBvcHVwIG1lbnUuCisgICAgdmFyIHNpemVyID0gY3JlYXRlRWxlbWVudCgi ZGl2IiwgQ2xhc3NOYW1lcy5Nb250aFNlbGVjdG9yUG9wdXBTaXplcik7CisgICAgdGhpcy5fbW9u dGhQb3B1cC5hcHBlbmRDaGlsZChzaXplcik7CiAgICAgYm94LmFwcGVuZENoaWxkKHRoaXMuX21v bnRoUG9wdXApOwogICAgIHRoaXMuX21vbnRoID0gY3JlYXRlRWxlbWVudCgiZGl2IiwgQ2xhc3NO YW1lcy5Nb250aFNlbGVjdG9yKTsKICAgICB0aGlzLl9tb250aC5hZGRFdmVudExpc3RlbmVyKCJj bGljayIsIGJpbmQodGhpcy5fc2hvd1BvcHVwLCB0aGlzKSwgZmFsc2UpOwpAQCAtNTk4LDcgKzYw MiwxMCBAQCBZZWFyTW9udGhDb250cm9sbGVyLnByb3RvdHlwZS5fc2hvd1BvcHVwID0gZnVuY3Rp b24oKSB7CiAgICAgICAgICAgIGlmIChib3R0b20gPiBwb3B1cEhlaWdodCkKICAgICAgICAgICAg ICAgIHRoaXMuX21vbnRoUG9wdXAuc2Nyb2xsVG9wID0gYm90dG9tIC0gcG9wdXBIZWlnaHQ7CiAg ICAgICAgIH0KLSAgICAgICAgdGhpcy5fbW9udGhQb3B1cC5zdHlsZS53ZWJraXRQYWRkaW5nRW5k ID0gJzE1cHgnOworICAgICAgICB2YXIgc2l6ZXIgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCIu IiArIENsYXNzTmFtZXMuTW9udGhTZWxlY3RvclBvcHVwU2l6ZXIpOworICAgICAgICB2YXIgc2Ny b2xsV2lkdGggPSB0aGlzLl9tb250aFBvcHVwQ29udGVudHMuY2xpZW50V2lkdGggLSBzaXplci5j bGllbnRXaWR0aDsKKyAgICAgICAgaWYgKHNjcm9sbFdpZHRoID4gMCkKKyAgICAgICAgICAgIHRo aXMuX21vbnRoUG9wdXAuc3R5bGUud2Via2l0UGFkZGluZ0VuZCA9IHNjcm9sbFdpZHRoICsgJ3B4 JzsKICAgICB9CiAgICAgdGhpcy5fbW9udGhQb3B1cC5mb2N1cygpOwogfTsK