93515 2012-08-08 13:47:41 -0700 LayoutTest: css3/calc/transitions-dependent.html causes css3/calc/transitions.html to fail 2012-08-08 16:40:09 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC Windows 7 RESOLVED FIXED LayoutTestFailure P2 Normal --- 1 roger_fong roger_fong mikelawther thorton tony webkit.review.bot oldest_to_newest 690687 0 roger_fong 2012-08-08 13:47:41 -0700 The transitions-dependent.html test was causing the transitions.html test to fail. This was a result of a timeout callback set in the first test that was only being fired in the second test. The first test did not use waitUntilDone/notifyDone. The second test printed out an extra TypeError: 'undefined' error message because the callback was defined in the first test and was thus 'undefined' by the time it was called while the second test was running. In addition, the test contained the following line: window.addEventListener("load", function() { waitForAnimationStart(runTest(expectedValues)); }, false); which does not work as intended because the parameter to waitForAnimationStart should have been a function that calls runTest, not the call to the runTest function itself, which calls the method immediately. 690695 1 157285 roger_fong 2012-08-08 13:56:30 -0700 Created attachment 157285 patch 690697 2 roger_fong 2012-08-08 13:57:05 -0700 Hi Mike, I believe you originally wrote the test 690698 3 roger_fong 2012-08-08 13:57:20 -0700 Can I get you to review it? Thanks 690759 4 157285 mikelawther 2012-08-08 14:41:47 -0700 Comment on attachment 157285 patch View in context: https://bugs.webkit.org/attachment.cgi?id=157285&action=review Nice - thanks for this Roger! I'll watch http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Fcalc%2Ftrans after this lands and once it's verified green we can remove the expectations set in http://trac.webkit.org/changeset/121506 and resolve https://bugs.webkit.org/show_bug.cgi?id=90234 as well, as I thought there was a problem in the transition test framework. The patch looks good to me, but as I'm not a reviewer, we'll need a reviewer to r+ this. > LayoutTests/css3/calc/transitions-dependent.html:68 > + nit: extra blank line 690764 5 thorton 2012-08-08 14:45:22 -0700 Ok, with Mike's input I'll happily r+ if you undo the extra blank line :D 690822 6 157310 roger_fong 2012-08-08 15:28:21 -0700 Created attachment 157310 patch nit fix Good to go, Thanks 690827 7 157311 roger_fong 2012-08-08 15:32:22 -0700 Created attachment 157311 the actual fixed patch 690913 8 157311 webkit.review.bot 2012-08-08 16:40:06 -0700 Comment on attachment 157311 the actual fixed patch Clearing flags on attachment: 157311 Committed r125111: <http://trac.webkit.org/changeset/125111> 690914 9 webkit.review.bot 2012-08-08 16:40:09 -0700 All reviewed patches have been landed. Closing bug. 157285 2012-08-08 13:56:30 -0700 2012-08-08 15:28:21 -0700 patch 93515_patch.txt text/plain 3709 roger_fong SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNTA4MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA4LTA4ICBSb2dlciBGb25nICA8cm9n ZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgY3NzMy9jYWxjL3RyYW5zaXRpb25zLWRlcGVu ZGVudC5odG1sIHdhcyBjYXVzaW5nIGNzczMvY2FsYy90cmFuc2l0aW9ucy5odG1sIHRvIGZhaWwK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNTE1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHRyYW5z aXRpb25zLWRlcGVuZGVudC5odG1sIHRlc3Qgd2FzIGNhdXNpbmcgdGhlIHRyYW5zaXRpb25zLmh0 bWwgdGVzdCB0byBmYWlsLgorICAgICAgICBUaGlzIHdhcyBhIHJlc3VsdCBvZiBhIHRpbWVvdXQg Y2FsbGJhY2sgc2V0IGluIHRoZSBmaXJzdCB0ZXN0IHRoYXQgd2FzIG9ubHkgYmVpbmcgZmlyZWQK KyAgICAgICAgaW4gdGhlIHNlY29uZCB0ZXN0IGJlY2F1c2UgdGhlIGZpcnN0IHRlc3QgZGlkIG5v dCB1c2Ugd2FpdFVudGlsRG9uZS9ub3RpZnlEb25lLiAKKyAgICAgICAgVGhlIHNlY29uZCB0ZXN0 IHByaW50ZWQgb3V0IGFuIGV4dHJhIFR5cGVFcnJvcjogJ3VuZGVmaW5lZCcgZXJyb3IgbWVzc2Fn ZSBiZWNhdXNlIHRoZSBjYWxsYmFjayAKKyAgICAgICAgd2FzIGRlZmluZWQgaW4gdGhlIGZpcnN0 IHRlc3QgYW5kIHdhcyB0aHVzICd1bmRlZmluZWQnIGJ5IHRoZSB0aW1lIGl0IHdhcyBjYWxsZWQg d2hpbGUgdGhlIHNlY29uZCB0ZXN0CisgICAgICAgIHdhcyBydW5uaW5nLgorICAgICAgICAKKyAg ICAgICAgSW4gYWRkaXRpb24sIHRoZSB0ZXN0IGNvbnRhaW5lZCB0aGUgZm9sbG93aW5nIGxpbmU6 CisgICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgZnVuY3Rpb24oKSB7IHdh aXRGb3JBbmltYXRpb25TdGFydChydW5UZXN0KGV4cGVjdGVkVmFsdWVzKSk7IH0sIGZhbHNlKTsK KyAgICAgICAgd2hpY2ggZG9lcyBub3Qgd29yayBhcyBpbnRlbmRlZCBiZWNhdXNlIHRoZSBwYXJh bWV0ZXIgdG8gd2FpdEZvckFuaW1hdGlvblN0YXJ0IHNob3VsZCBoYXZlIGJlZW4gYSBmdW5jdGlv bgorICAgICAgICB0aGF0IGNhbGxzIHJ1blRlc3QsIG5vdCB0aGUgY2FsbCB0byB0aGUgcnVuVGVz dCBmdW5jdGlvbiBpdHNlbGYsIHdoaWNoIGNhbGxzIHRoZSBtZXRob2QgaW1tZWRpYXRlbHkuCisK KyAgICAgICAgKiBjc3MzL2NhbGMvdHJhbnNpdGlvbnMtZGVwZW5kZW50Lmh0bWw6CisgICAgICAg IEFkZGVkIHdhaXRVbnRpbERvbmUvbm90aWZ5RG9uZS4KKyAgICAgICAgRml4ZWQgZnVuY3Rpb24g cGFyYW1ldGVyLgorICAgICAgICAKIDIwMTItMDgtMDggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1h bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTI1MDQ2KTogQnJlYWtzIGRl YnVnIGJ1aWxkIChhc3NlcnRpb24gaW4gcHJvdG9jb2wgdHlwZSBjaGVja3MpIChSZXF1ZXN0ZWQg YnkgcGZlbGRtYW4gb24gI3dlYmtpdCkuCkluZGV4OiBMYXlvdXRUZXN0cy9jc3MzL2NhbGMvdHJh bnNpdGlvbnMtZGVwZW5kZW50Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvY3NzMy9j YWxjL3RyYW5zaXRpb25zLWRlcGVuZGVudC5odG1sCShyZXZpc2lvbiAxMjQ5MDEpCisrKyBMYXlv dXRUZXN0cy9jc3MzL2NhbGMvdHJhbnNpdGlvbnMtZGVwZW5kZW50Lmh0bWwJKHdvcmtpbmcgY29w eSkKQEAgLTY1LDYgKzY1LDcgQEAgZXhwZWN0ZWRWYWx1ZXMgPSBbCiAgICAgWzEuMDAsICJpbm5l clRyYW5zaXRpb24iLCAnd2lkdGgnLCA0OTAsICJvdXRlciJdLAogXTsKIAorCiBmdW5jdGlvbiBy dW5UZXN0KGV4cGVjdGVkKSAKIHsKICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGV4cGVjdGVkLmxl bmd0aDsgKytpKSB7CkBAIC03MywyMCArNzQsMjQgQEAgZnVuY3Rpb24gcnVuVGVzdChleHBlY3Rl ZCkKICAgICAgICAgdmFyIHByb3BlcnR5ID0gZXhwZWN0ZWRbaV1bMl07CiAgICAgICAgIHZhciBl eHBlY3RlZFZhbHVlID0gZXhwZWN0ZWRbaV1bM107CiAgICAgICAgIHZhciBkZXBlbmRzT24gPSBl eHBlY3RlZFtpXVs0XTsKLSAgICAgICAgCiAgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikg ewogICAgICAgICAgICAgd2luZG93LnRlc3RSdW5uZXIucGF1c2VUcmFuc2l0aW9uQXRUaW1lT25F bGVtZW50V2l0aElkKHByb3BlcnR5LCB0aW1lLCBkZXBlbmRzT24pOwogICAgICAgICAgICAgd2lu ZG93LnRlc3RSdW5uZXIucGF1c2VUcmFuc2l0aW9uQXRUaW1lT25FbGVtZW50V2l0aElkKHByb3Bl cnR5LCB0aW1lLCBlbGVtZW50SWQpOwogICAgICAgICAgICAgdmFyIGFjdHVhbCA9IHdpbmRvdy5n ZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKGVsZW1lbnRJZCkpLmdldFBy b3BlcnR5Q1NTVmFsdWUocHJvcGVydHkpLmdldEZsb2F0VmFsdWUoQ1NTUHJpbWl0aXZlVmFsdWUu Q1NTX05VTUJFUik7CiAgICAgICAgICAgICB2YXIgcmVzdWx0ID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoInJlc3VsdCIpOwotCiAgICAgICAgICAgICBpZiAoYWN0dWFsID09IGV4cGVjdGVkVmFs dWUpCiAgICAgICAgICAgICAgICAgcmVzdWx0LmlubmVySFRNTCArPSAnUEFTUyAtICInICsgcHJv cGVydHkgKyAnIiBwcm9wZXJ0eSBmb3IgIicgKyBlbGVtZW50SWQgKyciIGVsZW1lbnQgYXQgJyAr IHRpbWUgKyAncyB3YXM6ICcgKyBhY3R1YWwgKyAnPGJyLz4nOwogICAgICAgICAgICAgZWxzZQog ICAgICAgICAgICAgICAgIHJlc3VsdC5pbm5lckhUTUwgKz0gJ0ZBSUwgLSAiJyArIHByb3BlcnR5 ICsgJyIgcHJvcGVydHkgZm9yICInICsgZWxlbWVudElkICsnIiBlbGVtZW50IGF0ICcgKyB0aW1l ICsgJ3MgZXhwZWN0ZWQ6ICcgKyBleHBlY3RlZFZhbHVlICsgJyBidXQgc2F3OiAnICsgYWN0dWFs ICsgJzxici8+JzsKICAgICAgICAgfQotICAgICAgICAgICAgCiAgICAgfQorICAgIGlmICh3aW5k b3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Cit9CisKK2Z1 bmN0aW9uIGxvYWRMaXN0ZW5lcigpCit7CisgICAgd2FpdEZvckFuaW1hdGlvblN0YXJ0KGZ1bmN0 aW9uKCl7cnVuVGVzdChleHBlY3RlZFZhbHVlcyk7fSk7CiB9CiAKIGZvciAodmFyIGkgPSAwOyBp IDwgdHJhbnNpdGlvbmluZ0VsZW1lbnRzLmxlbmd0aDsgaSsrKSB7CkBAIC05NCw2ICs5OSw3IEBA IGZvciAodmFyIGkgPSAwOyBpIDwgdHJhbnNpdGlvbmluZ0VsZW1lbnQKICAgICBlbGVtZW50LmNs YXNzTmFtZSArPSAiIGdvIjsKIH0KIAotd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoImxvYWQiLCBm dW5jdGlvbigpIHsgd2FpdEZvckFuaW1hdGlvblN0YXJ0KHJ1blRlc3QoZXhwZWN0ZWRWYWx1ZXMp KTsgfSwgZmFsc2UpOword2luZG93LmFkZEV2ZW50TGlzdGVuZXIoImxvYWQiLCBsb2FkTGlzdGVu ZXIsIGZhbHNlKTsKK3dpbmRvdy50ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKIAogPC9zY3Jp cHQ+Cg== 157310 2012-08-08 15:28:21 -0700 2012-08-08 15:32:22 -0700 patch nit fix 93515_patch.txt text/plain 3701 roger_fong SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNTA4MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA4LTA4ICBSb2dlciBGb25nICA8cm9n ZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgY3NzMy9jYWxjL3RyYW5zaXRpb25zLWRlcGVu ZGVudC5odG1sIHdhcyBjYXVzaW5nIGNzczMvY2FsYy90cmFuc2l0aW9ucy5odG1sIHRvIGZhaWwK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNTE1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHRyYW5z aXRpb25zLWRlcGVuZGVudC5odG1sIHRlc3Qgd2FzIGNhdXNpbmcgdGhlIHRyYW5zaXRpb25zLmh0 bWwgdGVzdCB0byBmYWlsLgorICAgICAgICBUaGlzIHdhcyBhIHJlc3VsdCBvZiBhIHRpbWVvdXQg Y2FsbGJhY2sgc2V0IGluIHRoZSBmaXJzdCB0ZXN0IHRoYXQgd2FzIG9ubHkgYmVpbmcgZmlyZWQK KyAgICAgICAgaW4gdGhlIHNlY29uZCB0ZXN0IGJlY2F1c2UgdGhlIGZpcnN0IHRlc3QgZGlkIG5v dCB1c2Ugd2FpdFVudGlsRG9uZS9ub3RpZnlEb25lLiAKKyAgICAgICAgVGhlIHNlY29uZCB0ZXN0 IHByaW50ZWQgb3V0IGFuIGV4dHJhIFR5cGVFcnJvcjogJ3VuZGVmaW5lZCcgZXJyb3IgbWVzc2Fn ZSBiZWNhdXNlIHRoZSBjYWxsYmFjayAKKyAgICAgICAgd2FzIGRlZmluZWQgaW4gdGhlIGZpcnN0 IHRlc3QgYW5kIHdhcyB0aHVzICd1bmRlZmluZWQnIGJ5IHRoZSB0aW1lIGl0IHdhcyBjYWxsZWQg d2hpbGUgdGhlIHNlY29uZCB0ZXN0CisgICAgICAgIHdhcyBydW5uaW5nLgorICAgICAgICAKKyAg ICAgICAgSW4gYWRkaXRpb24sIHRoZSB0ZXN0IGNvbnRhaW5lZCB0aGUgZm9sbG93aW5nIGxpbmU6 CisgICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgZnVuY3Rpb24oKSB7IHdh aXRGb3JBbmltYXRpb25TdGFydChydW5UZXN0KGV4cGVjdGVkVmFsdWVzKSk7IH0sIGZhbHNlKTsK KyAgICAgICAgd2hpY2ggZG9lcyBub3Qgd29yayBhcyBpbnRlbmRlZCBiZWNhdXNlIHRoZSBwYXJh bWV0ZXIgdG8gd2FpdEZvckFuaW1hdGlvblN0YXJ0IHNob3VsZCBoYXZlIGJlZW4gYSBmdW5jdGlv bgorICAgICAgICB0aGF0IGNhbGxzIHJ1blRlc3QsIG5vdCB0aGUgY2FsbCB0byB0aGUgcnVuVGVz dCBmdW5jdGlvbiBpdHNlbGYsIHdoaWNoIGNhbGxzIHRoZSBtZXRob2QgaW1tZWRpYXRlbHkuCisK KyAgICAgICAgKiBjc3MzL2NhbGMvdHJhbnNpdGlvbnMtZGVwZW5kZW50Lmh0bWw6CisgICAgICAg IEFkZGVkIHdhaXRVbnRpbERvbmUvbm90aWZ5RG9uZS4KKyAgICAgICAgRml4ZWQgZnVuY3Rpb24g cGFyYW1ldGVyLgorCiAyMDEyLTA4LTA4ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEyNTA0Nik6IEJyZWFrcyBkZWJ1ZyBidWls ZCAoYXNzZXJ0aW9uIGluIHByb3RvY29sIHR5cGUgY2hlY2tzKSAoUmVxdWVzdGVkIGJ5IHBmZWxk bWFuIG9uICN3ZWJraXQpLgpJbmRleDogTGF5b3V0VGVzdHMvY3NzMy9jYWxjL3RyYW5zaXRpb25z LWRlcGVuZGVudC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2NzczMvY2FsYy90cmFu c2l0aW9ucy1kZXBlbmRlbnQuaHRtbAkocmV2aXNpb24gMTI0OTAxKQorKysgTGF5b3V0VGVzdHMv Y3NzMy9jYWxjL3RyYW5zaXRpb25zLWRlcGVuZGVudC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC02 NSw2ICs2NSw3IEBAIGV4cGVjdGVkVmFsdWVzID0gWwogICAgIFsxLjAwLCAiaW5uZXJUcmFuc2l0 aW9uIiwgJ3dpZHRoJywgNDkwLCAib3V0ZXIiXSwKIF07CiAKKwogZnVuY3Rpb24gcnVuVGVzdChl eHBlY3RlZCkgCiB7CiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBleHBlY3RlZC5sZW5ndGg7ICsr aSkgewpAQCAtNzMsMjAgKzc0LDI0IEBAIGZ1bmN0aW9uIHJ1blRlc3QoZXhwZWN0ZWQpCiAgICAg ICAgIHZhciBwcm9wZXJ0eSA9IGV4cGVjdGVkW2ldWzJdOwogICAgICAgICB2YXIgZXhwZWN0ZWRW YWx1ZSA9IGV4cGVjdGVkW2ldWzNdOwogICAgICAgICB2YXIgZGVwZW5kc09uID0gZXhwZWN0ZWRb aV1bNF07Ci0gICAgICAgIAogICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKICAgICAg ICAgICAgIHdpbmRvdy50ZXN0UnVubmVyLnBhdXNlVHJhbnNpdGlvbkF0VGltZU9uRWxlbWVudFdp dGhJZChwcm9wZXJ0eSwgdGltZSwgZGVwZW5kc09uKTsKICAgICAgICAgICAgIHdpbmRvdy50ZXN0 UnVubmVyLnBhdXNlVHJhbnNpdGlvbkF0VGltZU9uRWxlbWVudFdpdGhJZChwcm9wZXJ0eSwgdGlt ZSwgZWxlbWVudElkKTsKICAgICAgICAgICAgIHZhciBhY3R1YWwgPSB3aW5kb3cuZ2V0Q29tcHV0 ZWRTdHlsZShkb2N1bWVudC5nZXRFbGVtZW50QnlJZChlbGVtZW50SWQpKS5nZXRQcm9wZXJ0eUNT U1ZhbHVlKHByb3BlcnR5KS5nZXRGbG9hdFZhbHVlKENTU1ByaW1pdGl2ZVZhbHVlLkNTU19OVU1C RVIpOwogICAgICAgICAgICAgdmFyIHJlc3VsdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJy ZXN1bHQiKTsKLQogICAgICAgICAgICAgaWYgKGFjdHVhbCA9PSBleHBlY3RlZFZhbHVlKQogICAg ICAgICAgICAgICAgIHJlc3VsdC5pbm5lckhUTUwgKz0gJ1BBU1MgLSAiJyArIHByb3BlcnR5ICsg JyIgcHJvcGVydHkgZm9yICInICsgZWxlbWVudElkICsnIiBlbGVtZW50IGF0ICcgKyB0aW1lICsg J3Mgd2FzOiAnICsgYWN0dWFsICsgJzxici8+JzsKICAgICAgICAgICAgIGVsc2UKICAgICAgICAg ICAgICAgICByZXN1bHQuaW5uZXJIVE1MICs9ICdGQUlMIC0gIicgKyBwcm9wZXJ0eSArICciIHBy b3BlcnR5IGZvciAiJyArIGVsZW1lbnRJZCArJyIgZWxlbWVudCBhdCAnICsgdGltZSArICdzIGV4 cGVjdGVkOiAnICsgZXhwZWN0ZWRWYWx1ZSArICcgYnV0IHNhdzogJyArIGFjdHVhbCArICc8YnIv Pic7CiAgICAgICAgIH0KLSAgICAgICAgICAgIAogICAgIH0KKyAgICBpZiAod2luZG93LnRlc3RS dW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworfQorCitmdW5jdGlvbiBs b2FkTGlzdGVuZXIoKQoreworICAgIHdhaXRGb3JBbmltYXRpb25TdGFydChmdW5jdGlvbigpe3J1 blRlc3QoZXhwZWN0ZWRWYWx1ZXMpO30pOwogfQogCiBmb3IgKHZhciBpID0gMDsgaSA8IHRyYW5z aXRpb25pbmdFbGVtZW50cy5sZW5ndGg7IGkrKykgewpAQCAtOTQsNiArOTksNyBAQCBmb3IgKHZh ciBpID0gMDsgaSA8IHRyYW5zaXRpb25pbmdFbGVtZW50CiAgICAgZWxlbWVudC5jbGFzc05hbWUg Kz0gIiBnbyI7CiB9CiAKLXdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgZnVuY3Rpb24o KSB7IHdhaXRGb3JBbmltYXRpb25TdGFydChydW5UZXN0KGV4cGVjdGVkVmFsdWVzKSk7IH0sIGZh bHNlKTsKK3dpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgbG9hZExpc3RlbmVyLCBmYWxz ZSk7Cit3aW5kb3cudGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CiAKIDwvc2NyaXB0Pgo= 157311 2012-08-08 15:32:22 -0700 2012-08-08 16:40:05 -0700 the actual fixed patch 93515_patch.txt text/plain 3520 roger_fong SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNTA4MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA4LTA4ICBSb2dlciBGb25nICA8cm9n ZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgY3NzMy9jYWxjL3RyYW5zaXRpb25zLWRlcGVu ZGVudC5odG1sIHdhcyBjYXVzaW5nIGNzczMvY2FsYy90cmFuc2l0aW9ucy5odG1sIHRvIGZhaWwK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNTE1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHRyYW5z aXRpb25zLWRlcGVuZGVudC5odG1sIHRlc3Qgd2FzIGNhdXNpbmcgdGhlIHRyYW5zaXRpb25zLmh0 bWwgdGVzdCB0byBmYWlsLgorICAgICAgICBUaGlzIHdhcyBhIHJlc3VsdCBvZiBhIHRpbWVvdXQg Y2FsbGJhY2sgc2V0IGluIHRoZSBmaXJzdCB0ZXN0IHRoYXQgd2FzIG9ubHkgYmVpbmcgZmlyZWQK KyAgICAgICAgaW4gdGhlIHNlY29uZCB0ZXN0IGJlY2F1c2UgdGhlIGZpcnN0IHRlc3QgZGlkIG5v dCB1c2Ugd2FpdFVudGlsRG9uZS9ub3RpZnlEb25lLiAKKyAgICAgICAgVGhlIHNlY29uZCB0ZXN0 IHByaW50ZWQgb3V0IGFuIGV4dHJhIFR5cGVFcnJvcjogJ3VuZGVmaW5lZCcgZXJyb3IgbWVzc2Fn ZSBiZWNhdXNlIHRoZSBjYWxsYmFjayAKKyAgICAgICAgd2FzIGRlZmluZWQgaW4gdGhlIGZpcnN0 IHRlc3QgYW5kIHdhcyB0aHVzICd1bmRlZmluZWQnIGJ5IHRoZSB0aW1lIGl0IHdhcyBjYWxsZWQg d2hpbGUgdGhlIHNlY29uZCB0ZXN0CisgICAgICAgIHdhcyBydW5uaW5nLgorICAgICAgICAKKyAg ICAgICAgSW4gYWRkaXRpb24sIHRoZSB0ZXN0IGNvbnRhaW5lZCB0aGUgZm9sbG93aW5nIGxpbmU6 CisgICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgZnVuY3Rpb24oKSB7IHdh aXRGb3JBbmltYXRpb25TdGFydChydW5UZXN0KGV4cGVjdGVkVmFsdWVzKSk7IH0sIGZhbHNlKTsK KyAgICAgICAgd2hpY2ggZG9lcyBub3Qgd29yayBhcyBpbnRlbmRlZCBiZWNhdXNlIHRoZSBwYXJh bWV0ZXIgdG8gd2FpdEZvckFuaW1hdGlvblN0YXJ0IHNob3VsZCBoYXZlIGJlZW4gYSBmdW5jdGlv bgorICAgICAgICB0aGF0IGNhbGxzIHJ1blRlc3QsIG5vdCB0aGUgY2FsbCB0byB0aGUgcnVuVGVz dCBmdW5jdGlvbiBpdHNlbGYsIHdoaWNoIGNhbGxzIHRoZSBtZXRob2QgaW1tZWRpYXRlbHkuCisK KyAgICAgICAgKiBjc3MzL2NhbGMvdHJhbnNpdGlvbnMtZGVwZW5kZW50Lmh0bWw6CisgICAgICAg IEFkZGVkIHdhaXRVbnRpbERvbmUvbm90aWZ5RG9uZS4KKyAgICAgICAgRml4ZWQgZnVuY3Rpb24g cGFyYW1ldGVyLgorCiAyMDEyLTA4LTA4ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEyNTA0Nik6IEJyZWFrcyBkZWJ1ZyBidWls ZCAoYXNzZXJ0aW9uIGluIHByb3RvY29sIHR5cGUgY2hlY2tzKSAoUmVxdWVzdGVkIGJ5IHBmZWxk bWFuIG9uICN3ZWJraXQpLgpJbmRleDogTGF5b3V0VGVzdHMvY3NzMy9jYWxjL3RyYW5zaXRpb25z LWRlcGVuZGVudC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2NzczMvY2FsYy90cmFu c2l0aW9ucy1kZXBlbmRlbnQuaHRtbAkocmV2aXNpb24gMTI0OTAxKQorKysgTGF5b3V0VGVzdHMv Y3NzMy9jYWxjL3RyYW5zaXRpb25zLWRlcGVuZGVudC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC03 MywyMCArNzMsMjQgQEAgZnVuY3Rpb24gcnVuVGVzdChleHBlY3RlZCkKICAgICAgICAgdmFyIHBy b3BlcnR5ID0gZXhwZWN0ZWRbaV1bMl07CiAgICAgICAgIHZhciBleHBlY3RlZFZhbHVlID0gZXhw ZWN0ZWRbaV1bM107CiAgICAgICAgIHZhciBkZXBlbmRzT24gPSBleHBlY3RlZFtpXVs0XTsKLSAg ICAgICAgCiAgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgewogICAgICAgICAgICAgd2lu ZG93LnRlc3RSdW5uZXIucGF1c2VUcmFuc2l0aW9uQXRUaW1lT25FbGVtZW50V2l0aElkKHByb3Bl cnR5LCB0aW1lLCBkZXBlbmRzT24pOwogICAgICAgICAgICAgd2luZG93LnRlc3RSdW5uZXIucGF1 c2VUcmFuc2l0aW9uQXRUaW1lT25FbGVtZW50V2l0aElkKHByb3BlcnR5LCB0aW1lLCBlbGVtZW50 SWQpOwogICAgICAgICAgICAgdmFyIGFjdHVhbCA9IHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKGVsZW1lbnRJZCkpLmdldFByb3BlcnR5Q1NTVmFsdWUocHJv cGVydHkpLmdldEZsb2F0VmFsdWUoQ1NTUHJpbWl0aXZlVmFsdWUuQ1NTX05VTUJFUik7CiAgICAg ICAgICAgICB2YXIgcmVzdWx0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpOwot CiAgICAgICAgICAgICBpZiAoYWN0dWFsID09IGV4cGVjdGVkVmFsdWUpCiAgICAgICAgICAgICAg ICAgcmVzdWx0LmlubmVySFRNTCArPSAnUEFTUyAtICInICsgcHJvcGVydHkgKyAnIiBwcm9wZXJ0 eSBmb3IgIicgKyBlbGVtZW50SWQgKyciIGVsZW1lbnQgYXQgJyArIHRpbWUgKyAncyB3YXM6ICcg KyBhY3R1YWwgKyAnPGJyLz4nOwogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgIHJl c3VsdC5pbm5lckhUTUwgKz0gJ0ZBSUwgLSAiJyArIHByb3BlcnR5ICsgJyIgcHJvcGVydHkgZm9y ICInICsgZWxlbWVudElkICsnIiBlbGVtZW50IGF0ICcgKyB0aW1lICsgJ3MgZXhwZWN0ZWQ6ICcg KyBleHBlY3RlZFZhbHVlICsgJyBidXQgc2F3OiAnICsgYWN0dWFsICsgJzxici8+JzsKICAgICAg ICAgfQotICAgICAgICAgICAgCiAgICAgfQorICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAg ICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Cit9CisKK2Z1bmN0aW9uIGxvYWRMaXN0ZW5l cigpCit7CisgICAgd2FpdEZvckFuaW1hdGlvblN0YXJ0KGZ1bmN0aW9uKCl7cnVuVGVzdChleHBl Y3RlZFZhbHVlcyk7fSk7CiB9CiAKIGZvciAodmFyIGkgPSAwOyBpIDwgdHJhbnNpdGlvbmluZ0Vs ZW1lbnRzLmxlbmd0aDsgaSsrKSB7CkBAIC05NCw2ICs5OCw3IEBAIGZvciAodmFyIGkgPSAwOyBp IDwgdHJhbnNpdGlvbmluZ0VsZW1lbnQKICAgICBlbGVtZW50LmNsYXNzTmFtZSArPSAiIGdvIjsK IH0KIAotd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoImxvYWQiLCBmdW5jdGlvbigpIHsgd2FpdEZv ckFuaW1hdGlvblN0YXJ0KHJ1blRlc3QoZXhwZWN0ZWRWYWx1ZXMpKTsgfSwgZmFsc2UpOword2lu ZG93LmFkZEV2ZW50TGlzdGVuZXIoImxvYWQiLCBsb2FkTGlzdGVuZXIsIGZhbHNlKTsKK3dpbmRv dy50ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKIAogPC9zY3JpcHQ+Cg==