93510 2012-08-08 13:12:40 -0700 Implement new synchronized audio I/O render method in chromium 2012-08-14 16:17:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers eric.carlson feature-media-reviews kbr webkit.review.bot oldest_to_newest 690646 0 crogers 2012-08-08 13:12:40 -0700 Implement new synchronized audio I/O render method in chromium 690653 1 157277 crogers 2012-08-08 13:17:56 -0700 Created attachment 157277 Patch 694288 2 157277 kbr 2012-08-13 17:43:41 -0700 Comment on attachment 157277 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157277&action=review Looks generally fine -- r=me -- but a couple of comments which you can feel free to ignore if they're off base. > Source/WebKit/chromium/src/AudioDestinationChromium.cpp:92 > + AudioBus silence(2, renderBufferSize); 2? Really? Why not numberOfChannels? > Source/WebKit/chromium/src/AudioDestinationChromium.cpp:139 > + AudioBus wrapperBus(2, numberOfFrames, false); 2 again? If this is a temporary hack until this code is generalized then add a FIXME. > Source/WebKit/chromium/src/AudioDestinationChromium.cpp:180 > + // Render using the Web Audio engine. Does this comment add any value? 695503 3 crogers 2012-08-14 16:17:25 -0700 Committed r125618: <http://trac.webkit.org/changeset/125618> 157277 2012-08-08 13:17:56 -0700 2012-08-13 17:43:41 -0700 Patch bug-93510-20120808131730.patch text/plain 6998 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDc4YjIwNzY3YmM3MDc4NzU5ZGNiYWM1ODc3NmNmYmVkMTVkOTVmZmYuLmE0ZjAxM2UxZTM0NTc2 ZWFlNTI1YzVjOGNjNTY0NTgyZTBkODBhM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTItMDgtMDggIENocmlzIFJvZ2VycyAgPGNyb2dlcnNAZ29vZ2xl LmNvbT4KKworICAgICAgICBJbXBsZW1lbnQgbmV3IHN5bmNocm9uaXplZCBhdWRpbyBJL08gcmVu ZGVyIG1ldGhvZCBpbiBjaHJvbWl1bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTM1MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgY2hyb21pdW0gaW1wbGVtZW50YXRpb24gb2YgQXVkaW9EZXN0aW5h dGlvbiBpcyBiZWluZyB1cGdyYWRlZCB0bworICAgICAgICBzdXBwb3J0IHN5bmNocm9uaXplZCBh dWRpbyBJL08uICBPdGhlciBjaGFuZ2VzIG9uIHRoZSBjaHJvbWl1bS1zaWRlCisgICAgICAgIGNh biB0aGVuIGJlIHRlc3RlZCBhZ2FpbnN0IHNvbWV0aGluZyB0aGF0IHdvcmtzIGluIFdlYktpdC4K KworICAgICAgICAqIHNyYy9BdWRpb0Rlc3RpbmF0aW9uQ2hyb21pdW0uY3BwOgorICAgICAgICAo V2ViQ29yZTo6QXVkaW9EZXN0aW5hdGlvbkNocm9taXVtOjpBdWRpb0Rlc3RpbmF0aW9uQ2hyb21p dW0pOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9EZXN0aW5hdGlvbkNocm9taXVtOjpyZW5kZXIp OgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0Rlc3RpbmF0aW9u Q2hyb21pdW06OnByb3ZpZGVJbnB1dCk6CisgICAgICAgICogc3JjL0F1ZGlvRGVzdGluYXRpb25D aHJvbWl1bS5oOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChBdWRpb0Rlc3RpbmF0aW9u Q2hyb21pdW0pOgorCiAyMDEyLTA3LTMxICBDaHJpcyBSb2dlcnMgIDxjcm9nZXJzQGdvb2dsZS5j b20+CiAKICAgICAgICAgQWxsb3cgQXVkaW9EZXN0aW5hdGlvbiB0byBzdXBwb3J0IGxvY2FsL2xp dmUgYXVkaW8gaW5wdXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0F1 ZGlvRGVzdGluYXRpb25DaHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9B dWRpb0Rlc3RpbmF0aW9uQ2hyb21pdW0uY3BwCmluZGV4IDY0NmU5ZWYwZGUxNzQyYWMxMWZmMTdm ZmVhODBjMDRhYWUwNjQyNTUuLmM0YTVjNmJhZDU4MWQwYTYzNmQwYmNhMDBlNmM2ZjM2MmYzNzUz YTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0F1ZGlvRGVzdGluYXRp b25DaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXVkaW9EZXN0 aW5hdGlvbkNocm9taXVtLmNwcApAQCAtMzIsNiArMzIsNyBAQAogCiAjaW5jbHVkZSAiQXVkaW9E ZXN0aW5hdGlvbkNocm9taXVtLmgiCiAKKyNpbmNsdWRlICJBdWRpb0ZJRk8uaCIKICNpbmNsdWRl ICJBdWRpb1B1bGxGSUZPLmgiCiAjaW5jbHVkZSAiV2ViS2l0LmgiCiAjaW5jbHVkZSAicGxhdGZv cm0vV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmgiCkBAIC01OSw2ICs2MCw3IEBAIFBhc3NPd25QdHI8 QXVkaW9EZXN0aW5hdGlvbj4gQXVkaW9EZXN0aW5hdGlvbjo6Y3JlYXRlKEF1ZGlvSU9DYWxsYmFj ayYgY2FsbGJhY2ssCiAKIEF1ZGlvRGVzdGluYXRpb25DaHJvbWl1bTo6QXVkaW9EZXN0aW5hdGlv bkNocm9taXVtKEF1ZGlvSU9DYWxsYmFjayYgY2FsbGJhY2ssIGZsb2F0IHNhbXBsZVJhdGUpCiAg ICAgOiBtX2NhbGxiYWNrKGNhbGxiYWNrKQorICAgICwgbV9pbnB1dEJ1cyhudW1iZXJPZkNoYW5u ZWxzLCByZW5kZXJCdWZmZXJTaXplKQogICAgICwgbV9yZW5kZXJCdXMobnVtYmVyT2ZDaGFubmVs cywgcmVuZGVyQnVmZmVyU2l6ZSwgZmFsc2UpCiAgICAgLCBtX3NhbXBsZVJhdGUoc2FtcGxlUmF0 ZSkKICAgICAsIG1faXNQbGF5aW5nKGZhbHNlKQpAQCAtNzAsNyArNzIsNyBAQCBBdWRpb0Rlc3Rp bmF0aW9uQ2hyb21pdW06OkF1ZGlvRGVzdGluYXRpb25DaHJvbWl1bShBdWRpb0lPQ2FsbGJhY2sm IGNhbGxiYWNrLCBmbAogICAgIEFTU0VSVChtX2NhbGxiYWNrQnVmZmVyU2l6ZSArIHJlbmRlckJ1 ZmZlclNpemUgPD0gZmlmb1NpemUpOwogICAgIGlmIChtX2NhbGxiYWNrQnVmZmVyU2l6ZSArIHJl bmRlckJ1ZmZlclNpemUgPiBmaWZvU2l6ZSkKICAgICAgICAgcmV0dXJuOwotICAgIAorCiAgICAg bV9hdWRpb0RldmljZSA9IGFkb3B0UHRyKFdlYktpdDo6UGxhdGZvcm06OmN1cnJlbnQoKS0+Y3Jl YXRlQXVkaW9EZXZpY2UobV9jYWxsYmFja0J1ZmZlclNpemUsIG51bWJlck9mQ2hhbm5lbHMsIHNh bXBsZVJhdGUsIHRoaXMpKTsKICAgICBBU1NFUlQobV9hdWRpb0RldmljZSk7CiAKQEAgLTgwLDYg KzgyLDE2IEBAIEF1ZGlvRGVzdGluYXRpb25DaHJvbWl1bTo6QXVkaW9EZXN0aW5hdGlvbkNocm9t aXVtKEF1ZGlvSU9DYWxsYmFjayYgY2FsbGJhY2ssIGZsCiAgICAgLy8gT3RoZXJ3aXNlLCB0aGUg RklGTyB3aWxsIGNhbGwgdGhlIHByb3ZpZGVyIGVub3VnaCB0aW1lcyB0bwogICAgIC8vIHNhdGlz ZnkgdGhlIHJlcXVlc3QgZm9yIGRhdGEuCiAgICAgbV9maWZvID0gYWRvcHRQdHIobmV3IEF1ZGlv UHVsbEZJRk8oKnRoaXMsIG51bWJlck9mQ2hhbm5lbHMsIGZpZm9TaXplLCByZW5kZXJCdWZmZXJT aXplKSk7CisKKyAgICAvLyBJbnB1dCBidWZmZXJpbmcuCisgICAgbV9pbnB1dEZpZm8gPSBhZG9w dFB0cihuZXcgQXVkaW9GSUZPKG51bWJlck9mQ2hhbm5lbHMsIGZpZm9TaXplKSk7CisKKyAgICAv LyBJZiB0aGUgY2FsbGJhY2sgc2l6ZSBkb2VzIG5vdCBtYXRjaCB0aGUgcmVuZGVyIHNpemUsIHRo ZW4gd2UgbmVlZCB0byBidWZmZXIgc29tZQorICAgIC8vIGV4dHJhIHNpbGVuY2UgZm9yIHRoZSBp bnB1dC4gT3RoZXJ3aXNlLCB3ZSBjYW4gb3Zlci1jb25zdW1lIHRoZSBpbnB1dCBGSUZPLgorICAg IGlmIChtX2NhbGxiYWNrQnVmZmVyU2l6ZSAhPSByZW5kZXJCdWZmZXJTaXplKSB7CisgICAgICAg IEF1ZGlvQnVzIHNpbGVuY2UoMiwgcmVuZGVyQnVmZmVyU2l6ZSk7CisgICAgICAgIG1faW5wdXRG aWZvLT5wdXNoKCZzaWxlbmNlKTsKKyAgICB9CiB9CiAKIEF1ZGlvRGVzdGluYXRpb25DaHJvbWl1 bTo6fkF1ZGlvRGVzdGluYXRpb25DaHJvbWl1bSgpCkBAIC0xMDgsNyArMTIwLDM2IEBAIGZsb2F0 IEF1ZGlvRGVzdGluYXRpb246OmhhcmR3YXJlU2FtcGxlUmF0ZSgpCiAgICAgcmV0dXJuIHN0YXRp Y19jYXN0PGZsb2F0PihXZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50KCktPmF1ZGlvSGFyZHdhcmVT YW1wbGVSYXRlKCkpOwogfQogCit2b2lkIEF1ZGlvRGVzdGluYXRpb25DaHJvbWl1bTo6cmVuZGVy KGNvbnN0IFdlYlZlY3RvcjxmbG9hdCo+JiBzb3VyY2VEYXRhLCBjb25zdCBXZWJWZWN0b3I8Zmxv YXQqPiYgYXVkaW9EYXRhLCBzaXplX3QgbnVtYmVyT2ZGcmFtZXMpCit7CisgICAgYm9vbCBpc051 bWJlck9mQ2hhbm5lbHNHb29kID0gYXVkaW9EYXRhLnNpemUoKSA9PSBudW1iZXJPZkNoYW5uZWxz OworICAgIGlmICghaXNOdW1iZXJPZkNoYW5uZWxzR29vZCkgeworICAgICAgICBBU1NFUlRfTk9U X1JFQUNIRUQoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIGJvb2wgaXNCdWZmZXJT aXplR29vZCA9IG51bWJlck9mRnJhbWVzID09IG1fY2FsbGJhY2tCdWZmZXJTaXplOworICAgIGlm ICghaXNCdWZmZXJTaXplR29vZCkgeworICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAg ICAgICAgcmV0dXJuOworICAgIH0KKworICAgIC8vIEJ1ZmZlciBvcHRpb25hbCBsaXZlIGlucHV0 LgorICAgIGlmIChzb3VyY2VEYXRhLnNpemUoKSA+PSAyKSB7CisgICAgICAgIEF1ZGlvQnVzIHdy YXBwZXJCdXMoMiwgbnVtYmVyT2ZGcmFtZXMsIGZhbHNlKTsKKyAgICAgICAgd3JhcHBlckJ1cy5z ZXRDaGFubmVsTWVtb3J5KDAsIHNvdXJjZURhdGFbMF0sIG51bWJlck9mRnJhbWVzKTsKKyAgICAg ICAgd3JhcHBlckJ1cy5zZXRDaGFubmVsTWVtb3J5KDEsIHNvdXJjZURhdGFbMV0sIG51bWJlck9m RnJhbWVzKTsKKyAgICAgICAgbV9pbnB1dEZpZm8tPnB1c2goJndyYXBwZXJCdXMpOworICAgIH0K KworICAgIG1fcmVuZGVyQnVzLnNldENoYW5uZWxNZW1vcnkoMCwgYXVkaW9EYXRhWzBdLCBudW1i ZXJPZkZyYW1lcyk7CisgICAgbV9yZW5kZXJCdXMuc2V0Q2hhbm5lbE1lbW9yeSgxLCBhdWRpb0Rh dGFbMV0sIG51bWJlck9mRnJhbWVzKTsKKworICAgIG1fZmlmby0+Y29uc3VtZSgmbV9yZW5kZXJC dXMsIG51bWJlck9mRnJhbWVzKTsKK30KKwogLy8gUHVsbHMgb24gb3VyIHByb3ZpZGVyIHRvIGdl dCB0aGUgcmVuZGVyZWQgYXVkaW8gc3RyZWFtLgorLy8gRklYTUU6IHJlbW92ZSB0aGlzIG1ldGhv ZCB3aGVuIHRoZSBjaHJvbWl1bS1zaWRlIHN3aXRjaGVzIG92ZXIgdG8gdGhlIHN5bmNocm9uaXpl ZCBJL08gcmVuZGVyKCkgbWV0aG9kIChhYm92ZSkuCiB2b2lkIEF1ZGlvRGVzdGluYXRpb25DaHJv bWl1bTo6cmVuZGVyKGNvbnN0IFdlYlZlY3RvcjxmbG9hdCo+JiBhdWRpb0RhdGEsIHNpemVfdCBu dW1iZXJPZkZyYW1lcykKIHsKICAgICBib29sIGlzTnVtYmVyT2ZDaGFubmVsc0dvb2QgPSBhdWRp b0RhdGEuc2l6ZSgpID09IG51bWJlck9mQ2hhbm5lbHM7CkBAIC0xMTYsNyArMTU3LDcgQEAgdm9p ZCBBdWRpb0Rlc3RpbmF0aW9uQ2hyb21pdW06OnJlbmRlcihjb25zdCBXZWJWZWN0b3I8ZmxvYXQq PiYgYXVkaW9EYXRhLCBzaXplX3QKICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAg ICAgIHJldHVybjsKICAgICB9Ci0gICAgICAgIAorCiAgICAgYm9vbCBpc0J1ZmZlclNpemVHb29k ID0gbnVtYmVyT2ZGcmFtZXMgPT0gbV9jYWxsYmFja0J1ZmZlclNpemU7CiAgICAgaWYgKCFpc0J1 ZmZlclNpemVHb29kKSB7CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwpAQCAtMTMwLDgg KzE3MSwxNCBAQCB2b2lkIEF1ZGlvRGVzdGluYXRpb25DaHJvbWl1bTo6cmVuZGVyKGNvbnN0IFdl YlZlY3RvcjxmbG9hdCo+JiBhdWRpb0RhdGEsIHNpemVfdAogCiB2b2lkIEF1ZGlvRGVzdGluYXRp b25DaHJvbWl1bTo6cHJvdmlkZUlucHV0KEF1ZGlvQnVzKiBidXMsIHNpemVfdCBmcmFtZXNUb1By b2Nlc3MpCiB7Ci0gICAgLy8gRklYTUU6IEFkZCBzdXBwb3J0IGZvciBsb2NhbC9saXZlIGF1ZGlv IGlucHV0LgotICAgIG1fY2FsbGJhY2sucmVuZGVyKDAsIGJ1cywgZnJhbWVzVG9Qcm9jZXNzKTsK KyAgICBBdWRpb0J1cyogc291cmNlQnVzID0gMDsKKyAgICBpZiAobV9pbnB1dEZpZm8tPmZyYW1l c0luRmlmbygpID49IGZyYW1lc1RvUHJvY2VzcykgeworICAgICAgICBtX2lucHV0Rmlmby0+Y29u c3VtZSgmbV9pbnB1dEJ1cywgZnJhbWVzVG9Qcm9jZXNzKTsKKyAgICAgICAgc291cmNlQnVzID0g Jm1faW5wdXRCdXM7CisgICAgfQorCisgICAgLy8gUmVuZGVyIHVzaW5nIHRoZSBXZWIgQXVkaW8g ZW5naW5lLgorICAgIG1fY2FsbGJhY2sucmVuZGVyKHNvdXJjZUJ1cywgYnVzLCBmcmFtZXNUb1By b2Nlc3MpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9BdWRpb0Rlc3RpbmF0aW9uQ2hyb21pdW0uaCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL0F1ZGlvRGVzdGluYXRpb25DaHJvbWl1bS5oCmluZGV4IGZkNjc2 ZDEwMmRjNjc0MjM5Mzk2NjlhNTFlYzIyOGI5MDdiNDFjZmEuLjdkMjYxYTdmYWFhNmExNDA5ZGE2 OTc0YTJiYTA5M2E3YTRkMjk5YjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL0F1ZGlvRGVzdGluYXRpb25DaHJvbWl1bS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL0F1ZGlvRGVzdGluYXRpb25DaHJvbWl1bS5oCkBAIC00MCw2ICs0MCw3IEBAIG5hbWVz cGFjZSBXZWJLaXQgeyBjbGFzcyBXZWJBdWRpb0RldmljZTsgfQogCiBuYW1lc3BhY2UgV2ViQ29y ZSB7IAogCitjbGFzcyBBdWRpb0ZJRk87CiBjbGFzcyBBdWRpb1B1bGxGSUZPOwogCiAvLyBBbiBB dWRpb0Rlc3RpbmF0aW9uIHVzaW5nIENocm9taXVtJ3MgYXVkaW8gc3lzdGVtCkBAIC01Niw2ICs1 Nyw3IEBAIHB1YmxpYzoKICAgICBmbG9hdCBzYW1wbGVSYXRlKCkgY29uc3QgeyByZXR1cm4gbV9z YW1wbGVSYXRlOyB9CiAKICAgICAvLyBXZWJLaXQ6OldlYkF1ZGlvRGV2aWNlOjpSZW5kZXJDYWxs YmFjaworICAgIHZpcnR1YWwgdm9pZCByZW5kZXIoY29uc3QgV2ViS2l0OjpXZWJWZWN0b3I8Zmxv YXQqPiYgc291cmNlRGF0YSwgY29uc3QgV2ViS2l0OjpXZWJWZWN0b3I8ZmxvYXQqPiYgYXVkaW9E YXRhLCBzaXplX3QgbnVtYmVyT2ZGcmFtZXMpOwogICAgIHZpcnR1YWwgdm9pZCByZW5kZXIoY29u c3QgV2ViS2l0OjpXZWJWZWN0b3I8ZmxvYXQqPiYgYXVkaW9EYXRhLCBzaXplX3QgbnVtYmVyT2ZG cmFtZXMpOwogCiAgICAgLy8gV2ViQ29yZTo6QXVkaW9Tb3VyY2VQcm92aWRlcgpAQCAtNjMsMTEg KzY1LDE0IEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAgICBBdWRpb0lPQ2FsbGJhY2smIG1fY2Fs bGJhY2s7CisgICAgQXVkaW9CdXMgbV9pbnB1dEJ1czsKICAgICBBdWRpb0J1cyBtX3JlbmRlckJ1 czsKICAgICBmbG9hdCBtX3NhbXBsZVJhdGU7CiAgICAgYm9vbCBtX2lzUGxheWluZzsKICAgICBP d25QdHI8V2ViS2l0OjpXZWJBdWRpb0RldmljZT4gbV9hdWRpb0RldmljZTsKICAgICBzaXplX3Qg bV9jYWxsYmFja0J1ZmZlclNpemU7CisKKyAgICBPd25QdHI8QXVkaW9GSUZPPiBtX2lucHV0Rmlm bzsKICAgICBPd25QdHI8QXVkaW9QdWxsRklGTz4gbV9maWZvOwogfTsKIAo=